Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 10:20:39AM -0400, Willem de Bruijn wrote: > On Tue, Apr 13, 2021 at 10:03 AM Michael S. Tsirkin wrote: > > > > On Tue, Apr 13, 2021 at 04:54:42PM +0800, Jason Wang wrote: > > > > > > 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: > > > > It's unsafe to operate a vq from

Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Willem de Bruijn
On Tue, Apr 13, 2021 at 10:03 AM Michael S. Tsirkin wrote: > > On Tue, Apr 13, 2021 at 04:54:42PM +0800, Jason Wang wrote: > > > > 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: > > > It's unsafe to operate a vq from multiple threads. > > > Unfortunately this is exactly what we do when invoking > > >

Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Michael S. Tsirkin
On Tue, Apr 13, 2021 at 04:54:42PM +0800, Jason Wang wrote: > > 在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: > > It's unsafe to operate a vq from multiple threads. > > Unfortunately this is exactly what we do when invoking > > clean tx poll from rx napi. > > As a fix move everything that deals with

Re: [PATCH RFC v2 3/4] virtio_net: move tx vq operation under tx queue lock

2021-04-13 Thread Jason Wang
在 2021/4/13 下午1:47, Michael S. Tsirkin 写道: It's unsafe to operate a vq from multiple threads. Unfortunately this is exactly what we do when invoking clean tx poll from rx napi. As a fix move everything that deals with the vq to under tx lock. Signed-off-by: Michael S. Tsirkin ---