Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 08:52 -0400, Steven Rostedt wrote: > On Thu, 2012-07-19 at 11:20 +0900, Masami Hiramatsu wrote: > > (2012/07/19 0:59), Steven Rostedt wrote: > > > On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote: > > > > > > Masami, can you give your Reviewed-by tag for this version?

Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 08:52 -0400, Steven Rostedt wrote: > > GLOBAL(ftrace_regs_call) > call ftrace_stub > @@ -1195,8 +1194,8 @@ GLOBAL(ftrace_regs_call) > popl %es > popl %fs > popl %gs > - addl $8, %esp /* Skip orig_ax and ip */ > - popf

Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-19 Thread Steven Rostedt
On Thu, 2012-07-19 at 11:20 +0900, Masami Hiramatsu wrote: > (2012/07/19 0:59), Steven Rostedt wrote: > > On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote: > > > > Masami, can you give your Reviewed-by tag for this version? Or is there > > something else needing to be fixed? > > No, that i

Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-18 Thread Masami Hiramatsu
(2012/07/19 0:59), Steven Rostedt wrote: > On Fri, 2012-07-13 at 14:47 -0400, Steven Rostedt wrote: > > Masami, can you give your Reviewed-by tag for this version? Or is there > something else needing to be fixed? No, that is OK for me. I've just missed that... Reviewed-by: Masami Hiramatsu Th

Re: Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-16 Thread Masami Hiramatsu
(2012/07/17 12:05), Steven Rostedt wrote: > On Tue, 2012-07-17 at 11:08 +0900, Masami Hiramatsu wrote: > >>> I found that regs_get_register() doesn't honor this either. Thus, >>> kprobes in tracing gets this: >>> >>> # echo 'p:ftrace sys_read+4 s=%sp' > /debug/tracing/kprobe_events >>> # echo 1

Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-16 Thread Steven Rostedt
On Tue, 2012-07-17 at 11:08 +0900, Masami Hiramatsu wrote: > > I found that regs_get_register() doesn't honor this either. Thus, > > kprobes in tracing gets this: > > > > # echo 'p:ftrace sys_read+4 s=%sp' > /debug/tracing/kprobe_events > > # echo 1 > /debug/tracing/events/kprobes/enable > > #

Re: Re: [RFC][PATCH 2/4 v4] ftrace/x86: Add save_regs for i386 function calls

2012-07-16 Thread Masami Hiramatsu
(2012/07/14 3:47), Steven Rostedt wrote: > On Thu, 2012-07-12 at 21:39 +0900, Masami Hiramatsu wrote: > >> /* >> * X86_32 CPUs don't save ss and esp if the CPU is already in kernel mode >> * when it traps. The previous stack will be directly underneath the saved >> * registers, and 'sp/ss' won