Linus Torvalds wrote:
> On Tue, May 1, 2018 at 9:46 AM Nadav Amit wrote:
>
>> My bad. It’s not the new-line. Let me do some more digging.
>
> From the gcc docs:
>
> Some targets require that GCC track the size of each instruction used
> in order to generate correct code. Because the fina
On Tue, May 1, 2018 at 9:46 AM Nadav Amit wrote:
> My bad. It’s not the new-line. Let me do some more digging.
From the gcc docs:
Some targets require that GCC track the size of each instruction used
in order to generate correct code. Because the final length of the
code produced by
On Tue, May 1, 2018 at 9:39 AM Nadav Amit wrote:
> Would it be reasonable to remove new-lines in such cases?
Yeah, that may be fine for some of our (already illegible) section crud.
Linus
Nadav Amit wrote:
> Linus Torvalds wrote:
>
>> On Tue, May 1, 2018 at 6:40 AM Josh Poimboeuf wrote:
>>
>>> But if I remove the section completely by removing the
>>> pushsection/popsection, then copy_overflow() gets inlined.
>>
>>> So GCC's inlining decisions are somehow influenced by the ex
Linus Torvalds wrote:
> On Tue, May 1, 2018 at 6:40 AM Josh Poimboeuf wrote:
>
>> But if I remove the section completely by removing the
>> pushsection/popsection, then copy_overflow() gets inlined.
>
>> So GCC's inlining decisions are somehow influenced by the existence of
>> some random empt
On Tue, May 1, 2018 at 6:40 AM Josh Poimboeuf wrote:
> But if I remove the section completely by removing the
> pushsection/popsection, then copy_overflow() gets inlined.
> So GCC's inlining decisions are somehow influenced by the existence of
> some random empty section. This definitely seems
On Tue, May 01, 2018 at 06:50:14AM +, Nadav Amit wrote:
> When gcc considers the size of a function for inlining decisions, it
> apparently considers *all* sections. Since the kernel extensively uses
> sections for things other than code (e.g., exception-table, bug-table), the
> optimality of t
When gcc considers the size of a function for inlining decisions, it
apparently considers *all* sections. Since the kernel extensively uses
sections for things other than code (e.g., exception-table, bug-table), the
optimality of these decisions seem questionable to me.
The objtool’s sections may
8 matches
Mail list logo