Re: [PATCH 0/2] module: Split modules_install compression and in-kernel decompression

2024-08-19 Thread Luis Chamberlain
On Mon, Jul 22, 2024 at 11:06:20AM +0200, Petr Pavlu wrote: > Allow enabling the in-kernel module decompression support separately, > without requiring to enable also the automatic compression during > 'make modules_install'. Applied and pushed, thanks! Luis

Re: [PATCH 1/2] module: Split modules_install compression and in-kernel decompression

2024-07-28 Thread Masahiro Yamada
then each module gets compressed during > >> 'make modules_install' and additionally one can also enable support for > >> a respective direct in-kernel decompression support. This means that the > >> decompression support cannot be enabled without the automatic com

Re: [PATCH 1/2] module: Split modules_install compression and in-kernel decompression

2024-07-25 Thread Petr Pavlu
On 7/22/24 12:23, Masahiro Yamada wrote: > On Mon, Jul 22, 2024 at 6:07 PM Petr Pavlu wrote: >> >> The kernel configuration allows specifying a module compression mode. If >> one is selected then each module gets compressed during >> 'make modules_install'

Re: [PATCH 1/2] module: Split modules_install compression and in-kernel decompression

2024-07-22 Thread Masahiro Yamada
On Mon, Jul 22, 2024 at 6:07 PM Petr Pavlu wrote: > > The kernel configuration allows specifying a module compression mode. If > one is selected then each module gets compressed during > 'make modules_install' and additionally one can also enable support for > a re

[PATCH 1/2] module: Split modules_install compression and in-kernel decompression

2024-07-22 Thread Petr Pavlu
The kernel configuration allows specifying a module compression mode. If one is selected then each module gets compressed during 'make modules_install' and additionally one can also enable support for a respective direct in-kernel decompression support. This means that the decompressi

[PATCH 0/2] module: Split modules_install compression and in-kernel decompression

2024-07-22 Thread Petr Pavlu
Allow enabling the in-kernel module decompression support separately, without requiring to enable also the automatic compression during 'make modules_install'. Petr Pavlu (2): module: Split modules_install compression and in-kernel decompression module: Clean up the description of M

Re: [PATCH 1/9] kbuild: remove unneeded mkdir for external modules_install

2021-04-07 Thread Masahiro Yamada
a/Makefile b/Makefile > index ed8bd815e8a3..0e06db5ed9d8 100644 > --- a/Makefile > +++ b/Makefile > @@ -1779,10 +1779,8 @@ $(MODORDER): descend > PHONY += modules_install > modules_install: _emodinst_ _emodinst_post > > -install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extr

[PATCH 1/9] kbuild: remove unneeded mkdir for external modules_install

2021-03-31 Thread Masahiro Yamada
+= modules_install modules_install: _emodinst_ _emodinst_post -install-dir := $(if $(INSTALL_MOD_DIR),$(INSTALL_MOD_DIR),extra) PHONY += _emodinst_ _emodinst_: - $(Q)mkdir -p $(MODLIB)/$(install-dir) $(Q)$(MAKE) -f $(srctree)/scripts/Makefile.modinst PHONY += _emodinst_post

Re: [PATCH] Revert "modsign: Abort modules_install when signing fails"

2019-03-16 Thread Masahiro Yamada
On Sat, Mar 16, 2019 at 1:25 AM Douglas Anderson wrote: > > This reverts commit caf6fe91ddf62a96401e21e9b7a07227440f4185. > > The commit was fine but is no longer needed as of commit 3a2429e1faf4 > ("kbuild: change if_changed_rule for multi-line recipe"). Let's go > back to using ";" to be consis

[PATCH] Revert "modsign: Abort modules_install when signing fails"

2019-03-15 Thread Douglas Anderson
This reverts commit caf6fe91ddf62a96401e21e9b7a07227440f4185. The commit was fine but is no longer needed as of commit 3a2429e1faf4 ("kbuild: change if_changed_rule for multi-line recipe"). Let's go back to using ";" to be consistent. For some discussion, see: https://lkml.kernel.org/r/CAK7LNAS

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-11 Thread Doug Anderson
perhaps with less complexity. > > > > > > > > Specifically I observed that by timing the parsing stage of the > > > > Makefile by adding statements like this to the beginning and end of > > > > the Makefile: > > > > ZZZ := $(shell echo &q

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Masahiro Yamada
t; > > the Makefile: > > > ZZZ := $(shell echo "$$(date '+%T.%N'): ..." >> /tmp/timing.txt) > > > > > > ...that three targets were spending 3 seconds each parsing the > > > Makefile in my environment (building a Chrome OS kernel wi

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Doug Anderson
rsing stage of the > > Makefile by adding statements like this to the beginning and end of > > the Makefile: > > ZZZ := $(shell echo "$$(date '+%T.%N'): ..." >> /tmp/timing.txt) > > > > ...that three targets were spending 3 seconds each parsing

Re: [PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Guenter Roeck
t;> /tmp/timing.txt) > > ...that three targets were spending 3 seconds each parsing the > Makefile in my environment (building a Chrome OS kernel with clang) > when it felt like they ought to be quick. These were: install, > modules_install and kernelrelease > > I saw t

[PATCH] kbuild: Speed up install, modules_install and kernelrelease

2019-03-08 Thread Douglas Anderson
ts like this to the beginning and end of the Makefile: ZZZ := $(shell echo "$$(date '+%T.%N'): ..." >> /tmp/timing.txt) ...that three targets were spending 3 seconds each parsing the Makefile in my environment (building a Chrome OS kernel with clang) when it felt like

Re: make modules_install install is failing

2019-03-04 Thread Tobin C. Harding
On Tue, Feb 05, 2019 at 11:30:53AM +0530, Bharath Vedartham wrote: > Hi all, > > I am unable to execute make modules_install install. > I get the following error: Could you show the complete commands you are trying please thanks, Tobin.

make modules_install install is failing

2019-02-04 Thread Bharath Vedartham
Hi all, I am unable to execute make modules_install install. I get the following error: ln: target 'linux-00096-gd1aa1a8/source' is not a directory Makefile:1281: recipe for target '_modinst_' failed make[1]: *** [_modinst_] Error 1 Makefile:296: recipe for target '_

Re: [PATCH v2] modules_install: warn when missing System.map file

2018-09-08 Thread Masahiro Yamada
2018-09-07 8:37 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > If there is no System.map file for "make modules_install", > scripts/depmod.sh will silently exit with success, having done > nothing. Since this is an unexpected situation, change it to > report a

[PATCH v2] modules_install: warn when missing System.map file

2018-09-06 Thread Randy Dunlap
From: Randy Dunlap If there is no System.map file for "make modules_install", scripts/depmod.sh will silently exit with success, having done nothing. Since this is an unexpected situation, change it to report a Warning for the missing file. The behavior is not changed except for t

Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-09-05 Thread Randy Dunlap
On 09/05/2018 12:17 AM, Masahiro Yamada wrote: > Hi Randy, > > 2018-09-01 7:33 GMT+09:00 Randy Dunlap : >> From: Randy Dunlap >> >> If there is no System.map file for "make modules_install", >> scripts/depmod.sh will silently exit with success

Re: [PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-09-05 Thread Masahiro Yamada
Hi Randy, 2018-09-01 7:33 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > If there is no System.map file for "make modules_install", > scripts/depmod.sh will silently exit with success, having done > nothing. Since this is an unexpected situation, change it to &

[PATCH] kbuild: modules_install: Warn if System.map file is not found

2018-08-31 Thread Randy Dunlap
From: Randy Dunlap If there is no System.map file for "make modules_install", scripts/depmod.sh will silently exit with success, having done nothing. Since this is an unexpected situation, change it to report a Warning for the missing file. The behavior is not changed except for t

Re: [PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error

2018-08-31 Thread Masahiro Yamada
2018-08-29 4:59 GMT+09:00 Randy Dunlap : > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status: > > Warning: 'make modules_install' requires /sbin/depmod. Please install it. > This

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-28 Thread Masahiro Yamada
gt; > Added for v4. Thanks. >> BTW, if System.map is missing, depmod is silently skipped. >> >> >> I think if System.map is missing, a user is doing something wrong, >> but you could do like this: >> >> $ make mrproper >>[snip] &g

[PATCH v4] modules_install: make missing $DEPMOD a Warning instead of an Error

2018-08-28 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status: Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Change the Error to a Warning because &quo

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-28 Thread Randy Dunlap
; Could you add the motivation of this change > (as Nikolaus reported) ? > > Without the reason recorded in git-log, > somebody may wonder why this commit is useful. > Added for v4. > >> Warning: 'make modules_install' requires /sbin/depmod. Please install

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread Masahiro Yamada
d in git-log, somebody may wonder why this commit is useful. > Warning: 'make modules_install' requires /sbin/depmod. Please install it. > This is probably in the kmod package. > > Signed-off-by: Randy Dunlap > Fixes: 934193a654c1 ("kbuild: verify that $DEPMOD i

Re: [PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread H. Nikolaus Schaller
Hi Randy, > Am 23.08.2018 um 20:13 schrieb Randy Dunlap : > > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status. > > Warning: 'make modules_install' requires /sbin/depmod. Please

[PATCH v3] modules_install: make missing $DEPMOD a warning instead of an error

2018-08-23 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status. Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Signed-off-by: Randy Dunlap Fixes: 93

Re: [PATCH v2] modules_install: make missing $DEPMOD a warning instead of error

2018-08-23 Thread Greg KH
On Thu, Aug 23, 2018 at 10:52:39AM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > When $DEPMOD is not found, only print a warning instead of exiting > with an error message and error status. > > Warning: 'make modules_install' requires /sbin/depmod. Please insta

[PATCH v2] modules_install: make missing $DEPMOD a warning instead of error

2018-08-23 Thread Randy Dunlap
From: Randy Dunlap When $DEPMOD is not found, only print a warning instead of exiting with an error message and error status. Warning: 'make modules_install' requires /sbin/depmod. Please install it. This is probably in the kmod package. Signed-off-by: Randy Dunlap --- v2: add missi

[PATCH 3.12 06/84] kbuild: Do not run modules_install and install in paralel

2016-10-17 Thread Jiri Slaby
12 @@ ifeq ($(KBUILD_EXTMOD),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) + mixed-targets := 1 +endif +endif ifeq ($(mix

[PATCH 4.4 15/73] kbuild: Do not run modules_install and install in paralel

2016-09-28 Thread Greg Kroah-Hartman
dif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) + mixed-targets := 1 +endif +endif ifeq ($(mixed-targets),1) # ===

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2015-12-10 Thread Michal Marek
gt; @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >> endif >> endif >> endif >> +# install and module_install need also be processed one by one >> +ifneq ($(filter install,$(MAKECMDGOALS)),) >> +ifneq ($(

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2015-12-09 Thread Andy Lutomirski
stall and module_install need also be processed one by one > +ifneq ($(filter install,$(MAKECMDGOALS)),) > +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) > + mixed-targets := 1 > +endif > +endif > > ifeq ($(mixed-targets),1) > # =

[PATCH 11/27] modsign: Abort modules_install when signing fails [ver #7]

2015-08-05 Thread David Howells
From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: David Howells --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9d8868..07650eeaaf06 100644 --- a/scripts/Makef

[PATCH 09/27] modsign: Abort modules_install when signing fails

2015-07-17 Thread David Howells
From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: David Howells --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9d8868..07650eeaaf06 100644 --- a/scripts/Makef

[PATCH 09/20] modsign: Abort modules_install when signing fails [ver #5]

2015-05-28 Thread David Howells
From: David Woodhouse Signed-off-by: David Woodhouse Signed-off-by: David Howells --- scripts/Makefile.modinst |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9d8868..07650eeaaf06 100644 --- a/scripts/Makef

[PATCH 9/8] modsign: Abort modules_install when signing fails

2015-05-19 Thread David Woodhouse
Signed-off-by: David Woodhouse --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9..07650ee 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -22,7 +22,7 @@ quiet_c

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Mimi Zohar
On Tue, 2015-05-19 at 12:57 +, Woodhouse, David wrote: > On Tue, 2015-05-19 at 07:45 -0400, Mimi Zohar wrote: > > > > /bin/sh: line 1: 22771 Segmentation fault (core dumped) > > scripts/sign-file "sha256" "pkcs11:manufacturer=piv_II;id=%01" > > ./signing_key.x509 /lib/modules/4.1.0-rc1

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Woodhouse, David
On Tue, 2015-05-19 at 07:45 -0400, Mimi Zohar wrote: > > /bin/sh: line 1: 22771 Segmentation fault (core dumped) > scripts/sign-file "sha256" "pkcs11:manufacturer=piv_II;id=%01" > ./signing_key.x509 /lib/modules/4.1.0-rc1 > -test+/kernel/net/ipv6/netfilter/ip6table_filter.ko > /home/zohar/s

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-19 Thread Mimi Zohar
On Tue, 2015-05-19 at 06:40 +, Woodhouse, David wrote: > On Mon, 2015-05-18 at 21:29 -0400, Mimi Zohar wrote: > > On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote: > > > Signed-off-by: David Woodhouse > > With this patch, as expected the modules_install

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-18 Thread Woodhouse, David
On Mon, 2015-05-18 at 21:29 -0400, Mimi Zohar wrote: > On Fri, 2015-05-15 at 17:52 +0100, David Woodhouse wrote: > > Signed-off-by: David Woodhouse > > I assume the patch descriptions will be added before being upstreamed. This patch aborts modules_install when signing fails

Re: [PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-18 Thread Mimi Zohar
/$(notdir $@) ; \ > -$(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) > ; \ > +$(mod_sign_cmd) $(2)/$(notdir $@) $(patsubst %,|| true,$(KBUILD_EXTMOD)) > && \ > $(mod_compress_cmd) $(2)/$(notdir $@) With this patch, as expected the mo

[PATCH 1/4] modsign: Abort modules_install when signing fails

2015-05-15 Thread David Woodhouse
Signed-off-by: David Woodhouse --- scripts/Makefile.modinst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.modinst b/scripts/Makefile.modinst index e48a4e9..07650ee 100644 --- a/scripts/Makefile.modinst +++ b/scripts/Makefile.modinst @@ -22,7 +22,7 @@ quiet_c

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
On Sun, Oct 12, 2014 at 12:40 PM, Willy Tarreau wrote: > Hi, > > On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: >> Hello Bertrand, >> >> Does this need any user space support? Cos currently on a debian >> testing box(powerpc) enabling this options causes a boot hang while >> mounting the r

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Willy Tarreau
Hi, On Sun, Oct 12, 2014 at 11:50:59AM -0400, Andev wrote: > Hello Bertrand, > > Does this need any user space support? Cos currently on a debian > testing box(powerpc) enabling this options causes a boot hang while > mounting the root file system. I suspect that your module-ini-tools/kmod are b

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-10-12 Thread Andev
no sign, no compress), the following table > shows observed disk space gain based on the allmodconfig .config : > >| time| >+-+-----+ > | manual .ko

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-20 Thread Rusty Russell
s), the following table > shows observed disk space gain based on the allmodconfig .config : > >| time| >+-+-+ > | manual .ko | m

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-20 Thread Rusty Russell
Andi Kleen writes: >> I understand your concern about this, but does is make sense to not use >> -9 when then following files use gzip or other compression tools with -9 : > > Just because someone else makes mistakes doesn't mean that you should > make them too. To be fair, you didn't provide har

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Andi Kleen
> I understand your concern about this, but does is make sense to not use > -9 when then following files use gzip or other compression tools with -9 : Just because someone else makes mistakes doesn't mean that you should make them too. -Andi -- To unsubscribe from this list: send the line "unsub

[PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
| time| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain +-+-+--+ -| | 18.61s | 378M | GZIP | 3

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
Hi, D'ar meurzh 19 a viz Eost 2014 e 19 eur 55, « Rusty Russell » he deus skrivet : > Andi Kleen writes: > > Bertrand Jacquin writes: > >> > >> +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed > >> +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZ

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Rusty Russell
Andi Kleen writes: > Bertrand Jacquin writes: >> >> +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed >> +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP >> +# or CONFIG_MODULE_COMPRESS_XZ. >> + >> +mod_compress_cmd = true >> +ifdef CONFIG_MODULE

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Bertrand Jacquin
Hi, D'ar meurzh 19 a viz Eost 2014 e 15 eur 17, « Andi Kleen » he deus skrivet : > Bertrand Jacquin writes: > > > > +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed > > +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP > > +# or CONFIG_MODULE_COM

Re: [PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-19 Thread Andi Kleen
Bertrand Jacquin writes: > > +# CONFIG_MODULE_COMPRESS, if defined, will cause module to be compressed > +# after they are installed in agreement with CONFIG_MODULE_COMPRESS_GZIP > +# or CONFIG_MODULE_COMPRESS_XZ. > + > +mod_compress_cmd = true > +ifdef CONFIG_MODULE_COMPRESS > + ifdef CONFIG_M

[PATCH 2/3] kbuild: handle module compression while running 'make modules_install'.

2014-08-16 Thread Bertrand Jacquin
| time| +-+-+ | manual .ko | make | size | percent | compression | modules_install | | gain +-+-+--+ -| | 18.61s | 378M | GZIP | 3m16s | 3m37s | 102M | 73.41% XZ | 5

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-07 Thread Michal Marek
kefile >>>>> +++ b/Makefile >>>>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >>>>> endif >>>>> endif >>>>> endif >>>>> +# install and module_install need also be processed one by one &

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-04 Thread Andy Lutomirski
t;>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/Makefile b/Makefile >>>> index 7680d7c..7e5e483 100644 >>>> --- a/Makefile >>>> +++ b/Makefile >>>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >>>>

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-07-04 Thread Michal Marek
>>> index 7680d7c..7e5e483 100644 >>> --- a/Makefile >>> +++ b/Makefile >>> @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >>> endif >>> endif >>> endif >>> +# install and module_install need also b

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-06-13 Thread Andy Lutomirski
gt; @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) >> endif >> endif >> endif >> +# install and module_install need also be processed one by one >> +ifneq ($(filter install,$(MAKECMDGOALS)),) >> +ifneq ($(filter modules_install,$(MAKECMD

Re: [PATCH] kbuild: Do not run modules_install and install in paralel

2014-06-13 Thread Michal Marek
stall and module_install need also be processed one by one > +ifneq ($(filter install,$(MAKECMDGOALS)),) > +ifneq ($(filter modules_install,$(MAKECMDGOALS)),) > + mixed-targets := 1 > +endif > +endif Note that this version does not enforce the ordering, i

[PATCH] kbuild: Do not run modules_install and install in paralel

2014-06-13 Thread Michal Marek
file index 7680d7c..7e5e483 100644 --- a/Makefile +++ b/Makefile @@ -503,6 +503,12 @@ ifeq ($(KBUILD_EXTMOD),) endif endif endif +# install and module_install need also be processed one by one +ifneq ($(filter install,$(MAKECMDGOALS)),) +ifneq ($(filter modul

Re: [PATCH] x86,build: Fix make -jN modules_install install

2014-06-12 Thread Andy Lutomirski
On Thu, Jun 12, 2014 at 1:33 AM, Michal Marek wrote: > Dne 11.6.2014 21:41, Andy Lutomirski napsal(a): >> Every few months, I forget why I type: >> >> $ sudo make -j12 modules_install && sudo make -j12 install >> >> instead of just: >> >> $ s

Re: [PATCH] x86,build: Fix make -jN modules_install install

2014-06-12 Thread Michal Marek
Dne 11.6.2014 21:41, Andy Lutomirski napsal(a): > Every few months, I forget why I type: > > $ sudo make -j12 modules_install && sudo make -j12 install > > instead of just: > > $ sudo make -j12 modules_install install > > I try the latter, it appears to w

Re: [PATCH] x86,build: Fix make -jN modules_install install

2014-06-11 Thread Andy Lutomirski
On Wed, Jun 11, 2014 at 12:44 PM, Sam Ravnborg wrote: > On Wed, Jun 11, 2014 at 12:41:57PM -0700, Andy Lutomirski wrote: >> Every few months, I forget why I type: >> >> $ sudo make -j12 modules_install && sudo make -j12 install >> >> instead of just: >&

Re: [PATCH] x86,build: Fix make -jN modules_install install

2014-06-11 Thread Sam Ravnborg
On Wed, Jun 11, 2014 at 12:41:57PM -0700, Andy Lutomirski wrote: > Every few months, I forget why I type: > > $ sudo make -j12 modules_install && sudo make -j12 install > > instead of just: > > $ sudo make -j12 modules_install install > > I try the latt

[PATCH] x86,build: Fix make -jN modules_install install

2014-06-11 Thread Andy Lutomirski
Every few months, I forget why I type: $ sudo make -j12 modules_install && sudo make -j12 install instead of just: $ sudo make -j12 modules_install install I try the latter, it appears to work, and then my machine won't boot because dracut got confused. This fixes it once and fo

[PATCH v2 4/4] MODSIGN: Add option to not sign modules during modules_install

2013-01-24 Thread Michal Marek
n MODULE_SIG + help + Sign all modules during make modules_install. Without this option, + modules must be signed manually, using the scripts/sign-file tool. + +comment "Do not forget to sign required modules with scripts/sign-file" + depends on MODULE_SIG

[PATCH 4/4] MODSIGN: Add option to not sign modules during modules_install

2013-01-23 Thread Michal Marek
Sign all modules during make modules_install. Without this option, + modules must be signed manually, using the scripts/sign-file tool. + +comment "Do not forget to sign required modules with scripts/sign-file" + depends on MODULE_SIG_FORCE && !MODULE_SIG_ALL +

Re: Failure while make modules_install if kmod was compiled with --with-rootprefix set

2012-08-30 Thread Michal Marek
On 10.8.2012 23:50, Arokux B. wrote: > Dear Mr. Marek, dear all, > > I have detected a hidden failure while building the kernel. If > --with-rootprefix is set for kmod, then depmod will look for modules > installed at the location $ROOTPREFIX/lib/modules/. The > kernel build system does not know a

Failure while make modules_install if kmod was compiled with --with-rootprefix set

2012-08-10 Thread Arokux B.
Dear Mr. Marek, dear all, I have detected a hidden failure while building the kernel. If --with-rootprefix is set for kmod, then depmod will look for modules installed at the location $ROOTPREFIX/lib/modules/. The kernel build system does not know anything about $ROOTPREFIX, and so the wrong direc

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread Jan Engelhardt
On Dec 29 2007 16:51, [EMAIL PROTECTED] wrote: > >> Erm... same system here - >> >> $ gzip -cd /proc/config.gz | grep DEBUG_INFO >> # CONFIG_DEBUG_INFO is not set >> >> I think you managed to snafu something during building. > >mhh - i have kernel-default-2.6.22.13-0.3 kernel (didn`t touch that

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread devzero
L PROTECTED], [EMAIL PROTECTED], Linux Kernel Mailing List > > Betreff: Re: kbuild: modules_install regression ? - depmod > > > On Dec 29 2007 14:30, [EMAIL PROTECTED] wrote: > >> On Dec 28 2007 16:08, [EMAIL PROTECTED] wrote: > >> > > >> >i

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread Jan Engelhardt
On Dec 29 2007 14:30, [EMAIL PROTECTED] wrote: >> On Dec 28 2007 16:08, [EMAIL PROTECTED] wrote: >> > >> >i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM >> > >> >System is openSUSE 10.3 >> >> If you enable CONFIG_DEBUG_INFO, don't be surprised. > >oh yes, that`s it! > >apparent

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread Jon Masters
On Sat, 2007-12-29 at 14:30 +0100, [EMAIL PROTECTED] wrote: > > Though I'd say depmod should ignore the debug sections. > > so depmod is acting sort of "stupid" here ? depmod has a bunch of issues that need taking care of, this is just one of them, but yeah, for now it should just ignore these

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread devzero
> [Adding jcm to Cc] > > On Dec 28 2007 16:08, [EMAIL PROTECTED] wrote: > > > >i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM > > > >System is openSUSE 10.3 > > > >on "make modules_install" , depmod reproduceably dies

Re: kbuild: modules_install regression ? - depmod

2007-12-29 Thread Jon Masters
On Sat, 2007-12-29 at 02:42 +0100, Jan Engelhardt wrote: > [Adding jcm to Cc] > > On Dec 28 2007 16:08, [EMAIL PROTECTED] wrote: > > > >i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM > > > >System is openSUSE 10.3 > > > >on "

Re: kbuild: modules_install regression ? - depmod

2007-12-28 Thread Jan Engelhardt
[Adding jcm to Cc] On Dec 28 2007 16:08, [EMAIL PROTECTED] wrote: > >i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM > >System is openSUSE 10.3 > >on "make modules_install" , depmod reproduceably dies with out of memory error >when it is

Re: kbuild: modules_install regression ? - depmod

2007-12-28 Thread Jan-Simon Möller
Am Freitag 28 Dezember 2007 16:08:19 schrieb [EMAIL PROTECTED]: > i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM > > System is openSUSE 10.3 > > on "make modules_install" , depmod reproduceably dies with out of memory > error when it is ~800MB VSZ an

Re: kbuild: modules_install regression ? - depmod

2007-12-28 Thread devzero
i have the same issue, but with 2.6.24-rc6 on a box with 512MB RAM System is openSUSE 10.3 on "make modules_install" , depmod reproduceably dies with out of memory error when it is ~800MB VSZ and ~350MB RSS this happens on different hardware. any clue what`s going wrong? how much mem

kbuild: modules_install regression ? - depmod

2007-10-31 Thread Jan-Simon Möller
Hi! I compiled kernel 2.6.24-rc1 (latest git as of today) on a Box with 256MB Ram. During "make modules_install" I got these errors: DEPMOD 2.6.24-rc1-default WARNING: Can't read module /lib/modules/2.6.24-rc1-default/kernel/net/bridge/bridge.ko: Cannot allocate memory WARN

Re: 2.6.22-rc3: regression: make M=$PWD modules_install does nothing

2007-05-29 Thread Andrey Borzenkov
/linux-git O=$HOME/build/linux-2.6.22 M=PWD > > V=1 > > that in this commandline you say M=PWD > > > modules_install > > make: Entering directory `/home/bor/src/linux-git' > > make -C /home/bor/build/linux-2.6.22 \ > > KBUILD_SRC=/home/bor/

Re: 2.6.22-rc3: regression: make M=$PWD modules_install does nothing

2007-05-29 Thread Sam Ravnborg
you say M=PWD > modules_install > make: Entering directory `/home/bor/src/linux-git' > make -C /home/bor/build/linux-2.6.22 \ > KBUILD_SRC=/home/bor/src/linux-git \ > KBUILD_EXTMOD="PWD" -f /home/bor/src/linux-git/Makefile which tell kbuild that module i

2.6.22-rc3: regression: make M=$PWD modules_install does nothing

2007-05-27 Thread Andrey Borzenkov
This has been working up and including -rc2: {pts/1}% sudo make -C ~/src/linux-git O=$HOME/build/linux-2.6.22 M=PWD V=1 modules_install make: Entering directory `/home/bor/src/linux-git' make -C /home/bor/build/linux-2.6.22 \ KBUILD_SRC=/home/bor/src/linux-git \ KBUILD_E

Re: 2.6.20-rc6-mm2 - modules_install error

2007-01-29 Thread Matthew Frost
I have a consistent problem running 'make modules_install' after compiling. The directory structure forms in /lib/modules, but no modules install. This problem showed up under -rc6-mm1 and -rc6-mm2, but not -rc6. I'm hoping somebody has hit this before, otherwise it's git-b

Re: newbie problem: compiling kernel 2.4.4, make modules_install , Help please !

2001-05-17 Thread Keith Owens
On Thu, 17 May 2001 20:50:46 +0200 (CEST), Joel Cordonnier <[EMAIL PROTECTED]> wrote: >It's the first time that i try to compile my own >kernel. At the moment, I have an old RH 6.1 with a >2.2.12 kernel. >- make modules_install ==> PROBLEM ! >FIRST the message say

newbie problem: compiling kernel 2.4.4, make modules_install , Help please !

2001-05-17 Thread Joel Cordonnier
. All seems OK for these steps. Then - make modules and - make modules_install ==> PROBLEM ! FIRST the message say that no argument -F exist for the command /sbin/depmod. So I change in the Makefile the call if [ -r System.map ]; then /sbin/depmod -ae -F System.map 2.4.4; fi TO if [ -r Sy

Re: Possible bug for Kernel 2.4.3 -> make modules_install

2001-04-08 Thread Chmouel Boudjnah
Patrick Shirkey <[EMAIL PROTECTED]> writes: > I am having trouble installing modules. The command hangs at the > following point in the install... > > --- > Finished dependencies of target file `_modinst_post'. > Must remake target `_modinst_post'. > if [ -r System.map ]; the

Possible bug for Kernel 2.4.3 -> make modules_install

2001-04-08 Thread Patrick Shirkey
I am having trouble installing modules. The command hangs at the following point in the install... --- Finished dependencies of target file `_modinst_post'. Must remake target `_modinst_post'. if [ -r System.map ]; then /sbin/depmod -ae -F System.map 2.4.3; fi Putting child 0

Re: modules_install does not install acpi with linux-2.4.2

2001-03-20 Thread Jeff Garzik
"Juergen Rose,K17,0331-9772437,030-2425483" wrote: > if I try 'make modules_install' with linux-2.4.2 I get: > ... > mkdir -p /lib/modules/2.4.2/kernel/drivers/acpi/ > cp common.o dispatcher.o events.o hardware.o interpreter.o namespace.o > parser.o resources.o

modules_install does not install acpi with linux-2.4.2

2001-03-20 Thread Juergen Rose,K17,0331-9772437,030-2425483
Hello, if I try 'make modules_install' with linux-2.4.2 I get: ... make[1]: Entering directory `/usr/src_laptop450/linux-2.4.2/drivers' make -C acpi modules_install make[2]: Entering directory `/usr/src_laptop450/linux-2.4.2/drivers/acpi' mkdir -p /lib/modules/2.4.2/ker

Re: 2.4.2-ac13 make modules_install error

2001-03-06 Thread Matt Johnston
Hi. I've had the same problem, it also happens in 2.4.2ac12 Cheers, Matt Johnston On Wed, 7 Mar 2001 13:04, Frank Davis wrote: > Hello, >While 'make modules_install' on 2.4.2-ac13, I receive the following > error: > > make -C kernel modules_install >

Re: 2.4.2-ac13 make modules_install error

2001-03-06 Thread Keith Owens
On Wed, 7 Mar 2001 00:04:08 -0500 (EST), Frank Davis <[EMAIL PROTECTED]> wrote: >make[2]: Entering directory '/usr/src/linux/drivers/atm' >mkdir -p /lib/modules/2.4.2-ac13/kernel/$(shell ($CONFIG_SHELL) >$(TOPDIR)/scripts/pathdown.sh) >/bin/sh: CONFIG_SHELL: command not found >/bin/sh: TOPDIR: c

2.4.2-ac13 make modules_install error

2001-03-06 Thread Frank Davis
Hello, While 'make modules_install' on 2.4.2-ac13, I receive the following error: make -C kernel modules_install make[1]: Entering directory '/usr/src/linux/kernel' make[1]: Nothing to be done for 'modules_install'. .. make -C drivers modules_install make[1]

Re: modules_install target

2001-02-14 Thread Mohammad A. Haque
You're forgetting it's using System.map from your build directory and not from /boot. "J . A . Magallon" wrote: > > I have recently noticed that 'make modules_install' tries as a last step > > if [ -r System.map ]; then /sbin/depmod -ae -F System.m

Re: modules_install target

2001-02-14 Thread Keith Owens
On Thu, 15 Feb 2001 01:38:46 +0100, "J . A . Magallon" <[EMAIL PROTECTED]> wrote: >I have recently noticed that 'make modules_install' tries as a last step > >if [ -r System.map ]; then /sbin/depmod -ae -F System.map 2.4.1-ac13; fi > >I depends on &

modules_install target

2001-02-14 Thread J . A . Magallon
I have recently noticed that 'make modules_install' tries as a last step if [ -r System.map ]; then /sbin/depmod -ae -F System.map 2.4.1-ac13; fi I depends on 'make install' doing the right symlinks in /boot. Would not be better to do a: if [ -r System.map-2.4.1-ac13 ]; t

Re: Bug Report : make modules_install seems to do a wrong call to depmod, using an unknow option "-F".

2000-12-05 Thread Mohammad A. Haque
Are you using the latest version of modutils? Delaporte Frédéric wrote: > > Hello. > > make modules_install seems to do a wrong call to depmod, using an unknow > option "-F". -- ==

Bug Report : make modules_install seems to do a wrong call to depmod, using an unknow option "-F".

2000-12-05 Thread Delaporte Frédéric
Hello. make modules_install seems to do a wrong call to depmod, using an unknow option "-F". The line concerned in the Makefile is the 376th, colonne 47, character 44. Replacing "-F" by "-m" seems to solve the trouble (I've trust the depmod's man

  1   2   >