Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-10 Thread Jiri Olsa
On Mon, Mar 07, 2016 at 10:11:43PM +0100, Andi Kleen wrote: SNIP > > > > I did not see the change for print_no_aggr_metric function > > in commit: > >perf, tools, stat: Add --metric-only support for -A > > > > which I saw in the email.. > > > > however now im confused, I did not noticed I

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-10 Thread Jiri Olsa
On Mon, Mar 07, 2016 at 10:11:43PM +0100, Andi Kleen wrote: SNIP > > > > I did not see the change for print_no_aggr_metric function > > in commit: > >perf, tools, stat: Add --metric-only support for -A > > > > which I saw in the email.. > > > > however now im confused, I did not noticed I

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Andi Kleen
On Mon, Mar 07, 2016 at 07:48:39PM +0100, Jiri Olsa wrote: > On Mon, Mar 07, 2016 at 07:22:27PM +0100, Andi Kleen wrote: > > On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote: > > > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: > > > > > > SNIP > > > > > > > > > > > % perf

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Andi Kleen
On Mon, Mar 07, 2016 at 07:48:39PM +0100, Jiri Olsa wrote: > On Mon, Mar 07, 2016 at 07:22:27PM +0100, Andi Kleen wrote: > > On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote: > > > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: > > > > > > SNIP > > > > > > > > > > > % perf

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Jiri Olsa
On Mon, Mar 07, 2016 at 07:22:27PM +0100, Andi Kleen wrote: > On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote: > > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: > > > > SNIP > > > > > > > > % perf stat -x, --metric-only -a -I 1000 > > > 1.001381652,frontend cycles

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Jiri Olsa
On Mon, Mar 07, 2016 at 07:22:27PM +0100, Andi Kleen wrote: > On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote: > > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: > > > > SNIP > > > > > > > > % perf stat -x, --metric-only -a -I 1000 > > > 1.001381652,frontend cycles

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Andi Kleen
On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote: > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: > > SNIP > > > > > % perf stat -x, --metric-only -a -I 1000 > > 1.001381652,frontend cycles idle,insn per cycle,stalled cycles per > > insn,branch-misses of all

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Andi Kleen
On Mon, Mar 07, 2016 at 11:08:42AM +0100, Jiri Olsa wrote: > On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: > > SNIP > > > > > % perf stat -x, --metric-only -a -I 1000 > > 1.001381652,frontend cycles idle,insn per cycle,stalled cycles per > > insn,branch-misses of all

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Jiri Olsa
On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: SNIP > > % perf stat -x, --metric-only -a -I 1000 > 1.001381652,frontend cycles idle,insn per cycle,stalled cycles per > insn,branch-misses of all branches, > 1.001381652,173.32,0.83,2.09,1.73, >

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-07 Thread Jiri Olsa
On Thu, Mar 03, 2016 at 03:57:31PM -0800, Andi Kleen wrote: SNIP > > % perf stat -x, --metric-only -a -I 1000 > 1.001381652,frontend cycles idle,insn per cycle,stalled cycles per > insn,branch-misses of all branches, > 1.001381652,173.32,0.83,2.09,1.73, >

perf, tools: Refactor and support interval and CSV metrics

2016-03-03 Thread Andi Kleen
Fixed even more last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8:

perf, tools: Refactor and support interval and CSV metrics

2016-03-03 Thread Andi Kleen
Fixed even more last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8:

perf, tools: Refactor and support interval and CSV metrics

2016-03-02 Thread Andi Kleen
Fixed even more last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8:

perf, tools: Refactor and support interval and CSV metrics

2016-03-02 Thread Andi Kleen
Fixed even more last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8:

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-01 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 01, 2016 at 10:57:45AM -0800, Andi Kleen escreveu: > Fixed even more last feedback. > > [v5: Fix mainly bisect problems. No regressions introduced by one > patch and fixed again later. Some minor fixes in addition] > [v6: Fix running/noise printing patch.] > [v7: Reorder and merge two

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-01 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 01, 2016 at 10:57:45AM -0800, Andi Kleen escreveu: > Fixed even more last feedback. > > [v5: Fix mainly bisect problems. No regressions introduced by one > patch and fixed again later. Some minor fixes in addition] > [v6: Fix running/noise printing patch.] > [v7: Reorder and merge two

perf, tools: Refactor and support interval and CSV metrics

2016-03-01 Thread Andi Kleen
Fixed even more last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8:

perf, tools: Refactor and support interval and CSV metrics

2016-03-01 Thread Andi Kleen
Fixed even more last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8:

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-01 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 29, 2016 at 02:36:19PM -0800, Andi Kleen escreveu: > Fixed last feedback. > > [v5: Fix mainly bisect problems. No regressions introduced by one > patch and fixed again later. Some minor fixes in addition] > [v6: Fix running/noise printing patch.] > [v7: Reorder and merge two patches

Re: perf, tools: Refactor and support interval and CSV metrics

2016-03-01 Thread Arnaldo Carvalho de Melo
Em Mon, Feb 29, 2016 at 02:36:19PM -0800, Andi Kleen escreveu: > Fixed last feedback. > > [v5: Fix mainly bisect problems. No regressions introduced by one > patch and fixed again later. Some minor fixes in addition] > [v6: Fix running/noise printing patch.] > [v7: Reorder and merge two patches

perf, tools: Refactor and support interval and CSV metrics

2016-02-29 Thread Andi Kleen
Fixed last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8: Minor fixes

perf, tools: Refactor and support interval and CSV metrics

2016-02-29 Thread Andi Kleen
Fixed last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8: Minor fixes

perf, tools: Refactor and support interval and CSV metrics

2016-02-26 Thread Andi Kleen
[v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8: Minor fixes for review feedback.

perf, tools: Refactor and support interval and CSV metrics

2016-02-26 Thread Andi Kleen
[v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0] [v8: Minor fixes for review feedback.

perf, tools: Refactor and support interval and CSV metrics

2016-02-17 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed

perf, tools: Refactor and support interval and CSV metrics

2016-02-17 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed

perf, tools: Refactor and support interval and CSV metrics

2016-01-30 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed

perf, tools: Refactor and support interval and CSV metrics

2016-01-30 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed

perf, tools: Refactor and support interval and CSV metrics

2016-01-26 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed

perf, tools: Refactor and support interval and CSV metrics

2016-01-26 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition] [v6: Fix running/noise printing patch.] [v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed

Re: perf, tools: Refactor and support interval and CSV metrics

2016-01-22 Thread Jiri Olsa
On Tue, Jan 19, 2016 at 06:26:43PM -0800, Andi Kleen wrote: > [v5: Fix mainly bisect problems. No regressions introduced by one > patch and fixed again later. Some minor fixes in addition] > [v6: Fix running/noise printing patch.] > [v7: Reorder and merge two patches to avoid a bisect hole where

Re: perf, tools: Refactor and support interval and CSV metrics

2016-01-22 Thread Jiri Olsa
On Tue, Jan 19, 2016 at 06:26:43PM -0800, Andi Kleen wrote: > [v5: Fix mainly bisect problems. No regressions introduced by one > patch and fixed again later. Some minor fixes in addition] > [v6: Fix running/noise printing patch.] > [v7: Reorder and merge two patches to avoid a bisect hole where

perf, tools: Refactor and support interval and CSV metrics v7

2015-12-14 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No

perf, tools: Refactor and support interval and CSV metrics v7

2015-12-14 Thread Andi Kleen
Rebased tree and fixed Jiri's last feedback. [v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No

Re: perf, tools: Refactor and support interval and CSV metrics v6

2015-11-04 Thread Andi Kleen
On Tue, Nov 03, 2015 at 08:46:16AM +0100, Jiri Olsa wrote: > On Mon, Nov 02, 2015 at 05:50:19PM -0800, Andi Kleen wrote: > > [v4: Addressed all review feedback.] > > [v3: Addressed all review feedback. Update manpage for CSV. Various changes > > (see individual patches). Remove some more

Re: perf, tools: Refactor and support interval and CSV metrics v6

2015-11-04 Thread Andi Kleen
On Tue, Nov 03, 2015 at 08:46:16AM +0100, Jiri Olsa wrote: > On Mon, Nov 02, 2015 at 05:50:19PM -0800, Andi Kleen wrote: > > [v4: Addressed all review feedback.] > > [v3: Addressed all review feedback. Update manpage for CSV. Various changes > > (see individual patches). Remove some more

Re: perf, tools: Refactor and support interval and CSV metrics v6

2015-11-02 Thread Jiri Olsa
On Mon, Nov 02, 2015 at 05:50:19PM -0800, Andi Kleen wrote: > [v4: Addressed all review feedback.] > [v3: Addressed all review feedback. Update manpage for CSV. Various changes > (see individual patches). Remove some more redundant code > in printout callers.] > [v2: Addressed (near)

perf, tools: Refactor and support interval and CSV metrics v6

2015-11-02 Thread Andi Kleen
[v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for

Re: perf, tools: Refactor and support interval and CSV metrics v6

2015-11-02 Thread Jiri Olsa
On Mon, Nov 02, 2015 at 05:50:19PM -0800, Andi Kleen wrote: > [v4: Addressed all review feedback.] > [v3: Addressed all review feedback. Update manpage for CSV. Various changes > (see individual patches). Remove some more redundant code > in printout callers.] > [v2: Addressed (near)

perf, tools: Refactor and support interval and CSV metrics v6

2015-11-02 Thread Andi Kleen
[v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for

perf, tools: Refactor and support interval and CSV metrics v5

2015-10-23 Thread Andi Kleen
I hope this version is acceptable now. [v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage

perf, tools: Refactor and support interval and CSV metrics v5

2015-10-23 Thread Andi Kleen
I hope this version is acceptable now. [v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage

perf, tools: Refactor and support interval and CSV metrics v4

2015-09-21 Thread Andi Kleen
[v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for

perf, tools: Refactor and support interval and CSV metrics v4

2015-09-21 Thread Andi Kleen
[v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for

perf, tools: Refactor and support interval and CSV metrics v4

2015-09-04 Thread Andi Kleen
[v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for

perf, tools: Refactor and support interval and CSV metrics v4

2015-09-04 Thread Andi Kleen
[v4: Addressed all review feedback.] [v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for

Re: perf, tools: Refactor and support interval and CSV metrics v3

2015-09-03 Thread Andi Kleen
> can't see perf/stat-metrics-5 branch > > [jolsa@krava perf]$ git remote update ak > Fetching ak > [jolsa@krava perf]$ git branch -r | grep perf/stat-metrics- > ak/perf/stat-metrics-3 > ak/perf/stat-metrics-4 > ak/perf/stat-metrics-refactor-2 > [jolsa@krava perf]$ Try again. I pushed

Re: perf, tools: Refactor and support interval and CSV metrics v3

2015-09-03 Thread Jiri Olsa
On Wed, Sep 02, 2015 at 04:35:45PM -0700, Andi Kleen wrote: > [v3: Addressed all review feedback. Update manpage for CSV. Various changes > (see individual patches). Remove some more redundant code > in printout callers.] > [v2: Addressed (near) all review feedback. No manpage updates

Re: perf, tools: Refactor and support interval and CSV metrics v3

2015-09-03 Thread Jiri Olsa
On Wed, Sep 02, 2015 at 04:35:45PM -0700, Andi Kleen wrote: > [v3: Addressed all review feedback. Update manpage for CSV. Various changes > (see individual patches). Remove some more redundant code > in printout callers.] > [v2: Addressed (near) all review feedback. No manpage updates

Re: perf, tools: Refactor and support interval and CSV metrics v3

2015-09-03 Thread Andi Kleen
> can't see perf/stat-metrics-5 branch > > [jolsa@krava perf]$ git remote update ak > Fetching ak > [jolsa@krava perf]$ git branch -r | grep perf/stat-metrics- > ak/perf/stat-metrics-3 > ak/perf/stat-metrics-4 > ak/perf/stat-metrics-refactor-2 > [jolsa@krava perf]$ Try again. I pushed

perf, tools: Refactor and support interval and CSV metrics v3

2015-09-02 Thread Andi Kleen
[v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for --per-core metrics. Various cleanups.]

perf, tools: Refactor and support interval and CSV metrics v3

2015-09-02 Thread Andi Kleen
[v3: Addressed all review feedback. Update manpage for CSV. Various changes (see individual patches). Remove some more redundant code in printout callers.] [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for --per-core metrics. Various cleanups.]

perf, tools: Refactor and support interval and CSV metrics v3

2015-08-07 Thread Andi Kleen
[v2: Addressed (near) all review feedback. No manpage updates so far. Add support for --per-core metrics. Various cleanups.] [v3: Everything compiles again. Some more cleanups. Updated to latest tip tree.] Currently perf stat does not support printing computed metrics for interval (-I xxx)

perf, tools: Refactor and support interval and CSV metrics v3

2015-08-07 Thread Andi Kleen
[v2: Addressed (near) all review feedback. No manpage updates so far. Add support for --per-core metrics. Various cleanups.] [v3: Everything compiles again. Some more cleanups. Updated to latest tip tree.] Currently perf stat does not support printing computed metrics for interval (-I xxx)

Re: perf, tools: Refactor and support interval and CSV metrics v2

2015-08-05 Thread Andi Kleen
> ^ > cc1: all warnings being treated as errors Sorry mistake in refactoring. I also forgot to include one patch. I'll fix this and repost (and also add the man page) -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: perf, tools: Refactor and support interval and CSV metrics v2

2015-08-05 Thread Jiri Olsa
On Mon, Aug 03, 2015 at 05:50:00PM -0700, Andi Kleen wrote: > [v2: Addressed (near) all review feedback. No manpage updates so far. > Add support for --per-core metrics. Various cleanups.] > > Currently perf stat does not support printing computed metrics for interval > (-I xxx) > or CSV

Re: perf, tools: Refactor and support interval and CSV metrics v2

2015-08-05 Thread Jiri Olsa
On Mon, Aug 03, 2015 at 05:50:00PM -0700, Andi Kleen wrote: [v2: Addressed (near) all review feedback. No manpage updates so far. Add support for --per-core metrics. Various cleanups.] Currently perf stat does not support printing computed metrics for interval (-I xxx) or CSV (-x,)

Re: perf, tools: Refactor and support interval and CSV metrics v2

2015-08-05 Thread Andi Kleen
^ cc1: all warnings being treated as errors Sorry mistake in refactoring. I also forgot to include one patch. I'll fix this and repost (and also add the man page) -Andi -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

perf, tools: Refactor and support interval and CSV metrics v2

2015-08-03 Thread Andi Kleen
[v2: Addressed (near) all review feedback. No manpage updates so far. Add support for --per-core metrics. Various cleanups.] Currently perf stat does not support printing computed metrics for interval (-I xxx) or CSV (-x,) mode. For example IPC or TSX metrics over time are quite useful to

perf, tools: Refactor and support interval and CSV metrics v2

2015-08-03 Thread Andi Kleen
[v2: Addressed (near) all review feedback. No manpage updates so far. Add support for --per-core metrics. Various cleanups.] Currently perf stat does not support printing computed metrics for interval (-I xxx) or CSV (-x,) mode. For example IPC or TSX metrics over time are quite useful to

perf, tools: Refactor and support interval and CSV metrics

2015-07-29 Thread Andi Kleen
Currently perf stat does not support printing computed metrics for interval (-I xxx) or CSV (-x,) mode. For example IPC or TSX metrics over time are quite useful to know. This patch implements them. The main obstacle was that the metrics printing was all open coded all over the metrics

perf, tools: Refactor and support interval and CSV metrics

2015-07-29 Thread Andi Kleen
Currently perf stat does not support printing computed metrics for interval (-I xxx) or CSV (-x,) mode. For example IPC or TSX metrics over time are quite useful to know. This patch implements them. The main obstacle was that the metrics printing was all open coded all over the metrics