Re: [PATCH v3 0/2] omap_hsmmc DT DMA Client support

2013-04-05 Thread Balaji T K
changes. Matt Porter (2): mmc: omap_hsmmc: convert to dma_request_slave_channel_compat() mmc: omap_hsmmc: add generic DMA request support to the DT binding Looks good to me Acked-by: Balaji T K .../devicetree/bindings/mmc/ti-omap-hsmmc.txt | 26 +++- drivers/mmc

Re: [PATCH] mmc: omap_hsmmc: clear status flags before starting a new command

2013-08-25 Thread Balaji T K
the event. Move the writing of the STAT register back in omap_hsmmc_do_irq(), before handling the status flags which generated the interrupt. Signed-off-by: Francesco Lavra Reviewed and Tested-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c |2 +- 1 files changed, 1 insertions(+), 1

Re: using mmc2 on panda [was: Regression 3.11-rc1: omap4panda: no usb and consequently no ethernet]

2013-10-01 Thread Balaji T K
Hi Roger, It has been a while, but I would like to pickup this thread. We have a couple of pandaboards used as test setup. These have an SDIO adapter hooked up to expansion connector A using MMC2. I have attached the patch file (just ignore platform_data stuff). Now on one board it works, but

Re: Uninitialized rx_req/tx_req (was: Re: [PATCH v2 2/3] mmc: omap_hsmmc: Skip platform_get_resource_byname() for dt case)

2013-09-12 Thread Balaji T K
On Thursday 12 September 2013 06:11 PM, Geert Uytterhoeven wrote: On Tue, Mar 5, 2013 at 10:13 PM, Matt Porter wrote: From: Santosh Shilimkar MMC driver probe will abort for DT case because of failed platform_get_resource_byname() lookup. Fix it by skipping resource byname lookup for device t

Re: Uninitialized rx_req/tx_req (was: Re: [PATCH v2 2/3] mmc: omap_hsmmc: Skip platform_get_resource_byname() for dt case)

2013-09-12 Thread Balaji T K
On Thursday 12 September 2013 06:11 PM, Geert Uytterhoeven wrote: On Tue, Mar 5, 2013 at 10:13 PM, Matt Porter wrote: From: Santosh Shilimkar MMC driver probe will abort for DT case because of failed platform_get_resource_byname() lookup. Fix it by skipping resource byname lookup for device t

Re: [PATCH 14/27] mmc: omap_hsmmc: Move away from using deprecated APIs

2013-10-10 Thread Balaji T K
. Additional cleanup done for keeping track suspended state. Cc: Balaji T K Cc: linux-o...@vger.kernel.org Signed-off-by: Ulf Hansson Acked-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c | 37 +++-- 1 file changed, 3 insertions(+), 34 deletions(-) diff

Re: [RFC v2] gpio/omap: auto-setup a GPIO when used as an IRQ

2013-09-24 Thread Balaji T K
On Tuesday 24 September 2013 09:10 PM, Tony Lindgren wrote: * Javier Martinez Canillas [130924 01:06]: The OMAP GPIO controller HW requires a pin to be configured in GPIO input mode in order to operate as an interrupt input. Since drivers should not be aware of whether an interrupt pin is also

Re: [PATCH v2 0/3] omap_hsmmc DT DMA Client support

2013-06-17 Thread Balaji T K
On Friday 14 June 2013 11:40 PM, Joel A Fernandes wrote: Resending on Matt's new email, thanks. On Fri, Jun 14, 2013 at 1:10 PM, Joel A Fernandes wrote: Hi, On Wed, Mar 6, 2013 at 7:37 AM, Matt Porter wrote: On Tue, Mar 05, 2013 at 09:26:01PM +, Arnd Bergmann wrote: On Tuesday 05 March

Re: [PATCH 09/11] mmc: omap_hsmmc: enhance pinctrl support

2013-06-07 Thread Balaji T K
On Tuesday 04 June 2013 08:16 PM, Tony Lindgren wrote: * Hebbar Gururaja [130531 03:19]: Amend the hsmmc controller to optionally take a pin control handle and set the state of the pins to: - "default" on boot, resume and before performing a mmc transfer - "idle" after initial default, after r

Re: [PATCH 3/5] ARM: dts: am33xx: Add interrupts and memory resources for MMC

2013-06-26 Thread Balaji T K
Hi Joel, On Wednesday 26 June 2013 06:54 AM, Joel A Fernandes wrote: From: Joel A Fernandes HWMOD irq entries for MMC were removed. We provide the same from DT for MMC. This fixes issue where memory resource could not be found during probe. Also, added the reg-offset property to account for t

Re: [PATCH 0/5] AM33xx: MMC resources from DT without HWMOD data

2013-06-27 Thread Balaji T K
On Thursday 27 June 2013 07:56 PM, Joel A Fernandes wrote: Hi Benoit, On Thu, Jun 27, 2013 at 7:03 AM, Benoit Cousson wrote: Hi Joel, On 06/26/2013 05:28 AM, Joel A Fernandes wrote: On Tue, Jun 25, 2013 at 8:23 PM, Joel A Fernandes wrote: From: Joel A Fernandes This series is fixes to ge

Re: [PATCH 0/5] AM33xx: MMC resources from DT without HWMOD data

2013-06-28 Thread Balaji T K
On Thursday 27 June 2013 11:38 PM, Fernandes, Joel wrote: Hi Balaji, Some patches were squashed and others dropped in the series resulting in the single patch above. This patch should be good to apply Hi Joel, Before pushing mmc dts support for am335x, Can you please let me know if below

Re: [PATCH] ARM: DTS: DRA7: Add TPS659038 PMIC nodes

2013-08-16 Thread Balaji T K
On Thursday 15 August 2013 05:05 AM, Nishanth Menon wrote: linux-omap, linux-arm-list should also be CCed, Benoit needs to be addressed for allowing him to merge, I have not done a proper schematics Vs data manual review yet (apologies on that), but, a couple of comments: On 08/13/2013 12:42 AM

Re: [PATCH v2 2/3] mmc: omap_hsmmc: Skip platform_get_resource_byname() for dt case

2013-03-06 Thread Balaji T K
On Wednesday 06 March 2013 02:43 AM, Matt Porter wrote: From: Santosh Shilimkar MMC driver probe will abort for DT case because of failed platform_get_resource_byname() lookup. Fix it by skipping resource byname lookup for device tree build. Issue is hidden because hwmod popullates the IO reso

[PATCH] arm/dts: omap5: Add mmc controller nodes and board data

2012-08-07 Thread Balaji T K
Add OMAP MMC related device tree data for OMAP5. Signed-off-by: Balaji T K --- arch/arm/boot/dts/omap5-evm.dts | 31 +++ arch/arm/boot/dts/omap5.dtsi| 31 +++ 2 files changed, 62 insertions(+), 0 deletions(-) diff --git a/arch/arm

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-06 Thread Balaji T K
in this case. Signed-off-by: Axel Lin --- Hi Balaji, I don't have this h/w, so please test if it works. Hi Axel, There were few issues when I tried using regmap helper, will check on this. Thanks and Regards, Balaji T K Regards, Axel drivers/regulator/pbias-regulato

Re: [PATCH V2 2/2] ARM: dts: omap3-ldp: fix mmc configuration

2014-02-20 Thread Balaji T K
that all relevant pins are configured for non-MMC boot mode. Signed-off-by: Nishanth Menon looks good to me Acked-by: Balaji T K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

[PATCH/RFC] dmaengine: omap-dma: split header file

2014-01-24 Thread Balaji T K
: Geert Uytterhoeven Signed-off-by: Balaji T K --- drivers/mmc/host/omap_hsmmc.c |2 +- include/linux/omap-dma.h | 19 +-- include/linux/omap-dmaengine.h | 21 + 3 files changed, 23 insertions(+), 19 deletions(-) create mode 100644 include/linux

Re: [PATCH/RFC] dmaengine: omap-dma: split header file

2014-01-24 Thread Balaji T K
On Friday 24 January 2014 10:21 PM, Balaji T K wrote: To Resolve build failure seen with sh-allmodconfig: include/linux/omap-dma.h:171:8: error: expected identifier before numeric constant make[4]: *** [drivers/mmc/host/omap_hsmmc.o] Error 1 due to CCR redefinition, move dmaengine

Re: [PATCH v3 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt on AM335x

2013-10-18 Thread Balaji T K
ct, commit 0e7a3ed04f0cd4311096d691888f88569310ee6c) BTW, - with the default polling, I get about 1Mb/sec with iperf - with sd-irq enabled and FCLK kept on the whole time, I get 4Mb/sec - with sd-irq enable, FCLK kept on, and the 5ms polling also running, I get over 5Mb/sec! Still mu

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-18 Thread Balaji T K
nks and Regards, Balaji T K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-18 Thread Balaji T K
On Friday 18 October 2013 09:05 PM, Tony Lindgren wrote: * Balaji T K [131018 00:41]: Any conclusion on using regmap for omap control module non-mux registers ? I don't think anybody has even started looking into a SCM driver yet considering there are tons of other issues to sort out

Re: [PATCH 4/6] pinctrl: single: Add support for wake-up interrupts

2013-10-11 Thread Balaji T K
odules PM state. Otherwise we'll have hard to trace hangs and oopses. Hi Tony, How are the clocks/power state currently handled in case of omap4_pmx_core, omap4_pmx_wkup register access via pinctrl-single ? Thanks and Regards, Balaji T K -- To unsubscribe from this list: send the line "uns

Re: [PATCH v3 3/4] mmc: omap_hsmmc: Remux pins to support SDIO interrupt on AM335x

2013-10-15 Thread Balaji T K
Thanks Andreas for the patch, On Saturday 05 October 2013 04:47 PM, Andreas Fenkart wrote: The am335x can't detect pending cirq in PM runtime suspend. This patch reconfigures dat1 as a GPIO before going to suspend. SDIO interrupts are detected with the GPIO, while in runtime suspend, standard de

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-22 Thread Balaji T K
On Monday 21 April 2014 11:02 PM, Felipe Balbi wrote: Hi, On Wed, Mar 26, 2014 at 07:04:45PM -0500, Felipe Balbi wrote: this series lets us access the newer registers introduced back in OMAP4 which give us some valid information about the OMAP HSMMC IP like max block size, support for ADMA, sup

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-24 Thread Balaji T K
On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote: Hi, this series lets us access the newer registers introduced back in OMAP4 which give us some valid information about the OMAP HSMMC IP like max block size, support for ADMA, support for Retention. "Support for Retention" looks interesti

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-24 Thread Balaji T K
On Thursday 24 April 2014 08:09 PM, Felipe Balbi wrote: On Thu, Apr 24, 2014 at 08:01:19PM +0530, Balaji T K wrote: On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote: Hi, this series lets us access the newer registers introduced back in OMAP4 which give us some valid information about

Re: [PATCH 3/5] mmc: host: omap_hsmmc: introduce new accessor functions

2014-04-24 Thread Balaji T K
On Thursday 27 March 2014 05:34 AM, Felipe Balbi wrote: we introduce new accessors which provide for register access with and without offsets. This is just to make sure newer versions of the IP can access the new registers prepended at the beginning of the address space. Signed-off-by: Felipe B

Re: [PATCH 0/5] mmc: host: omap_hsmmc: a few improvements

2014-04-24 Thread Balaji T K
On Tuesday 22 April 2014 09:18 PM, Felipe Balbi wrote: Hi, On Tue, Apr 22, 2014 at 09:00:12PM +0530, Balaji T K wrote: On Monday 21 April 2014 11:02 PM, Felipe Balbi wrote: Hi, On Wed, Mar 26, 2014 at 07:04:45PM -0500, Felipe Balbi wrote: this series lets us access the newer registers

Re: Multiple CCR definitions

2014-01-17 Thread Balaji T K
onfig for each SoC to enable the support. Use COMPILE_TEST to enable the build for other platforms. Signed-off-by: Amarinder Bindra Cc: Ezequiel Garcia Cc: Nishanth Menon Acked-by: Felipe Balbi Acked-by: Balaji T K Signed-off-by: Chris Ball --- driver

Re: [PATCH RFT] regulator: pbias: Convert to use regmap helper functions

2014-03-07 Thread Balaji T K
ver since pbias is not set to 0V anywhere, I think it shouldn't be an issue. Will test and confirm. Thanks and Regards Balaji T K 2) The is_enable implementation is wrong in some cases: e.g. for pbias_mmc_omap5: emable_mask is : BIT(27) | BIT(25) | BIT(26) However, pbias_regulator_enabl

Re: [PATCH 2/3] regulator: pbias: Convert to use regmap helper functions

2014-03-07 Thread Balaji T K
On Friday 07 March 2014 09:13 PM, Axel Lin wrote: This patch converts this driver to use the regmap helper functions provided by regulator core. Signed-off-by: Axel Lin Acked-by: Balaji T K --- drivers/regulator/pbias-regulator.c | 74 ++--- 1 file

Re: [PATCH 3/3] regulator: pbias: Convert to use regulator_[enable|is_enabled]_regmap

2014-03-07 Thread Balaji T K
ries with above dependent commit and it works as excepted So you can add my, Tested-by: Balaji T K Thanks for doing regmap conversion, now pbias driver looks as minimal as possible. drivers/regulator/pbias-regulator.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-

Re: [PATCH 1/3] regulator: pbias: Fix is_enabled callback implementation

2014-03-07 Thread Balaji T K
enable_mask of omap5 with .enable of omap4 :-) above comment should be "However, pbias_regulator_enable() only sets BIT(27) | BIT(26) bits" Other than that Acked-by: Balaji T K So is_enabled callback will always return false in this case. Fix the logic to compare the register value

Re: [PATCH V2 1/2] mmc: omap_hsmmc: Add support for quirky omap3 hsmmc controller

2014-02-18 Thread Balaji T K
). Signed-off-by: Nishanth Menon looks good to me Acked-by: Balaji T K --- Changes since v1: - new compatible flag as suggested by Tony which contains the relevant controller flag to work around the erratum V1: https://patchwork.kernel.org/patch/3514851/ .../devicetre

Re: [PATCH/RFC] dmaengine: omap-dma: split header file

2014-02-04 Thread Balaji T K
On Friday 24 January 2014 10:21 PM, Balaji T K wrote: To Resolve build failure seen with sh-allmodconfig: include/linux/omap-dma.h:171:8: error: expected identifier before numeric constant make[4]: *** [drivers/mmc/host/omap_hsmmc.o] Error 1 due to CCR redefinition, move dmaengine