Re: [ 02/38] PCI/PM: Fix deadlock when unbinding device if parent in D3cold

2012-11-26 Thread Huang Ying
On Mon, 2012-11-26 at 11:30 -0800, Greg Kroah-Hartman wrote: > On Mon, Nov 26, 2012 at 11:08:18AM -0800, Greg Kroah-Hartman wrote: > > On Mon, Nov 26, 2012 at 10:55:05AM -0800, Greg Kroah-Hartman wrote: > > > On Fri, Nov 23, 2012 at 11:09:37AM +0800, Huang Ying wrote: > > &

Re: [ 02/38] PCI/PM: Fix deadlock when unbinding device if parent in D3cold

2012-11-29 Thread Huang Ying
On Thu, 2012-11-29 at 18:01 -0800, Greg Kroah-Hartman wrote: > On Fri, Nov 23, 2012 at 03:47:42PM +0800, Huang Ying wrote: > > On Fri, 2012-11-23 at 11:09 +0800, Huang Ying wrote: > > > On Fri, 2012-11-23 at 02:35 +, Ben Hutchings wrote: > > > > On Wed, 2012-11

[PATCH 0/4] PCI/PM: D3cold support for system suspend

2013-01-28 Thread Huang Ying
[PATCH 1/4] PCI/ACPI: Add target state as parameter to pci_platform_pm_ops->run_wake [PATCH 2/4] PCI: Rename pci_dev->runtime_d3cold to pci_dev->set_d3cold [PATCH 3/4] PCI/PM: Set pci_dev->set_d3cold in pci_set_power_state [PATCH 4/4] PCI/PM: Enable D3cold support for system suspend

[PATCH 4/4] PCI/PM: Enable D3cold support for system suspend

2013-01-28 Thread Huang Ying
Device may need to be put in D3cold on some platforms, especially because we treat ACPI_STATE_D3 as ACPI_STATE_D3_COLD now. Signed-off-by: Huang Ying --- drivers/pci/pci-driver.c |5 + drivers/pci/pci.c|4 2 files changed, 5 insertions(+), 4 deletions(-) --- a/drivers

[PATCH 2/4] PCI: Rename pci_dev->runtime_d3cold to pci_dev->set_d3cold

2013-01-28 Thread Huang Ying
Will use this flag for system suspend in addition to runtime suspend. Signed-off-by: Huang Ying --- drivers/pci/pci-driver.c |2 +- drivers/pci/pci.c|6 +++--- include/linux/pci.h |7 +++ 3 files changed, 7 insertions(+), 8 deletions(-) --- a/drivers/pci/pci

[PATCH 3/4] PCI/PM: Set pci_dev->set_d3cold in pci_set_power_state

2013-01-28 Thread Huang Ying
path now. Signed-off-by: Huang Ying --- drivers/pci/pci-driver.c |2 -- drivers/pci/pci.c| 12 +++- 2 files changed, 7 insertions(+), 7 deletions(-) --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -1036,8 +1036,6 @@ static int pci_pm_runtime_resume(struct

[PATCH 1/4] PCI/ACPI: Add target state as parameter to pci_platform_pm_ops->run_wake

2013-01-28 Thread Huang Ying
ops->run_wake to solve the issue. Signed-off-by: Huang Ying --- drivers/pci/pci-acpi.c |5 +++-- drivers/pci/pci.c |9 + drivers/pci/pci.h |2 +- 3 files changed, 9 insertions(+), 7 deletions(-) --- a/drivers/pci/pci-acpi.c +++ b/drivers/pci/pci-acpi.c @@ -261,7

Re: [PATCH EDAC 03/13] ghes: add the needed hooks for EDAC error report

2013-02-24 Thread Huang Ying
On Fri, 2013-02-22 at 05:57 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 22 Feb 2013 05:50:21 -0300 > Mauro Carvalho Chehab escreveu: > > > Em Fri, 22 Feb 2013 08:45:11 +0800 > > Huang Ying escreveu: > > > > > On Thu, 2013-02-21 at 09:04 -0300, Mauro Carva

Re: [PATCH EDAC 03/13] ghes: add the needed hooks for EDAC error report

2013-02-20 Thread Huang Ying
inline void ghes_edac_report_mem_error(struct ghes *ghes, int sev, > + struct cper_sec_mem_err *mem_err) > +{ > +} > + > +static inline int ghes_edac_register(struct ghes *ghes, struct device *dev) > +{ > + return 0; > +} > + > +static

Re: [PATCH EDAC 03/13] ghes: add the needed hooks for EDAC error report

2013-02-21 Thread Huang Ying
On Thu, 2013-02-21 at 09:04 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 21 Feb 2013 09:26:07 +0800 > Huang Ying escreveu: > > > Sorry for late! > > Thanks for your comments. See my answers below. > > > > On Fri, 2013-02-15 at 10:44 -0200, Mauro Carvalho Cheh

Re: [RESEND BUGFIX PATCH 1/3] PCI/AER: fix pci_ops return NULL when hotplug a pci bus which was doing aer error inject

2012-08-27 Thread Huang Ying
ecial happened. Best Regards, Huang Ying > On 08/27/2012 09:23 AM, Huang Ying wrote: > > On Sat, 2012-08-25 at 17:59 +0800, Yijing Wang wrote: > >> When we inject aer errors to the target pci device by aer_inject module, > >> the pci_ops of pci > >> b

[PATCH 0/5] x86: ioremap and change_page_attr fixes

2008-01-30 Thread Huang, Ying
This patchset adds executable mapping support to ioremap, fixes some issue of change_page_attr and early_ioremap, and fixes EFI memory mapping accordingly. This patchset is based on latest x86 git tree and has been tested on EFI 32 and EFI 64 platform. Best Regards, Huang Ying -- To unsubscribe

[PATCH 3/5] x86: early_ioremap_reset fix 2

2008-01-30 Thread Huang, Ying
This patch fixes a bug of early_ioremap_reset(), which had been fixed before by "convert the boot time page table to the kernels native format" patch. But that patch has been reverted now. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/mm/ioremap.c |2 +- 1

[PATCH 4/5] x86: add executable mapping support to ioremap

2008-01-30 Thread Huang, Ying
This patch makes ioremap() can be used to map pages as executable, this is needed by EFI support. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/mm/ioremap.c | 35 +++ include/asm-x86/io_32.h | 14 ++ include/asm-x86/io_64.h

[PATCH 1/5] x86: change_page_attr_clear fix

2008-01-30 Thread Huang, Ying
This patch replaces __change_page_attr_set_clr() with change_page_attr_set_clr() in change_page_attr_clear() to flush the TLB/cache properly. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/mm/pageattr.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/arch/

[PATCH 2/5] x86: c_p_a clflush_cache_range fix

2008-01-30 Thread Huang, Ying
. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/mm/pageattr.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c @@ -36,11 +36,14 @@ within(unsigned long addr, unsigned long */ void clflush_cache_range(void

[PATCH 5/5] x86: EFI memory mapping changes according to changes to ioremap and c_p_a

2008-01-30 Thread Huang, Ying
The patch fixes EFI runtime memory mapping code according to the changes to ioremap() and change_page_attr(). Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/kernel/efi.c| 53 arch/x86/kernel/efi_64.c

Re: [PATCH 2/5] x86: c_p_a clflush_cache_range fix

2008-01-31 Thread Huang, Ying
On Thu, 2008-01-31 at 08:40 +0100, Andi Kleen wrote: > On Thursday 31 January 2008 08:36:02 Huang, Ying wrote: > > Because in i386 early boot stage, boot_cpu_data may be not available, > > which makes clflush_cach_range() into infinite loop, which is called > > by change_pa

Re: [PATCH 4/5] x86: add executable mapping support to ioremap

2008-01-31 Thread huang ying
On Jan 31, 2008 9:00 PM, Thomas Gleixner <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008, Huang, Ying wrote: > > > This patch makes ioremap() can be used to map pages as executable, > > this is needed by EFI support. > > > +extern void __iomem *__ioremap(unsig

Re: [PATCH 5/5] x86: EFI memory mapping changes according to changes to ioremap and c_p_a

2008-01-31 Thread huang ying
Jan 31, 2008 8:18 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Huang, Ying <[EMAIL PROTECTED]> wrote: > > > + /* Assume pages are mapped as WB */ > > + if (mode == IOR_MODE_UNCACHED) > > +

[PATCH 3/4] x86: update usage of set_memory_xx

2008-02-01 Thread Huang, Ying
This patch updates the usage of set_memory_xx according to changes in previous patch. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/kernel/pci-gart_64.c |3 ++- arch/x86/mm/init_32.c |4 ++-- arch/x86/mm/init_64.c |8 arch/x86/mm/ior

[PATCH 1/4] x86: check __supported_pte_mask in set_memory_x/nx

2008-02-01 Thread Huang, Ying
This patch adds __supported_pte_mask checking to set_memory_x/nx. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/mm/pageattr.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) --- a/arch/x86/mm/pageattr.c +++ b/arch/x86/mm/pageattr.c @@ -445,13 +

[PATCH 0/4] x86: set_memory_xx enhancement

2008-02-01 Thread Huang, Ying
This patchset enhances set_memory_xx functions and updates its usage such as EFI accordingly. This patchset is based on latest x86 git tree and has been tested on EFI 32 and EFI 64 platform. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

[PATCH 2/4] x86: set_memory_xx enhancement

2008-02-01 Thread Huang, Ying
This patch makes set_memory_xx can be used on arbitrary memory mapping (besides identity mapping), such as memory mapped with ioremap. The physical address is added to the set_memory_xx functions as another parameter. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/mm/pageattr-

[PATCH 4/4] x86: efi update for set_memory_xx

2008-02-01 Thread Huang, Ying
The patch updates EFI runtime memory mapping code according to the changes to set_memory_xx. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/kernel/efi.c| 48 +++ arch/x86/kernel/efi_64.c

[BUGFIX 2/2] PCI/PM: Resume device before shutdown

2012-10-23 Thread Huang Ying
Some actions during shutdown need device to be in D0 state, such as MSI shutdown etc, so resume device before shutdown. Signed-off-by: Huang Ying --- drivers/pci/pci-driver.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) --- a/drivers/pci/pci-driver.c +++ b/drivers/pci

[BUGFIX 1/2] PCI/PM: Fix deadlock when unbind device if its parent in D3cold

2012-10-24 Thread Huang Ying
might call driver's callback function. So I fixed the dead lock as follow: - remove device_lock from pci_walk_bus - add device_lock into callback if callback will call driver's callback I checked pci_walk_bus users one by one, and found only PCIe aer needs device lock. Signed-off-by

[BUGFIX] PCI/PM: Fix proc config reg access for D3cold and bridge suspending

2012-10-24 Thread Huang Ying
. This is the same as /sys/bus/pci/devices/:??:??.?/config access issue. So the function used to solve sysfs issue is used to solve this issue. Cc: sta...@vger.kernel.org Reported-by: Peter Signed-off-by: Huang Ying --- drivers/pci/pci-sysfs.c | 34

PCI/PM: Add comments for PME poll support for PCIe

2012-10-25 Thread Huang Ying
of commit: 379021d5c0899fcf9410cae4ca7a59a5a94ca769 Cc: Rafael J. Wysocki Signed-off-by: Huang Ying --- drivers/pci/pci.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -1578,15 +1578,25 @@ void

Re: Latest kernel doesn't boot

2008-02-12 Thread Huang, Ying
not? > > > > Don't know. > 3.6 doesn't do the mapping in ia32/system.c create_boot_params(). > 3.8 does. > > The problem is, that i wasn't able to produce a working elilo.efi files > with my gentoo toolchain. the files elilo-3.8.efi provided by the elil

[PATCH] x86: EFI runtime code mapping enhancement

2008-02-13 Thread Huang, Ying
x in early_mapping_set_exec(). This eliminates the duplicated implementation. This patch has been tested on Intel x86_64 platform with EFI64/32 firmware. Signed-off-by: Huang Ying <[EMAIL PROTECTED]> --- arch/x86/kernel/efi.c|6 ++ arch/x86/kernel/efi_6

Re: [PATCH] x86: EFI runtime code mapping enhancement

2008-02-13 Thread Huang, Ying
On Wed, 2008-02-13 at 12:32 +0100, Andi Kleen wrote: > Huang, Ying wrote: > > This patch enhances EFI runtime code memory mapping as following: > > > > - Move __supported_pte_mask & _PAGE_NX checking before invoking > > runtime_code_page_mkexec(). This ma

Re: [2.6 patch] x86: make struct efi_phys static

2008-02-13 Thread Huang, Ying
ta; > static efi_system_table_t efi_systab __initdata; > > static int __init setup_noefi(char *arg) Reviewed-by: Huang Ying <[EMAIL PROTECTED]> Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI

Re: [PATCH] x86: EFI runtime code mapping enhancement

2008-02-14 Thread Huang, Ying
h set_memory_*() and lookup_address() implementation. For example, it lacked 1G support when that is added to lookup_address(). Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] x86: EFI runtime code mapping enhancement

2008-02-14 Thread Huang, Ying
Hi, Ingo, Please revert this patch. Because it does not work with 1GB pages. Although the original implementation does not work with 1GB pages too, it can be fixed easier than this one. I will compose a new patch to fix the original implementation. Best Regards, Huang Ying On Wed, 2008-02-13 at

Re: [PATCH] Fix left over EFI cache mapping problems

2008-02-14 Thread Huang, Ying
x8000 #define EFI_MEMORY_UC 0x0001 But because end_pfn_map contains the above UC memory area, efi_ioremap() is not used on EFI 64. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Fix left over EFI cache mapping problems

2008-02-14 Thread Huang, Ying
ush it to Linus? (this fix is also in the latest x86.git#mm) I think the patch following may be better, because it is possible that the EFI_PAGE_SHIFT and PAGE_SHIFT are different. Best Regards, Huang Ying -> The EFI-runtime mapping code changed a larger memory area t

Re: [PATCH] Fix left over EFI cache mapping problems

2008-02-14 Thread Huang, Ying
On Thu, 2008-02-14 at 21:44 -0800, Linus Torvalds wrote: > > On Fri, 15 Feb 2008, Huang, Ying wrote: > > > > I think the patch following may be better, because it is possible that > > the EFI_PAGE_SHIFT and PAGE_SHIFT are different. > > If this is a problem i

Re: [PATCH] Fix left over EFI cache mapping problems

2008-02-14 Thread Huang, Ying
On Fri, 2008-02-15 at 08:08 +0100, Ingo Molnar wrote: > * Huang, Ying <[EMAIL PROTECTED]> wrote: > > > On Thu, 2008-02-14 at 17:12 +0100, Ingo Molnar wrote: > > > this is indeed a bug (we change the attributes for a larger area than > > > needed), but your

Re: [PATCH] Fix left over EFI cache mapping problems

2008-02-15 Thread Huang, Ying
On Fri, 2008-02-15 at 09:48 +0100, Andi Kleen wrote: > On Fri, Feb 15, 2008 at 12:48:06PM +0800, Huang, Ying wrote: > > > > This patch has been tested on Intel x86 platform with EFI 32/64. > > Can EFI_PAGE_SIZE ever be < 4k? If yes you would need to round up > firs

Re: [PATCH] Fix left over EFI cache mapping problems

2008-02-15 Thread Huang, Ying
sure this path works I tested efi_ioremap with "memmap=...", and it works fine on my 2G EFI box. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://v

Re: [BUGFIX 2/2] PCI/PM: Resume device before shutdown

2012-11-02 Thread Huang Ying
On Fri, 2012-11-02 at 10:52 -0600, Bjorn Helgaas wrote: > On Wed, Oct 24, 2012 at 12:54 AM, Huang Ying wrote: > > Some actions during shutdown need device to be in D0 state, such as > > MSI shutdown etc, so resume device before shutdown. > > Is there a problem report or bu

Re: [BUGFIX 1/2] PCI/PM: Fix deadlock when unbind device if its parent in D3cold

2012-11-02 Thread Huang Ying
On Fri, 2012-11-02 at 10:50 -0600, Bjorn Helgaas wrote: > On Wed, Oct 24, 2012 at 12:54 AM, Huang Ying wrote: > > If a PCI device and its parents are put into D3cold, unbinding the > > device will trigger deadlock as follow: > > > > - driver_unbind &g

Re: [BUGFIX 1/2] PCI/PM: Fix deadlock when unbind device if its parent in D3cold

2012-11-03 Thread Huang Ying
On Sat, 2012-11-03 at 11:22 -0600, Bjorn Helgaas wrote: > On Fri, Nov 2, 2012 at 11:06 PM, Huang Ying wrote: > > On Fri, 2012-11-02 at 10:50 -0600, Bjorn Helgaas wrote: > >> On Wed, Oct 24, 2012 at 12:54 AM, Huang Ying wrote: > >> > If a PCI device and its parents

Re: [BUGFIX 2/2] PCI/PM: Resume device before shutdown

2012-11-03 Thread Huang Ying
On Sat, 2012-11-03 at 11:21 -0600, Bjorn Helgaas wrote: > On Fri, Nov 2, 2012 at 11:05 PM, Huang Ying wrote: > > On Fri, 2012-11-02 at 10:52 -0600, Bjorn Helgaas wrote: > >> On Wed, Oct 24, 2012 at 12:54 AM, Huang Ying wrote: > >> > Some actions during shutdown

[BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-04 Thread Huang Ying
all its children are suspended, and may cause issue. This issue is fixed via checking the usage count of the child device because if the runtime PM of the child device is forbidden, the usage_count of the child device will be non-zero. Signed-off-by: Huang Ying --- drivers/base/power/runtime.c |

[RFC] PCI/PM: Add ABI document for sysfs file d3cold_allowed

2012-07-27 Thread Huang Ying
This patch adds ABI document for the following sysfs file: /sys/bus/pci/devices/.../d3cold_allowed Signed-off-by: Huang Ying --- Documentation/ABI/testing/sysfs-bus-pci | 12 1 file changed, 12 insertions(+) --- a/Documentation/ABI/testing/sysfs-bus-pci +++ b/Documentation/ABI

Re: [RFC] PCI/PM: Add ABI document for sysfs file d3cold_allowed

2012-07-30 Thread Huang Ying
Hi, Don, Thanks for your comments. On Mon, 2012-07-30 at 14:03 -0400, Don Dutile wrote: > On 07/27/2012 04:07 AM, Huang Ying wrote: > > This patch adds ABI document for the following sysfs file: > > > > /sys/bus/pci/devices/.../d3cold_allowed > > &g

Re: [RFC 3/3] PCI/PM: Disable PME poll for PCIe devices

2012-09-20 Thread Huang Ying
On Thu, 2012-09-20 at 21:31 +0200, Rafael J. Wysocki wrote: > On Monday, September 17, 2012, Huang Ying wrote: > > PME poll is not necessary for PCIe devices, because PCIe devices use > > in-band PME message and IRQ on PCIe port to report PME. > > Alas, not all of them as it

[PATCH] ACPI/PCI: Make PCI devices notified when its power resource turned on

2012-09-26 Thread Huang Ying
D0uninitialized state. These devices should be resumed, so that they can get opportunity to go to low power state later. Signed-off-by: Huang Ying Acked-by: Rafael J. Wysocki --- drivers/acpi/pci_bind.c |2 ++ 1 file changed, 2 insertions(+) --- a/drivers/acpi/pci_bind.c +++ b/drivers/acpi

[PATCH RESEND] ACPI/PCI: Make PCI devices notified when its power resource turned on

2012-09-26 Thread Huang Ying
off. When one of the device is waked, the power resource will be turned on and all devices share it will be powered on to D0uninitialized state. These devices should be resumed, so that they can get opportunity to go to low power state later. Signed-off-by: Huang Ying Acked-by: Rafael J. Wysocki

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-29 Thread Huang Ying
gt; explicit about how uuid's should be encoded, and it's in internet byte > order. This is what OSF/DCE uses, and it's what the rest of the world > (Microsoft, SAP AG, Apple, GNOME, KDE) uses as well. uuid_be complies RFC4122, it uses internet byte order. But EFI uses littl

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-30 Thread Huang Ying
On Tue, 2012-10-30 at 00:48 -0400, Theodore Ts'o wrote: > On Tue, Oct 30, 2012 at 09:49:58AM +0800, Huang Ying wrote: > > The uuid_le/be_gen() in lib/uuid.c has set UUID variants to be DCE, > > that is done in __uuid_gen_common() with "b[8] = (b[8] & 0x3F) | 0x80&qu

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-30 Thread Huang Ying
On Tue, 2012-10-30 at 22:38 -0400, Theodore Ts'o wrote: > On Wed, Oct 31, 2012 at 09:35:37AM +0800, Huang Ying wrote: > > > > The intention of lib/uuid.c is to unify various UUID related code, and > > put them in same place. In addition to UUID generation, it provide

Re: Question about failure in PCI power-state change

2012-09-09 Thread Huang Ying
sed to change power state, currently in D3" Hi, Larry, We fixed a similar issue recently. And the patch has been merged by v3.6-rc5. Can you try v3.6-rc5? Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH] genalloc: make possible to use a custom allocation algorithm

2012-09-09 Thread Huang Ying
, > + unsigned long start, unsigned int nr, void *data), void *data) > +{ > + rcu_read_lock(); IMHO, you can use pool->lock here. _set_algo need not to be lock-less. > + > + pool->algo = algo; > + if (!pool->algo) > + pool->algo = gen_pool_f

Re: [PATCH 7/7] PM / ACPI: Take device PM QoS flags into account

2012-10-08 Thread Huang Ying
ff-by: Rafael J. Wysocki > Reviewed-by: Jean Pihet Reviewed-by: Huang Ying Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 2/3] llist: add a safe version of llist_for_each_entry

2012-12-10 Thread Huang Ying
On Mon, 2012-12-10 at 18:24 +0100, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné > Cc: Huang Ying > Cc: Konrad Rzeszutek Wilk > --- > include/linux/llist.h | 27 +++ > 1 files changed, 27 insertions(+), 0 deletions(-) > > diff --git

Re: [ 02/38] PCI/PM: Fix deadlock when unbinding device if parent in D3cold

2012-12-11 Thread Huang Ying
On Fri, 2012-11-30 at 10:54 +0800, Huang Ying wrote: > On Thu, 2012-11-29 at 18:01 -0800, Greg Kroah-Hartman wrote: > > On Fri, Nov 23, 2012 at 03:47:42PM +0800, Huang Ying wrote: > > > On Fri, 2012-11-23 at 11:09 +0800, Huang Ying wrote: > > > > On Fri, 2012-11-23

Re: [PATCH v3] llist: add a safe version of llist_for_each_entry

2012-12-11 Thread Huang Ying
On Tue, 2012-12-11 at 12:25 +0100, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné > Cc: Huang Ying > Cc: Konrad Rzeszutek Wilk > --- > Changes since v2: > * Allow to pass a NULL node as the first entry of deleted list >entries. > --- > i

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-11 Thread Huang Ying
On Fri, 2012-11-09 at 11:41 -0500, Alan Stern wrote: > On Fri, 9 Nov 2012, Huang Ying wrote: > > > On Thu, 2012-11-08 at 12:07 -0500, Alan Stern wrote: > > > On Thu, 8 Nov 2012, Rafael J. Wysocki wrote: > > > > > > > > > > is it a goo

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-11 Thread Huang Ying
On Sun, 2012-11-11 at 21:36 -0500, Alan Stern wrote: > On Mon, 12 Nov 2012, Huang Ying wrote: > > > > The first question: How should the PCI subsystem prevent the parents of > > > driverless VGA devices from being runtime suspended while userspace is > > >

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-12 Thread Huang Ying
On Mon, 2012-11-12 at 11:32 -0500, Alan Stern wrote: > On Mon, 12 Nov 2012, Huang Ying wrote: > > > > > Is it absolute necessary to call pm_runtime_set_suspended? If the > > > > device is disabled, the transition to SUSPENDED state will not be > > > &

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-12 Thread Huang Ying
On Mon, 2012-11-12 at 21:32 -0500, Alan Stern wrote: > On Tue, 13 Nov 2012, Huang Ying wrote: > > > Sorry, my original idea is: > > > > pm_runtime_disable will put device into SUSPENDED state if > > dev->power.runtime_auto is clear. pm_runtime_a

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-13 Thread Huang Ying
On Tue, 2012-11-13 at 11:10 -0500, Alan Stern wrote: > On Tue, 13 Nov 2012, Huang Ying wrote: > > > > This is not quite right. Consider a device that is in runtime suspend > > > when a system sleep starts. When the system sleep ends, the device > > > will be r

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-14 Thread Huang Ying
On Wed, 2012-11-14 at 10:52 +0100, Rafael J. Wysocki wrote: > On Wednesday, November 14, 2012 09:08:28 AM Huang Ying wrote: > > On Tue, 2012-11-13 at 11:10 -0500, Alan Stern wrote: > > > On Tue, 13 Nov 2012, Huang Ying wrote: > > > > > > > > This is not

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-14 Thread Huang Ying
ou are going to enable it. While > > the device is enabled, its runtime status should match the physical > > power level. > > OK If my memory were correct, RPM_SUSPENDED just means device stop working, but need not be put into low-power state. So for RPM_ACTIVE

Re: [PATCH RESEND] ACPI/PCI: Make PCI devices notified when its power resource turned on

2012-11-05 Thread Huang Ying
On Mon, 2012-11-05 at 17:02 -0700, Bjorn Helgaas wrote: > On Wed, Sep 26, 2012 at 7:59 AM, Huang Ying wrote: > > Sorry for bothering. It appears that this patch should go through ACPI > > tree because code changed are under drivers/acpi. > > > > A set of power resource

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-05 Thread Huang Ying
On Sun, 2012-11-04 at 20:56 -0500, Alan Stern wrote: > On Mon, 5 Nov 2012, Huang Ying wrote: > > > In current runtime PM implementation, the active child count of the > > parent device may be decreased if the runtime PM of the child device > > is disabled and forbidden.

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-06 Thread Huang Ying
On Tue, 2012-11-06 at 10:17 -0500, Alan Stern wrote: > On Tue, 6 Nov 2012, Huang Ying wrote: > > > On Sun, 2012-11-04 at 20:56 -0500, Alan Stern wrote: > > > On Mon, 5 Nov 2012, Huang Ying wrote: > > > > > > > In current runtime PM implementation, th

[PATCH -v2] ACPI/PCI: Make PCI devices notified when its power resource turned on

2012-11-06 Thread Huang Ying
D0uninitialized state. These devices should be resumed, so that they can get opportunity to go to low power state later. v2: - Fix build error Signed-off-by: Huang Ying Acked-by: Rafael J. Wysocki Cc: Bjorn Helgaas --- drivers/acpi/pci_bind.c |2 ++ 1 file changed, 2 insertions(+) --- a

Re: [PATCH] pci/runtime-pm: respect devices autosuspend timeout on config access

2012-11-06 Thread Huang Ying
POSTing the cards. The driver configures the autosuspend timeout to 5s for > this reason, and I think the PCI layer config accesses should respect > the autosuspend. > > Cc: Huang Ying > Cc: Bjorn Helgaas > Cc: Rafael J. Wysocki > Signed-off-by: Dave Airlie > --- &g

Re: [PATCH] pci/runtime-pm: respect devices autosuspend timeout on config access

2012-11-06 Thread Huang Ying
On Wed, 2012-11-07 at 01:15 -0500, David Airlie wrote: > > > > > > Cc: Huang Ying > > > Cc: Bjorn Helgaas > > > Cc: Rafael J. Wysocki > > > Signed-off-by: Dave Airlie > > > --- > > > drivers/pci/pci-sysfs.c | 2 +- > > >

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-07 Thread Huang Ying
NULL; > + const struct dev_pm_ops *pm; > + > + if (!dev->driver) > + goto out: > > + pm = dev->driver->pm; > if (!pm) > return -ENOSYS; > > @@ -1065,8 +1070,8 @@ static int pci_pm_runtime_idle(struct de >

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-07 Thread Huang Ying
On Thu, 2012-11-08 at 02:35 +0100, Rafael J. Wysocki wrote: > On Thursday, November 08, 2012 09:15:08 AM Huang Ying wrote: > > On Thu, 2012-11-08 at 00:09 +0100, Rafael J. Wysocki wrote: > > > On Wednesday, November 07, 2012 11:51:15 PM Rafael J. Wysocki wrote: > > >

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-08 Thread Huang Ying
oesn't seem to be a problem. It can arise without disabling > runtime PM at all -- just call pm_runtime_get_noresume. I think pm_runtime_get_noresume can not fix the issue. pm_runtiem_set_active() should be invoked before pm_runtime_enable() if necessary. That is, the i

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-15 Thread Huang Ying
On Thu, 2012-11-15 at 10:51 +0100, Rafael J. Wysocki wrote: > On Thursday, November 15, 2012 09:03:44 AM Huang Ying wrote: > > On Thu, 2012-11-15 at 00:10 +0100, Rafael J. Wysocki wrote: > > > On Wednesday, November 14, 2012 04:45:01 PM Alan Stern wrote: > > > >

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-15 Thread Huang Ying
On Fri, 2012-11-16 at 01:44 +0100, Rafael J. Wysocki wrote: > On Friday, November 16, 2012 08:36:14 AM Huang Ying wrote: > > On Thu, 2012-11-15 at 10:51 +0100, Rafael J. Wysocki wrote: > > > On Thursday, November 15, 2012 09:03:44 AM Huang Ying wrote: > > > > On

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-15 Thread Huang Ying
On Fri, 2012-11-16 at 01:55 +0100, Rafael J. Wysocki wrote: > On Friday, November 16, 2012 01:44:00 AM Rafael J. Wysocki wrote: > > On Friday, November 16, 2012 08:36:14 AM Huang Ying wrote: > > > On Thu, 2012-11-15 at 10:51 +0100, Rafael J. Wysocki wrote: > > [...]

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-15 Thread Huang Ying
On Fri, 2012-11-16 at 02:29 +0100, Rafael J. Wysocki wrote: > On Friday, November 16, 2012 08:54:56 AM Huang Ying wrote: > > On Fri, 2012-11-16 at 01:55 +0100, Rafael J. Wysocki wrote: > > > On Friday, November 16, 2012 01:44:00 AM Rafael J. Wysocki wrote: > > > > O

Re: [BUGFIX] PM: Fix active child counting when disabled and forbidden

2012-11-15 Thread Huang Ying
On Thu, 2012-11-15 at 10:51 +0100, Rafael J. Wysocki wrote: > On Thursday, November 15, 2012 09:03:44 AM Huang Ying wrote: > > On Thu, 2012-11-15 at 00:10 +0100, Rafael J. Wysocki wrote: > > > On Wednesday, November 14, 2012 04:45:01 PM Alan Stern wrote: > > > >

[RFC] PCI/PM: Keep runtime PM enabled for unbound PCI devices

2012-11-18 Thread Huang Ying
do nothing. Maybe it is better to use a dedicated flag such as .skip_rtpm_callbacks. That may improve code readability. Signed-off-by: Huang Ying CC: Rafael J. Wysocki CC: Alan Stern CC: sta...@vger.kernel.org # v3.6+ --- drivers/pci/pci-driver.c |

Re: [RFC] PCI/PM: Keep runtime PM enabled for unbound PCI devices

2012-11-19 Thread Huang Ying
On Mon, 2012-11-19 at 23:00 +0100, Rafael J. Wysocki wrote: > On Monday, November 19, 2012 11:31:01 AM Alan Stern wrote: > > On Mon, 19 Nov 2012, Huang Ying wrote: > > > > > For unbound PCI devices, what we need is: > > > > > > - Always in D0 state

[PATCH] PCI/PM: Keep runtime PM enabled for unbound PCI devices

2012-11-20 Thread Huang Ying
will do nothing if the PCI devices are unbound. This way, we can put the PCI devices into SUSPENDED state without put the PCI devices into D3 state. Signed-off-by: Huang Ying Cc: Rafael J. Wysocki Cc: Alan Stern CC: sta...@vger.kernel.org # v3.6+ --- drivers/pci/pci-driver.c | 69

Re: kmemleak in apei_res_add

2013-08-22 Thread Huang Ying
freeing missing on an error path. > > No. > dmesg |grep APEI > [9.602274] GHES: APEI firmware first mode is enabled by APEI bit and WHEA > _OSC. > Can you try the following debug patch, and send me back the output of: $ dmesg | grep apei_res Best Regards, Huang Ying

Re: [Update][PATCH] PCI / PM: Disable runtime PM of PCIe ports

2013-04-01 Thread huang ying
recently reported by > Martin are another. Do you want me to dig deeper? For bug 53811, I have a debug patch posted in bugzilla to disable runtime PM for PCIe port with hotplug capability. It appears that patch resolved the issue for the reporter. Do think that patch can solve the hotplug iss

Re: [Update][PATCH] PCI / PM: Disable runtime PM of PCIe ports

2013-04-01 Thread huang ying
On Tue, Apr 2, 2013 at 1:28 PM, huang ying wrote: > On Tue, Apr 2, 2013 at 4:51 AM, Rafael J. Wysocki wrote: >> >> On Monday, April 01, 2013 11:34:46 AM Bjorn Helgaas wrote: >> > [+cc Zheng, who added this with 71a83bd727] >> > >> > On Sat, Mar 30,

Re: [Update][PATCH] PCI / PM: Disable runtime PM of PCIe ports

2013-04-01 Thread huang ying
nt me at a specific message, I'll dig up an archive URL for it. > > Otherwise, I'm afraid we'll just oscillate between "enable PM, find > bug, disable PM, enable PM, find same bug, disable PM, etc..." Sorry for late! I am trying to fix a way to fix 53

[PATCH 0/4] PCI/PM: PCI D3cold support fixes for 3.6-rc1

2012-08-02 Thread Huang Ying
[BUGFIX 1/4] PCI/PM: enable D3/D3cold by default for most devices [BUGFIX 2/4] PCI/PM: Keep parent bridge active when probing device [BUGFIX 3/4] PCI/PM: Fix config reg access for D3cold and bridge suspending [PATCH 4/4] PCI/PM: Add ABI document for sysfs file d3cold_allowed Best Regards, Huang

[BUGFIX 3/4] PCI/PM: Fix config reg access for D3cold and bridge suspending

2012-08-02 Thread Huang Ying
To avoid resume/suspend PCIe port for each configuration register read/write, a small delay is added before the PCIe port to go suspended. Reported-by: Bjorn Mork Signed-off-by: Huang Ying --- drivers/pci/pci-sysfs.c| 37 + drivers/pci/pcie/portd

[PATCH 4/4] PCI/PM: Add ABI document for sysfs file d3cold_allowed

2012-08-02 Thread Huang Ying
This patch adds ABI document for the following sysfs file: /sys/bus/pci/devices/.../d3cold_allowed Signed-off-by: Huang Ying Acked-by: Rafael J. Wysocki --- Documentation/ABI/testing/sysfs-bus-pci | 12 1 file changed, 12 insertions(+) --- a/Documentation/ABI/testing/sysfs-bus

[BUGFIX 2/4] PCI/PM: Keep parent bridge active when probing device

2012-08-02 Thread Huang Ying
o active state before probing. Reported-by: Bjorn Mork Signed-off-by: Huang Ying --- drivers/pci/pci-driver.c |6 ++ 1 file changed, 6 insertions(+) --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -280,8 +280,12 @@ static long local_pci_probe(void *_ddi) {

[BUGFIX 1/4] PCI/PM: enable D3/D3cold by default for most devices

2012-08-02 Thread Huang Ying
is patch enables D3/D3cold by default for most devices. This restores the original behavior. For some devices that suspected to have broken D3cold support, such as PCIe port, D3cold is disabled by default. Reported-by: Bjorn Mork Signed-off-by: Huang Ying --- drivers/pci/pci.c |1 +

[PATCH -v2 4/4] PCI/PM: Add ABI document for sysfs file d3cold_allowed

2012-08-05 Thread Huang Ying
This patch adds ABI document for the following sysfs file: /sys/bus/pci/devices/.../d3cold_allowed Signed-off-by: Huang Ying Acked-by: Rafael J. Wysocki --- Documentation/ABI/testing/sysfs-bus-pci | 12 1 file changed, 12 insertions(+) --- a/Documentation/ABI/testing/sysfs-bus

[BUGFIX -v2 2/4] PCI/PM: Keep parent bridge active when probing device

2012-08-05 Thread Huang Ying
o active state before probing. Reported-by: Bjorn Mork Signed-off-by: Huang Ying Reviewed-by: Rafael J. Wysocki --- drivers/pci/pci-driver.c |6 ++ 1 file changed, 6 insertions(+) --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -280,8 +280,12 @@ static long local_pci_pr

[PATCH -v2 0/4] PCI/PM: PCI D3cold support fixes for 3.6-rc1

2012-08-05 Thread Huang Ying
Changes: v2: - Change some pm_runtime_put to pm_runtime_put_sync per Alan and Rafael's comments. [BUGFIX -v2 1/4] PCI/PM: enable D3/D3cold by default for most devices [BUGFIX -v2 2/4] PCI/PM: Keep parent bridge active when probing device [BUGFIX -v2 3/4] PCI/PM: Fix config reg access for D3col

[BUGFIX -v2 3/4] PCI/PM: Fix config reg access for D3cold and bridge suspending

2012-08-05 Thread Huang Ying
To avoid resume/suspend PCIe port for each configuration register read/write, a small delay is added before the PCIe port to go suspended. Reported-by: Bjorn Mork Signed-off-by: Huang Ying --- drivers/pci/pci-sysfs.c| 37 + drivers/pci/pcie/portd

[BUGFIX -v2 1/4] PCI/PM: enable D3/D3cold by default for most devices

2012-08-05 Thread Huang Ying
is patch enables D3/D3cold by default for most devices. This restores the original behavior. For some devices that suspected to have broken D3cold support, such as PCIe port, D3cold is disabled by default. Reported-by: Bjorn Mork Signed-off-by: Huang Ying Reviewed-by: Rafael J. Wysocki --- drivers/p

Re: [RESEND BUGFIX PATCH 1/3] PCI/AER: fix pci_ops return NULL when hotplug a pci bus which was doing aer error inject

2012-08-26 Thread Huang Ying
eturn bus_ops->ops; > } > + > + /* here can't find bus_ops, fall back to get bus_ops of upstream bus */ > + list_for_each_entry(bus_ops, &pci_bus_ops_list, list) { > + if (pci_is_upstream_bus(bus, bus_ops->bus)) > + return bus_ops->o

[RFC 0/3] PCI/PM: RTD3 fixes/changes for 3.7

2012-09-17 Thread Huang Ying
[RFC 1/3] PCI/PM: Fix kexec for D3cold and bridge suspending [RFC 2/3] PCI/PM: Make PCI devices notified when its power [RFC 3/3] PCI/PM: Disable PME poll for PCIe devices Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

  1   2   3   4   5   6   7   8   9   10   >