ASK. Returned value shall be the last one written to the eventfd.
select(2), poll(2) and similar:
When polling on the eventfd marked by EFD_MASK flag, all the events specified
in last written 'events' field shall be signaled.
Signed-off-by: Martin Sustrik
---
fs/eventfd.c| 10
On 07/02/13 20:12, Andy Lutomirski wrote:
On 02/06/2013 10:41 PM, Martin Sustrik wrote:
When implementing network protocols in user space, one has to implement
fake user-space file descriptors to represent the sockets for the protocol.
While all the BSD socket API functionality for such
the last one written to the eventfd.
select(2), poll(2) and similar:
When polling on the eventfd marked by EFD_MASK flag, all the events specified
in last written 'events' field shall be signaled.
Signed-off-by: Martin Sustrik
---
fs/eventfd.c| 105
On 07/02/13 23:44, Andrew Morton wrote:
So please update the changelog and then cc net...@vger.kernel.org on
the patch - the netdev people are probably best-situated to comment on
the proposal.
OK. Done. Thanks for the advice!
Martin
--
To unsubscribe from this list: send the line "unsubscr
Hi Andy,
On 08/02/13 02:03, Andy Lutomirski wrote:
There may be some
advantage to adding (later on, if needed) an option to change the
flags set in:
+ if (waitqueue_active(&ctx->wqh))
+ wake_up_locked_poll(&ctx->wqh,
+ (unsigned
On 08/02/13 07:36, Andy Lutomirski wrote:
On 08/02/13 02:03, Andy Lutomirski wrote:
There may be some
advantage to adding (later on, if needed) an option to change the
flags set in:
+ if (waitqueue_active(&ctx->wqh))
+ wake_up_locked_poll(&ctx->wqh,
+
fd marked by
EFD_MASK. Returned value shall be the last one written to the eventfd.
select(2), poll(2) and similar:
When polling on the eventfd marked by EFD_MASK flag, all the events specified
in last written 'events' field shall be signaled.
Signed-off-by: Martin Sustrik
---
v2 - Con
On 07/02/13 23:44, Andrew Morton wrote:
That's a nice changelog but it omitted a critical thing: why do you
think the kernel needs this feature? What's the value and use case for
being able to poll these descriptors?
To address the question, I've written down detailed description of the
chal
Hi Eric,
On 08/02/13 23:21, Eric Wong wrote:
Martin Sustrik wrote:
On 07/02/13 23:44, Andrew Morton wrote:
That's a nice changelog but it omitted a critical thing: why do you
think the kernel needs this feature? What's the value and use case for
being able to poll these descrip
On 08/02/13 23:08, Eric Wong wrote:
poll(2) function (POLLIN, POLLOUT, POLLERR, POLLHUP etc.) Specified
events will
be signaled when polling (select, poll, epoll) on the eventfd is done
later on.
'ptr' is an opaque pointer that is not interpreted by eventfd object.
How does this interact with
On 09/02/13 04:54, Eric Wong wrote:
Using one eventfd per userspace socket still seems a bit wasteful.
Wasteful in what sense? Occupying a slot in file descriptor table?
That's the price for having the socket uniquely identified by the
fd.
Yes. I realize eventfd is small, but I don't think
On 2013-02-09 12:51, Eric Wong wrote:
Yes, your eventfd change is probably the best way if you want/need
to only watch a subset of your sockets, especially if you want
poll/select to be an option.
Yes, the poll/select thing is the important point.
I wouldn't care if the only problem was that
Comment in eventfd.h referred to 'include/asm-generic/fcntl.h'
while the correct path is 'include/uapi/asm-generic/fcntl.h'.
Signed-off-by: Martin Sustrik
---
include/linux/eventfd.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux
Hi Andrew,
Thanks for the detailed code review! I'll have a look at all the
problems you've pointed out, however, one quick question:
- ret = seq_printf(m, "eventfd-count: %16llx\n",
-(unsigned long long)ctx->count);
+ if (ctx->flags& EFD_MASK) {
+
On 15/02/13 18:32, Andy Lutomirski wrote:
On Thu, Feb 14, 2013 at 9:24 PM, Andrew Morton
wrote:
On Fri, 15 Feb 2013 04:42:27 +0100 Martin Sustrik wrote:
This is a non-back-compatible userspace interface change. A procfs
file which previously displayed
eventfd-count:
can now
On 14/02/13 23:54, Andrew Morton wrote:
+/* On x86-64 keep the same binary layout as on i386. */
+#ifdef __x86_64__
+#define EVENTFD_MASK_PACKED __packed
+#else
+#define EVENTFD_MASK_PACKED
+#endif
+
+struct eventfd_mask {
+ __u32 events;
+ __u64 data;
+} EVENTFD_MASK_PACKED;
The
lling on the eventfd marked by EFD_MASK flag, all the events specified
in last written 'events' field shall be signaled.
Signed-off-by: Martin Sustrik
---
Following changes were made to the patch since v2:
- eventfd_mask structure renamed to efd_mask to keep user-space prefixes
consisten
On 14/02/13 23:54, Andrew Morton wrote:
This patch adds userspace interfaces which will require manpage
updates. Please Cc Michael and work with him on getting those changes
completed.
Right. It adds the efd_mask structure. As far as I understand how it
works is that the actual user-space de
n
On 2013-02-18 8:34 PM, Martin Sustrik wrote:
When implementing network protocols in user space, one has to
implement
fake file descriptors to represent the sockets for the protocol.
Polling on such fake file descriptors is a problem (poll/select/epoll
accept
only true file descriptors) and f
On 2015-07-09 11:06, Damian Hobson-Garcia wrote:
Hi Martin,
On 2015-07-09 5:41 PM, Martin Sustrik wrote:
Hi Damian,
Yes, this patch would be geneally useful for implementing stuff in
user
space that otherwise would have to live in kernelspace.
Unfortunately, I have no cycles left to pursue
On 2015-08-10 08:23, Damian Hobson-Garcia wrote:
Replying to my own post, but I had the following comments/questions.
Martin, if you have any response to my comments I would be very happy
to
hear them.
On 2015-08-10 2:51 PM, Damian Hobson-Garcia wrote:
From: Martin Sustrik
[snip]
write
On 2015-09-16 08:27, Damian Hobson-Garcia wrote:
From: Martin Sustrik
When implementing network protocols in user space, one has to implement
fake file descriptors to represent the sockets for the protocol.
Polling on such fake file descriptors is a problem (poll/select/epoll
accept only true
On 2015-08-10 10:57, Damian Hobson-Garcia wrote:
Hi Martin,
Thanks for your comments.
On 2015-08-10 3:39 PM, Martin Sustrik wrote:
On 2015-08-10 08:23, Damian Hobson-Garcia wrote:
Replying to my own post, but I had the following comments/questions.
Martin, if you have any response to my
23 matches
Mail list logo
