Re: [linux-lvm] commit c527a0cbfc3 may have a bug

2020-02-14 Thread heming.z...@suse.com
Hello David, I accept your points. the commit c527a0cbfc3 is correct. I still not sure if the correct fix would have unintended consequences. I think the most of people should only config device/filter in their machine. After this commit, machine with duplicated devs should config 2 same copies

Re: [linux-lvm] commit c527a0cbfc3 may have a bug

2020-02-14 Thread David Teigland
On Fri, Feb 14, 2020 at 08:34:19PM +0100, Gionatan Danti wrote: > Hi David, being filters one of the most asked questions, can I ask why we > have so many different filters, leading to such complex interactions and > behaviors? > > Don't get me wrong: I am sure you (the lvm team) have very good

Re: [linux-lvm] commit c527a0cbfc3 may have a bug

2020-02-14 Thread David Teigland
On Fri, Feb 14, 2020 at 11:13:04PM +0800, heming.z...@suse.com wrote: > Hello list & David, > > The stable-2.02 branch commit c527a0cbfc391645d30407d2 may intruduce a bug. > There is a new function label_scan_pvscan_all(), which uses > cmd->lvmetad_filter to create devices list for scan. > >

[linux-lvm] commit c527a0cbfc3 may have a bug

2020-02-14 Thread heming.z...@suse.com
Hello list & David, The stable-2.02 branch commit c527a0cbfc391645d30407d2 may intruduce a bug. There is a new function label_scan_pvscan_all(), which uses cmd->lvmetad_filter to create devices list for scan. code: ``` label_scan_pvscan_all if (!(iter = dev_iter_create(cmd->lvmetad_filter,