Re: mcam-core.c:undefined reference to `vb2_dma_sg_memops'

2013-09-30 Thread Geert Uytterhoeven
Hi Fengguang, On Mon, Sep 30, 2013 at 5:05 AM, Fengguang Wu fengguang...@intel.com wrote: FYI, kernel build failed on tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 15c03dd4859ab16f9212238f29dd315654aa94f6 commit:

RE: [PATCH 1/5] ARM: Kconfig: Move if ARCH_S3C64XX statement to mach-s3c64xx/Kconfig

2013-09-30 Thread Kukjin Kim
Tomasz Figa wrote: All other platforms have this condition checked inside their own Kconfig files, so for consistency this patch makes it this way for mach-s3c64xx as well. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/Kconfig | 2 --

Re: [PATCH] SOLO6x10: don't do DMA from stack in solo_dma_vin_region().

2013-09-30 Thread Hans Verkuil
Ismael, Can you Ack these four patches? Regards, Hans On 09/12/2013 02:25 PM, Krzysztof Hałasa wrote: Signed-off-by: Krzysztof Hałasa khal...@piap.pl diff --git a/drivers/staging/media/solo6x10/solo6x10-disp.c b/drivers/staging/media/solo6x10/solo6x10-disp.c index

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Hans Verkuil
Hi Shaik, I have a few questions regarding the selection part... On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: This patch adds the Makefile and memory to memory (m2m) interface functionality for the SCALER driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com ---

Re: mcam-core.c:undefined reference to `vb2_dma_sg_memops'

2013-09-30 Thread Fengguang Wu
On Mon, Sep 30, 2013 at 09:09:13AM +0200, Geert Uytterhoeven wrote: Hi Fengguang, On Mon, Sep 30, 2013 at 5:05 AM, Fengguang Wu fengguang...@intel.com wrote: FYI, kernel build failed on tree: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head:

Re: [PATCH v8] s5k5baf: add camera sensor driver

2013-09-30 Thread Mark Rutland
diff --git a/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt new file mode 100644 index 000..7704a1e --- /dev/null +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt @@ -0,0 +1,58 @@

Re: iram pool not available for MX27

2013-09-30 Thread Philipp Zabel
Hi Chris, Am Montag, den 30.09.2013, 13:40 +0800 schrieb Chris Ruehl: Hi Phillipp, hope things doing OK. I recently update to the 3.12-rc kernel and hit this problem below. [ 3.377790] coda coda-imx27.0: iram pool not available [ 3.383363] coda: probe of coda-imx27.0 failed with error

Re: [PATCH RFC] media: rc: OF: Add Generic bindings for remote-control

2013-09-30 Thread Srinivas KANDAGATLA
On 27/09/13 14:57, Mauro Carvalho Chehab wrote: Em Fri, 27 Sep 2013 14:26:12 +0100 Srinivas KANDAGATLA srinivas.kandaga...@st.com escreveu: On 27/09/13 12:34, Mark Rutland wrote: + - rx-mode: Can be infrared or uhf. rx-mode should be present iff + the rx pins are wired up. I'm unsure on

Re: iram pool not available for MX27

2013-09-30 Thread Chris Ruehl
Hi Philipp, On Monday, September 30, 2013 04:30 PM, Philipp Zabel wrote: Hi Chris, Am Montag, den 30.09.2013, 13:40 +0800 schrieb Chris Ruehl: Hi Phillipp, hope things doing OK. I recently update to the 3.12-rc kernel and hit this problem below. [ 3.377790] coda coda-imx27.0: iram pool not

Re: iram pool not available for MX27

2013-09-30 Thread Chris Ruehl
On Monday, September 30, 2013 05:08 PM, Chris Ruehl wrote: Hi Philipp, On Monday, September 30, 2013 04:30 PM, Philipp Zabel wrote: Hi Chris, Am Montag, den 30.09.2013, 13:40 +0800 schrieb Chris Ruehl: Hi Phillipp, hope things doing OK. I recently update to the 3.12-rc kernel and hit this

Re: [PATCH 6/8] ALSA: ppc: keywest: Don't use i2c_client-driver

2013-09-30 Thread Takashi Iwai
At Sun, 29 Sep 2013 10:51:04 +0200, Lars-Peter Clausen wrote: The 'driver' field of the i2c_client struct is redundant and is going to be removed. Use 'to_i2c_driver(client-dev.driver)' instead to get direct access to the i2c_driver struct. Signed-off-by: Lars-Peter Clausen l...@metafoo.de

Re: Initial scan files for PT

2013-09-30 Thread Oliver Schinagl
Hello Nuno, On 28-09-13 13:07, Nuno Gonçalves wrote: Here goes the initial scan files for Portugal DVB-T. Please commit them. Thank you for these files, I decided to merge them all together into a pt-All. See github/git.linuxtv.com for details. Portugal is schedule to migrate from a SFN to

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Shaik, I have a few questions regarding the selection part... On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: This patch adds the Makefile and memory to memory (m2m) interface

Re: [PATCH RFC 1/7] V4L: Add mem2mem ioctl and file operation helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: This patch adds ioctl helpers to the V4L2 mem-to-mem API, so we can avoid several ioctl handlers in the mem-to-mem video node drivers that are simply a pass-through to the v4l2_m2m_* calls. These helpers will only be useful for drivers that use

Re: [PATCH RFC 2/7] mem2mem_testdev: Use mem-to-mem ioctl and vb2 helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: Simplify the driver by using the m2m ioctl and vb2 helpers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyugmin Park kyungmin.p...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans

Re: [PATCH RFC 3/7] exynos4-is: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: Simplify the FIMC mem-to-mem driver by using the m2m ioctl and vb2 helpers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyugmin Park kyungmin.p...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards,

Re: [PATCH RFC 4/7] s5p-jpeg: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: Simplify the driver by using the m2m ioctl and vb2 helpers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyugmin Park kyungmin.p...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans

Re: [PATCH RFC 5/7] mx2-emmaprp: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: Simplify the driver by using the m2m ioctl and vb2 helpers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyugmin Park kyungmin.p...@samsung.com --- drivers/media/platform/mx2_emmaprp.c | 108

Re: [PATCH RFC 7/7] s5p-g2d: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: Simplify the driver by using the m2m ioctl and vb2 helpers. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyugmin Park kyungmin.p...@samsung.com Acked-by: Hans Verkuil hans.verk...@cisco.com Regards, Hans

Re: [PATCH RFC 6/7] exynos-gsc: Use mem-to-mem ioctl helpers

2013-09-30 Thread Hans Verkuil
On 09/13/2013 02:56 PM, Sylwester Nawrocki wrote: Simplify the driver by using the m2m ioctl and vb2 helpers. TODO: Add setting of default initial format. So this patch can't be applied yet. Other than that it looks good, but I won't ack it since it introduces a regression as long as the

Re: [PATCH] v4l2: Support for multiple selections

2013-09-30 Thread Hans Verkuil
Hi Ricardo, Sorry for the delayed review, but I'm finally catching up with my backlog. I've got a number of comments regarding this patch. I'm ignoring the platform driver patches for now until the core support is correct. On 09/16/2013 02:54 PM, Ricardo Ribalda Delgado wrote: From: Ricardo

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Hans Verkuil
On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Shaik, I have a few questions regarding the selection part... On 09/12/2013 03:09 PM, Shaik Ameer Basha wrote: This patch

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
Hi Hans, On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Shaik, I have a few questions regarding the

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Shaik Ameer Basha
On Mon, Sep 30, 2013 at 4:18 PM, Shaik Ameer Basha shaik.sams...@gmail.com wrote: Hi Hans, On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans

Re: [PATCH] v4l2: Support for multiple selections

2013-09-30 Thread Ricardo Ribalda Delgado
Hello Hans As allways thank you very much for your comments. On Mon, Sep 30, 2013 at 12:21 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Ricardo, Sorry for the delayed review, but I'm finally catching up with my backlog. I've got a number of comments regarding this patch. I'm ignoring the

Re: [RFC 1/1] v4l: return POLLERR on V4L2 sub-devices if no events are subscribed

2013-09-30 Thread Hans Verkuil
Hi Teemu, Sakari, I've been thinking about this change and I think it is a reasonable change. I had some doubts earlier, but after thinking it through I agree with this. But it needs a bit more work, see below. On 09/17/2013 08:07 PM, Sakari Ailus wrote: From: Teemu Tuominen

Re: ivtv 1.4.2/1.4.3 broken in recent kernels?

2013-09-30 Thread Hans Verkuil
On 09/17/2013 10:49 PM, Rajil Saraswat wrote: Hi, I have a couple of PVR-500's which have additional tuners connected to them (using daughter cards). The audio is not usable on either 1.4.2 or 1.4.3 ivtv drivers. The issue is described at

Re: [RFC 1/1] v4l: return POLLERR on V4L2 sub-devices if no events are subscribed

2013-09-30 Thread Sakari Ailus
Hi Hans, Thanks for the review. Hans Verkuil wrote: Hi Teemu, Sakari, I've been thinking about this change and I think it is a reasonable change. I had some doubts earlier, but after thinking it through I agree with this. But it needs a bit more work, see below. On 09/17/2013 08:07 PM,

Re: [PATCH] [media] videobuf2-core: call __setup_offsets only for mmap memory type

2013-09-30 Thread Hans Verkuil
On 09/19/2013 09:37 AM, Philipp Zabel wrote: __setup_offsets fills the v4l2_planes' mem_offset fields, which is only valid for V4L2_MEMORY_MMAP type buffers. For V4L2_MEMORY_DMABUF and _USERPTR buffers, this incorrectly overwrites the fd and userptr fields. Reported-by: Michael Olbrich

Re: [PATCH 04/10] [media] coda: fix FMO value setting for CodaDx6

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:13 AM, Philipp Zabel wrote: The register is only written on CodaDx6, so the temporary variable to be written only needs to be initialized on CodaDx6. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 6 +++--- 1 file changed, 3

Re: [PATCH 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:13 AM, Philipp Zabel wrote: Moving the ioctl handler callbacks into the coda namespace helps tremendously to make sense of backtraces. I like the idea, but I would just use the coda_ prefix, not coda_vidioc_. In general the prefix is either vidioc_ or the name of the driver,

Re: [PATCH 10/10] [media] coda: v4l2-compliance fix: zero pixel format priv field

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:13 AM, Philipp Zabel wrote: Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index d15238a..6dec34d 100644 ---

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-09-30 Thread Hans Verkuil
On 09/19/2013 11:44 PM, Russell King wrote: Replace the following sequence: dma_set_mask(dev, mask); dma_set_coherent_mask(dev, mask); with a call to the new helper dma_set_mask_and_coherent(). Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Acked-by: Hans Verkuil

Re: [PATCH] v4l2: Support for multiple selections

2013-09-30 Thread Hans Verkuil
On 09/30/2013 01:17 PM, Ricardo Ribalda Delgado wrote: Hello Hans As allways thank you very much for your comments. On Mon, Sep 30, 2013 at 12:21 PM, Hans Verkuil hverk...@xs4all.nl wrote: Hi Ricardo, Sorry for the delayed review, but I'm finally catching up with my backlog. I've got a

Re: [PATCH v3 3/4] [media] exynos-scaler: Add m2m functionality for the SCALER driver

2013-09-30 Thread Hans Verkuil
On 09/30/2013 12:48 PM, Shaik Ameer Basha wrote: Hi Hans, On Mon, Sep 30, 2013 at 4:02 PM, Hans Verkuil hverk...@xs4all.nl wrote: On 09/30/2013 11:32 AM, Shaik Ameer Basha wrote: Hi Hans, Thanks for pointing it out. On Mon, Sep 30, 2013 at 1:38 PM, Hans Verkuil hverk...@xs4all.nl

Re: [PATCH] saa7134: Fix crash when device is closed before streamoff

2013-09-30 Thread Hans Verkuil
On 09/20/2013 07:15 PM, Simon Farnsworth wrote: pm_qos_remove_request was not called on video_release, resulting in the PM core's list of requests being corrupted when the file handle was freed. This has no immediate symptoms, but later in operation, the kernel will panic as the PM core

Re: [PATCH 00/10] [media] remove unnecessary pci_set_drvdata()

2013-09-30 Thread Hans Verkuil
On 09/23/2013 03:43 AM, Jingoo Han wrote: Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound), the driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the

Re: [PATCH] [media] stk1135: fix two warnings added by changeset 76e0598

2013-09-30 Thread Hans Verkuil
On 09/26/2013 12:42 PM, Mauro Carvalho Chehab wrote: drivers/media/usb/gspca/stk1135.c:615:6: warning: no previous prototype for 'stk1135_try_fmt' [-Wmissing-prototypes] void stk1135_try_fmt(struct gspca_dev *gspca_dev, struct v4l2_format *fmt) ^

Re: [PATCH v9 09/13] [media] exynos5-fimc-is: Add the hardware pipeline control

2013-09-30 Thread Hans Verkuil
On 09/27/2013 12:59 PM, Arun Kumar K wrote: This patch adds the crucial hardware pipeline control for the fimc-is driver. All the subdev nodes will call this pipeline interfaces to reach the hardware. Responsibilities of this module involves configuring and maintaining the hardware pipeline

Re: [PATCH 3/8] [media] core: Don't use i2c_client-driver

2013-09-30 Thread Hans Verkuil
On 09/29/2013 10:51 AM, Lars-Peter Clausen wrote: The 'driver' field of the i2c_client struct is redundant and is going to be removed. The results of the expressions 'client-driver.driver-field' and 'client-dev.driver-field' are identical, so replace all occurrences of the former with the

Re: [PATCH 2/6] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-09-30 Thread Hans Verkuil
On 09/02/2013 12:29 PM, Dinesh Ram wrote: Hi Hans and Eduardo, Sorry for my radio silence. I was infact travelling and didn't have much opportunity to check my mails. I will go through the list of comments in the thread and try to fix / justify them in the next few days. Hans, probably

Re: [PATCH 04/10] [media] coda: fix FMO value setting for CodaDx6

2013-09-30 Thread Philipp Zabel
Am Montag, den 30.09.2013, 13:48 +0200 schrieb Hans Verkuil: On 09/19/2013 11:13 AM, Philipp Zabel wrote: The register is only written on CodaDx6, so the temporary variable to be written only needs to be initialized on CodaDx6. Signed-off-by: Philipp Zabel p.za...@pengutronix.de ---

Re: [PATCH 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_

2013-09-30 Thread Philipp Zabel
Am Montag, den 30.09.2013, 13:50 +0200 schrieb Hans Verkuil: On 09/19/2013 11:13 AM, Philipp Zabel wrote: Moving the ioctl handler callbacks into the coda namespace helps tremendously to make sense of backtraces. I like the idea, but I would just use the coda_ prefix, not coda_vidioc_. In

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-30 Thread Prabhakar Lad
Hi All, On Mon, Sep 23, 2013 at 8:18 AM, Prabhakar Lad prabhakar.cse...@gmail.com wrote: Hi Sylwester, On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki s.nawro...@samsung.com wrote: Hi Prabhakar, On 09/20/2013 10:11 AM, Prabhakar Lad wrote: OK I will, just send out a fix up patch which

[PATCH v2 01/10] [media] coda: allow more than four instances on CODA7541

2013-09-30 Thread Philipp Zabel
With the new firmware, there are not anymore four register sets, but a single register set, which the driver has to conserve across context switches. This allows to handle more than four instances at the same time. Signed-off-by: Philipp Zabel p.za...@pengutronix.de ---

[PATCH v2 03/10] [media] coda: add compressed flag to format enumeration output

2013-09-30 Thread Philipp Zabel
Correctly flag compressed formats in the ENUM_FMT ioctl output. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index 945c539..53539c1 100644

[PATCH v2 06/10] [media] coda: use picture type returned from hardware

2013-09-30 Thread Philipp Zabel
Instead of copying v4l2_buf.flags from the source buffer, set the destination buffer flags as reported by the hardware codec. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH v2 09/10] [media] coda: v4l2-compliance fix: implement try_decoder_cmd

2013-09-30 Thread Philipp Zabel
Implement try_decoder_cmd to let userspace determine available commands and flags. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 28 1 file changed, 20 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/coda.c

[PATCH v2 07/10] [media] coda: prefix v4l2_ioctl_ops with coda_ instead of vidioc_

2013-09-30 Thread Philipp Zabel
Moving the ioctl handler callbacks into the coda namespace helps tremendously to make sense of backtraces. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Use coda_ instead of coda_vidioc_ prefix --- drivers/media/platform/coda.c | 123

[PATCH v2 08/10] [media] coda: v4l2-compliance fix: overwrite invalid pixel formats with the current setting

2013-09-30 Thread Philipp Zabel
This patch fixes the v4l2-compliance TRY_FMT(G_FMT) != G_FMT issue. The driver now overwrites invalid formats with the current setting, using coda_get_max_dimensions to find device specific max width/height. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c |

[PATCH v2 10/10] [media] coda: v4l2-compliance fix: zero pixel format priv field

2013-09-30 Thread Philipp Zabel
If unused, the pixel format priv field has to be cleared by the driver in try_fmt. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Clear pixel format priv in try_fmt only --- drivers/media/platform/coda.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v2 0/10] CODA driver fixes

2013-09-30 Thread Philipp Zabel
This series contains a few fixes for the CODA driver to allow more than four simultaneous instances on i.MX53, and to make v4l2-compliance a bit happier. Changes since v1: - Removed no-op lines leaving FMOPARAM fields of CMD_ENC_SEQ_FMO at zero values on CodaDx6. - Use coda_ instead of

[PATCH v2 05/10] [media] coda: move coda_product_name above vidioc_querycap

2013-09-30 Thread Philipp Zabel
Use the product name (currently CodaDx6 or CODA7541) to fill the v4l2_capabilities.name field. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 35 +++ 1 file changed, 19 insertions(+), 16 deletions(-) diff --git

[PATCH v2 02/10] [media] coda: only set buffered input queue for decoder

2013-09-30 Thread Philipp Zabel
Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/platform/coda.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c index 2805538..945c539 100644 --- a/drivers/media/platform/coda.c +++

[PATCH v2 04/10] [media] coda: fix FMO value setting for CodaDx6

2013-09-30 Thread Philipp Zabel
The register is only written on CodaDx6, so the temporary variable to be written only needs to be initialized on CodaDx6. Also, drop two no-op lines. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- Changes since v1: - Removed no-op lines leaving FMOPARAM fields of CMD_ENC_SEQ_FMO at

[PATCH] [media] platform: Kconfig: Select SRAM for VIDEO_CODA

2013-09-30 Thread Fabio Estevam
Running the coda driver without CONFIG_SRAM selected leads to the following probe error: coda 63ff4000.vpu: iram pool not available coda: probe of 63ff4000.vpu failed with error -12 In order to avoid it, select CONFIG_SRAM inside VIDEO_CODA. Signed-off-by: Fabio Estevam

RE: [PATCH 2/6] si4713 : Modified i2c driver to handle cases where interrupts are not used

2013-09-30 Thread Dinesh Ram
Hi Hans, I probably should have done it by now. I will send you the changes this weekend and you can test those. I have been quite busy on my thesis lately. Regards, Dinesh From: Hans Verkuil [hverk...@xs4all.nl] Sent: 30 September 2013 15:07 To: Dinesh

Re: [PATCH] media: i2c: adv7343: fix the DT binding properties

2013-09-30 Thread Laurent Pinchart
Hi Prabhakar, On Monday 30 September 2013 18:57:01 Prabhakar Lad wrote: On Mon, Sep 23, 2013 at 8:18 AM, Prabhakar Lad wrote: On Fri, Sep 20, 2013 at 3:22 PM, Sylwester Nawrocki wrote: On 09/20/2013 10:11 AM, Prabhakar Lad wrote: OK I will, just send out a fix up patch which fixes the

Re: [PATCH] Revert V4L/DVB: uvc: Enable USB autosuspend by default on uvcvideo

2013-09-30 Thread Laurent Pinchart
Hi, On Tuesday 24 September 2013 08:55:19 VDR User wrote: On Tue, Sep 24, 2013 at 4:34 AM, Laurent Pinchart wrote: I've discussed this issue during LPC last week, and I still believe we should enable auto-suspend. The feature really saves power, without it my C910 Logitech webcam gets hot

Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Michael Krufky
Jiří, Do you have any documentation that supports this value change? Changing this value affects the algorithm, and we'd be happier making this change if the patch included some better description and perhaps a reference explaining why the new value is correct. Regards, Mike Krufky On Sun, Sep

Re: Subject: [PATCH 2/2] [media] r820t: simplify divisor calculation

2013-09-30 Thread Michael Krufky
Jiří, It's difficult to understand a patch like this, let alone merging it, without any kind of explanation. At a quick glance, the patch looks wrong. If you believe the patch is correct, then please resubmit with some sort of description and explanation for the change. Best regards, Mike

Re: [PATCH] dvb: fix potential format string leak

2013-09-30 Thread Michael Krufky
On Mon, Sep 16, 2013 at 7:48 PM, Joe Perches j...@perches.com wrote: On Mon, 2013-09-16 at 16:37 -0700, Kees Cook wrote: Make sure that a format string cannot accidentally leak into the printk buffer. [] diff --git a/drivers/media/dvb-frontends/dib9000.c

Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Michael Krufky
Do you have any comments on this, Mauro? Assuming that Mauro is OK with this change, (since he is the author of this driver) then yes - please resubmit the patch with some explanation within comments inline or within the commit message. Best regards, Mike Krufky On Mon, Sep 30, 2013 at 12:42

Re: [PATCH RFC] media: rc: OF: Add Generic bindings for remote-control

2013-09-30 Thread Mark Rutland
On Fri, Sep 27, 2013 at 02:47:19PM +0100, Mauro Carvalho Chehab wrote: Em Fri, 27 Sep 2013 12:34:58 +0100 Mark Rutland mark.rutl...@arm.com escreveu: On Fri, Sep 27, 2013 at 10:33:11AM +0100, Srinivas KANDAGATLA wrote: From: Srinivas Kandagatla srinivas.kandaga...@st.com This patch

Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Jiří Pinkava
Mike, unfortunately no documentation can be referenced except preliminary version of datasheet (1).This change is based on lucky guess and supported by lot of testing on real hardware. This change add support for devices with Xtal frequency bellow 28.8MHz. From Nint are computed values of Ni

Re: [PATCH 1/2] [media] r820t: fix nint range check

2013-09-30 Thread Mauro Carvalho Chehab
Em Mon, 30 Sep 2013 12:46:52 -0400 Michael Krufky mkru...@linuxtv.org escreveu: Do you have any comments on this, Mauro? Assuming that Mauro is OK with this change, (since he is the author of this driver) then yes - please resubmit the patch with some explanation within comments inline or

Re: [PATCH 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT

2013-09-30 Thread Sakari Ailus
Hi Laurent, On Fri, Sep 20, 2013 at 11:08:47PM +0200, Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. Thanks for the review! :) On Thursday 19 September 2013 01:01:05 Sakari Ailus wrote: Pads that set this flag must be connected by an active link for the entity to stream.

Re: [PATCH 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT

2013-09-30 Thread Laurent Pinchart
Hi Sakari, On Tuesday 01 October 2013 02:08:47 Sakari Ailus wrote: On Fri, Sep 20, 2013 at 11:08:47PM +0200, Laurent Pinchart wrote: On Thursday 19 September 2013 01:01:05 Sakari Ailus wrote: Pads that set this flag must be connected by an active link for the entity to stream.

Re: [PATCH 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT

2013-09-30 Thread Sakari Ailus
Hi Laurent, Thnanks for the comments. A few more below. On Tue, Oct 01, 2013 at 01:21:58AM +0200, Laurent Pinchart wrote: Hi Sakari, On Tuesday 01 October 2013 02:08:47 Sakari Ailus wrote: On Fri, Sep 20, 2013 at 11:08:47PM +0200, Laurent Pinchart wrote: On Thursday 19 September 2013

cron job: media_tree daily build: WARNINGS

2013-09-30 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Oct 1 04:00:14 CEST 2013 git branch: test git hash: ffee921033e64edf8579a3b21c7f15d1a6c3ef71 gcc

Re: [PATCH 00/10] [media] remove unnecessary pci_set_drvdata()

2013-09-30 Thread Sachin Kamat
Hi Hans, On 30 September 2013 17:52, Hans Verkuil hverk...@xs4all.nl wrote: On 09/23/2013 03:43 AM, Jingoo Han wrote: Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d (device-core: Ensure drvdata = NULL when no driver is bound), the driver core clears the driver data to NULL after

[no subject]

2013-09-30 Thread Mr. Donald Hall
Hello, Do you need a loan? Do you need money to pay off your debts? Do you need money to establish a new business or to refinance an existing business? our loan company offers loans at 3% interest rate with an understandable loan terms and condition. If you are interested in obtaining a

Re: [PATCH V5 1/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi

2013-09-30 Thread Kishon Vijay Abraham I
Hi, On Sunday 29 September 2013 12:57 AM, Sylwester Nawrocki wrote: Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Felipe Balbi ba...@ti.com Can this

Re: Hauppauge HVR-900 HD and HVR 930C-HD with si2165

2013-09-30 Thread Matthias Schwarzott
On 26.09.2013 16:54, Antti Palosaari wrote: On 25.09.2013 07:50, Matthias Schwarzott wrote: On 17.08.2013 13:30, Ulf wrote: Hi, I know the topic Hauppauge HVR-900 HD and HVR 930C-HD with si2165 demodulator was already discussed

Re: [PATCH 4/9] [media] pci: mantis: Remove redundant pci_set_drvdata

2013-09-30 Thread Manu Abraham
On Fri, Sep 20, 2013 at 2:06 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Cc: Manu Abraham abraham.m...@gmail.com Acked-by: Manu Abraham m...@linuxtv.org ---

Re: [PATCH 8/9] [media] pci: bt878: Remove redundant pci_set_drvdata

2013-09-30 Thread Manu Abraham
On Fri, Sep 20, 2013 at 2:06 PM, Sachin Kamat sachin.ka...@linaro.org wrote: Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Manu Abraham m...@linuxtv.org --- drivers/media/pci/bt8xx/bt878.c |1 - 1 file changed,