Re: Bug#929262: libv4l-dev: pac207 cam(s) give frame decode errors

2019-05-20 Thread Gregor Jasny
Hello, On 20.05.19 10:25, folk...@vanheusden.com wrote: Trying to get a pac207 camera to work with constatus. 2019-05-20 10:22:34.864900 INFO constatus [1-1] source v4l2 thread started libv4l2: error got 4 consecutive frame decode errors, last error: v4l-convert: error unknown pac207 row head

Re: [PATCH v4l-utils] libdvbv5: leaks and double free in dvb_fe_open_fname()

2019-05-03 Thread Gregor Jasny
Hello, On 03.05.19 15:00, Mauro Carvalho Chehab wrote: Are you planning to release a version 1.16.6 any time soon? I could likely do it as well, but I would prefer if you can do, as you know better the drills. We're still receiving new complaints about this issue at Kaffeine's BZ. Just received

Re: missing patch on v4l-utils-1.14 / 1.16

2019-04-08 Thread Gregor Jasny
Hello, It seems that commit 6e21f6f34c1d7c3a7a059062e1ddd9705c984e2c is also missing on 1.16 (in addition to 1.14). Otherwise the return paths are still messed up: ret = dvb_fe_open_fname(parms, dvb_dev->path, flags); if (ret < 0) { free(parms); <--- double

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

2019-03-28 Thread Gregor Jasny
Hello, On 28.03.19 20:17, Mauro Carvalho Chehab wrote: Em Thu, 28 Mar 2019 19:48:35 +0100 Samuel CHEMLA escreveu: 1) I did reproduce the bug with a serial console, but the serial console was also frozen, and there was no message before freeze. The only way for a machine to freeze even on ser

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

2019-03-21 Thread Gregor Jasny
Hello, On 21.03.19 12:30, Mauro Carvalho Chehab wrote: I went ahead and cherry-picked the relevant patches to -1.12, -1.14 and -1.16, and tested both dvbv5-zap and dvbv5-scan with all versions. So, we can release a new minor version for all those stable branches. After the patches, on my tests,

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

2019-03-20 Thread Gregor Jasny
Hello Mauro, On 19.03.19 20:45, Mauro Carvalho Chehab wrote: Hi Gregor, Samuel reported in priv that the issues he had with user after free were solved by the patchsets merged at 1.12 and 1.16 stable branches. Could you please generate a new staging release for them? Sure, I can create a new

Re: [Bug report] dvbv5-zap crash dvb-tool ARMHF builds

2019-03-12 Thread Gregor Jasny
Hello Mauro, below you find a bug report about an use-after-free in dvbv5-zap. On 12.03.19 13:37, CHEMLA Samuel wrote: please find a bug report that seems to concern ARMHF builds of dvbv5-zap (dvb-tool package) : https://bugs.launchpad.net/raspbian/+bug/1819650 I filed it against raspbian becau

Re: [PATCH] keytable: fix BPF protocol compilation on mips

2018-11-07 Thread Gregor Jasny
On 11/7/18 4:36 PM, Sean Young wrote: clang -idirafter /usr/local/include -idirafter +/usr/lib/llvm-6.0/lib/clang/6.0.1/include -idirafter +/usr/include/mips64el-linux-gnuabi64 -idirafter /usr/include +-I../../../include -target bpf -O2 -c grundig.c In file included from grundig.c:5: In file inc

si2168: NULL pointer dereference at unplug

2017-11-25 Thread Gregor Jasny
Hello, when I unplug my August DVB-T230 stick I get the message below. Is this a known issue? If not, is there anything I could do to get you a better stack trace? Thanks, Gregor [9.573636] BUG: unable to handle kernel NULL pointer dereference at 00b8 [9.573653] IP: si2168_s

Re: dvbv5-scan: Missing NID, TID, and RID in VDR channel output

2017-11-25 Thread Gregor Jasny
Hello Mauro, On 11/25/17 12:54 PM, Mauro Carvalho Chehab wrote: > Em Sat, 25 Nov 2017 09:08:19 -0200 > Mauro Carvalho Chehab escreveu: >> Em Wed, 22 Nov 2017 20:50:56 +0100 >> Gregor Jasny escreveu: >>> >>> Mauro, do you think it would be possible to parse

dvbv5-scan: Missing NID, TID, and RID in VDR channel output

2017-11-22 Thread Gregor Jasny
Hello Mauro and list, since some days my region in Germany finally got DVB-T2 coverage. Something in the broadcasted tabled makes w_scan only find a subset each time. dvbv5-scan is somewhat more reliable. But with the VDR compatible channel list exported from dvbv5-scan I cannot make VDR produce

Re: [PATCH v2] Build libv4lconvert helper support only when fork() is available.

2017-07-26 Thread Gregor Jasny
On 7/26/17 2:51 PM, Hugues Fruchet wrote: > Build libv4lconvert helper support only when fork() is available. > This fix the build issue reported here: > http://autobuild.buildroot.net/results/7e8/7e8fbd99a8c091d7bbeedd16066297682bbe29fe/build-end.log > > More details on buildroot mailing list her

Re: Problems pushing to v4l-utils

2017-07-26 Thread Gregor Jasny
On 7/26/17 8:15 PM, Gregor Jasny wrote: > I'm having problems to push to v4l-utils: Please ignore. It was the wrong clone of v4l-utils. Thanks, Gregor

Problems pushing to v4l-utils

2017-07-26 Thread Gregor Jasny
Hello Mauro & list, I'm having problems to push to v4l-utils: Did the setup recently change? gjasny@sid:~/src/v4l-utils$ git remote -v origin git://linuxtv.org/v4l-utils.git (fetch) origin git://linuxtv.org/v4l-utils.git (push) gjasny@sid:~/src/v4l-utils$ git push -v Pushing to git://linuxtv.

Re: [PATCH] libdvbv5: T2 delivery descriptor: fix wrong size of bandwidth field

2017-05-04 Thread Gregor Jasny
Hello Mauro, On 04.05.17 00:33, Mauro Carvalho Chehab wrote: Em Wed, 3 May 2017 09:53:03 -0300 Mauro Carvalho Chehab escreveu: Em Tue, 2 May 2017 22:30:29 +0200 Gregor Jasny escreveu: I just used your patch and another to hopefully fix https://bugs.debian.org/cgi-bin/bugreport.cgi?bug

Re: [PATCH] libdvbv5: T2 delivery descriptor: fix wrong size of bandwidth field

2017-05-02 Thread Gregor Jasny
Hello Clemens, On 4/1/17 5:50 PM, Clemens Ladisch wrote: > ETSI EN 300 468 V1.11.1 § 6.4.4.2 defines the bandwith field as having > four bits. I just used your patch and another to hopefully fix https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859008 But I'm a little bit hesitant to merge it to

Re: dvb-tools: dvbv5-scan segfaults with DVB-T2 HD service that just started in Germany

2017-03-30 Thread Gregor Jasny
Hello Mauro, could you please take a look? Thanks, Gregor On 3/30/17 9:36 PM, Frank Heckenbach wrote: > I got the same problem, only on some channels though, e.g. ZDF using > this input: > > [CH34] > DELIVERY_SYSTEM = DVBT2 > FREQUENCY = 57800 > BANDWIDTH_HZ = 800 > MODULATION = QAM/16

Re: dvb-tools: dvbv5-scan segfaults with DVB-T2 HD service that just started in Germany

2017-03-29 Thread Gregor Jasny
Hello Mauro & list, could you please have a look at the dvbv5-scan crash report below? https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=859008 Is there anything else you need to debug this? Thanks, Gregor On 3/29/17 4:42 PM, Tino Mettler wrote: > > $ gdb --args ./utils/dvb/dvbv5-scan ~/tmp/dv

Re: Bug#854100: libdvbv5-0: fails to tune / scan

2017-02-10 Thread Gregor Jasny
ttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854100 On 2/4/17 5:43 PM, Marcel Heinz wrote: > Am 04.02.2017 um 15:57 schrieb Gregor Jasny: >> Thanks for sharing! Maybe you could try to bisect to find the breaking >> commit? > > OK, I ended up with > > d982b0d03b1f929269104b

Re: Bug#854100: libdvbv5-0: fails to tune / scan

2017-02-04 Thread Gregor Jasny
Hello, On 2/4/17 3:35 AM, Marcel Heinz wrote: > After the upgrade from libdvbv5-0 1.10.1-1 to 1.12.2-2, any applications > using libdvbv5-0 fail to work with my DVB-S card. > > Output with old dvb-tools / libdvbv5-0 1.10.1-1: > > |$ dvbv5-scan -l UNIVERSAL /usr/share/dvb/dvb-s/Astra-19.2e > |Usi

Re: Time for a v4l-utils 1.12 release

2017-01-16 Thread Gregor Jasny
On 16/01/2017 11:06, Sean Young wrote: > On Mon, Jan 16, 2017 at 09:10:36AM +0100, Gregor Jasny wrote: >> Hello, >> >> I'd like to do a new v4l-utils release before the Debian freeze. Is master >> in a releasable state? Or should I wait for some more patches to

Re: Time for a v4l-utils 1.12 release

2017-01-16 Thread Gregor Jasny
On 16/01/2017 09:10, Gregor Jasny wrote: > I'd like to do a new v4l-utils release before the Debian freeze. Is > master in a releasable state? Or should I wait for some more patches to > land? Mauro, could you please check the pot files? It looks like they need a re-build and trans

Re: Time for a v4l-utils 1.12 release

2017-01-16 Thread Gregor Jasny
On 16/01/2017 12:01, Arnaud Vrac wrote: > Also, make dist is failing. Thanks, fixed. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Time for a v4l-utils 1.12 release

2017-01-16 Thread Gregor Jasny
Hello, I'd like to do a new v4l-utils release before the Debian freeze. Is master in a releasable state? Or should I wait for some more patches to land? Thanks, Gregor -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.o

Re: [v4l-utils PATCH 2/2] Add --with-static-binaries option to link binaries statically

2016-09-26 Thread Gregor Jasny
On 19/09/2016 16:21, Mauro Carvalho Chehab wrote: > Em Mon, 19 Sep 2016 16:22:30 +0300 > Sakari Ailus escreveu: > >> Add a new variable STATIC_LDFLAGS to add the linker flags required for >> static linking for each binary built. >> >> Static and dynamic libraries are built by default but the bina

Need help with ir-keytable imon bug report

2016-06-15 Thread Gregor Jasny
Hello, could someone please help me triaging the following ir-keytable bug? The reporter complains that the 'other' IR protocol results in double clicks and we should set the device to RC6 instead: https://bugs.launchpad.net/ubuntu/+source/v4l-utils/+bug/1579760 This is what we have in v4l-utils

Re: [v4l-utils PATCH 1/1] Allow building static binaries

2015-12-16 Thread Gregor Jasny
Hello, On 10/12/15 14:21, Sakari Ailus wrote: > I discussed with Hans and he thought you'd be the best person to take a look > at this. > > The case is that I'd like to build static binaries and that doesn't seem to > work with what's in Makefile.am for libv4l1 and libv4l2 at the moment. Sorry f

Re: [PATCH 0/2] v4l-utils: new configure options

2015-09-14 Thread Gregor Jasny
Hi, On 03/09/15 17:23, Hans Verkuil wrote: Gregor, Can you take a look at this to see if I did this correctly? I'm no autoconf hero, so before I push I'd like some feedback. The main reason for these changes is that I need to build v4l2-ctl for an embedded system and rather than having to hack

Re: Time for a v4l-utils 1.8.0 release

2015-09-14 Thread Gregor Jasny
Hello, On 05/05/15 22:22, Mauro Carvalho Chehab wrote: Em Tue, 05 May 2015 21:08:49 +0200 Gregor Jasny escreveu: Hello, It's already more than half a year since the last v4l-utils release. Do you have any pending commits or objections? If no one vetos I'd like to release th

Re: [PATCHv2 1/4] Use off_t and off64_t instead of __off_t and __off64_t

2015-05-09 Thread Gregor Jasny
Hello, Due to complete lack of unit / integration tests I feel uncomfortable merging this patch without the ACK of Hans de Goede. On 05/05/15 21:02, Felix Janda wrote: > Since _LARGEFILE64_SOURCE is 1, these types coincide if defined. This statement is only partially true: $ git grep _LARGEFILE

Re: [patch]: v4l-utils/util/dvb add -C to manpages

2015-05-09 Thread Gregor Jasny
On 08/05/15 16:16, Vincent McIntyre wrote: > I noticed the -C option was in the help from the -? option > but not in the manpages. Thanks. Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 3/4] Wrap LFS64 functions only if __GLIBC__

2015-05-05 Thread Gregor Jasny
On 05/05/15 14:34, Mauro Carvalho Chehab wrote: > Em Sun, 25 Jan 2015 21:36:36 +0100 > Felix Janda escreveu: >> -#ifdef linux >> +#ifdef __GLIBC__ > > Hmm... linux was added here to avoid breaking on FreeBSD, on this > changeset: > > So, either we should get an ack from Hans Peter, or you should

Time for a v4l-utils 1.8.0 release

2015-05-05 Thread Gregor Jasny
Hello, It's already more than half a year since the last v4l-utils release. Do you have any pending commits or objections? If no one vetos I'd like to release this weekend. Thanks, Gregor -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord.

Re: [PATCH/RFC v4 11/11] Add a libv4l plugin for Exynos4 camera

2015-03-15 Thread Gregor Jasny
> diff --git a/lib/libv4l-exynos4-camera/Makefile.am > b/lib/libv4l-exynos4-camera/Makefile.am > new file mode 100644 > index 000..23c60c6 > --- /dev/null > +++ b/lib/libv4l-exynos4-camera/Makefile.am > @@ -0,0 +1,7 @@ > +if WITH_V4L_PLUGINS > +libv4l2plugin_LTLIBRARIES = libv4l-exynos4-camera

Re: [PATCH/RFC v4 11/11] Add a libv4l plugin for Exynos4 camera

2015-03-15 Thread Gregor Jasny
On 21/11/14 17:14, Jacek Anaszewski wrote: > diff --git a/lib/Makefile.am b/lib/Makefile.am > index 3a0e19c..56b3a9f 100644 > --- a/lib/Makefile.am > +++ b/lib/Makefile.am > @@ -5,7 +5,12 @@ SUBDIRS = \ > libv4l2rds \ > libv4l-mplane > > +if WITH_V4LUTILS > +SUBDIRS += \ > + libv

Re: v4l-utils stable release 1.6.2

2014-11-21 Thread Gregor Jasny
dd initial checks for VIDIOC_QUERY_EXT_CTRL > v4l2-ctl: add support for U32 control type. > v4l2-ctl: fix array handling > > > v4l-utils-1.6.1 > --- > > Gregor Jasny (5): > man: remove duplicate backslash from NAME section > man: Use Unicode char

v4l-utils stable release 1.6.1

2014-11-20 Thread Gregor Jasny
dvb_guess_user_country() v4l-utils/libdvbv5: add gconv module for the text conversions of ISDB-S/T. Gregor Jasny (7): Start v4l-utils 1.7.0 development cycle man: remove duplicate backslash from NAME section man: Use Unicode character for ellipsis and fall back to

Re: [PATCH v4] v4l-utils/libdvbv5: add gconv module for the text conversions of ISDB-S/T.

2014-11-02 Thread Gregor Jasny
Hello, this does not compile for me on my Debian Sid machine: > make[3]: Entering directory '/home/gjasny/src/linuxtv/v4l-utils/lib/gconv' > ld -o ARIB-STD-B24.so ARIB-STD-B24.o -shared --version-script=gconv.map -z > combreloc -rpath=/usr/lib/gconv /usr/lib/gconv/libJIS.so > /usr/lib/gconv/li

Re: [PATCH] v4l-utils/libdvbv5: restore deleted functions to keep API/ABI compatible

2014-11-02 Thread Gregor Jasny
On 02/11/14 13:01, tsk...@gmail.com wrote: > From: Akihiro Tsukada > > dvb_new_freq_is_needed() was integrated to dvb_new_entry_is_needed(), > and dvb_scan_add_entry() was added a new parameter. > As those changes broke API/ABI compatibility, > restore the original functions. I suppose you intro

Re: [git:v4l-utils/master] libdvbv5, dvbv5-scan: generalize channel duplication check

2014-11-02 Thread Gregor Jasny
On 02/11/14 10:41, Mauro Carvalho Chehab wrote: > Em Sun, 02 Nov 2014 18:30:46 +0900 > Akihiro TSUKADA escreveu: > >> Hi, >> >> After I re-checked the source, >> I noticed that dvb_scan_add_entry() also breaks API/ABI compatibility >> as well as dvb_new_freq_is_needed(), and those functions are >

Re: [PATCH v3 6/7] v4l-utils/dvb: add COUNTRY property

2014-11-02 Thread Gregor Jasny
Hello, Hello Coverity detected that dvb_guess_user_country introduces a resource leak (CID 1250445). On 31/10/14 14:13, tsk...@gmail.com wrote: > +enum dvb_country_t dvb_guess_user_country(void) > +{ > + char * buf, * pch, * pbuf; > + unsigned cat; > + enum dvb_country_t id = COUNTRY_

Re: [PATCH/RFC 0/1] Libv4l: Add a plugin for the Exynos4 camera

2014-10-09 Thread Gregor Jasny
Hi, On 08/10/14 10:46, Jacek Anaszewski wrote: > This patch adds a plugin for the Exynos4 camera. I wanted to split > at least the parser part to the separate module but encountered > some problems with autotools configuration and therefore I'd like > to ask for an instruction on how to adjust the

Re: Upcoming v4l-utils 1.6.0 release

2014-10-05 Thread Gregor Jasny
Hello, On 04/10/14 16:22, Mauro Carvalho Chehab wrote: > Em Tue, 30 Sep 2014 18:29:26 +0200 > Hans de Goede escreveu: >> About the 1.6.0 release, please do not release it until the series >> fixing the regression in 1.4.0 with gstreamer which I've posted >> today. A review of that series would be

Re: Upcoming v4l-utils 1.6.0 release

2014-09-30 Thread Gregor Jasny
Hello, On 27/09/14 13:54, Mauro Carvalho Chehab wrote: > Em Sat, 27 Sep 2014 12:57:11 +0200 > Gregor Jasny escreveu: >> As far as I understand the service_location feature should work but is >> an extension to the standard. Does it harm if we keep it until we have >> some

[PATCH 1/3] libdvbv5: Add todo file

2014-09-30 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- TODO.libdvbv5 | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 TODO.libdvbv5 diff --git a/TODO.libdvbv5 b/TODO.libdvbv5 new file mode 100644 index 000..21091c4 --- /dev/null +++ b/TODO.libdvbv5 @@ -0,0 +1,2 @@ +- On next SONAME bump + - clean up

[PATCH 0/3] libdvbv5: Remove broken descriptor parsers

2014-09-30 Thread Gregor Jasny
Hello, this patch series removes the service_list and service_location descriptors. It breaks API compatibility by removing the public header files but maintains ABI compatibility by providing stub implementations. Thanks, Gregor Gregor Jasny (3): libdvbv5: Add todo file libdvbv5: remove

[PATCH 3/3] libdvbv5: remove service_list descriptor

2014-09-30 Thread Gregor Jasny
CC: Andre Roth Signed-off-by: Gregor Jasny --- doxygen_libdvbv5.cfg | 1 - lib/include/libdvbv5/desc_service_list.h | 119 --- lib/libdvbv5/Makefile.am | 2 - lib/libdvbv5/compat-soname.c | 8 ++ lib

[PATCH 2/3] libdvbv5: remove service_location descriptor

2014-09-30 Thread Gregor Jasny
CC: Andre Roth Signed-off-by: Gregor Jasny --- TODO.libdvbv5| 1 + lib/include/libdvbv5/desc_service_location.h | 107 --- lib/libdvbv5/Makefile.am | 3 +- lib/libdvbv5/compat-soname.c

Upcoming v4l-utils 1.6.0 release

2014-09-27 Thread Gregor Jasny
Hello, Mauro was very busy adding Doxygen documentation to libdvbv5. Instead of cherry picking the (many) individual commits I'd like to release master as 1.6.0. Has anyone uncommited pending work? If not I'd like to release on Monday (29th). About the DVB API/ABI incompatibility discussed below

[PATCH 5/5] libdvbv5: Make dummy_fe static

2014-08-23 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/libdvbv5/dvb-fe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libdvbv5/dvb-fe.c b/lib/libdvbv5/dvb-fe.c index 6471f68..c260674 100644 --- a/lib/libdvbv5/dvb-fe.c +++ b/lib/libdvbv5/dvb-fe.c @@ -35,7 +35,7 @@ static void dvb_v5_free

[PATCH 2/5] libdvbv5: Rename and hide charset definitions

2014-08-23 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/include/libdvbv5/descriptors.h | 2 -- lib/libdvbv5/descriptors.c | 3 --- lib/libdvbv5/descriptors/desc_event_extended.c | 2 +- lib/libdvbv5/descriptors/desc_event_short.c| 4 ++-- lib/libdvbv5/descriptors

[PATCH 4/5] libdvbv5: Make dvb_xxx_charset const strings

2014-08-23 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/libdvbv5/parse_string.c | 13 +++-- lib/libdvbv5/parse_string.h | 8 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/libdvbv5/parse_string.c b/lib/libdvbv5/parse_string.c index db47c3a..081b2f8 100644 --- a/lib/libdvbv5

[PATCH 3/5] libdvbv5: Hide unused and unexposed cnr_to_qual_s tables

2014-08-23 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/libdvbv5/dvb-fe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libdvbv5/dvb-fe.c b/lib/libdvbv5/dvb-fe.c index 013edd6..6471f68 100644 --- a/lib/libdvbv5/dvb-fe.c +++ b/lib/libdvbv5/dvb-fe.c @@ -944,7 +944,7 @@ struct

[PATCH 0/5] Further clean up libdvbv5

2014-08-23 Thread Gregor Jasny
Hello, Here you'll find some patches to clean up libdvbv5. I tried to reduce exported symbols of the shared library to easy maintenance in the future. Thanks, Gregor Gregor Jasny (5): libdvbv5: Remove dvbsat_polarization_name (same as dvb_sat_pol_name) libdvbv5: Rename and hide ch

[PATCH 1/5] libdvbv5: Remove dvbsat_polarization_name (same as dvb_sat_pol_name)

2014-08-23 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/include/libdvbv5/dvb-sat.h | 2 -- lib/libdvbv5/dvb-sat.c | 7 --- 2 files changed, 9 deletions(-) diff --git a/lib/include/libdvbv5/dvb-sat.h b/lib/include/libdvbv5/dvb-sat.h index a414448..f14e7e4 100644 --- a/lib/include/libdvbv5/dvb-sat.h

[PATCH 1/2] Hide parse_string.h content in shared library interface

2014-06-22 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/libdvbv5/parse_string.h | 8 1 file changed, 8 insertions(+) diff --git a/lib/libdvbv5/parse_string.h b/lib/libdvbv5/parse_string.h index 61d0ed4..39f7dc4 100644 --- a/lib/libdvbv5/parse_string.h +++ b/lib/libdvbv5/parse_string.h @@ -17,6 +17,10

[PATCH 0/2] Clean up public libdvbv5 interface

2014-06-22 Thread Gregor Jasny
Hi, If we want to enable libdvbv5 from v4l-utils by default its exported interface should be as clean as possible. This series prefixes all functions with _dvb. I omitted symbols starting with atsc and isdb. Thanks, Gregor Gregor Jasny (2): Hide parse_string.h content in shared library

[PATCH 2/2] Prefix exported functions with dvb_

2014-06-22 Thread Gregor Jasny
Signed-off-by: Gregor Jasny --- lib/include/libdvbv5/crc32.h | 2 +- lib/include/libdvbv5/desc_extension.h | 8 +- lib/include/libdvbv5/descriptors.h | 4 +- lib/include/libdvbv5/dvb-demux.h | 2 +- lib/include/libdvbv5/dvb-file.h

Time for v4l-utils 1.2 release?

2014-06-20 Thread Gregor Jasny
Hello, It's been 11 months since the 1.0.0 release. What do you think about releasing HEAD? Do you have any pending commits? Mauro, you tried to re-license the DVB library. What's the status there? Thanks, Gregor -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the bo

Re: How to tell libv4l2 which src_fmt should be prefered?

2014-01-18 Thread Gregor Jasny
Hi, On 18/01/14 11:43, Andreas Weber wrote: Is there a way to tell libv4l2 which native source format it should prefer to convert from? For example my uvcvideo webcam supports natively YUYV and MJPG (see output below) ... So it picks up YUYV as source format. I had a look at v4lconvert_try_form

Re: [PATCH] Update the link pointing the patch for porting the application to libv4l2

2014-01-14 Thread Gregor Jasny
On 13/01/14 11:59, Prabhakar Lad wrote: From: "Lad, Prabhakar" Signed-off-by: Lad, Prabhakar --- README.libv4l |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to ma

Re: [PATCH] Update the README name for libv4l

2014-01-14 Thread Gregor Jasny
On 13/01/14 10:28, Prabhakar Lad wrote: The README for libv4l was renamed from README.lib to README.libv4l but the reference to it was not fixed. This patch fixes the above. Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to ma

Re: [PATCH 2/3] libdvbv5: implement MGT table parser

2014-01-09 Thread Gregor Jasny
Hello André, On 08/01/14 12:23, André Roth wrote: ... + union { + uint16_t bitfield; + struct { + uint16_t pid:13; + uint16_t one:3; + } __attribute__((packed)); + } __attribute__((packed)); +

Re: libdvbv5: dvb_table_pat_init is leaking memory

2013-12-15 Thread Gregor Jasny
Hello Mauro, On 28/11/13 13:24, Mauro Carvalho Chehab wrote: After a good resting night, I reviewed it, and it turns that memory leaks can occur. So, I re-worked the logic. I also fixed the other bugs pointed by Coverity today. Could you please re-run the Coverity tests, to see if everything is

Re: [PATCH] [v4l-utils] Fix configure.ac --disable-v4l-utils option

2013-11-19 Thread Gregor Jasny
On 19/11/13 14:28, Alain VOLMAT wrote: When using AC_ARG_ENABLE with a string containing - in it, the variable created will contains a _ instead of the -. Thus for AC_ARG_ENABLE(v4l-utils ..., the variable enable_v4l_utils must be checked. Applied, Thanks! -- To unsubscribe from this list:

Re: libtool warning in libdvbv5

2013-10-07 Thread Gregor Jasny
Hello Hans, On 10/4/13 1:14 PM, Hans Verkuil wrote: When linking libdvbv5.la I get the following warning from libtool: CCLD libdvbv5.la libtool: link: warning: `-version-info/-version-number' is ignored for convenience libraries Other libs don't give that warning, but I don't see any o

Re: [PATCH v2 1/2] libv4lconvert: Support for Y16 pixel format

2013-08-16 Thread Gregor Jasny
On 8/13/13 10:56 AM, Hans de Goede wrote: Series looks good to me: Acked-by: Hans de Goede I submitted it yesterday. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

Re: [PATCH v2 1/2] libv4lconvert: Support for Y16 pixel format

2013-08-12 Thread Gregor Jasny
On 8/9/13 6:04 PM, Ricardo Ribalda Delgado wrote: ping? Thank you for your the updated series. Unfortunately I'm still partially busy with moving. I hoped the v4lconvert maintainer Hans (de Goede) will ack these patches. If this series does not get an ack by Sunday I'll double check and comm

Re: [PATCH v2 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-03 Thread Gregor Jasny
On 8/3/13 12:42 AM, Ricardo Ribalda Delgado wrote: + case V4L2_PIX_FMT_RGB32: + switch (dest_pix_fmt) { + case V4L2_PIX_FMT_RGB24: + v4lconvert_rgb32_to_rgb24(src, dest, width, height, 0); + break; + case

Re: [PATCH 3/5] qv4l2: add ALSA stream to qv4l2

2013-08-02 Thread Gregor Jasny
Hello, diff --git a/utils/qv4l2/Makefile.am b/utils/qv4l2/Makefile.am index 22d4c17..eed25b0 100644 --- a/utils/qv4l2/Makefile.am +++ b/utils/qv4l2/Makefile.am @@ -4,7 +4,8 @@ qv4l2_SOURCES = qv4l2.cpp general-tab.cpp ctrl-tab.cpp vbi-tab.cpp v4l2-api.cpp capture-win-qt.cpp capture-win-qt.h

Re: [PATCH 2/2] libv4lconvert: Support for RGB32 and BGR32 format

2013-08-02 Thread Gregor Jasny
Hello, On 8/1/13 3:04 PM, Ricardo Ribalda Delgado wrote: --- a/lib/libv4lconvert/libv4lconvert-priv.h +++ b/lib/libv4lconvert/libv4lconvert-priv.h @@ -108,7 +108,7 @@ unsigned char *v4lconvert_alloc_buffer(int needed, int v4lconvert_oom_error(struct v4lconvert_data *data); void v4lconvert_r

Re: Doing a v4l-utils-1.0.0 release

2013-08-01 Thread Gregor Jasny
Hello, On 6/14/13 9:15 AM, Hans de Goede wrote: IIRC the 0.9.x series were meant as development releases leading up to a new stable 1.0.0 release. Lately there have been no maintenance 0.8.x releases and a lot of interesting development going on in the 0.9.x, while at the same time there have be

[PATCH 2/4] libdvbv5: Fix reallocation in parse_lcn

2013-07-25 Thread Gregor Jasny
Detected by Coverity. Signed-off-by: Gregor Jasny CC: Mauro Carvalho Chehab --- lib/libdvbv5/descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libdvbv5/descriptors.c b/lib/libdvbv5/descriptors.c index 73338d8..99d8fa3 100644 --- a/lib/libdvbv5/descriptors.c

[PATCH 4/4] libdvbv5: Fix copy and paste error in parse_service()

2013-07-25 Thread Gregor Jasny
Detected by Coverity. Signed-off-by: Gregor Jasny CC: Mauro Carvalho Chehab CC: André Roth --- lib/libdvbv5/descriptors.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libdvbv5/descriptors.c b/lib/libdvbv5/descriptors.c index 99d8fa3..9b6b050 100644 --- a/lib

[PATCH 3/4] rds-ctl: Always terminate strings properly

2013-07-25 Thread Gregor Jasny
Detected by Coverity. Signed-off-by: Gregor Jasny CC: Hans Verkuil --- utils/rds-ctl/rds-ctl.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/utils/rds-ctl/rds-ctl.cpp b/utils/rds-ctl/rds-ctl.cpp index a9fe2a8..74972eb 100644 --- a/utils/rds-ctl/rds

[PATCH 0/4] v4l-utils: Some fixes for Coverity issues

2013-07-25 Thread Gregor Jasny
Hello, the following patches fix issues that the Coverity static analyzer found in v4l-utils. Please review. Thanks, Gregor Gregor Jasny (4): xc3082: Fix use after free in free_firmware() libdvbv5: Fix reallocation in parse_lcn rds-ctl: Always terminate strings properly libdvbv5: Fix

[PATCH 1/4] xc3082: Fix use after free in free_firmware()

2013-07-25 Thread Gregor Jasny
Detected by Coverity Scanner. CC: Mauro Carvalho Chehab Signed-off-by: Gregor Jasny --- utils/xc3028-firmware/firmware-tool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utils/xc3028-firmware/firmware-tool.c b/utils/xc3028-firmware/firmware-tool.c index b2e9de4

Re: Doing a v4l-utils-1.0.0 release

2013-07-25 Thread Gregor Jasny
Hello Guy, On 6/15/13 12:33 PM, Guy Martin wrote: Can we wait a little bit more like a week max ? I'd like to see the polarization stuff fixed because otherwise you can't use sat at all with libdvbv5. I'll work on the new patches this weekend. I'll hopefully have something today. I'll see what

[PATCH 2/2] keytable: Always check if strtok return value is null

2013-06-27 Thread Gregor Jasny
The Mayhem Team found a crash caused by a nullptr. Details are here: http://www.forallsecure.com/bug-reports/567323cd26f180910beb03ae26afb40c432a0c6a/ Signed-off-by: Gregor Jasny --- utils/keytable/keytable.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] v4l-utils: Fix crashes found by Mayhem

2013-06-27 Thread Gregor Jasny
The Mayhem Team ran their code checker over the Debian archive and also found two crashes in v4l-utils. See http://lists.debian.org/debian-devel/2013/06/msg00720.html Gregor Jasny (2): libv4lconvert: Prevent integer overflow by checking width and height keytable: Always check if strtok

[PATCH 1/2] libv4lconvert: Prevent integer overflow by checking width and height

2013-06-27 Thread Gregor Jasny
The Mayhem Team found a crash caused by an integer overflow. Details are here: http://www.forallsecure.com/bug-reports/8aae67d864bce76993f3f9812b4a2aeea0eb38da/ Signed-off-by: Gregor Jasny --- lib/libv4lconvert/ov511-decomp.c | 7 ++- lib/libv4lconvert/ov518-decomp.c | 7 ++- 2 files

Re: Doing a v4l-utils-1.0.0 release

2013-06-17 Thread Gregor Jasny
Hello, On 6/14/13 9:15 AM, Hans de Goede wrote: So how about taking current master and releasing that as a 1.0.0 release ? I'm fine with preparing a 1.0.0 release. But I'm under the impression that the libdvbv5 interface is not polished enough to build a shared library from it. So I'd like t

[gspca] Green/garbled/black webcam [0x0ac8 0xc002] output for Sony VGN-FE21M laptop

2013-04-20 Thread Gregor Jasny
Hello, I could need some help with this Ubuntu bug report: https://bugs.launchpad.net/ubuntu/+source/v4l-utils/+bug/1134565 Is there known error in the gspca driver that is causing this kernel log: [ 2830.890605] gspca_main: ISOC data error: [27] len=0, status=-71 v4l-info reports the following:

Re: [PATCH] v4l-utils: use openat when available

2013-02-02 Thread Gregor Jasny
Hello, On 1/22/13 5:37 PM, Riku Voipio wrote: > New architectures such as 64-Bit arm build kernels without legacy > system calls - Such as the the no-at system calls. Thus, use > SYS_openat whenever it is available. > +#ifdef SYS_openat > +#define SYS_OPEN(file, oflag, mode) \ > + syscall(SYS

Re: [segfault] running ir-keytable with v4l-utils 0.8.9

2012-11-04 Thread Gregor Jasny
Hello, On 10/27/12 1:26 PM, Gregor Jasny wrote: > I looked at the crash and it seems that the rc_dev structure is not > initialized when a device name is set on the command line. Could you > please take a look? I filed this as a Fedora bug report so that it does not get lo

Re: [segfault] running ir-keytable with v4l-utils 0.8.9

2012-10-27 Thread Gregor Jasny
Hello Mauro, On 10/14/12 9:54 PM, Wojciech Myrda wrote: > However I experienced a segfault trying to run this command: > ir-keytable --protocol=rc-6 --device /dev/input/by-id/usb-15c2_0038-event-if00 > Trace I got in gdb: > Program terminated with signal 11, Segmentation fault. > #0 0x7fd1c6

[PATCH] Add Fujitsu Siemens Amilo Pi 2530 to gspca upside down table

2012-10-18 Thread Gregor Jasny
e add the attached patch to the DVB kernel tree. Thanks, Gregor From 82b684714f9cee10c7b5c4c7873cd8e65a937aa3 Mon Sep 17 00:00:00 2001 From: Gregor Jasny Date: Thu, 18 Oct 2012 13:20:47 +0200 Subject: [PATCH] Add Fujitsu Siemens Amilo Pi 2530 to gspca upside down table. The DMI information for

Re: [segfault] running ir-keytable with v4l-utils 0.8.9

2012-10-16 Thread Gregor Jasny
Hello, On 10/14/12 9:54 PM, Wojciech Myrda wrote: On my system I have just installed using bumped Gentoo ebuilds v4l-utils package [ebuild R] media-libs/libv4l-0.8.9::bigvo 0 kB [ebuild R] media-tv/v4l-utils-0.8.9::bigvo USE="-qt4" 0 kB ebuilds used for bumbing to version 0.8.9:

Announcing v4l-utils development snapshot 0.9.1

2012-10-14 Thread Gregor Jasny
Hello, I'd like to announce the first development snapshot of the upcoming 0.10.x release. Compared to the latest stable version the biggest changes are the introduction of the libv4l plugin API, the new RDS library and utility and the DVBv5 library and tools. Additionally the build system has bee

Announcing v4l-utils-0.8.9

2012-10-14 Thread Gregor Jasny
Hi, I'm happy to announce the release of v4l-utils-0.8.9. It contains purely backports from the development branch. The most interesting additions are the improvements for the Pixart based webcams and the updated v4l2-compliance, v4l-ctl, and qv4l2 utilities. ChangeLog: * libv4l changes (0.9.x ba

Re: [v4l-utils] Use RCC variable to call rcc compiler

2012-10-07 Thread Gregor Jasny
Hello Khem, On 10/7/12 8:41 PM, Khem Raj wrote: > In cross compile environment rcc native version > may be staged in a different directory or even > called rcc4 or somesuch. Lets provide a facility > to specify it in environment I'll take care of this patch. > diff --git a/utils/qv4l2/Makefile.a

ir-keytable: Bug in gen_keytables.pl script

2012-10-07 Thread Gregor Jasny
Hello, I recently received this launchpad bug: https://bugs.launchpad.net/ubuntu/+source/v4l-utils/+bug/1054122 It seems that the mentioned key mappings are missing. If you check the generated mapping file http://git.linuxtv.org/v4l-utils.git/blob/HEAD:/utils/keytable/rc_keymaps/imon_pad and co

[PATCH] libdvbv5: Fix byte swapping for embedded toolchains

2012-08-21 Thread Gregor Jasny
Reported-by: "Lad, Prabhakar" Signed-off-by: Gregor Jasny --- lib/include/descriptors.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/include/descriptors.h b/lib/include/descriptors.h index 9039014..a64370c 100644 --- a/lib/include/descriptors.h

[PATCH] Fix libdvbv5 endianess function for embedded toolchains

2012-08-21 Thread Gregor Jasny
host architecture. Thanks, Gregor Gregor Jasny (1): libdvbv5: Fix byte swapping for embedded toolchains lib/include/descriptors.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" i

Re: [RFC PATCH 1/2] Add libv4l2rds library (with changes proposed in RFC)

2012-08-09 Thread Gregor Jasny
Hello Konke, On 8/7/12 5:11 PM, Konke Radlow wrote: diff --git a/configure.ac b/configure.ac index 8ddcc9d..1109c4d 100644 --- a/configure.ac +++ b/configure.ac @@ -146,9 +148,12 @@ AC_ARG_WITH(libv4l2subdir, AS_HELP_STRING(--with-libv4l2subdir=DIR,set libv4l2 l AC_ARG_WITH(libv4lconvertsubdi

Re: [RFC PATCH 0/2] Add support for RDS decoding

2012-07-29 Thread Gregor Jasny
Hello Konke, On 7/27/12 4:27 PM, Konke Radlow wrote: > changing the condition in the library header from >> #if __GNUC__ >= 4 >> #define LIBV4L_PUBLIC __attribute__ ((visibility("default"))) >> #else >> #define LIBV4L_PUBLIC >> #endif > > to >> #if HAVE_VISIBILITY >> #define LIBV4L_PUBLIC __att

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > +static void print_rds_af(struct v4l2_rds_af_set *af_set) > +{ > + int counter = 0; > + > + printf("\nAnnounced AFs: %u", af_set->announced_af); > + for (int i = 0; i < af_set->size && i < af_set->announced_af; i++, > counter++) { > +

Re: [RFC PATCH 2/2] Initial version of RDS Control utility Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > --- /dev/null > +++ b/utils/rds-ctl/rds-ctl.cpp > @@ -0,0 +1,978 @@ > +/* > + * rds-ctl.cpp is based on v4l2-ctl.cpp > + * > + * the following applies for all RDS related parts: > + * Copyright 2012 Cisco Systems, Inc. and/or its affiliates. All rights >

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > --- /dev/null > +++ b/lib/libv4l2rds/Makefile.am > @@ -0,0 +1,11 @@ > +if WITH_LIBV4L > +lib_LTLIBRARIES = libv4l2rds.la > +include_HEADERS = ../include/libv4l2rds.h > +pkgconfig_DATA = libv4l2rds.pc > +else > +noinst_LTLIBRARIES = libv4l2rds.la > +endif >

Re: [RFC PATCH 1/2] Initial version of the RDS-decoder library Signed-off-by: Konke Radlow

2012-07-26 Thread Gregor Jasny
On 7/25/12 7:44 PM, Konke Radlow wrote: > diff --git a/configure.ac b/configure.ac > index 8ddcc9d..1d7eb29 100644 > --- a/configure.ac > +++ b/configure.ac ... > @@ -146,13 +148,17 @@ AC_ARG_WITH(libv4l2subdir, > AS_HELP_STRING(--with-libv4l2subdir=DIR,set libv4l2 l > AC_ARG_WITH(libv4lconvertsu

  1   2   >