Em Mon, 9 Apr 2018 02:39:50 +0900
tsk...@gmail.com escreveu:
> From: Akihiro Tsukada
>
> The tuner is used in Earthsoft PT1/PT2 DVB boards,
> and the driver was extraced from (the former) va1j5jf8007s.c of PT1.
> it might contain PT1 specific configs.
>
> Signed-off-by: Akihiro Tsukada
Plea
Em Mon, 9 Apr 2018 02:21:38 +0900
tsk...@gmail.com escreveu:
> From: Akihiro Tsukada
>
> i2c message buf might be on stack.
That patch also applied without changes. So, just patch 3/5 was not applied.
>
> Signed-off-by: Akihiro Tsukada
> ---
> Changes since v4:
> - none
>
> drivers/media/
Em Mon, 9 Apr 2018 02:21:37 +0900
tsk...@gmail.com escreveu:
> From: Akihiro Tsukada
>
> As the kernel doc "timers-howto.txt" reads,
> short delay with msleep() can take much longer.
> In a case of raspbery-pi platform where CONFIG_HZ_100 was set,
> it actually affected the init of Friio device
Em Mon, 9 Apr 2018 02:21:36 +0900
tsk...@gmail.com escreveu:
> From: Akihiro Tsukada
>
> Friio device contains "gl861" bridge and "tc90522" demod,
> for which the separate drivers are already in the kernel.
> But friio driver was monolithic and did not use them,
> practically copying those feat
Em Wed, 25 Apr 2018 03:37:00 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> The following changes since commit 60cc43fc888428bb2f18f08997432d426a243338:
>
>
>
Hi Kieran,
Em Sat, 5 May 2018 08:46:50 +0100
Kieran Bingham escreveu:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA512
>
> Hello again,
>
> On 05/05/18 08:34, Kieran Bingham wrote:
> > Hi Sebastian,
> >
> > On 04/05/18 19:45, Sebastian Reichel wrote:
> >> Hi,
> >>
> >> I just got the fo
: Bartlomiej Zolnierkiewicz
Cc: Randy Dunlap
Cc: tomi.valkei...@ti.com
Cc: linux-o...@vger.kernel.org
Cc: linux-fb...@vger.kernel.org
Fixes: 771f7be87ff9 ("media: omapfb: omapfb_dss.h: add stubs to build with
COMPILE_TEST && DRM_OMAP")
Signed-off-by: Mauro Carvalho Chehab
Em Wed, 4 Apr 2018 16:02:10 +0300
Sakari Ailus escreveu:
> Add two macros that facilitate printing V4L fourcc values with printf
> family of functions. v4l2_fourcc_conv provides the printf conversion
> specifier for printing formats and v4l2_fourcc_to_conv provides the actual
> arguments for tha
#x27;m assuming that you'll be applying it together with other PXA patches.
So:
Acked-by: Mauro Carvalho Chehab
Regards,
Mauro
>
> Regards,
>
> Hans
>
> > ---
> > drivers/media/platform/pxa_camera.c | 22 +++---
> > 1 file changed,
n order to keep it together with the patches doing the removal of
the old API, it is probably better to apply this via ALSA tree:
Acked-by: Mauro Carvalho Chehab
>
> Regards,
>
> Tim
Thanks,
Mauro
Such check is already there at the routine. So, no need to
repeat it outside.
Cc: Akihiro Tsukada
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/pt3/pt3.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/pt3/pt3.c b/drivers/media/pci/pt3
Em Fri, 4 May 2018 18:08:59 +0200
SF Markus Elfring escreveu:
> > Adjust jump targets so that a bit of exception handling can be better
> > reused at the end of these functions.
>
> Why was this update suggestion rejected once more a moment ago?
>
> https://patchwork.linuxtv.org/patch/47827/
Em Tue, 13 Mar 2018 23:18:03 +0100
Daniel Scheller escreveu:
> From: Daniel Scheller
>
> Additional enums:
> * FEC ratios 1/4 and 1/3
> * 64/128/256-APSK modulations (DVB-S2X)
> * 15%, 10% and 5% rolloff factors (DVB-S2X)
> * 64K transmission mode (DVB-T2)
>
> Add these enums to the fronte
Em Fri, 4 May 2018 16:37:23 +0200
Geert Uytterhoeven escreveu:
> Hi Mauro,
>
> On Fri, May 4, 2018 at 2:13 PM, Mauro Carvalho Chehab
> wrote:
> > With the new vsp1 code changes introduced by changeset
> > f81f9adc4ee1 ("media: v4l: vsp1: Assign BRU and BRS
assumed 'state' could be null (see line 878)
drivers/media/dvb-frontends/lgdt330x.c:920 lgdt330x_probe() error:
dereferencing freed memory 'state'
Fixes: 23ba635d45f5 ("media: lgdt330x: convert it to the new I2C binding way")
Signed-off-by: Mauro Carv
Em Mon, 9 Apr 2018 18:47:48 +0200
Daniel Scheller escreveu:
> From: Daniel Scheller
>
> This adds initial support for the new MCI-based (micro-code interface)
> DD cards, with the first one being the MaxSX8 eight-tuner DVB-S/S2/S2X
> PCIe card. The MCI is basically a generalized interface impl
is not at beginning of
declaration [-Wold-style-declaration]
const static struct v4l2_frmsize_discrete amg88xx_size = {
^~~~~
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/i2c/video-i2c.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/video-i
Em Thu, 3 May 2018 11:30:50 +0300
Sakari Ailus escreveu:
> On Mon, Apr 30, 2018 at 12:41:00PM +0300, Sakari Ailus wrote:
> > Hi Alan,
> >
> > On Sun, Apr 29, 2018 at 01:18:37AM +0100, Alan Cox wrote:
> > >
> > > I think this is going to be the best option. When I started cleaning up
> > > the
From: Mauro Carvalho Chehab
This driver depends on sony-laptop driver, but this is available
only for x86. So, add a stub function, in order to allow building
it on non-x86 too.
Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/meye/Kconfig | 3
IDEO_VIA_CAMERA) depends on viafb
> it also needs a little fixup.
>
> Cc: Florian Tobias Schandinat
> Cc: Mauro Carvalho Chehab
> Signed-off-by: Bartlomiej Zolnierkiewicz
> ---
> drivers/media/platform/via-camera.c |5 +
> drivers/video/fbdev/Kconfig
Em Wed, 25 Apr 2018 12:47:34 +0200
Bartlomiej Zolnierkiewicz escreveu:
> On Monday, April 23, 2018 10:55:57 AM Mauro Carvalho Chehab wrote:
> > Em Mon, 23 Apr 2018 14:47:28 +0200
> > Bartlomiej Zolnierkiewicz escreveu:
> >
> > > On Friday, April 20, 2018 01:
Em Mon, 23 Apr 2018 14:19:31 +0200
Bartlomiej Zolnierkiewicz escreveu:
> Hi Mauro,
>
> On Friday, April 20, 2018 04:03:21 PM Mauro Carvalho Chehab wrote:
> > This driver depends on FB_VIA for lots of things. Provide stubs
> > for the functions it needs, in order to a
x27; could be null (see line 180)
This is a false positive, as, if pipe->bru is NULL, the brx
var will be different, with ends by calling a code that will
set pipe->bru to another value.
Yet, cleaning this false positive is as easy as adding an explicit
check if pipe->bru is NULL.
Sign
Em Fri, 04 May 2018 13:58:39 +0300
Jani Nikula escreveu:
> On Fri, 04 May 2018, Mauro Carvalho Chehab wrote:
> > From now on, I'll start using my @kernel.org as my development e-mail.
> >
> > As such, let's remove the entries that point to the old
> > mc
-rc4
From: Gustavo A. R. Silva (1):
media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR
Mauro Carvalho Chehab (1):
MAINTAINERS & files: Canonize the e-mails I use at files
Documentation/doc-guide/parse-headers.rst | 4 ++--
Documentation/media
box anyway.
Signed-off-by: Mauro Carvalho Chehab
Signed-off-by: Brian Warner
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/doc-guide/parse-headers.rst | 4 ++--
Documentation/media/uapi/rc/keytable.c.rst | 2 +-
Documentation/media/uapi/v4l/v4l2grab.c.rst | 2 +-
Doc
Em Fri, 27 Apr 2018 20:15:00 +0200
"Jasmin J." escreveu:
> Hello Mauro!
>
> > This patch looks fine, but not for the above-mentioned.
> So I shall reword the commit message?
Yes.
>
> > The thing is that it is not consistent to have some places with
> > things like:
> > timeout = ktime_se
e the
patch below (untested).
Regards,
Mauro
media: dvbsky: use just one mutex for serializing device R/W ops
Right now, there are two mutexes serializing r/w ops: one "generic"
and another one specifically for stream on/off.
Clean it a little bit, getting rid of one of the mutexes.
S
Em Thu, 26 Apr 2018 16:41:56 -0500
"Gustavo A. R. Silva" escreveu:
> Hi Mauro,
>
> On 04/23/2018 02:17 PM, Mauro Carvalho Chehab wrote:
> > Em Mon, 23 Apr 2018 14:11:02 -0500
> >
> > Thanks, I 'll mark this series as rejected at patchwork.linuxtv.org.
Em Wed, 25 Apr 2018 17:58:25 +0200
Arnd Bergmann escreveu:
> On Wed, Apr 25, 2018 at 5:26 PM, Christoph Hellwig wrote:
> > On Wed, Apr 25, 2018 at 01:15:18PM +0200, Arnd Bergmann wrote:
> >> That thought had occurred to me as well. I removed the oldest ISDN
> >> drivers already some years ago,
Em Wed, 25 Apr 2018 14:24:09 +0200
mjs escreveu:
> Op Wed, 25 Apr 2018 08:18:55 -0300
> Mauro Carvalho Chehab schreef:
>
> > Em Wed, 25 Apr 2018 12:11:10 +0200
> > mjs escreveu:
> >
> > > Op Wed, 25 Apr 2018 06:16:20 -0300
> > > Mauro Carvalho C
Em Wed, 25 Apr 2018 12:11:10 +0200
mjs escreveu:
> Op Wed, 25 Apr 2018 06:16:20 -0300
> Mauro Carvalho Chehab schreef:
>
> > Em Wed, 25 Apr 2018 11:09:50 +0200
> > mjs escreveu:
> >
> > > From 0a3355b47dc465c6372d30fa4a36d1c5db6c0fe2 Mon Sep 17 00
Em Wed, 25 Apr 2018 11:09:50 +0200
mjs escreveu:
> From 0a3355b47dc465c6372d30fa4a36d1c5db6c0fe2 Mon Sep 17 00:00:00 2001
> From: Marcel Stork
> Date: Wed, 25 Apr 2018 10:53:34 +0200
> Subject: [PATCH] Add new dvb-t board ":Zolid Hybrid Tv Stick".
>
> Extra code to be able to use this stick, on
Em Tue, 24 Apr 2018 12:36:09 +0200
Peter Zijlstra escreveu:
> On Tue, Apr 24, 2018 at 12:35:00PM +0300, Dan Carpenter wrote:
> > On Mon, Apr 23, 2018 at 03:24:55PM -0300, Mauro Carvalho Chehab wrote:
> > > Em Mon, 23 Apr 2018 12:38:03 -0500
> > > &quo
Em Tue, 24 Apr 2018 09:55:55 +0200
Arnd Bergmann escreveu:
> On Fri, Apr 20, 2018 at 7:42 PM, Mauro Carvalho Chehab
> wrote:
> > The virt_to_bus/bus_to_virt macros are arch-specific. Some
> > archs don't support it. Yet, as it is interesting to allow
> > doing compi
o static arrays. Peter do you know the answer here?
>
> regards,
> dan carpenter
>
> On Mon, Apr 23, 2018 at 03:24:55PM -0300, Mauro Carvalho Chehab wrote:
> > Em Mon, 23 Apr 2018 12:38:03 -0500
> > "Gustavo A. R. Silva" escreveu:
> >
> > > f->index
Em Mon, 23 Apr 2018 22:21:29 +0200
mjs escreveu:
> Op Mon, 23 Apr 2018 14:15:59 -0300
> Mauro Carvalho Chehab schreef:
>
> > Em Mon, 23 Apr 2018 12:35:06 -0400
> > Alexandre-Xavier Labonté-Lamoureux escreveu:
> >
> > > This should giv
Em Mon, 23 Apr 2018 22:48:06 +0300
Laurent Pinchart escreveu:
> Hi Mauro,
>
> On Monday, 23 April 2018 17:22:27 EEST Mauro Carvalho Chehab wrote:
> > Em Mon, 23 Apr 2018 15:56:53 +0200 Bartlomiej Zolnierkiewicz escreveu:
> > > On Monday, April 23, 2018 02:47:28 PM B
Em Mon, 23 Apr 2018 14:11:02 -0500
"Gustavo A. R. Silva" escreveu:
> On 04/23/2018 01:24 PM, Mauro Carvalho Chehab wrote:
> > Em Mon, 23 Apr 2018 12:38:03 -0500
> > "Gustavo A. R. Silva" escreveu:
> >
> >> f->index can be contro
Em Mon, 23 Apr 2018 12:38:03 -0500
"Gustavo A. R. Silva" escreveu:
> f->index can be controlled by user-space, hence leading to a
> potential exploitation of the Spectre variant 1 vulnerability.
>
> Smatch warning:
> drivers/media/usb/tm6000/tm6000-video.c:879 vidioc_enum_fmt_vid_cap() warn:
>
Em Mon, 23 Apr 2018 12:35:06 -0400
Alexandre-Xavier Labonté-Lamoureux escreveu:
> This should give you an idea of what you need to do:
> https://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches
Yes.
In particular, you should send it against the upstream development Kernel,
Em Mon, 23 Apr 2018 17:09:19 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Thu, Apr 19, 2018 at 07:42:28AM -0300, Mauro Carvalho Chehab wrote:
> > Em Wed, 18 Apr 2018 12:04:14 +0300
> > Sakari Ailus escreveu:
> >
> > > On Tue, Apr 17, 2018 at 06:20:10A
Em Mon, 23 Apr 2018 17:11:14 +0300
Tomi Valkeinen escreveu:
> On 23/04/18 16:56, Bartlomiej Zolnierkiewicz wrote:
>
> > Ideally we should be able to build both drivers in the same kernel
> > (especially as modules).
> >
> > I was hoping that it could be fixed easily but then I discovered
> > th
Em Mon, 23 Apr 2018 15:56:53 +0200
Bartlomiej Zolnierkiewicz escreveu:
> On Monday, April 23, 2018 02:47:28 PM Bartlomiej Zolnierkiewicz wrote:
> > On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote:
> > > Add stubs for omapfb_dss.h, in the case it is incl
Em Mon, 23 Apr 2018 14:23:28 +0200
Hans Verkuil escreveu:
> >> + spin_lock_irqsave(&req->lock, flags);
> >> + state = req->state;
> >> + spin_unlock_irqrestore(&req->lock, flags);
> >
> > IMO, it would be better to use an atomic var for state, having a
> > lockless access to it.
>
> In m
Em Mon, 23 Apr 2018 14:47:28 +0200
Bartlomiej Zolnierkiewicz escreveu:
> On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote:
> > Add stubs for omapfb_dss.h, in the case it is included by
> > some driver when CONFIG_FB_OMAP2 is not defined, with can
> > happen
Em Mon, 23 Apr 2018 13:49:11 +0200
Hans Verkuil escreveu:
> On 04/10/2018 11:52 AM, Mauro Carvalho Chehab wrote:
> > Em Mon, 9 Apr 2018 16:20:00 +0200
> > Hans Verkuil escreveu:
> >
> >> From: Hans Verkuil
> >>
> >> Add support for allocati
Em Mon, 23 Apr 2018 13:41:31 +0200
Hans Verkuil escreveu:
> On 04/10/2018 01:00 PM, Sakari Ailus wrote:
> > On Tue, Apr 10, 2018 at 06:38:56AM -0300, Mauro Carvalho Chehab wrote:
> >> Em Mon, 9 Apr 2018 16:19:59 +0200
> >> Hans Verkuil escreveu:
>
is a parameter of the current function.
So, explicitly limit strcmp() and strcpy() to ensure that the
devpath size (32) will be respected.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/common/siano/smscoreapi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff
messages per call with different data,
with sounds messy.
Simplify it by getting rid of DUMP_I2C_MESSAGES and adding a new
flag to debug (0x40), and making the debug logic there more
consistent.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/common/
ret was filled with a non-sero value. It toesn't make sense to override
such error code with a videobuf_streamoff() error.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/davinci/vpfe_capture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
ixes: be7fd3c3a8c5 ("media: em28xx: Hauppauge DualHD second tuner
functionality")
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/usb/em28xx/em28xx-core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-core.c
b/drivers/media
Em Mon, 23 Apr 2018 10:04:20 +0100
Sean Young escreveu:
> On Sun, Apr 22, 2018 at 11:47:51AM +0200, Greg KH wrote:
> > On Mon, Apr 16, 2018 at 10:15:28AM +0100, Sean Young wrote:
> > > On Mon, Apr 16, 2018 at 10:50:15AM +0200, Greg KH wrote:
> > > > On Mon, Apr 16, 2018 at 09:43:45AM +0100, S
This driver depends on FB_VIA for lots of things. Provide stubs
for the functions it needs, in order to allow building it with
COMPILE_TEST outside x86 architecture.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index
Building this driver on arm64 gives this warning:
drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c:430:16: error:
return expression in void function
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/s5p-jpeg/jpeg-hw-exynos3250.c | 4 ++--
1 file changed, 2 insertions
Despite depending on ACPI, this driver builds fine on non-x86
archtecture with COMPILE_TEST, as it doesn't depend on
ACPI-specific functions/structs.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/intel/ipu3/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
Add stubs for omapfb_dss.h, in the case it is included by
some driver when CONFIG_FB_OMAP2 is not defined, with can
happen on ARM when DRM_OMAP is not 'n'.
That allows building such driver(s) with COMPILE_TEST.
Signed-off-by: Mauro Carvalho Chehab
---
include/video/omapfb_
e at:
https://git.linuxtv.org/mchehab/experimental.git/log/?h=compile_test_v7
Mauro Carvalho Chehab (7):
asm-generic, media: allow COMPILE_TEST with virt_to_bus
media: meye: allow building it with COMPILE_TEST on non-x86
media: rc: allow build pnp-dependent drivers with COMPILE_TEST
media: ipu
This driver depends on FB_VIA for lots of things. Provide stubs
for the functions it needs, in order to allow building it with
COMPILE_TEST outside x86 architecture.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/Kconfig | 2 +-
drivers/media/platform/via-camera.c | 10
Mauro Carvalho Chehab
---
drivers/media/pci/sta2x11/Kconfig | 4 ++--
drivers/media/pci/zoran/Kconfig | 3 ++-
include/asm-generic/io.h | 2 +-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/sta2x11/Kconfig
b/drivers/media/pci/sta2x11/Kconfig
The pnp header already provide enough stub to build those
drivers with COMPILE_TEST on non-x86 archs.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/rc/Kconfig | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc
Now that FB_OMAP has stubs, the omap2 media drivers can be
built on ARM with COMPILE_TEST && DRM_OMAP.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/omap/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/omap/Kc
This driver depends on sony-laptop driver, but this is available
only for x86. So, add a stub function, in order to allow building
it on non-x86 too.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/meye/Kconfig | 3 ++-
include/linux/sony-laptop.h| 4
2 files changed, 6
Em Fri, 20 Apr 2018 14:58:15 +0200
Takashi Iwai escreveu:
> On Fri, 20 Apr 2018 14:51:29 +0200,
> Mauro Carvalho Chehab wrote:
> >
> > Em Fri, 20 Apr 2018 14:37:46 +0200
> > Takashi Iwai escreveu:
> >
> > > On Fri, 20 Apr 2018 14:32:15 +
Em Fri, 20 Apr 2018 09:51:29 -0300
Mauro Carvalho Chehab escreveu:
> Em Fri, 20 Apr 2018 14:37:46 +0200
> Takashi Iwai escreveu:
>
> > On Fri, 20 Apr 2018 14:32:15 +0200,
> > Mauro Carvalho Chehab wrote:
> > >
> > > All sound drivers that don't d
Drivers that depend on ISAPNP currently can't be built with
COMPILE_TEST. However, looking at isapnp.h, there are already
stubs there to allow drivers to include it even when isa
PNP is not supported.
So, remove such dependencies when COMPILE_TEST.
Signed-off-by: Mauro Carvalho C
Em Fri, 20 Apr 2018 14:37:46 +0200
Takashi Iwai escreveu:
> On Fri, 20 Apr 2018 14:32:15 +0200,
> Mauro Carvalho Chehab wrote:
> >
> > All sound drivers that don't depend on PNP can be safelly
> > build with COMPILE_TEST, as ISA provides function stubs to
All sound drivers that don't depend on PNP can be safelly
build with COMPILE_TEST, as ISA provides function stubs to
be used for such purposes.
As a side effect, with this change, the radio-miropcm20
can now be built outside i386 with COMPILE_TEST.
Signed-off-by: Mauro Carvalho C
Mauro Carvalho Chehab (4):
media: radio: allow building ISA drivers with COMPILE_TEST
media: sta2x11_vip: allow build with COMPILE_TEST
sound, media: allow building ISA drivers it with COMPILE_TEST
media: siano: get rid of __le32/__le16 cast warnings
drivers/media/common/siano/smsendian.c
This driver doesn't use any weird API. So, allow building it
with COMPILE_TEST.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/pci/sta2x11/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/sta2x11/Kconfig
b/drivers/media/pci/sta2x11/Kc
Several radio devices only build on i386, because they depend
on ISA. Allow them to build on other archs by adding a
COMPILE_TEST check.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/radio/Kconfig | 38 --
1 file changed, 24 insertions(+), 14
-off-by: Mauro Carvalho Chehab
---
drivers/media/common/siano/smsendian.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/media/common/siano/smsendian.c
b/drivers/media/common/siano/smsendian.c
index bfe831c10b1c..b95a631f23f9 100644
--- a/drivers/media
This file does a lot of non-trivial struff. Document it using
kernel-doc markups where needed and improve the comments inside
do_video_ioctl().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 165 +-
1 file changed, 159 insertions
Em Fri, 20 Apr 2018 13:16:00 +0200
Hans Verkuil escreveu:
Thanks for the review!
> > +/**
> > + * do_video_ioctl() - Ancillary function with handles a compat32 ioctl call
> > + *
> > + * @file: pointer to &struct file with the file handler
> > + * @cmd: ioctl to be called
> > + * @arg: arguments
Em Thu, 19 Apr 2018 12:33:32 -0400
Mauro Carvalho Chehab escreveu:
> This file does a lot of non-trivial struff. Document it using
> kernel-doc markups where needed and improve the comments inside
> do_video_ioctl().
Sent it too fast. It should be merged with this diff:
diff --git
ng more about that,
it sounded better to call it as "new_p64", as this makes clearer
that this is the data structure that was allocated inside this
file in order to be used to pass/retrieve data when calling the
64-bit ready file->f_op->unlocked_ioctl() function.
Suggested-by: Sa
This file does a lot of non-trivial struff. Document it using
kernel-doc markups where needed and improve the comments inside
do_video_ioctl().
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 166 +-
1 file changed, 160 insertions
+v4l2-compliance SHA : bc71e4a67c6fbc5940062843bc41e7c8679634ce, 64
bits
Using the latest version of v4l-utils with this patch applied:
https://patchwork.linuxtv.org/patch/48746/
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 36 +++--
] *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13:got void *[assigned]
edid
Fix them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 51 ++-
1 file changed, 35 insertions(+), 16 deletions(-)
diff --git a/drivers
This series correspond to the last 3 patches of my previous patch series:
https://www.spinics.net/lists/linux-media/msg132453.html
It contains the compat32 related bits.
Version 2 addresses some comments from Hans.
It adds a new patch better documenting it.
Mauro Carvalho Chehab (4
Em Thu, 19 Apr 2018 13:37:52 +0200
Hans Verkuil escreveu:
> On 04/19/18 13:15, Mauro Carvalho Chehab wrote:
> > Making the cast right for get_user/put_user is not trivial, as
> > it needs to ensure that the types are the correct ones.
> >
> > Improve it by using m
Em Tue, 3 Apr 2018 19:52:25 -0500
Yong Zhi escreveu:
> This is a preliminary effort to add documentation for the
> following BNR(bayer noise reduction) structs:
>
> ipu3_uapi_bnr_static_config_wb_gains_config
> ipu3_uapi_bnr_static_config_wb_gains_thr_config
> ipu3_uapi_bnr_static_config_thr_co
] *uptr
drivers/media/v4l2-core/v4l2-compat-ioctl32.c:973:13:got void *[assigned]
edid
Fix them.
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 51 ++-
1 file changed, 35 insertions(+), 16 deletions(-)
diff --git a/drivers
ng more about that,
it sounded better to call it as "new_p64", as this makes clearer
that this is the data structure that was allocated inside this
file in order to be used to pass/retrieve data when calling the
64-bit ready file->f_op->unlocked_ioctl() function.
Suggested-by: Sa
dd ARM and
COMMON_CLK dependencies.
Signed-off-by: Laurent Pinchart
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/platform/Kconfig | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kco
Drivers that depend on omap-iommu.h (currently, just omap3isp)
need a stub implementation in order to be built with COMPILE_TEST.
Cc: Tony Lindgren
Cc: Arnd Bergmann
Acked-by: Sakari Ailus
Signed-off-by: Mauro Carvalho Chehab
---
include/linux/omap-iommu.h | 5 +
1 file changed, 5
From: Arnd Bergmann
There aren't much things required for it to build with COMPILE_TEST.
It just needs to not compile the code that depends on arm-specific
iommu implementation.
Signed-off-by: Arnd Bergmann
Co-developed-by: Mauro Carvalho Chehab
Acked-by: Sakari Ailus
Signed-off-by:
+v4l2-compliance SHA : bc71e4a67c6fbc5940062843bc41e7c8679634ce, 64
bits
Using the latest version of v4l-utils with this patch applied:
https://patchwork.linuxtv.org/patch/48746/
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 40 ++---
nn (1):
media: omap3isp: Allow it to build with COMPILE_TEST
Laurent Pinchart (1):
media: omap3isp: Enable driver compilation on ARM with COMPILE_TEST
Mauro Carvalho Chehab (4):
omap: omap-iommu.h: allow building drivers with COMPILE_TEST
media: v4l2-compat-ioctl32: fix several __user annotation
Em Wed, 18 Apr 2018 12:04:14 +0300
Sakari Ailus escreveu:
> On Tue, Apr 17, 2018 at 06:20:10AM -0400, Mauro Carvalho Chehab wrote:
> > There were several interactions at the COMPILE_TEST and smatch
> > patch series. While I applied most of them, there are 5 patches that
> >
Instead of +=, the rule had :=, with actually disables build
of everything else.
Fixes: 58757984ca3c ("media: si470x: allow build both USB and I2C at the same
time")
Reported-by: Daniel Scheller
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/radio/si470x/Makefile | 2
Em Wed, 18 Apr 2018 21:06:12 +0200
Daniel Scheller escreveu:
> Am Wed, 18 Apr 2018 15:53:09 -0300
> schrieb Mauro Carvalho Chehab :
>
> > Em Wed, 18 Apr 2018 19:07:40 +0200
> > Daniel Scheller escreveu:
> >
> > > Am Fri, 6 Apr 2018 13:46:03 -0300
Em Wed, 18 Apr 2018 19:07:40 +0200
Daniel Scheller escreveu:
> Am Fri, 6 Apr 2018 13:46:03 -0300
> schrieb Mauro Carvalho Chehab :
>
> > Em Sat, 7 Apr 2018 00:21:07 +0800
> > kbuild test robot escreveu:
> >
> > > Hi Mauro,
> > >
>
Em Wed, 18 Apr 2018 11:57:13 +0300
Sakari Ailus escreveu:
> Hi Mauro,
>
> On Tue, Apr 17, 2018 at 10:25:37AM -0400, Mauro Carvalho Chehab wrote:
> > Making the cast right for get_user/put_user is not trivial, as
> > it needs to ensure that the types are the correct ones.
&
+v4l2-compliance SHA : bc71e4a67c6fbc5940062843bc41e7c8679634ce, 64
bits
Using the latest version of v4l-utils with this patch applied:
https://patchwork.linuxtv.org/patch/48746/
Signed-off-by: Mauro Carvalho Chehab
---
drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 40 ++---
Em Tue, 17 Apr 2018 10:58:24 -0300
Mauro Carvalho Chehab escreveu:
> Em Tue, 17 Apr 2018 10:10:09 -0300
> Mauro Carvalho Chehab escreveu:
>
> > Em Tue, 17 Apr 2018 10:01:31 -0300
> > Mauro Carvalho Chehab escreveu:
> >
> > > > >> ->block
As we need to have a 32 bits version in order to check for
compat32 issues, let's print if v4l2-compliance was built
with 32 or 64 bits.
Signed-off-by: Mauro Carvalho Chehab
diff --git a/utils/v4l2-compliance/v4l2-compliance.cpp
b/utils/v4l2-compliance/v4l2-compliance.cpp
index eb1f90f
Em Tue, 17 Apr 2018 10:10:09 -0300
Mauro Carvalho Chehab escreveu:
> Em Tue, 17 Apr 2018 10:01:31 -0300
> Mauro Carvalho Chehab escreveu:
>
> > > >> ->blocks is a u32, so this should be a u32 cast as well.
> > >
> > > Be aware that the un
Em Tue, 17 Apr 2018 15:11:10 +0200
Hans Verkuil escreveu:
> >> Be aware that the unsigned char * cast is actually a bug: it will clamp the
> >> u32 'blocks' value to a u8.
> >>
> >> Regards,
> >>
> >>Hans
> >
> > What about this approach (code untested)?
>
> I prefer the explicit casts.
Em Tue, 17 Apr 2018 10:01:31 -0300
Mauro Carvalho Chehab escreveu:
> > >> ->blocks is a u32, so this should be a u32 cast as well.
> >
> > Be aware that the unsigned char * cast is actually a bug: it will clamp the
> > u32 'blocks' value t
801 - 900 of 12856 matches
Mail list logo
