Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Em 26-06-2012 13:40, Ezequiel Garcia escreveu: > Mauro, > > On Mon, Jun 25, 2012 at 5:53 PM, Mauro Carvalho Chehab > wrote: >> >> Yeah, research is needed ;) As "bttv" is the mother of the I2C code found at >> other PCI drivers, as it is one of the oldest implementations, I bet you'll >> find thi

Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Mauro, On Mon, Jun 25, 2012 at 5:53 PM, Mauro Carvalho Chehab wrote: > > Yeah, research is needed ;) As "bttv" is the mother of the I2C code found at > other PCI drivers, as it is one of the oldest implementations, I bet you'll > find this field propagated without usage on some drivers (and proba

Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Em 25-06-2012 17:06, Ezequiel Garcia escreveu: > On Mon, Jun 25, 2012 at 4:49 PM, Mauro Carvalho Chehab > wrote: >> >> If i2c_rc was never initialized, then just remove it. If it is required, >> then there's a bug somewhere out there on those drivers. >> >> IMHO, if the I2C bus doesn't register, a

Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

On Mon, Jun 25, 2012 at 4:49 PM, Mauro Carvalho Chehab wrote: > > If i2c_rc was never initialized, then just remove it. If it is required, > then there's a bug somewhere out there on those drivers. > > IMHO, if the I2C bus doesn't register, any driver that requires I2C bus > should return -ENODEV.

Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Em 25-06-2012 16:42, Ezequiel Garcia escreveu: > Hi Mauro, > > On Mon, Jun 25, 2012 at 4:29 PM, Mauro Carvalho Chehab > wrote: >>> diff --git a/drivers/media/video/saa7164/saa7164-i2c.c >>> b/drivers/media/video/saa7164/saa7164-i2c.c >>> index 26148f7..536f7dc 100644 >>> --- a/drivers/media/vide

Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Hi Mauro, On Mon, Jun 25, 2012 at 4:29 PM, Mauro Carvalho Chehab wrote: >> diff --git a/drivers/media/video/saa7164/saa7164-i2c.c >> b/drivers/media/video/saa7164/saa7164-i2c.c >> index 26148f7..536f7dc 100644 >> --- a/drivers/media/video/saa7164/saa7164-i2c.c >> +++ b/drivers/media/video/saa716

Re: [PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Em 18-06-2012 16:23, Ezequiel Garcia escreveu: > Signed-off-by: Ezequiel Garcia > --- > drivers/media/video/saa7164/saa7164-i2c.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/saa7164/saa7164-i2c.c > b/drivers/media/video/saa7164/saa7164-i2

[PATCH 01/12] saa7164: Use i2c_rc properly to store i2c register status

Signed-off-by: Ezequiel Garcia --- drivers/media/video/saa7164/saa7164-i2c.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/saa7164/saa7164-i2c.c b/drivers/media/video/saa7164/saa7164-i2c.c index 26148f7..536f7dc 100644 --- a/drivers/media/video/saa