Re: [PATCH v2 19/26] media: ov9650: fix bogus warnings

2017-11-02 Thread Nicholas Mc Guire
On Thu, Nov 02, 2017 at 10:06:06AM +, Nicholas Mc Guire wrote: > On Wed, Nov 01, 2017 at 05:05:56PM -0400, Mauro Carvalho Chehab wrote: > > The smatch logic gets confused with the syntax used to check if the > > ov9650x_read() reads succedded: > > drivers/media/i2c/ov9650.c:895 __g_volatile

Re: [PATCH v2 19/26] media: ov9650: fix bogus warnings

2017-11-02 Thread Nicholas Mc Guire
On Wed, Nov 01, 2017 at 05:05:56PM -0400, Mauro Carvalho Chehab wrote: > The smatch logic gets confused with the syntax used to check if the > ov9650x_read() reads succedded: > drivers/media/i2c/ov9650.c:895 __g_volatile_ctrl() error: uninitialized > symbol 'reg2'. > drivers/media/i2c/

[PATCH v2 19/26] media: ov9650: fix bogus warnings

2017-11-01 Thread Mauro Carvalho Chehab
The smatch logic gets confused with the syntax used to check if the ov9650x_read() reads succedded: drivers/media/i2c/ov9650.c:895 __g_volatile_ctrl() error: uninitialized symbol 'reg2'. drivers/media/i2c/ov9650.c:895 __g_volatile_ctrl() error: uninitialized symbol 'reg1'. There'