Re: [REVIEW PATCH 5/5] v4l2-ioctl: simplify debug code.

2013-03-18 Thread Hans Verkuil
On Fri March 15 2013 13:25:21 Laurent Pinchart wrote: > Hi Hans, > > Thanks for the patch. > > On Friday 15 March 2013 11:27:25 Hans Verkuil wrote: > > From: Hans Verkuil > > > > The core debug code can now be simplified since all the write-only ioctls > > are now const and will not modify the

Re: [REVIEW PATCH 5/5] v4l2-ioctl: simplify debug code.

2013-03-15 Thread Laurent Pinchart
Hi Hans, Thanks for the patch. On Friday 15 March 2013 11:27:25 Hans Verkuil wrote: > From: Hans Verkuil > > The core debug code can now be simplified since all the write-only ioctls > are now const and will not modify the data they pass to the drivers. > > So instead of logging write-only ioc

[REVIEW PATCH 5/5] v4l2-ioctl: simplify debug code.

2013-03-15 Thread Hans Verkuil
From: Hans Verkuil The core debug code can now be simplified since all the write-only ioctls are now const and will not modify the data they pass to the drivers. So instead of logging write-only ioctls before the driver is called this can now be done afterwards, which is cleaner when it comes to