[RFCv2 PATCH 06/10] radio_ms800: use video_drvdata instead of filp-private_data

2011-01-03 Thread Hans Verkuil
filp-private_data will be used to store v4l2_fh instead. Signed-off-by: Hans Verkuil hverk...@xs4all.nl --- drivers/media/radio/radio-mr800.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/media/radio/radio-mr800.c

Re: [RFCv2 PATCH 06/10] radio_ms800: use video_drvdata instead of filp-private_data

2011-01-03 Thread David Ellingsworth
Why does this matter? From my understanding, v4l2_fh is meant to be embed it in a device specific structure. If it is the first member in the device specific structure, then the pointer to v4l2_fh is the same as the one to the device specific structure. Otherwise, a simple container_of can be used

Re: [RFCv2 PATCH 06/10] radio_ms800: use video_drvdata instead of filp-private_data

2011-01-03 Thread Hans Verkuil
On Monday, January 03, 2011 20:35:41 David Ellingsworth wrote: Why does this matter? From my understanding, v4l2_fh is meant to be embed it in a device specific structure. No, v4l2_fh is a per-filehandle structure, not a per-device node structure. filp-private_data is meant to store