[PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-22 Thread Simon Farnsworth
The SAA7134 appears to have trouble buffering more than one line of video when doing DMA. Rather than try to fix the driver to cope (as has been done by Andy Walls for the cx18 driver), put in a pm_qos_request to limit deep sleep exit latencies. The visible effect of not having this is that seemin

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Simon Farnsworth
On Monday 22 October 2012 12:50:11 Simon Farnsworth wrote: > The SAA7134 appears to have trouble buffering more than one line of video > when doing DMA. Rather than try to fix the driver to cope (as has been done > by Andy Walls for the cx18 driver), put in a pm_qos_request to limit deep > sleep ex

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2012 11:25:38 + Simon Farnsworth escreveu: > On Monday 22 October 2012 12:50:11 Simon Farnsworth wrote: > > The SAA7134 appears to have trouble buffering more than one line of video > > when doing DMA. Rather than try to fix the driver to cope (as has been done > > by Andy Wall

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Simon Farnsworth
On Monday 29 October 2012 09:58:17 Mauro Carvalho Chehab wrote: > I prefer if you don't c/c me on that ;) Patchwork is the main source that I > use > on my patch reviews. > Noted. > Btw, I saw your patch yesterday (and skipped it, for now), as I never played > with those pm QoS stuff before, nor

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Andy Walls
On Mon, 2012-10-29 at 13:02 +, Simon Farnsworth wrote: > On Monday 29 October 2012 09:58:17 Mauro Carvalho Chehab wrote: > > I prefer if you don't c/c me on that ;) Patchwork is the main source that I > > use > > on my patch reviews. > > > Noted. > > > Btw, I saw your patch yesterday (and sk

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Simon Farnsworth
On Monday 29 October 2012 09:32:27 Andy Walls wrote: > On Mon, 2012-10-29 at 13:02 +, Simon Farnsworth wrote: > > It will affect other drivers as well; the basic cause is that modern chips > > can enter a package deep sleep state that affects both CPU speed and latency > > to start of DMA. On o

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Andy Walls
On Mon, 2012-10-29 at 13:02 +, Simon Farnsworth wrote: > On Monday 29 October 2012 09:58:17 Mauro Carvalho Chehab wrote: > > I prefer if you don't c/c me on that ;) Patchwork is the main source that I > > use > > on my patch reviews. > > > Noted. > > > Btw, I saw your patch yesterday (and sk

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2012 14:11 + Simon Farnsworth escreveu: > On Monday 29 October 2012 09:32:27 Andy Walls wrote: > > On Mon, 2012-10-29 at 13:02 +, Simon Farnsworth wrote: > > > It will affect other drivers as well; the basic cause is that modern chips > > > can enter a package deep sleep st

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-29 Thread Simon Farnsworth
On Monday 29 October 2012 13:44:45 Mauro Carvalho Chehab wrote: > Thanks for digging into it and getting more data. Do you know if this change > it also needed with USB devices that do DMA (isoc and/or bulk)? Or the USB > core already handles that? > I'm not a huge expert - the linux-pm list (cc'd

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-10-30 Thread Alan Stern
On Mon, 29 Oct 2012, Simon Farnsworth wrote: > On Monday 29 October 2012 13:44:45 Mauro Carvalho Chehab wrote: > > Thanks for digging into it and getting more data. Do you know if this change > > it also needed with USB devices that do DMA (isoc and/or bulk)? Or the USB > > core already handles th

Re: [PATCH] saa7134: Add pm_qos_request to fix video corruption

2012-12-04 Thread Mauro Carvalho Chehab
Em Mon, 29 Oct 2012 14:11 + Simon Farnsworth escreveu: > On Monday 29 October 2012 09:32:27 Andy Walls wrote: > > On Mon, 2012-10-29 at 13:02 +, Simon Farnsworth wrote: > > > It will affect other drivers as well; the basic cause is that modern chips > > > can enter a package deep sleep st