Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Dan Carpenter
On Mon, Jun 18, 2012 at 06:00:52PM -0300, Ezequiel Garcia wrote: > On Mon, Jun 18, 2012 at 5:56 PM, Dan Carpenter > wrote: > > On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote: > >> Hi Mauro, > >> > >> This patchset cleans the i2c part of some drivers. > >> This issue was recently

Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Ezequiel Garcia
On Mon, Jun 18, 2012 at 5:56 PM, Dan Carpenter wrote: > On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote: >> Hi Mauro, >> >> This patchset cleans the i2c part of some drivers. >> This issue was recently reported by Dan Carpenter [1], >> and revealed wrong (and harmless) usage of str

Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Dan Carpenter
On Mon, Jun 18, 2012 at 04:23:14PM -0300, Ezequiel Garcia wrote: > Hi Mauro, > > This patchset cleans the i2c part of some drivers. > This issue was recently reported by Dan Carpenter [1], > and revealed wrong (and harmless) usage of struct i2c_algo_bit. > How is this harmless? We are setting t

Re: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Ezequiel Garcia
Hi Palash, On Mon, Jun 18, 2012 at 5:30 PM, Palash Bandyopadhyay wrote: > Thanks Ezequiel and Dan. The changes look ok. I'll have someone check out the > changes on the CX devices. > If you can have them tested, I think it would be great. Thanks for reviewing, Ezequiel. -- To unsubscribe from

RE: [PATCH 0/12] struct i2c_algo_bit_data cleanup on several drivers

2012-06-18 Thread Palash Bandyopadhyay
Thanks Ezequiel and Dan. The changes look ok. I'll have someone check out the changes on the CX devices. Rgds, Palash -Original Message- From: Ezequiel Garcia [mailto:elezegar...@gmail.com] Sent: Monday, June 18, 2012 12:23 PM To: Mauro Carvalho Chehab Cc: linux-media; Dan Carpenter; Pa