RE: [PATCH 4/5 v2] [media] ov9740: Remove hardcoded resolution regs

2011-06-01 Thread Guennadi Liakhovetski
On Tue, 31 May 2011, Andrew Chew wrote: + /* Width must be a multiple of 4 pixels. */ + *width += *width % 4; No, this doesn't make it a multiple of 4, unless it was even;) Just take 5 as an example. What you really want here is Geez, you're right. Not sure what was going on

RE: [PATCH 4/5 v2] [media] ov9740: Remove hardcoded resolution regs

2011-05-31 Thread Andrew Chew
+ /* Width must be a multiple of 4 pixels. */ + *width += *width % 4; No, this doesn't make it a multiple of 4, unless it was even;) Just take 5 as an example. What you really want here is Geez, you're right. Not sure what was going on in my head when I did this. Thanks for

Re: [PATCH 4/5 v2] [media] ov9740: Remove hardcoded resolution regs

2011-05-29 Thread Guennadi Liakhovetski
Now, this is really the direction I like! Now it's becoming a real driver;) Thanks for doing this! On Wed, 25 May 2011, ac...@nvidia.com wrote: From: Andrew Chew ac...@nvidia.com Derive resolution-dependent register settings programmatically. Signed-off-by: Andrew Chew ac...@nvidia.com