Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-08 Thread Guennadi Liakhovetski
On Thu, 8 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Thursday 08 Dec 2016 14:34:46 Guennadi Liakhovetski wrote: > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > > On Tuesday 06 Dec 2016 11:39:22 Guennadi Liakhovetski wrote: > > >> On Tue, 6 Dec 2016, Laurent Pinchart wrote: > >

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-08 Thread Laurent Pinchart
Hi Guennadi, On Thursday 08 Dec 2016 14:34:46 Guennadi Liakhovetski wrote: > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > On Tuesday 06 Dec 2016 11:39:22 Guennadi Liakhovetski wrote: > >> On Tue, 6 Dec 2016, Laurent Pinchart wrote: > >>> On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-08 Thread Guennadi Liakhovetski
Hi Laurent, One more question: On Tue, 6 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday 06 Dec 2016 11:39:22 Guennadi Liakhovetski wrote: > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > > On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski wrote: > > >> On Tue, 6 Dec

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-06 Thread Laurent Pinchart
Hi Guennadi, On Tuesday 06 Dec 2016 11:39:22 Guennadi Liakhovetski wrote: > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski wrote: > >> On Tue, 6 Dec 2016, Laurent Pinchart wrote: > >> + /* > >> + * Register a metadata node.

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-06 Thread Guennadi Liakhovetski
Hi Laurent, On Tue, 6 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski wrote: > > Just one question: > > > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > + /* > > + * Register a metadata node. TODO: shall this

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-05 Thread Laurent Pinchart
Hi Guennadi, On Monday 05 Dec 2016 23:13:53 Guennadi Liakhovetski wrote: > Just one question: > > On Tue, 6 Dec 2016, Laurent Pinchart wrote: > +/* > + * Register a metadata node. TODO: shall this only be enabled > for some > + * cameras? > +

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-05 Thread Guennadi Liakhovetski
Just one question: On Tue, 6 Dec 2016, Laurent Pinchart wrote: > > >> +/* > > >> + * Register a metadata node. TODO: shall this only be enabled > > >> for some > > >> + * cameras? > > >> + */ > > >> +if (!(dev->quirks & UVC_QUIRK_BUILTIN_ISIGHT)) > > >> +

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-05 Thread Laurent Pinchart
Hi Guennadi, On Monday 05 Dec 2016 16:35:39 Guennadi Liakhovetski wrote: > On Mon, 5 Dec 2016, Laurent Pinchart wrote: > > On Friday 02 Dec 2016 11:53:23 Guennadi Liakhovetski wrote: > >> Some UVC video cameras contain metadata in their payload headers. This > >> patch extracts that data,

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-05 Thread Guennadi Liakhovetski
Hi Laurent, Thanks for the review! I'll work to address your comments. A couple of clarifications: On Mon, 5 Dec 2016, Laurent Pinchart wrote: > Hi Guennadi, > > Thank you for the patch. > > On Friday 02 Dec 2016 11:53:23 Guennadi Liakhovetski wrote: > > Some UVC video cameras contain

Re: [PATCH v2 3/3] uvcvideo: add a metadata device node

2016-12-05 Thread Laurent Pinchart
Hi Guennadi, Thank you for the patch. On Friday 02 Dec 2016 11:53:23 Guennadi Liakhovetski wrote: > Some UVC video cameras contain metadata in their payload headers. This > patch extracts that data, skipping the standard part of the header, on > both bulk and isochronous endpoints and makes it