Re: [PATCH] V4L - Fix videobuf_dma_contig_user_get() getting page aligned physical address

2009-12-01 Thread Magnus Damm
On Wed, Dec 2, 2009 at 12:30 AM, wrote: > From: Muralidharan Karicheri > > If a USERPTR address that is not aligned to page boundary is passed to the > videobuf_dma_contig_user_get() function, it saves a page aligned address to > the dma_handle. This is not correct. This issue is observed when u

RE: [PATCH] V4L - Fix videobuf_dma_contig_user_get() getting page aligned physical address

2009-12-02 Thread Karicheri, Muralidharan
Magnus, >Thanks for the patch. For non-page aligned user space pointers I agree >that a fix is needed. Don't you think the while loop in >videobuf_dma_contig_user_get() also needs to be adjusted to include >the last page? I think the while loop checks one page too little in >the non-aligned case t

Re: [PATCH] V4L - Fix videobuf_dma_contig_user_get() getting page aligned physical address

2009-12-04 Thread Magnus Damm
Hi again Murali, Thanks for your work on this. On Thu, Dec 3, 2009 at 12:48 AM, Karicheri, Muralidharan wrote: > Magnus, > >>Thanks for the patch. For non-page aligned user space pointers I agree >>that a fix is needed. Don't you think the while loop in >>videobuf_dma_contig_user_get() also need

RE: [PATCH] V4L - Fix videobuf_dma_contig_user_get() getting page aligned physical address

2009-12-04 Thread Karicheri, Muralidharan
n >Cc: linux-media@vger.kernel.org; mche...@infradead.org; davinci-linux-open- >sou...@linux.davincidsp.com >Subject: Re: [PATCH] V4L - Fix videobuf_dma_contig_user_get() getting page >aligned physical address > >Hi again Murali, > >Thanks for your work on this. > >