18/2016 12:09 AM, Helen Koike wrote:
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
+
From: Helen Fornazier
First version of the Virtual Media Controller.
Add a simple version of the core of the driver, the capture and
sensor nodes in the topology, generating a grey image in a hardcoded
format.
Signed-off-by: Helen Koike
---
Patch based in media/master tree, and available
Signed-off-by: Helen Koike
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0a16a82..43e0eb4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12540,6 +12540,14 @@ W: https://linuxtv.org
S: Maintained
F: drivers/media/platform
The format was only being propagated to the subdevices directly
connected to the node being changed.
Continue propagating the format to all the subdevices in the video pipe.
Signed-off-by: Helen Koike
---
Only one level of propagation was not that useful for me so I made it to
completely
Hello,
One of the discussions we had when developing Vimc, was regarding
optimizing image generation.
The ideia was to generate the images directly in the capture instead
of propagating through the pipeline (to make things faster).
But my question is: if this optimization is on, and if there is a
On 8/22/18 3:49 AM, Hans Verkuil wrote:
> On 08/22/2018 05:35 AM, Helen Koike wrote:
>> Hello,
>>
>> One of the discussions we had when developing Vimc, was regarding
>> optimizing image generation.
>> The ideia was to generate the images directly in the
Hi Hans and Mauro,
On 9/24/18 11:42 AM, Hans Verkuil wrote:
> Hi all,
>
> We are organizing a media mini-summit on Thursday October 25th in
> Edinburgh, Edinburgh International Conference Centre.
>
> If you plan to attend, please let Mauro know. It is open for all, but
> we have a limited numbe
Hi Dafna,
Thanks for you patch.
On 10/6/18 4:21 PM, Dafna Hirschfeld wrote:
> Replace calls to `printk` with the appropriate `pr_*`
> macro.
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/usb/pvrusb2/pvrusb2-hdw.c | 8
> drivers/media/usb/pvrusb2/pvrusb2-i2c-core.c |
Hi Dmitry,
On 10/31/18 7:46 AM, Hans Verkuil wrote:
> On 10/30/2018 03:02 PM, Dmitry Vyukov wrote:
>> Hello Helen and linux-media,
>>
>> I've attended your talk "Shifting Media App Development into High
>> Gear" on OSS Summit last week and approached you with some questions
>> if/how this can be u
Hi Dmitry,
On 10/31/18 9:49 AM, Helen Koike wrote:
> Hi Dmitry,
>
> On 10/31/18 7:46 AM, Hans Verkuil wrote:
>> On 10/30/2018 03:02 PM, Dmitry Vyukov wrote:
>>> Hello Helen and linux-media,
>>>
>>> I've attended your talk "Shifting Media Ap
Hi Gabriel,
Thanks for your patch.
On 10/9/18 9:49 PM, Gabriel Francisco Mandaji wrote:
> Simulate a more precise timestamp by calculating it based on the
> current framerate.
>
> Signed-off-by: Gabriel Francisco Mandaji
> ---
> drivers/media/platform/vivid/vivid-core.h| 1 +
> driver
;
> Signed-off-by: Julia Lawall
Acked-by: Helen Koike
>
> ---
> drivers/media/platform/vimc/vimc-sensor.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-sensor.c
> b/drivers/media/platform/vimc/vimc-sensor.c
If link is disabled, media_entity_remote_pad returns NULL, causing a
NULL pointer deference.
Ignore links that are not enabled instead.
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/vimc
Add API to allow userspace to create any type of topology in vimc using
basic system calls such as mkdir/rmdir/read/write.
Signed-off-by: Helen Koike
---
Hi,
This patch introduces the configufs API for configuring the topology in
vimc while it removes the hardcoded topology, so now, when you
Hi Hans,
On 12/10/18 9:31 AM, Hans Verkuil wrote:
> On 12/7/18 7:22 PM, Helen Koike wrote:
>> Add API to allow userspace to create any type of topology in vimc using
>> basic system calls such as mkdir/rmdir/read/write.
>>
>> Signed-off-by: Helen Koike
>&g
Hi Mauro,
On 12/15/18 4:01 PM, Mauro Carvalho Chehab wrote:
> Hi Lucas,
>
>
> Em Sat, 15 Dec 2018 14:46:31 -0200
> Lucas A. M. Magalhães escreveu:
>
>> The previous code pipeline used the stack to walk on the graph and
>> process a frame. Basically the vimc-sensor entity starts a thread that
>
Hi Lucas,
Thank you for your patch, just some small comments below.
On 12/15/18 2:46 PM, Lucas A. M. Magalhães wrote:
> The previous code pipeline used the stack to walk on the graph and
> process a frame. Basically the vimc-sensor entity starts a thread that
> generates the frames and calls the
Hi Dafna,
Thanks for the patch, just a few comments, mostly regarding coding
style, I'll let Hans review the major logic.
On 12/23/18 6:36 PM, Dafna Hirschfeld wrote:
> Add support for the selection api for the crop and compose targets.
> The driver rounds up the coded width and height such that
Hi Hans
On 1/11/19 1:25 PM, Hans Verkuil wrote:
> Hi Helen,
>
> I've started work to fix the last compliance failures with vimc so that
> vimc can be used in regression tests.
>
> But I found a kernel warning and a kernel oops using vimc from our master
> tree.
>
> To test, load vimc, then run
Hi Hans,
Thanks for the patch.
On 1/14/19 12:58 PM, Hans Verkuil wrote:
> Add VB2_USERPTR to the vimc capture device.
>
> Signed-off-by: Hans Verkuil
> ---
> diff --git a/drivers/media/platform/vimc/vimc-capture.c
> b/drivers/media/platform/vimc/vimc-capture.c
> index 3f7e9ed56633..35c730f484a
Hi Lucas,
Thank you for this patch, please see my comments below.
On 1/14/19 10:19 PM, Lucas A. M. Magalhaes wrote:
> Add a linear pipeline logic for the stream control. It's created by
> walking backwards on the entity graph. When the stream starts it will
> simply loop through the pipeline call
On 1/17/19 8:15 PM, Lucas A. M. Magalhaes wrote:
> Add a linear pipeline logic for the stream control. It's created by
> walking backwards on the entity graph. When the stream starts it will
> simply loop through the pipeline calling the respective process_frame
> function of each entity.
>
> F
function of each entity.
>
> Fixes: f2fe89061d797 ("vimc: Virtual Media Controller core, capture
> and sensor")
> Cc: sta...@vger.kernel.org # for v4.20
> Signed-off-by: Lucas A. M. Magalhães
lgtm, thanks for the patch.
Acked-by: Helen Koike
Regards,
Helen
> ---
>
On 4/25/19 10:22 PM, André Almeida wrote:
> Move sp2mp functions from vivid code to v4l2-common as it will be reused
> by vimc driver for multiplanar support.
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Changes in v4: none
>
> Changes in v3:
m_planes = 1), re-use the multiplanar code, and
> transform them back to single planar. This is implemented with
> v4l2_fmt_sp2mp_func().
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Changes in v4:
> - Add comment that was in wrong commit
> - Check the ret
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Change in v4: none
>
> Changes in v3:
> - Fix typo on commit message
> - Add `_sp` to single planar default format
> - Modify identation
>
> Change in v2:
> - Move here the default format is set to veri
On 4/25/19 10:22 PM, André Almeida wrote:
> Add functions to handle multiplanar format ioctls, calling
> the generic format ioctls functions when possible.
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Change in v4:
> - Split from multiplanar par
bdevices work with
> the frame.
>
> Change the return and argument type of process_frame from void* to
> vimc_frame*. Change the frame in subdevices structs from u8* to vimc_frame.
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Changes in v4:
> - Remo
On 4/25/19 10:22 PM, André Almeida wrote:
> This commit adapts vimc-sensor to handle multiplanar pixel formats,
> adapting the memory allocation and TPG configuration.
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Changes in v4:
> - Correct `unsigned
On 4/25/19 10:22 PM, André Almeida wrote:
> Change the scaling functions in order to scale planes. This change makes
> easier to support multiplanar pixel formats.
>
> Signed-off-by: André Almeida
> ---
> Changes in v4:
> - Rename `frame_size` to `plane_size`
> - Correct `unsigned int ret` to
CAP_VIDEO_CAPTURE and CAP_VIDEO_CAPTURE_MPLANAR at the
> same time.
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Change in v4:
> - Split commit with "Add handler for multiplanar fmt ioctls"
>
> Change in v3:
> - Squash commit with "Ad
On 4/25/19 10:22 PM, André Almeida wrote:
> Adapt vimc-capture to support multiplanar formats, copying
> each plane to the correct buffer.
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Change in v4:
> - Move variables to inside the for loop
> -
On 4/26/19 4:51 PM, André Almeida wrote:
> Change the scaling functions in order to scale planes. This change makes
> easier to support multiplanar pixel formats.
>
> Signed-off-by: André Almeida
Acked-by: Helen Koike
> ---
> Changes in v5:
> - Remove bpp from vimc_s
Hi Shuah,
On 7/2/19 10:44 PM, shuah wrote:
> On 5/23/19 9:07 AM, shuah wrote:
>> Hi Hans and Helen,
>>
>> vimc streaming fails on Linux 5.2-rc1
>>
>> vimc: format doesn't match in link Scaler->RGB/YUV Capture
>>
>> You can reproduce this easily with v4l2-ctl
>>
>> Streaming works fine on Linux 5.1
Hi Niklas,
Thanks for the patch (and sorry for my late reply).
On 5/17/19 10:07 PM, Niklas Söderlund wrote:
> A sensor which is running is already part of a pipeline and trying to
> start a new pipeline is not possible. This prevents two capture devices
> connected to the same sensor from running
On 7/25/19 3:41 PM, Mauro Carvalho Chehab wrote:
> Em Fri, 26 Jul 2019 01:29:58 +0800
> Chen-Yu Tsai escreveu:
>
>> On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia
>> wrote:
>>>
>>> On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote:
Em Mon, 15 Jul 2019 18:23:16 -0300
On 1/30/19 11:43 AM, Hans Verkuil wrote:
> It is good practice to fill in bus_info.
>
> Also just use 'platform:vimc' when filling in the bus_info in querycap:
> the bus_info has nothing to do with the video device name.
>
> Signed-off-by: Hans Verkuil
Acked-by
Hi Hans,
Sorry about my delay.
On 1/14/19 3:05 PM, Hans Verkuil wrote:
> On 1/14/19 6:04 PM, Helen Koike wrote:
>> Hi Hans,
>>
>> Thanks for the patch.
>>
>> On 1/14/19 12:58 PM, Hans Verkuil wrote:
>>> Add VB2_USERPTR to the vimc capture device.
>
eries depends on
"[PATCH] media: Introduce helpers to fill pixel format structs "
Thanks,
Helen
Helen Koike (8):
media: vimc: deb: fix default sink bayer format
media: vimc: stream: fix thread state before sleep
media: vimc: cap: fix step width/height in enum framesize
media: v
The format of the sink pad should be a bayer mbus format.
This fixes a kernel NULL pointer dereference error that was caused when
the stream starts because the configured format was not found in the
pixelmap table.
Reported-by: Hans Verkuil
Signed-off-by: Helen Koike
---
drivers/media
in __might_sleep() call, as it's expecting the
task to be in TASK_RUNNING state just before changing the state to
a sleeping state.
Reported-by: Hans Verkuil
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-streamer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The type V4L2_FRMSIZE_TYPE_CONTINUOUS expects a step of 1.
This fixes v4l2-compliance test error:
fail: v4l2-test-formats.cpp(184): invalid step_width/height for
continuous framesize
test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: FAIL
Signed-off-by: Helen Koike
---
drivers/media
Add bayer format information in struct v4l2_format_info table.
Signed-off-by: Helen Koike
---
drivers/media/v4l2-core/v4l2-common.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-common.c
b/drivers/media/v4l2-core/v4l2-common.c
index
Add missing documentation for struct vimc_stream
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-streamer.h | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/media/platform/vimc/vimc-streamer.h
b/drivers/media/platform/vimc/vimc-streamer.h
index
There is no need to have the frame field in the vimc_stream struct.
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-streamer.c | 10 --
drivers/media/platform/vimc/vimc-streamer.h | 1 -
2 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/media
previous code was not a problem because the first entity is a video
device and not a subdevice, but this patch prepares vimc to allow
setting some configuration in the entity before calling s_stream.
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-streamer.c | 25
in a given pixelformat. So we can allow almost any media bus
format to be configured between pads, except for debayer that expects a
media bus code of type bayer in the sink pad.
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-capture.c | 76 +++--
drivers/media/platform/vimc
Hi André, thanks for the patch.
On 4/24/19 10:56 AM, André Almeida wrote:
> Add a multiplanar flag in vimc_stream in order to propagate the
> state (singleplanar/multiplanar) to subdevices at the stream.
This shouldn't be required as you are using multiplanar only between the
subdevices :)
Helen
Hi André
On 4/24/19 10:56 AM, André Almeida wrote:
> Struct vimc_frame is intended to hold metadata about a frame,
> such as memory address of a plane, number of planes and size
> of each plane, to better integrated with the multiplanar operations.
> The struct can be also used with singleplanar f
Hi André,
On 4/24/19 10:56 AM, André Almeida wrote:
> This commit adapts vimc-sensor to handle multiplanar pixel formats,
> adapting the memory allocation and TPG configuration.
>
> Signed-off-by: André Almeida
> ---
> Changes in v3:
> - Adapt to new vimc_frame
>
> Changes in v2:
> - Fix alignm
Hi André,
Thanks for the patch, please see my comments below.
On 4/24/19 10:56 AM, André Almeida wrote:
> Change the scaling functions in order to scale planes. This change makes
> easier to support multiplanar pixel formats.
>
> Signed-off-by: André Almeida
> ---
> Change in v3:
> - Adapt to n
Hi André,
On 4/24/19 10:56 AM, André Almeida wrote:
> Adapt vimc-capture to support multiplanar formats, copying
> each plane to the correct buffer.
>
> Signed-off-by: André Almeida
> ---
> Change in v3:
> - Adapt to new vimc_frame
>
> Change in v2: none
>
> drivers/media/platform/vimc/vimc-c
Hi André,
Thanks for the patch, please see my comments below.
On 4/24/19 10:56 AM, André Almeida wrote:
> Create multiplanar kernel module parameter to define if the driver is
> running in single planar or in multiplanar mode. Define the device
> capabilities and format ioctls according to the mu
On 4/24/19 10:56 AM, André Almeida wrote:
> Since multiplanar is a superset of single planar formats, instead of
> having different implementations for them, treat all formats as
> multiplanar. If we need to work with single planar formats, convert them to
> multiplanar (with num_planes = 1), re
On 4/24/19 8:03 PM, André Almeida wrote:
> Hello Helen,
>
> Thanks for your review!
>
> On 4/24/19 6:32 PM, Helen Koike wrote:
>> Hi André,
>>
>> Thanks for the patch, please see my comments below.
>>
>> On 4/24/19 10:56 AM, André Almeida wrote:
&
Hi Dafna,
Thanks for the patch. Just small comments below.
On 8/29/19 8:00 AM, Dafna Hirschfeld wrote:
> Userspace can disable links and create pipelines that
> do not start with a source entity. Trying to stream
> from such a pipeline should fail with -EPIPE
> currently this is not handled and c
Hello,
On 9/12/19 8:35 AM, Ezequiel Garcia wrote:
> On Thu, 2019-09-12 at 14:52 +0900, Tomasz Figa wrote:
>> On Thu, Sep 12, 2019 at 4:49 AM Nicolas Dufresne
>> wrote:
>>> Le mercredi 11 septembre 2019 à 09:27 +0100, Ezequiel Garcia a écrit :
On Mon, 2019-09-09 at 16:07 +0900, Tomasz Figa w
;>>> Attendees for this session:
>>>>>>
>>>>>> Kieran Bingham
>>>>
>>>> Unfortunately I can no longer attend ELCE.
>>>>
>>>> (My second baby will be a bit too new for an extended stay away from home)
>>>
--help-all option was not displaying options from --help-subdev.
Add missing subdev_usage() in usage_all() to fix it.
Signed-off-by: Helen Koike
---
utils/v4l2-ctl/v4l2-ctl.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/utils/v4l2-ctl/v4l2-ctl.cpp
index
+Hans +Shuah
Hi Guilherme and Danilo,
Thank you for the patch, please see my comments below.
On 9/9/19 1:08 AM, Guilherme Alcarde Gallo wrote:
> Add support for the scaler subdevice to respond VIDIOC_G_SELECTION and
> VIDIOC_S_SELECTION ioctls with the following targets:
> V4L2_SEL_TGT_COMPOSE_B
8:30 (tentative, might change) to 12:00 (we have to vacate the room at that
>> time).
>>
>> Confirmed attendees for this session:
>>
>> Boris Brezillon
>> Alexandre Courbot
>> Nicolas Dufresne
>> Tomasz Figa
>> Ezequiel Garcia
>> Daniel G
Hi Dafna,
On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
> since NULL value for vimc entity pointer indicates
> that entity creation failed and this is tested, the
> pointers should be initialized to NULL.
Nice catch :)
>
> Signed-off-by: Dafna Hirschfeld
> ---
> drivers/media/platform/vimc/vimc
tration also frees vsen.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-sensor.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-sensor.c
>
Hi Dafna,
Thanks for your patch
On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
> according to the docs, this function must be called during
> the cleanup phase after unregistering the entity.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
I just have on
On 10/1/19 2:25 PM, Andrzej Pietrasiewicz wrote:
> Hi Dafna, hi Helen,
>
> W dniu 01.10.2019 o 19:19, Helen Koike pisze:
>> Hi Dafna,
>>
>> On 10/1/19 1:50 PM, Dafna Hirschfeld wrote:
>>> since NULL value for vimc entity pointer indicates
>>> that e
Hi Dafna,
Thanks for your patch, just some comments below.
On 10/1/19 2:07 PM, Dafna Hirschfeld wrote:
> since the pads array is of known small size, there is no reason to
> allocate it separately. Instead, it is embedded in the entity struct.
> This also conforms to the media controller doc:
> '
On 10/3/19 7:44 AM, Dafna Hirschfeld wrote:
> since NULL value for vimc entity pointer indicates
> that entity creation failed and this is tested, the
> pointers should be initialized to NULL.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
> ---
> driver
ng like:
"media: vimc: remove unnecessary var when adding entities"
It makes clear what you are doing and where, what do you think?
With this:
Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-core.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(
unregisters the subdevice
> and then frees vsen, this cause double free since the release
> callback that follows subdevice unregistration also frees vsen.
>
> Signed-off-by: Dafna Hirschfeld
> Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-sensor.c | 20 +
On 10/3/19 7:44 AM, Dafna Hirschfeld wrote:
> since this function only calls v4l2_device_unregister_subdev,
> it is pointless.
>
> Signed-off-by: Dafna Hirschfeld
Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-common.c | 5 -
> drivers/med
; Signed-off-by: Wei Yongjun
Acked-by: Helen Koike
Thank you
Helen
> ---
> drivers/media/platform/vimc/vimc-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-core.c
> b/drivers/media/platform/vimc/vimc-co
t;> The second session deals with libcamera and is on Wednesday morning
>> from 9:00 to 13:00.
>>
>> Attendees for this session:
>>
>> Nicolas Dufresne
>> Tomasz Figa
>> Ezequiel Garcia
>> Dafna Hirschfeld
>
> I beliebe Dafna and I s
Hi
On 01/04/2016 15:22, Mauro Carvalho Chehab wrote:
Hi Helen,
This is just a quick look on it. See below.
Em Fri, 1 Apr 2016 14:18:13 -0300
Helen Mae Koike Fornazier escreveu:
The test pattern generator will be used by other drivers as the virtual
media controller (vimc)
Signed-off-by: He
Hi Mauro,
Please pull the following patches correcting the returned error codes
and respective docs in the pipeline validation.
Regards,
Helen
The following changes since commit 45c175c4ae9695d6d2f30a45ab7f3866cfac184b:
[media] tw686x: avoid going past array (2016-04-26 06:38:53 -0300)
ar
On 2017-06-02 11:58 PM, Helen Koike wrote:
Add a parameter called vsen_tpg, if true then vimc will work as before:
frames will be generated in the sensor nodes then propagated through the
pipe and processed by each node until a capture node is reached.
If vsen_tpg is false, then the frame is
Hi All,
Just reviving this discussion
On 2017-04-07 06:53 AM, Laurent Pinchart wrote:
Hi Hans,
On Friday 07 Apr 2017 11:46:48 Hans Verkuil wrote:
On 04/04/2017 03:22 PM, Sakari Ailus wrote:
On Mon, Apr 03, 2017 at 12:11:54PM -0300, Helen Koike wrote:
On 2017-03-31 06:57 AM, Mauro Carvalho
Hi Sakari,
Thanks for replying
On 2017-05-31 03:31 AM, Sakari Ailus wrote:
Hi Helen,
On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote:
colorspace, ycbcr_enc, quantization and xfer_func must match across the
link.
Check if they match in v4l2_subdev_link_validate_default unless
Hi
On 2017-06-08 08:41 AM, Mauro Carvalho Chehab wrote:
Em Tue, 6 Jun 2017 19:15:34 -0300
Helen Koike escreveu:
Hi Sakari,
Thanks for replying
On 2017-05-31 03:31 AM, Sakari Ailus wrote:
Hi Helen,
On Tue, May 30, 2017 at 04:08:08PM -0300, Helen Koike wrote:
colorspace, ycbcr_enc
colorspace, ycbcr_enc, quantization and xfer_func must match
across the link.
Check if they match in v4l2_subdev_link_validate_default
unless they are set as _DEFAULT.
Signed-off-by: Helen Koike
---
Hi,
As discussed previously, I added a warn message instead of returning
error to give drivers
Hi Hans,
Thanks for your review, just a question below
On 2017-06-12 06:50 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v3:
[media] vimc: common
Hi Hans,
Thank you for your review
On 2017-06-12 07:03 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
Add a parameter called vsen_tpg, if true then vimc will work as before:
frames will be generated in the sensor nodes then propagated through the
pipe and processed by each
Hi Hans,
Thank you for your review. Please check my comments below
On 2017-06-12 07:37 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
Change the core structure for adding subdevices in the topology.
Instead of calling the specific create function for each subdevice,
inject
Hi Hans,
On 2017-06-13 03:49 AM, Hans Verkuil wrote:
On 06/12/2017 10:35 PM, Helen Koike wrote:
Hi Hans,
Thank you for your review. Please check my comments below
On 2017-06-12 07:37 AM, Hans Verkuil wrote:
On 06/03/2017 04:58 AM, Helen Koike wrote:
+static struct component_match
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Koike (11):
[media] vimc: sen: Integrate the tpg on the sensor
[m
Allow user space to change the image format as the frame size, the
media bus pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: sen: Support several image formats
- use
_device in the system.
It also facilitates other implementations of different nodes without
touching the core code and remove the need of a header file for each
type of node.
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: Subdevices as modules
- Rebase without [media] vimc
Allow user space to change the image format as the frame size, the
pixel format, colorspace, quantization, field YCbCr encoding
and the transfer function
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: cap: Support several image formats
- add vimc_colorimetry_clamp macro
Colorimetry value will always be checked in the same way. Adding a
helper macro for that
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: common: Add vimc_colorimetry_clamp
- this is a new patch in the series
Changes in v3: None
Changes in v2: None
---
drivers/media
Implement the debayer filter and integrate it with the core
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: deb: Add debayer filter
- Rebase without [media] vimc: Optimize frame generation through
pipe
- use vimc_colorimetry_clamp
- replace
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: sca: Add scaler
- use vimc_colorimetry_clamp
- replace V4L2_COLORSPACE_SRGB by V4L2_COLORSPACE_DEFAULT in the
default format struct
- use struct
All links will be checked in the same way. Adding a helper function for
that
Signed-off-by: Helen Koike
---
Changes in v4:
[media] vimc: common: Add vimc_link_validate
- remove vimc_fmt_pix_to_mbus(), replaced by
v4l2_fill_mbus_format()
- remove EXPORT_SYMBOL
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: common: Add vimc_ent_sd_* helper
Move the vimc_cap_pipeline_s_stream from the vimc-cap.c to vimc-common.c
as this core will be reused by other subdevices to activate the stream
in their directly connected nodes
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: Add vimc_pipeline_s_stream in the
Initialize the test pattern generator on the sensor
Generate a colored bar image instead of a grey one
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: sen: Integrate the tpg on the sensor
- Declare frame_size as a local variable
- Set tpg frame
Remove helper functions from vimc-core and add it in vimc-common to
clean up the core.
Signed-off-by: Helen Koike
---
Changes in v4: None
Changes in v3:
[media] vimc: Move common code from the core
- This is a new patch in the series
Changes in v2: None
---
drivers/media/platform
-by: Helen Koike
---
Changes in v2::
- replace the type by capability
- erase V4L2_INPUT_TYPE_DEFAULT
- also consider output
- plug helpers in the ops automatically so drivers doesn't need
to set it by hand
- update docs
- commit messag
return EBUSY when trying to set the format while stream is on
- remove vsd struct
- add IS_SRC and IS_SINK macros
- add sca_mult as a parameter of the module
- check set_fmt default parameters for quantization, colorspace ...
- add more dev_dbg
Helen Ko
As all the subdevices in the topology will be initialized in the same
way, to avoid code repetition the vimc_ent_sd_{register, unregister}
helper functions were created
Signed-off-by: Helen Koike
---
Changes in v5: None
Changes in v4: None
Changes in v3:
[media] vimc: common: Add vimc_ent_sd_
Declare vimc_sen_video_ops as static, remove warning from sparse tool
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: sen: Declare vimc_sen_video_ops as static
- This is a new patch in the series
Changes in v4: None
Changes in v3: None
Changes in v2: None
---
drivers
Implement scaler and integrated with the core
Signed-off-by: Helen Koike
---
Changes in v5:
[media] vimc: sca: Add scaler
- declare vimc_sca_video_ops as static, remove sparse warning
Changes in v4:
[media] vimc: sca: Add scaler
- use vimc_colorimetry_clamp
- replace
1 - 100 of 168 matches
Mail list logo
