On Mon, Mar 23, 2009 at 09:38:47AM -0500, Seth Forshee wrote:
> On Mon, Mar 23, 2009 at 03:15:07PM +0200, Ameya Palande wrote:
> > From: Seth Forshee
> >
> > The error handling is ineffective and can lead to an oops.
> >
> > Acked-by: Ameya Palande
> &g
On Mon, Mar 23, 2009 at 03:15:07PM +0200, Ameya Palande wrote:
> From: Seth Forshee
>
> The error handling is ineffective and can lead to an oops.
>
> Acked-by: Ameya Palande
> Signed-off-by: Seth Forshee
Ah, hadn't seen this one yet when I sent my previous repl
I'm working with what basically amounts to an older version of the linux-omap
kernel with substantial modifications. I found that in some situations I was
getting about 4 mA more current draw during suspend than at other times. This
was ultimately being caused by some of the code that runs in SRA
is to blame. If this is the case, the patch below
fixes the problem.
--
From: Seth Forshee <[EMAIL PROTECTED]>
Subject: [PATCH] ARM: OMAP2: Set PRCM_CLKSRC_CTRL correctly in
omap2_enable_osc_ck
This patch fixes an incorrect use of prm_rmw_reg_bits() in
omap2_enable_osc_ck() which
Currently the MMC2 device configuration is defined for OMAP2430
when CONFIG_ARCH_OMAP243X is defined. This should be
CONFIG_ARCH_OMAP2430.
Signed-off-by: Seth Forshee <[EMAIL PROTECTED]>
---
arch/arm/plat-omap/devices.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff
On Tue, Apr 01, 2008 at 08:44:47PM +0530, Madhusudhan Chikkature Rajashekar
wrote:
> Hi,
>
> I did not see any board level code to power up the second slot along with
> this patch.
> Where is the code that enables 1.8V to the second slot?
I am working with a custom board that isn't supported in
OMAP2430/3430 contain an 1.8V-only MMC2 host that is not properly
supported by the current driver. This patch contains changes to
correctly set up this host.
Signed-off-by: Seth Forshee <[EMAIL PROTECTED]>
Acked-by: Francisco Alecrim <[EMAIL PROTECTED]>
---
drivers/mmc/host/omap_hs
On Mon, Mar 31, 2008 at 11:45:21PM +0300, Francisco Alecrim wrote:
> Hello Seth,
>It's fine and work for 3430! Maybe you should resend changing the
> commit message. It's too big.
>
> Remove "RFC" from subject.
>
> What do you think?
>
> if(changes)
>Acked-by: Francisco Alecrim <[EMAIL
This patch contains some fixes for the 1.8V MMC2 interface on the OMAP
2430/3430 that I had submitted for comment in a previous patch, this time
leaving out the device configuration in deference to the other patch submitted
for this purpose (once it has been resubmitted). These fixes were necessar
On Thu, Mar 20, 2008 at 07:44:02PM -0500, Seth Forshee wrote:
> Shouldn't you only register each device if enabled in the corresponding
> configuration, i.e.:
>
> if (mmc_conf->mmc[1].enabled)
> (void) platform_device_register(&mmc_omap_device1);
On Thu, Mar 20, 2008 at 10:25:01AM -0400, Carlos Aguiar wrote:
> if (cpu_is_omap2430() || cpu_is_omap34xx()) {
> - if (mmc->enabled)
> + mmc = &mmc_conf->mmc[1];
> + if (mmc->enabled) {
> (void) platform_device_register(&mmc_omap_devic
On Wed, Mar 19, 2008 at 08:53:48PM +0200, Keppler Alecrim wrote:
> What about DMA channel? Isn't it necessary?
>
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 3d4a7d1..262d846 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
On Tue, Mar 18, 2008 at 07:27:00PM +0530, Syed Mohammed, Khasim wrote:
> This looks ok to me, can you please do some cleanups and submit this patch to
> Tony for getting it onto tree?
Sure, I'll try to look into it later today. I won't be able to test
it against the current git repo beyond ensur
On Tue, Mar 18, 2008 at 06:50:39PM +0530, Syed Mohammed, Khasim wrote:
>
>
> > -Original Message-
> > From: [EMAIL PROTECTED] [mailto:linux-omap-
> > [EMAIL PROTECTED] On Behalf Of Tony Lindgren
> > Sent: Tuesday, March 18, 2008 5:23 PM
> > To: Remith Ravi
> > Cc: linux-omap@vger.kernel.o
On Wed, Mar 12, 2008 at 12:56:10PM -0500, Seth Forshee wrote:
> The IRQ handler in omap-i2c.c can sometimes clear status bits without
> actually processing them. In particular, error status bits will be
> ignored if any of the ARDY, RRDY, RDR, XRDY, or XDR bits are
> concurrently set
On Wed, Mar 12, 2008 at 01:14:32PM -0500, Felipe Balbi wrote:
> > - int count = 0;
> > + int err, count = 0;
>
> int err = 0, count = 0; will be better and you avoid that err=0 before
> using err right below.
No, the err = 0 I added is in a while loop. It needs to be
reinitialized for each i
The IRQ handler in omap-i2c.c can sometimes clear status bits without
actually processing them. In particular, error status bits will be
ignored if any of the ARDY, RRDY, RDR, XRDY, or XDR bits are
concurrently set.
Signed-off-by: Seth Forshee <[EMAIL PROTECTED]>
---
More informati
17 matches
Mail list logo
