Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-21 Thread Jarkko Nikula
On 02/20/2012 11:52 AM, Peter Ujfalusi wrote: > I have patch on top of the mcbsp merge series which allows users > (developers) to switch between McBSP2 master/slave configuration on > Beagle. It will have two PCM: > 0 is the current configuration (twl4030 master, mcbsp2 slave) > 1 is the same as w

Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-20 Thread Grazvydas Ignotas
On Mon, Feb 20, 2012 at 3:26 PM, Peter Ujfalusi wrote: > On 02/20/2012 12:50 PM, Grazvydas Ignotas wrote: >> Sounds good, I can wait for this I guess. > > I just wonder why not just switch to twl4030 master scenario for > pandora? I know that there are products out there using this scenario (I > m

Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-20 Thread Peter Ujfalusi
On 02/20/2012 12:50 PM, Grazvydas Ignotas wrote: > Sounds good, I can wait for this I guess. I just wonder why not just switch to twl4030 master scenario for pandora? I know that there are products out there using this scenario (I mean real consumer devices), and AFAIK they work pretty well. What

Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-20 Thread Grazvydas Ignotas
On Mon, Feb 20, 2012 at 11:52 AM, Peter Ujfalusi wrote: > On 02/19/2012 05:52 PM, Grazvydas Ignotas wrote: >>> Might be an idea to do this in the McBSP driver - have it do the switch >>> transparently, then flip back when the port is brought up again? >> >> Maybe, but I think pandora is the only o

Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-20 Thread Peter Ujfalusi
On 02/19/2012 05:52 PM, Grazvydas Ignotas wrote: >> Might be an idea to do this in the McBSP driver - have it do the switch >> transparently, then flip back when the port is brought up again? > > Maybe, but I think pandora is the only one using external clock in > mainline I have patch on top of

Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-19 Thread Grazvydas Ignotas
On Sun, Feb 19, 2012 at 8:30 AM, Mark Brown wrote: > On Sun, Feb 19, 2012 at 12:39:55AM +0200, Grazvydas Ignotas wrote: >> For some reason, OMAP doesn't enter lower power states with functional >> clock (CLKS) source set to external, so switch it back to internal when >> done playing. >> >> Signed

Re: [PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-18 Thread Mark Brown
On Sun, Feb 19, 2012 at 12:39:55AM +0200, Grazvydas Ignotas wrote: > For some reason, OMAP doesn't enter lower power states with functional > clock (CLKS) source set to external, so switch it back to internal when > done playing. > > Signed-off-by: Grazvydas Ignotas Might be an idea to do this i

[PATCH] ASoC: pandora: switch clock back to internal on stop

2012-02-18 Thread Grazvydas Ignotas
For some reason, OMAP doesn't enter lower power states with functional clock (CLKS) source set to external, so switch it back to internal when done playing. Signed-off-by: Grazvydas Ignotas --- sound/soc/omap/omap3pandora.c | 22 ++ 1 files changed, 22 insertions(+), 0 dele