[Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Arun KS
OMAP2EVM: Add ethernet support (smc911x) Signed-off-by: Arun KS <[EMAIL PROTECTED]> --- arch/arm/mach-omap2/board-omap2evm.c | 41 include/asm-arm/arch-omap/board-omap2evm.h |5 ++- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/arch/arm/m

Re: [Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Felipe Balbi
Your patch came with spaces in place of tabs, please tabify and resend -- Best Regards, Felipe Balbi http://felipebalbi.com [EMAIL PROTECTED] -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vge

[Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Arun KS
OMAP2EVM: Add ethernet support (smc911x) Signed-off-by: Arun KS <[EMAIL PROTECTED]> --- arch/arm/mach-omap2/board-omap2evm.c | 41 include/asm-arm/arch-omap/board-omap2evm.h |5 ++- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/arch/arm/m

Re: [Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Arun KS
Hi Felipe, Thanks for your comments. I will incorporate those changes and will send back. Regards Arun Felipe Balbi wrote: Hi, On Tue, 24 Jun 2008 18:55:26 +0530, "Arun KS" <[EMAIL PROTECTED]> wrote: +static inline void __init omap2evm_init_smc911x(void) +{ + int gpio = OMAP2EVM_ETH

Re: [Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Felipe Balbi
Hi, On Tue, 24 Jun 2008 18:55:26 +0530, "Arun KS" <[EMAIL PROTECTED]> wrote: > +static inline void __init omap2evm_init_smc911x(void) > +{ > + int gpio = OMAP2EVM_ETHR_GPIO_IRQ; > + int ret; > + > + ret = gpio_request(gpio, "smc911x IRQ"); > + if (ret >= 0) > +

Re: [Resend] [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Arun KS
OMAP2EVM: Add ethernet support (smc911x) Signed-off-by: Arun KS <[EMAIL PROTECTED]> --- arch/arm/mach-omap2/board-omap2evm.c | 39 include/asm-arm/arch-omap/board-omap2evm.h |5 ++- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/arch/arm/m

Re: [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Felipe Balbi
On Tue, 24 Jun 2008 18:24:11 +0530, "Arun KS" <[EMAIL PROTECTED]> wrote: >> it looks like drivers/net/smc911x doesn't use IORESOURCE_IRQ, am I >> misreading it ? >> > > Yes this driver uses platform_get_irq(pdev, 0) to get its irq number. Cool, thanks :-) -- Best Regards, Felipe Balbi http:

Re: [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Arun KS
On Tue, Jun 24, 2008 at 5:42 PM, Felipe Balbi <[EMAIL PROTECTED]> wrote: > > > On Tue, 24 Jun 2008 17:34:59 +0530, "Arun KS" <[EMAIL PROTECTED]> wrote: >> From 58efa8d0019a7f777aaad2d43afb05170df25fae Mon Sep 17 00:00:00 2001 >> From: Arun KS <[EMAIL PROTECTED]> >> Date: Tue, 24 Jun 2008 16:01:32 +

Re: [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Arun KS
Hi Felipe, I will do the changes and resend the patches. Best Regards, Arun On Tue, Jun 24, 2008 at 5:42 PM, Felipe Balbi <[EMAIL PROTECTED]> wrote: > > > On Tue, 24 Jun 2008 17:34:59 +0530, "Arun KS" <[EMAIL PROTECTED]> wrote: >> From 58efa8d0019a7f777aaad2d43afb05170df25fae Mon Sep 17 00:00:00

Re: [PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Felipe Balbi
On Tue, 24 Jun 2008 17:34:59 +0530, "Arun KS" <[EMAIL PROTECTED]> wrote: > From 58efa8d0019a7f777aaad2d43afb05170df25fae Mon Sep 17 00:00:00 2001 > From: Arun KS <[EMAIL PROTECTED]> > Date: Tue, 24 Jun 2008 16:01:32 +0530 > Subject: [PATCH] OMAP2EVM: Adding ethernet support > > OMAP2EVM: add et

[PATCH 1/3] OMAP2EVM: add ethernet support (smc911x)

2008-06-24 Thread Arun KS
>From 58efa8d0019a7f777aaad2d43afb05170df25fae Mon Sep 17 00:00:00 2001 From: Arun KS <[EMAIL PROTECTED]> Date: Tue, 24 Jun 2008 16:01:32 +0530 Subject: [PATCH] OMAP2EVM: Adding ethernet support OMAP2EVM: add ethernet support (smc911x) Signed-off-by: Arun KS <[EMAIL PROTECTED]> --- arch/arm/mac