[PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-11 Thread Laurent Pinchart
Define PWM_POLARITY_NORMAL and PWM_POLARITY_INVERTED macros in include/dt-bindings/pwm/pwm.h to be used by device tree sources. Signed-off-by: Laurent Pinchart --- Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt | 6 +++--- Documentation/devicetree/bindings/pwm/pwm-samsung.txt | 5 ++

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-11 Thread Thierry Reding
On Thu, Jul 11, 2013 at 04:37:48PM +0200, Laurent Pinchart wrote: [...] > diff --git a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt > b/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt > index de0eaed..be09be4 100644 > --- a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-11 Thread Stephen Warren
On 07/11/2013 08:37 AM, Laurent Pinchart wrote: > Define PWM_POLARITY_NORMAL and PWM_POLARITY_INVERTED macros in > include/dt-bindings/pwm/pwm.h to be used by device tree sources. > Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt | 6 +++--- > Documentation/devicetree/bindings/pwm/pwm-sa

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-11 Thread Stephen Warren
On 07/11/2013 09:36 AM, Thierry Reding wrote: > On Thu, Jul 11, 2013 at 04:37:48PM +0200, Laurent Pinchart wrote: > [...] >> diff --git >> a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt >> b/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt index >> de0eaed..be09be4 100644 --- >>

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-11 Thread Thierry Reding
On Thu, Jul 11, 2013 at 11:50:48AM -0600, Stephen Warren wrote: > On 07/11/2013 09:36 AM, Thierry Reding wrote: > > On Thu, Jul 11, 2013 at 04:37:48PM +0200, Laurent Pinchart wrote: > > [...] > >> diff --git > >> a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt > >> b/Documentation/device

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-11 Thread Stephen Warren
On 07/11/2013 01:32 PM, Thierry Reding wrote: > On Thu, Jul 11, 2013 at 11:50:48AM -0600, Stephen Warren wrote: >> On 07/11/2013 09:36 AM, Thierry Reding wrote: >>> On Thu, Jul 11, 2013 at 04:37:48PM +0200, Laurent Pinchart >>> wrote: [...] diff --git a/Documentation/devicetree/bindings/

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-12 Thread Laurent Pinchart
Hi Stephen, On Thursday 11 July 2013 11:40:37 Stephen Warren wrote: > On 07/11/2013 08:37 AM, Laurent Pinchart wrote: > > Define PWM_POLARITY_NORMAL and PWM_POLARITY_INVERTED macros in > > include/dt-bindings/pwm/pwm.h to be used by device tree sources. > > > > Documentation/devicetree/bindings/

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-12 Thread Laurent Pinchart
Hi Thierry, On Thursday 11 July 2013 08:36:00 Thierry Reding wrote: > On Thu, Jul 11, 2013 at 04:37:48PM +0200, Laurent Pinchart wrote: > [...] > > > diff --git a/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt > > b/Documentation/devicetree/bindings/pwm/atmel-tcb-pwm.txt index > > de0eae

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-12 Thread Laurent Pinchart
Hi, On Thursday 11 July 2013 14:06:44 Stephen Warren wrote: > On 07/11/2013 01:32 PM, Thierry Reding wrote: > > On Thu, Jul 11, 2013 at 11:50:48AM -0600, Stephen Warren wrote: > >> On 07/11/2013 09:36 AM, Thierry Reding wrote: > >>> On Thu, Jul 11, 2013 at 04:37:48PM +0200, Laurent Pinchart > >>>

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-12 Thread Stephen Warren
On 07/12/2013 04:41 AM, Laurent Pinchart wrote: > Hi Stephen, > > On Thursday 11 July 2013 11:40:37 Stephen Warren wrote: >> On 07/11/2013 08:37 AM, Laurent Pinchart wrote: >>> Define PWM_POLARITY_NORMAL and PWM_POLARITY_INVERTED macros in >>> include/dt-bindings/pwm/pwm.h to be used by device tre

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-12 Thread Stephen Warren
On 07/12/2013 05:01 AM, Laurent Pinchart wrote: > Hi, > > On Thursday 11 July 2013 14:06:44 Stephen Warren wrote: >> On 07/11/2013 01:32 PM, Thierry Reding wrote: >>> On Thu, Jul 11, 2013 at 11:50:48AM -0600, Stephen Warren wrote: On 07/11/2013 09:36 AM, Thierry Reding wrote: > On Thu, Ju

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-12 Thread Thierry Reding
On Fri, Jul 12, 2013 at 08:40:07AM -0600, Stephen Warren wrote: > On 07/12/2013 04:41 AM, Laurent Pinchart wrote: > > Hi Stephen, [...] > > What about splitting it in three patches that > > > > - add the include/dt-bindings/pwm/pwm.h header, and update > > include/linux/pwm.h > > and Documentati

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-12 Thread Stephen Warren
On 07/12/2013 11:24 AM, Thierry Reding wrote: > On Fri, Jul 12, 2013 at 08:40:07AM -0600, Stephen Warren wrote: >> On 07/12/2013 04:41 AM, Laurent Pinchart wrote: >>> Hi Stephen, > [...] >>> What about splitting it in three patches that >>> >>> - add the include/dt-bindings/pwm/pwm.h header, and u

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-15 Thread Laurent Pinchart
Hi Stephen, On Friday 12 July 2013 08:42:41 Stephen Warren wrote: > On 07/12/2013 05:01 AM, Laurent Pinchart wrote: > > On Thursday 11 July 2013 14:06:44 Stephen Warren wrote: > >> On 07/11/2013 01:32 PM, Thierry Reding wrote: > >>> On Thu, Jul 11, 2013 at 11:50:48AM -0600, Stephen Warren wrote: >

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-15 Thread Laurent Pinchart
Hello, On Friday 12 July 2013 11:40:44 Stephen Warren wrote: > On 07/12/2013 11:24 AM, Thierry Reding wrote: > > On Fri, Jul 12, 2013 at 08:40:07AM -0600, Stephen Warren wrote: > >> On 07/12/2013 04:41 AM, Laurent Pinchart wrote: > >>> Hi Stephen, > > > > [...] > > > >>> What about splitting it

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-15 Thread Stephen Warren
On 07/15/2013 07:10 PM, Laurent Pinchart wrote: > On Friday 12 July 2013 08:42:41 Stephen Warren wrote: ... >> I think the values for any common system-wide flags should be defined >> once in some system-wide place, and the values for any HW-specific >> values should be defined only in the document

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-17 Thread Laurent Pinchart
Hi Stephen, On Monday 15 July 2013 21:39:31 Stephen Warren wrote: > On 07/15/2013 07:10 PM, Laurent Pinchart wrote: > > On Friday 12 July 2013 08:42:41 Stephen Warren wrote: > ... > > >> I think the values for any common system-wide flags should be defined > >> once in some system-wide place, and

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-17 Thread Stephen Warren
On 07/17/2013 05:00 AM, Laurent Pinchart wrote: > On Monday 15 July 2013 21:39:31 Stephen Warren wrote: ... >> But then there's a problem where people assume that the common flags are >> always available, and somewhere they aren't... Care is needed in the >> choice of which common flags to define a

Re: [PATCH 2/2] pwm: Add PWM polarity flag macros for DT

2013-07-17 Thread Thierry Reding
On Wed, Jul 17, 2013 at 11:11:19AM -0600, Stephen Warren wrote: > On 07/17/2013 05:00 AM, Laurent Pinchart wrote: > > On Monday 15 July 2013 21:39:31 Stephen Warren wrote: > ... > >> But then there's a problem where people assume that the common flags are > >> always available, and somewhere they a