Re: [PATCH 5/6] tty: serial: 8250-core: add rs485 support

2014-07-10 Thread Sebastian Andrzej Siewior
On 07/09/2014 09:01 PM, Lennart Sorensen wrote: >> diff --git a/drivers/tty/serial/8250/8250_core.c >> b/drivers/tty/serial/8250/8250_core.c >> index c7c3bf7..bf06a4c 100644 >> --- a/drivers/tty/serial/8250/8250_core.c >> +++ b/drivers/tty/serial/8250/8250_core.c >> @@ -1281,10 +1283,34 @@ static

Re: [PATCH 5/6] tty: serial: 8250-core: add rs485 support

2014-07-10 Thread One Thousand Gnomes
> static inline void __stop_tx(struct uart_8250_port *p) > { > + if (p->rs485.flags & SER_RS485_ENABLED) { > + int ret; > + > + ret = (p->rs485.flags & SER_RS485_RTS_AFTER_SEND) ? 1 : 0; > + if (gpio_get_value(p->rts_gpio) != ret) { > +

Re: [PATCH 5/6] tty: serial: 8250-core: add rs485 support

2014-07-09 Thread Lennart Sorensen
On Wed, Jul 09, 2014 at 07:49:36PM +0200, Sebastian Andrzej Siewior wrote: > So after I stuffed the rs485 support from the omap-serial into > 8250-omap, I've been looking at it and the only omap specific part was > the OMAP_UART_SCR_TX_EMPTY part. The driver has always TX_EMPTY set > because the 82

[PATCH 5/6] tty: serial: 8250-core: add rs485 support

2014-07-09 Thread Sebastian Andrzej Siewior
So after I stuffed the rs485 support from the omap-serial into 8250-omap, I've been looking at it and the only omap specific part was the OMAP_UART_SCR_TX_EMPTY part. The driver has always TX_EMPTY set because the 8250 core expects an interrupt after the TX fifo + shift register is empty. The rs485