Re: [PATCH v2 1/4] ASoC: DMIC: Adding the OMAP DMIC driver

2011-01-07 Thread Mark Brown
On Fri, Jan 07, 2011 at 10:34:53AM -0600, Lambert, David wrote: > On Thu, Jan 6, 2011 at 4:20 PM, Mark Brown > > I suggested switch statements previously; you didn't comment on my > > reply. > Sorry... my personal standard on when to go with a switch statement is > >2 choices, > I'll change it ov

Re: [PATCH v2 1/4] ASoC: DMIC: Adding the OMAP DMIC driver

2011-01-07 Thread Lambert, David
On Thu, Jan 6, 2011 at 4:20 PM, Mark Brown wrote: > On Thu, Jan 06, 2011 at 08:00:36AM -0600, David Lambert wrote: > >> @@ -103,6 +106,7 @@ config SND_OMAP_SOC_SDP4430 >>       depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP_4430SDP >>       select SND_OMAP_SOC_MCPDM >>       select SND_SOC_T

Re: [PATCH v2 1/4] ASoC: DMIC: Adding the OMAP DMIC driver

2011-01-06 Thread Mark Brown
On Thu, Jan 06, 2011 at 08:00:36AM -0600, David Lambert wrote: > @@ -103,6 +106,7 @@ config SND_OMAP_SOC_SDP4430 > depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP_4430SDP > select SND_OMAP_SOC_MCPDM > select SND_SOC_TWL6040 > + select SND_SOC_DMIC > help >

[PATCH v2 1/4] ASoC: DMIC: Adding the OMAP DMIC driver

2011-01-06 Thread David Lambert
This patch adds support for the OMAP4 digital microphone DAI. This DAI can support support recording in 2, 4, or 6 channels When provided with a 19.2Mhz functional clock, can encode at 96Khz or 192Khz (all channels must have the same sample rate). Details of the hardware interface can be found i