RE: [PATCH v3 2/2] OMAP: DSS2: Use dss_features framework on DSS2 code

2010-09-15 Thread Tomi Valkeinen
On Wed, 2010-09-15 at 13:34 +0200, ext Taneja, Archit wrote: > Hi, > > I was reworking some patches, I saw 2 functions in manager.c: > > dss_mgr_wait_for_go() and dss_mgr_wait_for_go_ovl() both > define the var "enum omap_channel channel;" but don't use it. > > Is there any reason this is done,

RE: [PATCH v3 2/2] OMAP: DSS2: Use dss_features framework on DSS2 code

2010-09-15 Thread Taneja, Archit
Hi, I was reworking some patches, I saw 2 functions in manager.c: dss_mgr_wait_for_go() and dss_mgr_wait_for_go_ovl() both define the var "enum omap_channel channel;" but don't use it. Is there any reason this is done, or is it just stray code? Tomi Valkeinen wrote: > On Mon, 2010-09-13 at 07:3

RE: [PATCH v3 2/2] OMAP: DSS2: Use dss_features framework on DSS2 code

2010-09-15 Thread Taneja, Archit
Tomi Valkeinen wrote: > On Mon, 2010-09-13 at 07:30 +0200, ext Archit Taneja wrote: >> Calls init functions of dss_features during dss_probe, and the >> following features are made omap independent: >> - number of managers, overlays >> - supported color modes for each overlay >> - support

Re: [PATCH v3 2/2] OMAP: DSS2: Use dss_features framework on DSS2 code

2010-09-15 Thread Tomi Valkeinen
On Mon, 2010-09-13 at 07:30 +0200, ext Archit Taneja wrote: > Calls init functions of dss_features during dss_probe, and the following > features are made omap independent: > - number of managers, overlays > - supported color modes for each overlay > - supported displays for each manager

[PATCH v3 2/2] OMAP: DSS2: Use dss_features framework on DSS2 code

2010-09-12 Thread Archit Taneja
Calls init functions of dss_features during dss_probe, and the following features are made omap independent: - number of managers, overlays - supported color modes for each overlay - supported displays for each manager - global aplha, and restriction of global alpha for video1 pipeline