Re: [PATCH v3 5/5] drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request fails

2014-03-12 Thread Tony Lindgren
* Santosh Shilimkar [140312 14:08]: > On Thursday 13 March 2014 01:28 AM, Tony Lindgren wrote: > > * Peter Ujfalusi [140304 23:14]: > >> On 03/04/2014 04:37 PM, Santosh Shilimkar wrote: > >>> On Tuesday 04 March 2014 08:48 PM, Peter Ujfalusi wrote: > Use dev_err() which will going to print t

Re: [PATCH v3 5/5] drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request fails

2014-03-12 Thread Santosh Shilimkar
On Thursday 13 March 2014 01:28 AM, Tony Lindgren wrote: > * Peter Ujfalusi [140304 23:14]: >> On 03/04/2014 04:37 PM, Santosh Shilimkar wrote: >>> On Tuesday 04 March 2014 08:48 PM, Peter Ujfalusi wrote: Use dev_err() which will going to print the driver's name as well and the KERN_ERR

Re: [PATCH v3 5/5] drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request fails

2014-03-12 Thread Tony Lindgren
* Peter Ujfalusi [140304 23:14]: > On 03/04/2014 04:37 PM, Santosh Shilimkar wrote: > > On Tuesday 04 March 2014 08:48 PM, Peter Ujfalusi wrote: > >> Use dev_err() which will going to print the driver's name as well and the > >> KERN_ERR level is sufficient in this case (we also print via dev_err

Re: [PATCH v3 5/5] drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request fails

2014-03-04 Thread Peter Ujfalusi
On 03/04/2014 04:37 PM, Santosh Shilimkar wrote: > On Tuesday 04 March 2014 08:48 PM, Peter Ujfalusi wrote: >> Use dev_err() which will going to print the driver's name as well and the >> KERN_ERR level is sufficient in this case (we also print via dev_err when >> there is an error with the mem res

Re: [PATCH v3 5/5] drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request fails

2014-03-04 Thread Santosh Shilimkar
On Tuesday 04 March 2014 08:48 PM, Peter Ujfalusi wrote: > Use dev_err() which will going to print the driver's name as well and the > KERN_ERR level is sufficient in this case (we also print via dev_err when > there is an error with the mem resources) > > Signed-off-by: Peter Ujfalusi > Reviewed

[PATCH v3 5/5] drivers: bus: omap_l3: Change pr_crit() to dev_err() when IRQ request fails

2014-03-04 Thread Peter Ujfalusi
Use dev_err() which will going to print the driver's name as well and the KERN_ERR level is sufficient in this case (we also print via dev_err when there is an error with the mem resources) Signed-off-by: Peter Ujfalusi Reviewed-by: Santosh Shilimkar --- drivers/bus/omap_l3_noc.c | 7 +++ 1