Re: [PATCH v5 08/14] ARM: OMAP2+: gpmc: bool type timing helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Some of the timing configuration like extra delay > has bool type configurations. Provide a helper so > that these too can be configured in Kernel. > > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 55 >

Re: [PATCH v5 09/14] ARM: OMAP2+: gpmc: holler if no configuration

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Some of the GPMC peripherals depend on bootloader to do the > configuration. This facility is deprecated, notify user > about the present GPMC settings & inform that that relying > on bootloader for GPMC setting is deprecated. Nit, "holler" is slang

Re: [PATCH v5 10/14] ARM: OMAP2+: gpmc: waitpin helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Helper for configuring waitpin. There are two parts to it; > configuring at CS level and the other at device level. > A device embedding multiple CS has been provided the > capability to use same waitpin (different waitpins has not > been supported a

Re: [PATCH v5 12/14] ARM: OMAP2+: gpmc: cs reconfigure helper

2012-06-11 Thread Jon Hunter
On 06/11/2012 09:27 AM, Afzal Mohammed wrote: > Helper for reconfiguring CS, peripheral that necessitated > it was OneNAND. Why? I think you need to add more about why this was needed. Jon > Signed-off-by: Afzal Mohammed > --- > arch/arm/mach-omap2/gpmc.c | 32 > +++

RE: [PATCH 1/3] ARM: OMAP2+: nand: unify init functions

2012-06-11 Thread Mohammed, Afzal
Hi Jon, On Mon, Jun 11, 2012 at 21:13:45, Hunter, Jon wrote: > Which boards have been tested with this change? Beagle board > Reviewed-by: Jon Hunter Thanks Regards Afzal -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kerne

Re: RFC: changing DMA slave configuration API

2012-06-11 Thread Vinod Koul
On Mon, 2012-06-11 at 17:33 +0800, Dong Aisheng wrote: > > I think it is a good idea. And I would like to extend it even a > little > > bit. Do we have any users of peripheral to peripheral slave dma? > Yes, IMX sdma does support such kind of transfer. > The driver still does not support it current

Re: RFC: changing DMA slave configuration API

2012-06-11 Thread Vinod Koul
On Mon, 2012-06-11 at 09:24 +0100, Russell King - ARM Linux wrote: > On Mon, Jun 11, 2012 at 10:20:49AM +0530, Vinod Koul wrote: > > I think it is a good idea. And I would like to extend it even a little > > bit. Do we have any users of peripheral to peripheral slave dma? > > IIRC that is not the

RE: [PATCH 2/3] ARM: OMAP2+: onenand: cleanup for gpmc driver conversion

2012-06-11 Thread Mohammed, Afzal
Hi Jon, On Tue, Jun 12, 2012 at 00:06:30, Hunter, Jon wrote: > I agree with getting rid of the first instance at the beginning of > _set_async_mode, but why get rid of the above one? Are you assuming that > by default it is in async mode? Could be nice to keep it to be explicit. Second one is ac

RE: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings

2012-06-11 Thread Mohammed, Afzal
Hi Jon, On Tue, Jun 12, 2012 at 00:19:35, Hunter, Jon wrote: > What boards have been tested with this change? Beagle board, after applying all 5 series of patches, without all patch series it can't be tested for beagle board as it depended on bootloader, not this API > > + u16 bus_turnaround

Re: [PATCH 5/5] Input: ads7846: set proper debounce time in driver level

2012-06-11 Thread Tony Lindgren
* Zumeng Chen [120611 07:05]: > If we don't set proper debouce time for ads7846, then there are > flooded interrupt counters of ads7846 responding to one time > touch on screen, so the driver couldn't work well. > > And since most OMAP3 series boards pass NULL pointer of board_pdata > to omap_ads

RE: [PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

2012-06-11 Thread Mohammed, Afzal
Hi Jon, On Tue, Jun 12, 2012 at 01:26:29, Hunter, Jon wrote: > > + pdev = omap_device_build(name, -1, oh, pdata, > > + sizeof(*pdata), NULL, 0, 0); > > + if (IS_ERR(pdev)) { > > + WARN(1, "Can't build omap_device for %s:%s.\n", > > +

<    1   2