Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Linus Walleij
On Tue, Aug 30, 2016 at 11:42 PM, Russell King - ARM Linux wrote: > On Tue, Aug 30, 2016 at 11:25:19PM +0200, Linus Walleij wrote: >> > +#define to_gpio_reg(x) container_of(x, struct gpio_reg, gc) >> >> You don't need that trickery anymore, just: >> >> > +static int gpio_reg_get_direction(struct

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 11:25:19PM +0200, Linus Walleij wrote: > On Mon, Aug 29, 2016 at 12:24 PM, Russell King > wrote: > > > Add a simple, generic, single register fixed-direction GPIO driver. > > This is able to support a single register where a fixed number of > > bits are used for input and

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Robert Jarzmik
Russell King - ARM Linux writes: > If you can wait a day or two, I'll push a branch out for everything in > all these multiple series. Sure, just ping me when you have something. Cheers. -- Robert ___ Linux PCMCIA reimplementation list http://lists.

Re: [RFC PATCH 00/33] SA11x0/PXA GPIO rework (Core + PCMCIA only)

2016-08-30 Thread Linus Walleij
On Mon, Aug 29, 2016 at 12:23 PM, Russell King - ARM Linux wrote: > Following on from the PCMCIA fixes, this series reworks GPIO on SA11x0 > and PXA platforms. This is a subset of a larger series, which I'm > splitting up due to its size. This part contains the base and PCMCIA > updates. Furth

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Linus Walleij
On Mon, Aug 29, 2016 at 12:24 PM, Russell King wrote: > Add a simple, generic, single register fixed-direction GPIO driver. > This is able to support a single register where a fixed number of > bits are used for input and a fixed number of bits used for output. > > Signed-off-by: Russell King C

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 06:42:03PM +0200, Robert Jarzmik wrote: > Russell King - ARM Linux writes: > > > On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > >> Maybe this one would deserve a doxygen comment ? > > > > Does this solve it? > Oh yes, that's very nice, especially the "1

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Robert Jarzmik
Russell King - ARM Linux writes: > On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: >> Maybe this one would deserve a doxygen comment ? > > Does this solve it? Oh yes, that's very nice, especially the "1 = in" for which I have always a doubt. Reviewed-by: Robert Jarzmik I hope t

[Bug 88801] SCM PCMCIA CompactFlash Adapter seems not to be recognized

2016-08-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88801 --- Comment #49 from Alan --- The synchronize cache failed is unrelated - it may even be a drive firmware funny, and in the cases you hot unplug the card I'd expect to see it in the trace anyway. I'll get the pflags patch upstreamed ASAP -- You

[Bug 88801] SCM PCMCIA CompactFlash Adapter seems not to be recognized

2016-08-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88801 --- Comment #48 from Elmar Stellnberger --- Created attachment 231431 --> https://bugzilla.kernel.org/attachment.cgi?id=231431&action=edit dmesg with the proposed fix: issue resolved / no backtrace Yes, that in deed does resolve the issue (no b

[Bug 88801] SCM PCMCIA CompactFlash Adapter seems not to be recognized

2016-08-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=88801 --- Comment #47 from Alan --- I'll submit the patch for the flags one once Elmar confirms its a fix. -- You are receiving this mail because: You are the assignee for the bug. ___ Linux PCMCIA reimplem

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > Maybe this one would deserve a doxygen comment ? Does this solve it? diff --git a/drivers/gpio/gpio-reg.c b/drivers/gpio/gpio-reg.c index fc7e0a395f9f..b91488ec122c 100644 --- a/drivers/gpio/gpio-reg.c +++ b/drivers/gpio/gpio-reg.c

Re: [PATCH 05/33] gpio: add generic single-register fixed-direction GPIO driver

2016-08-30 Thread Russell King - ARM Linux
On Tue, Aug 30, 2016 at 09:08:03AM +0300, Alexander Shiyan wrote: > >Вторник, 30 августа 2016, 2:12 +03:00 от Russell King - ARM Linux > >: > > > >On Mon, Aug 29, 2016 at 09:39:54PM +0200, Robert Jarzmik wrote: > >> Hi Russell, > >> > >> Russell King < rmk+ker...@armlinux.org.uk > writes: > >> >