[PATCH 3/9] drivers/infiniband: Fix continuation lines

2010-03-26 Thread Joe Perches
Signed-off-by: Joe Perches --- drivers/infiniband/hw/nes/nes_nic.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c index 91fdde3..9963676 100644 --- a/drivers/infiniband/hw/nes/nes_nic.c +++ b

[PATCH 09/36] drivers/infiniband: Remove unnecessary casts of private_data

2010-07-12 Thread Joe Perches
Signed-off-by: Joe Perches --- drivers/infiniband/hw/ipath/ipath_file_ops.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/ipath/ipath_file_ops.c b/drivers/infiniband/hw/ipath/ipath_file_ops.c index 9c5c66d..65eb892 100644 --- a/drivers

[PATCH 02/13] drivers/infiniband: Remove unnecessary casts of private_data

2010-09-04 Thread Joe Perches
Signed-off-by: Joe Perches --- drivers/infiniband/hw/qib/qib_file_ops.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_file_ops.c b/drivers/infiniband/hw/qib/qib_file_ops.c index 6b11645..cef5d67 100644 --- a/drivers/infiniband/hw/qib

[PATCH 07/11] drivers/infiniband: Remove pr_ uses of KERN_

2010-09-11 Thread Joe Perches
Signed-off-by: Joe Perches --- drivers/infiniband/hw/amso1100/c2_intr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/amso1100/c2_intr.c b/drivers/infiniband/hw/amso1100/c2_intr.c index 3b50954..0ebe4e8 100644 --- a/drivers/infiniband/hw

[PATCH 04/10] drivers/infiniband: Remove unnecessary KERN_ uses

2010-10-25 Thread Joe Perches
Signed-off-by: Joe Perches --- drivers/infiniband/hw/amso1100/c2_intr.c |4 ++-- drivers/infiniband/hw/cxgb3/iwch_cm.c|4 ++-- drivers/infiniband/hw/cxgb4/cm.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/amso1100/c2_intr.c

[PATCH 00/10] Remove multiple uses of KERN_

2010-10-25 Thread Joe Perches
Found using strings vmlinux | grep "^<.>.*<.>" and a couple of other cleanups of logging message format strings. Joe Perches (10): arch/x86/kernel/apic/io_apic.c: Typo fix WARNING drivers/atm/eni.c: Remove multiple uses of KERN_ drivers/hid/hid-input.c: Remove KERN_

[PATCH 12/49] drivers/infiniband: Use vzalloc

2010-11-04 Thread Joe Perches
Signed-off-by: Joe Perches --- drivers/infiniband/hw/amso1100/c2_rnic.c |5 ++--- drivers/infiniband/hw/ehca/ipz_pt_fn.c|5 ++--- drivers/infiniband/hw/ipath/ipath_driver.c|3 +-- drivers/infiniband/hw/ipath/ipath_file_ops.c | 11 +++ drivers/infiniband/hw

[PATCH 00/14] Use printf extension %pR for struct resource

2010-11-12 Thread Joe Perches
Yet more trivia... Joe Perches (14): arch/frv: Use printf extension %pR for struct resource arch/mips: Use printf extension %pR for struct resource arch/powerpc: Use printf extension %pR for struct resource drivers/dma/ppc4xx: Use printf extension %pR for struct resource drivers

[PATCH 05/14] drivers/infiniband: Use printf extension %pR for struct resource

2010-11-12 Thread Joe Perches
Using %pR standardizes the struct resource output. Signed-off-by: Joe Perches --- drivers/infiniband/hw/ipath/ipath_driver.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/ipath/ipath_driver.c b/drivers/infiniband/hw/ipath/ipath_driver.c

Re: [RFC 1/3] RDMA: Add netlink infrastructure

2011-05-13 Thread Joe Perches
On Fri, 2011-05-13 at 09:18 -0700, Roland Dreier wrote: > From: Roland Dreier > [Dave please do not apply even if this ends up in netdev patchwork!] Just trivia: > diff --git a/drivers/infiniband/core/netlink.c > b/drivers/infiniband/core/netlink.c [] > +#define pr_fmt(fmt) "%s:%s: " fmt, KBUIL

Re: [RFC 1/3] RDMA: Add netlink infrastructure

2011-05-13 Thread Joe Perches
On Fri, 2011-05-13 at 19:18 +0200, Bart Van Assche wrote: > On Fri, May 13, 2011 at 6:44 PM, Joe Perches wrote: > > On Fri, 2011-05-13 at 09:18 -0700, Roland Dreier wrote: > >> From: Roland Dreier > >> [Dave please do not apply even if this ends up in netdev patchwork!

Re: [RFC 1/3] RDMA: Add netlink infrastructure

2011-05-13 Thread Joe Perches
On Fri, 2011-05-13 at 20:12 +0200, Bart Van Assche wrote: > On Fri, May 13, 2011 at 7:36 PM, Joe Perches wrote: > > On Fri, 2011-05-13 at 19:18 +0200, Bart Van Assche wrote: > > One long term goal for me is a generic run-time mechanism > > to prefix all pr_ uses not just the

Re: [PATCH] [Trivial] qib: fix an incorrect message

2012-07-19 Thread Joe Perches
On Thu, 2012-07-19 at 13:34 -0600, Betty Dall wrote: > There is a cut and paste typo in the function qib_pci_slot_reset() where > it prints that the "link_reset" function is called rather than the > "slot_reset" function. This makes the message misleading. Hi Betty. > diff --git a/drivers/infinib

Re: [PATCH] [Trivial] qib: fix an incorrect message

2012-07-19 Thread Joe Perches
On Thu, 2012-07-19 at 12:56 -0600, Betty Dall wrote: > Thanks for the comment Joe. It looks like Roland already accepted the > trivial change. No worries. > On Thu, 2012-07-19 at 11:03 -0700, Joe Perches wrote: > > On Thu, 2012-07-19 at 13:34 -0600, Betty Dall wrote: [] >

[PATCH net-next 00/21] treewide: Use consistent api style for address testing

2012-10-18 Thread Joe Perches
*) ipv4_addr_(__be32) ipv6_addr_(const struct in6_addr *) Add temporary backward compatibility #defines for the old names too. Joe Perches (21): etherdevice: Rename is__ether_addr tests to eth_addr_ net: Convert is__ether_addr uses to eth_addr_ arch: Convert is__ether_addr uses to eth_addr_

Re: [PATCH] tile: revert pr_info to printk in

2013-02-01 Thread Joe Perches
On Fri, 2013-02-01 at 12:34 -0500, Chris Metcalf wrote: > Using pr_info in a header exposes us to potential trouble from > subsystems that define pr_fmt. This change fixes: > > In file included from include/linux/scatterlist.h:10, >from include/scsi/scsi.h:12, >

[Trivial PATCH 11/33] infiniband: Convert use of typedef ctl_table to struct ctl_table

2013-06-13 Thread Joe Perches
This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/infiniband/core/ucma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 5ca44cd..9416280 100644 --- a/drivers

[Trivial PATCH 00/33] Remove uses of typedef ctl_table

2013-06-13 Thread Joe Perches
It's clearer to use struct ctl_table instead Joe Perches (33): arm: kernel: isa: Convert use of typedef ctl_table to struct ctl_table frv: Convert use of typedef ctl_table to struct ctl_table ia64: crash: Convert use of typedef ctl_table to struct ctl_table mips: lasat: sysctl: Co

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2011-12-20 Thread Joe Perches
On Wed, 2011-12-21 at 01:32 +, Ben Hutchings wrote: > Physical addresses may be wider than virtual addresses (e.g. on i386 > with PAE) and must not be formatted with %p. [] > The resource could alternately be formatted with %Pr. > diff --git a/drivers/infiniband/hw/cxgb4/device.c > b/drivers/i

[trivial PATCH] treewide: Add __GFP_NOWARN to k.alloc calls with v.alloc fallbacks

2013-06-19 Thread Joe Perches
Don't emit OOM warnings when k.alloc calls fail when there there is a v.alloc immediately afterwards. Converted a kmalloc/vmalloc with memset to kzalloc/vzalloc. Signed-off-by: Joe Perches --- drivers/block/drbd/drbd_bitmap.c | 2 +- drivers/infiniband/hw/ehca/ipz_pt

Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

2013-07-01 Thread Joe Perches
On Mon, 2013-07-01 at 10:49 -0700, Roland Dreier wrote: > So I'm inclined to apply the mlx5 driver for 3.11, since it's a > completely new driver. However, reading through it so far I had the > following comments, and I'd like these cleanups addressed along with > Dave Miller's: > > - The debug m

Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

2013-07-01 Thread Joe Perches
On Mon, 2013-07-01 at 11:11 -0700, Roland Dreier wrote: > On Mon, Jul 1, 2013 at 11:03 AM, Joe Perches wrote: > > There's some value in block enabling/disabling messages > > that dynamic_debug doesn't currently offer. > > As far as I can see, the mlx5 stuff

Re: [PATCH for-next 0/8] Add Mellanox mlx5 driver for Connect-IB devices

2013-07-01 Thread Joe Perches
On Mon, 2013-07-01 at 14:20 -0700, Roland Dreier wrote: > On Mon, Jul 1, 2013 at 1:19 PM, Joe Perches wrote: > > I think these are the groupings. > > > > +enum { > > + MLX5_MOD_MAIN, > > + MLX5_MOD_CMDIF, > > + MLX5_MOD_EQ, > > +

Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-03 Thread Joe Perches
On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > From: Eli Cohen trivial comments: > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c > b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c [] > +static const char *deliv_status_to_str(u8 status) > +{ > + switch (status) { > +

Re: [PATCH V2 5/9] IB/mlx5: Mellanox Connect-IB, IB driver part 1/5

2013-07-03 Thread Joe Perches
On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > From: Eli Cohen more trivia: > diff --git a/drivers/infiniband/hw/mlx5/ah.c b/drivers/infiniband/hw/mlx5/ah.c [] > +struct ib_ah *create_ib_ah(struct ib_ah_attr *ah_attr, > +struct mlx5_ib_ah *ah) > +{ > + u32 sgi

Re: [PATCH V2 7/9] IB/mlx5: Mellanox Connect-IB, IB driver part 3/5

2013-07-03 Thread Joe Perches
On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > From: Eli Cohen More trivia: > diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h > b/drivers/infiniband/hw/mlx5/mlx5_ib.h [] > +#define mlx5_ib_dbg(dev, format, arg...) \ > +do {

Re: [PATCH V2 1/9] net/mlx5: Mellanox Connect-IB, core driver part 1/3

2013-07-04 Thread Joe Perches
On Thu, 2013-07-04 at 16:26 +0300, Jack Morgenstein wrote: > On Wednesday 03 July 2013 23:29, Joe Perches wrote: > > On Wed, 2013-07-03 at 20:13 +0300, Or Gerlitz wrote: > > > From: Eli Cohen > > > > trivial comments: > > > > > diff --git a/drivers/n

Re: [trivial PATCH] treewide: Add __GFP_NOWARN to k.alloc calls with v.alloc fallbacks

2013-07-26 Thread Joe Perches
On Wed, 2013-06-19 at 12:15 -0700, Joe Perches wrote: > Don't emit OOM warnings when k.alloc calls fail when > there there is a v.alloc immediately afterwards. > > Converted a kmalloc/vmalloc with memset to kzalloc/vzalloc. Hey Jiri. What's your schedule for accepting or

[PATCH] iscsi_iser: Add missing newlines to logging messages

2013-10-07 Thread Joe Perches
Logging messages need terminating newlines to avoid possible message interleaving. Add them. Signed-off-by: Joe Perches --- drivers/infiniband/ulp/iser/iscsi_iser.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.c b/drivers

[Trivial PATCH] infiniband: Remove unnecessary semicolons

2013-10-08 Thread Joe Perches
These aren't necessary after switch blocks. Signed-off-by: Joe Perches --- drivers/infiniband/hw/amso1100/c2_ae.c | 2 +- drivers/infiniband/hw/mthca/mthca_eq.c | 2 +- drivers/infiniband/hw/ocrdma/ocrdma_hw.c| 6 +++--- drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 +- dr

[PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table

2013-10-22 Thread Joe Perches
Joe Perches (24): arm: Convert use of typedef ctl_table to struct ctl_table ia64: Convert use of typedef ctl_table to struct ctl_table s390: Convert use of typedef ctl_table to struct ctl_table tile: Convert use of typedef ctl_table to struct ctl_table cdrom: Convert use of typedef

[PATCH 07/24] infiniband: Convert use of typedef ctl_table to struct ctl_table

2013-10-22 Thread Joe Perches
This typedef is unnecessary and should just be removed. Signed-off-by: Joe Perches --- drivers/infiniband/core/ucma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index b0f189b..3f93093 100644 --- a/drivers

Re: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table

2013-10-22 Thread Joe Perches
On Tue, 2013-10-22 at 16:53 -0700, David Daney wrote: > After all this work, why not go ahead and remove the typedef? That way > people won't add more users of this abomination. Hi David. The typedef can't be removed until all the uses are gone. I've sent this before as a single large patch as

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: > Physical addresses may be wider than virtual addresses (e.g. on i386 > with PAE) and must not be formatted with %p. %pa works. %pa also prefixes with 0x. > diff --git a/drivers/infiniband/hw/cxgb4/device.c > b/drivers/infiniband/hw/cxgb4

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 22:02 +, Ben Hutchings wrote: > On Sun, 2013-10-27 at 14:58 -0700, Joe Perches wrote: > > On Sun, 2013-10-27 at 21:50 +, Ben Hutchings wrote: > > > Physical addresses may be wider than virtual addresses (e.g. on i386 > > > with PAE) and mu

Re: [PATCH 1/8] IB/cxgb4: Fix formatting of physical address

2013-10-27 Thread Joe Perches
On Sun, 2013-10-27 at 22:26 +, Ben Hutchings wrote: > I don't think so. This doesn't find anything: > git grep '&[ (]*pci_resource_start' > and I was able to build drivers/{net,pci,scsi}/ successfully with > pci_resource_start() changed to an inline function. Hi again Ben. You're right.

Re: [PATCHv3 net-next 03/31] cxgb4: Rectify emitting messages about SGE Ingress DMA channels being potentially stuck

2014-03-04 Thread Joe Perches
On Tue, 2014-03-04 at 18:11 +0530, Hariprasad Shenai wrote: > From: Kumar Sanghvi > > Based on original work by Casey Leedom trivial comments: > diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c > b/drivers/net/ethernet/chelsio/cxgb4/sge.c > @@ -2031,21 +2041,65 @@ static void sge_rx_tim

[PATCH net-next] chelsio: Use more current logging style

2014-03-04 Thread Joe Perches
On Tue, 2014-03-04 at 23:22 +0300, Sergei Shtylyov wrote: > On 03/04/2014 08:43 PM, Joe Perches wrote: > >> From: Kumar Sanghvi > >> + CH_WARN(adap, "SGE idma%u, queue%u, maybe stuck state%u %dsecs" > >> + " (debug0=%#x,

Re: [PATCHv5 net-next 15/31] iw_cxgb4: save the correct map length for fast_reg_page_lists

2014-03-10 Thread Joe Perches
On Mon, 2014-03-10 at 23:43 +0300, Sergei Shtylyov wrote: > Hello. > > On 03/10/2014 08:08 PM, Hariprasad Shenai wrote: > > From: Steve Wise > > We cannot save the mapped length using the rdma max_page_list_len field > > of the ib_fast_reg_page_list struct because the core code uses it. This > >

[PATCH -next 00/26] treewide: Use dma_zalloc_coherent

2014-06-15 Thread Joe Perches
Use the zeroing function instead of dma_alloc_coherent & memset(,0,) Joe Perches (26): powerpc: Use dma_zalloc_coherent sh: Use dma_zalloc_coherent ata: Use dma_zalloc_coherent block: Use dma_zalloc_coherent crypto: Use dma_zalloc_coherent dma: Use dma_zalloc_coherent gpu:

[PATCH -next 08/26] infiniband: Use dma_zalloc_coherent

2014-06-15 Thread Joe Perches
Use the zeroing function instead of dma_alloc_coherent & memset(,0,) Signed-off-by: Joe Perches --- drivers/infiniband/hw/cxgb3/cxio_hal.c | 7 +++ drivers/infiniband/hw/mthca/mthca_memfree.c | 5 ++--- drivers/infiniband/hw/ocrdma/ocrdma_hw.c| 20 dri

[PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. Joe Perches (22): pci-dma-compat: Add pci_zalloc_consistent helper atm

[PATCH 05/22] infiniband: Use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
Remove the now unnecessary memset too. Signed-off-by: Joe Perches --- drivers/infiniband/hw/amso1100/c2.c | 6 ++ drivers/infiniband/hw/nes/nes_hw.c| 12 ++-- drivers/infiniband/hw/nes/nes_verbs.c | 5 ++--- 3 files changed, 10 insertions(+), 13 deletions(-) diff --git a

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote: > On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: > > Adding the helper reduces object code size as well as overall > > source size line count. > > > > It's also consistent with all the vari

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Joe Perches
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > We should prefer `const struct pci_device_id` over > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl

Re: [PATCH net-next 1/5] RDMA/cxgb4: Cleanup Filter related macros/register defines

2014-11-21 Thread Joe Perches
On Fri, 2014-11-21 at 12:52 +0530, Hariprasad Shenai wrote: > This patch cleanups all filter related macros/register defines that are > defined > in t4fw_api.h and the affected files. Is there any real value in the FW_FILTER_WR_ prefix? Does it need to be so long? Perhaps it'd be nicer to read i

Re: [PATCH 02/15] i40iw: add main, hdr, status

2015-12-16 Thread Joe Perches
On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > i40iw_main.c contains routines for i40e <=> i40iw interface and setup. > i40iw.h is header file for main device data structures. > i40iw_status.h is for return status codes. [] > diff --git a/drivers/infiniband/hw/i40iw/i40iw.h > b/drivers/i

Re: [PATCH 01/15] i40e: Add support for client interface for IWARP driver

2015-12-16 Thread Joe Perches
On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > From: Anjali Singhai Jain > > This patch adds a Client interface for i40iw driver > support. Also expands the Virtchannel to support messages > from i40evf driver on behalf of i40iwvf driver. [] > diff --git a/drivers/net/ethernet/intel/i40

Re: [PATCH 00/15] add Intel(R) X722 iWARP driver

2015-12-16 Thread Joe Perches
On Wed, 2015-12-16 at 13:58 -0600, Faisal Latif wrote: > This series contains the addition of the i40iw.ko driver. This series should probably be respun against -next instead of linus' tree. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to major