Re: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-10-01 Thread Pradeep Satyanarayana
On 9/30/2010 5:35 PM, Ralph Campbell wrote: > I was looking at the Rx connection tear down and found a bug. > I don't know if it would cause this panic but you might try it. > I haven't stress tested it but it compiles and basic network > connections work. > > I also don't like the call to cancel_

Re: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-09-30 Thread Ralph Campbell
I was looking at the Rx connection tear down and found a bug. I don't know if it would cause this panic but you might try it. I haven't stress tested it but it compiles and basic network connections work. I also don't like the call to cancel_delayed_work(&priv->cm.stale_task) at the end of ipoib_c

RE: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-09-03 Thread Ralph Campbell
ght exist. From: Pradeep Satyanarayana [prade...@linux.vnet.ibm.com] Sent: Thursday, September 02, 2010 8:41 PM To: Ralph Campbell Cc: Roland Dreier; linux-rdma@vger.kernel.org Subject: Re: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and i

Re: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-09-02 Thread Pradeep Satyanarayana
Ralph, I see the following crash sporadically (only under stress) with a Sles11SP1 (which is 2.6.32 kernel). I saw this crash with V4 of your patch and have not yet had a chance to try V5. Have you seen this in your testing? If this not the crash stack can you please share what your patch fixes

[PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-08-17 Thread Ralph Campbell
Basically, a struct sk_buff has a pointer to a struct dst_entry which has a pointer to a struct neighbour. IPoIB uses struct neighbour.ha to store the IB "hardware address" and a pointer to a struct ipoib_neigh. When using connected mode, struct ipoib_neigh has a pointer to struct ipoib_cm_tx which