Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-22 Thread Doug Ledford
On Wed, 2015-01-21 at 12:37 -0800, Roland Dreier wrote: On Wed, Jan 21, 2015 at 12:34 PM, Or Gerlitz gerlitz...@gmail.com wrote: Because Doug's changes fixed some bad, easy-to-reproduce issues. On the other hand we don't want to introduce new regressions to fix the old issues. See

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Roland Dreier
On Tue, Jan 20, 2015 at 8:16 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: After trying your V4 patch series, I can tell that first, the endless scheduling of the mcast task is indeed over, but still, the multicast functionality in ipoib is unstable. Is this worse than 3.18? (Have you

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Doug Ledford
It's worse than 3.18, but only if your test is rmmod ipoib based. For normal running conditions it's better. However, I'm going to try and fix the rmmod issue today if at all possible. Sent from my iPhone On Jan 21, 2015, at 12:20 PM, Roland Dreier rol...@kernel.org wrote: On Tue, Jan 20,

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Doug Ledford
On Wed, 2015-01-21 at 12:37 -0800, Roland Dreier wrote: On Wed, Jan 21, 2015 at 12:34 PM, Or Gerlitz gerlitz...@gmail.com wrote: Because Doug's changes fixed some bad, easy-to-reproduce issues. On the other hand we don't want to introduce new regressions to fix the old issues. See

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Or Gerlitz
On Wed, Jan 21, 2015 at 7:19 PM, Roland Dreier rol...@kernel.org wrote: On Tue, Jan 20, 2015 at 8:16 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: After trying your V4 patch series, I can tell that first, the endless scheduling of the mcast task is indeed over, but still, the multicast

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Or Gerlitz
On Wed, Jan 21, 2015 at 10:37 PM, Roland Dreier rol...@kernel.org wrote: On Wed, Jan 21, 2015 at 12:34 PM, Or Gerlitz gerlitz...@gmail.com wrote: Because Doug's changes fixed some bad, easy-to-reproduce issues. On the other hand we don't want to introduce new regressions to fix the old

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Doug Ledford
On Wed, 2015-01-21 at 22:34 +0200, Or Gerlitz wrote: On Wed, Jan 21, 2015 at 7:19 PM, Roland Dreier rol...@kernel.org wrote: On Tue, Jan 20, 2015 at 8:16 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: After trying your V4 patch series, I can tell that first, the endless scheduling

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Roland Dreier
On Wed, Jan 21, 2015 at 12:34 PM, Or Gerlitz gerlitz...@gmail.com wrote: Because Doug's changes fixed some bad, easy-to-reproduce issues. On the other hand we don't want to introduce new regressions to fix the old issues. See above, we did introduced regressions. Yes, I know, that's my

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-20 Thread Doug Ledford
On Tue, 2015-01-20 at 18:16 +0200, Erez Shitrit wrote: On 1/20/2015 5:58 AM, Doug Ledford wrote: These patches are to resolve issues created by my previous patch set. While that set worked fine in my testing, there were problems with multicast joins after the initial set of joins had

[PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-19 Thread Doug Ledford
These patches are to resolve issues created by my previous patch set. While that set worked fine in my testing, there were problems with multicast joins after the initial set of joins had completed. Since my testing relied upon the normal set of multicast joins that happen when the interface is