Hi Geert,
On 20/02/17 20:45, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Mon, Feb 20, 2017 at 6:47 PM, Kieran Bingham
> wrote:
>> This change breaks POSIX SH compliance, as reported by shellcheck:
>>
>> In scripts/bin2png.sh line 7:
>> local pnm=${file/%bin/pnm}
>> ^-
Hi Kieran,
On Mon, Feb 20, 2017 at 6:47 PM, Kieran Bingham
wrote:
> This change breaks POSIX SH compliance, as reported by shellcheck:
>
> In scripts/bin2png.sh line 7:
> local pnm=${file/%bin/pnm}
> ^-- SC2039: In POSIX sh, string replacement is not
> supported.
>
>
>
Hi Laurent,
Thanks for your integration and cleanups.
One issue arisen to resolve:
On 13/02/17 14:03, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday 01 Dec 2016 21:31:46 Kieran Bingham wrote:
>> From: Kieran Bingham
>>
>> Identify the size and format from th
Hi Geert,
On Monday 13 Feb 2017 15:17:10 Geert Uytterhoeven wrote:
> On Mon, Feb 13, 2017 at 3:03 PM, Laurent Pinchart wrote:
> >> +PNM=$(echo $FILE | sed -e 's|\.bin$|.pnm|')
> >
> > You can write this as
> >
> > PNM=${FILE/.bin/.pnm}
>
> / doesn't just match the suffix, try with waste.bin.pic
Hi Laurent,
On Mon, Feb 13, 2017 at 3:03 PM, Laurent Pinchart
wrote:
>> +PNM=$(echo $FILE | sed -e 's|\.bin$|.pnm|')
>
> You can write this as
>
> PNM=${FILE/.bin/.pnm}
/ doesn't just match the suffix, try with waste.bin.picture.bin :-)
PNM=${FILE%.bin}.pnm
Gr{oetje,eeting}s,
Hi Kieran,
Thank you for the patch.
On Thursday 01 Dec 2016 21:31:46 Kieran Bingham wrote:
> From: Kieran Bingham
>
> Identify the size and format from the test output filename, and pass
> to raw2rgbpnm for conversion to a PNM file.
>
> From there we can convert easily to a PNG output file.
>
From: Kieran Bingham
Identify the size and format from the test output filename, and pass
to raw2rgbpnm for conversion to a PNM file.
>From there we can convert easily to a PNG output file.
Signed-off-by: Kieran Bingham
---
v2:
- use 'convert' to proces png files to png
- strip '.bin' from t