Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
On 18 October 2011 11:17, Chris Ball wrote: > Hi, > > On Tue, Oct 18 2011, Jaehoon Chung wrote: >> Hi Girish. >> >> This patch is merged on mmc-next..did you know that? >> And if deleted commit id bd3151f6c55c553bed2c0df72792841457b75bb5, >> I will re-work for eMMC feature4.5. >> git://git.infrade

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
On 18 October 2011 11:07, Jaehoon Chung wrote: > Hi Girish. > > I know you're worked based-on latest mmc-next. > But this patch is already merged on mmc-next... > > Merged patch is already included #define MMC_CAP2_CACHE_CTRL and > EXT_CSD_FLUSH_CACHE. > > So i didn't add them in [mmc: core: Add

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Chris Ball
Hi, On Tue, Oct 18 2011, Jaehoon Chung wrote: > Hi Girish. > > This patch is merged on mmc-next..did you know that? > And if deleted commit id bd3151f6c55c553bed2c0df72792841457b75bb5, > I will re-work for eMMC feature4.5. > git://git.infradead.org/users/kmpark/linux-2.6-samsung emmc4.5 > > To Chr

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Jaehoon Chung
Hi Girish. I know you're worked based-on latest mmc-next. But this patch is already merged on mmc-next... Merged patch is already included #define MMC_CAP2_CACHE_CTRL and EXT_CSD_FLUSH_CACHE. So i didn't add them in [mmc: core: Add cache control for eMMC4.5 device] on the below repository git:

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
On 18 October 2011 10:49, Girish K S wrote: > On 18 October 2011 10:46, Jaehoon Chung wrote: >> Hi Girish. >> >> This patch is merged on mmc-next..did you know that? >> And if deleted commit id bd3151f6c55c553bed2c0df72792841457b75bb5, >> I will re-work for eMMC feature4.5. >> git://git.infradead

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
On 18 October 2011 10:46, Jaehoon Chung wrote: > Hi Girish. > > This patch is merged on mmc-next..did you know that? > And if deleted commit id bd3151f6c55c553bed2c0df72792841457b75bb5, > I will re-work for eMMC feature4.5. > git://git.infradead.org/users/kmpark/linux-2.6-samsung emmc4.5 > > To Ch

Re: [PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Jaehoon Chung
Hi Girish. This patch is merged on mmc-next..did you know that? And if deleted commit id bd3151f6c55c553bed2c0df72792841457b75bb5, I will re-work for eMMC feature4.5. git://git.infradead.org/users/kmpark/linux-2.6-samsung emmc4.5 To Chris. If you re-commit this patch, i also change "git pull requ

Re: [PATCH] mmc: core: Modify the timeout value for writing power class

2011-10-17 Thread Chris Ball
Hi, On Tue, Oct 18 2011, Seungwon Jeon wrote: > This patch will apply the generic CMD6 timeout to switch command > for power class. > > Signed-off-by: Seungwon Jeon Thanks, applied to mmc-next for 3.2. - Chris. -- Chris Ball One Laptop Per Child -- To unsubscribe from

[PATCH V9] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
This patch adds the support for power off notify feature, available in eMMC 4.5 devices. If the the host has support for this feature, then the mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON). For suspend mode s

[PATCH] mmc: core: Modify the timeout value for writing power class

2011-10-17 Thread Seungwon Jeon
This patch will apply the generic CMD6 timeout to switch command for power class. Signed-off-by: Seungwon Jeon --- drivers/mmc/core/mmc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index f8ea938..d19440d 100644 --- a/

RE: [PATCH V8] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Seungwon Jeon
Base code of V8 may be mixed. Please check below for next resending. It seems like unrelated. #define MMC_CAP2_CACHE_CTRL (1 << 1) #define EXT_CSD_FLUSH_CACHE 32 Best regards, Seungwon Jeon. Girish K S wrote: > This patch adds the support for power off notify feature, available i

Re: [PATCH V8 RESEND] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
On 17 October 2011 20:17, Girish K S wrote: > This patch adds the support for power off notify feature, available in > eMMC 4.5 devices. If the the host has support for this feature, then the > mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION > byte in the extended csd r

[PATCH V8 RESEND] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
This patch adds the support for power off notify feature, available in eMMC 4.5 devices. If the the host has support for this feature, then the mmc core will notify it to the device by setting the POWER_OFF_NOTIFICATION byte in the extended csd register with a value 1(POWER_ON). For suspend mode s

Re: [PATCH V8] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Chris Ball
Hi, On Mon, Oct 17 2011, Girish K S wrote: > After fetching your mmc-next branch. i can see that this patch is > already applied. How about the changes that have been pointed here? Thanks, it's in mmc-next for testing -- please do resend the patch and I'll fold in your changes. - Chris. -- Chri

Re: [PATCH V8] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Girish K S
On 17 October 2011 18:17, Chris Ball wrote: > Hi Girish, > > On Mon, Oct 17 2011, Girish K S wrote: + if (card != NULL && mmc_card_mmc(card) && >>> >>> != NULL is unnecessary. >> >> This is required. Let me explain the scenario where i felt it is necessary. > > I'm not saying that you shouldn

Re: [PATCH V8] mmc: core: Add Power Off Notify Feature eMMC 4.5

2011-10-17 Thread Chris Ball
Hi Girish, On Mon, Oct 17 2011, Girish K S wrote: >>> + if (card != NULL && mmc_card_mmc(card) && >> >> != NULL is unnecessary. > > This is required. Let me explain the scenario where i felt it is necessary. I'm not saying that you shouldn't test whether card is NULL -- I'm saying that "if (card