RE: [PATCH V2 RE-SEND 0/7] add new Samsung SXGbE driver

2014-03-15 Thread Andrew.an
David Miller wrote: > From: Byungho An > Date: Thu, 13 Mar 2014 15:55:28 +0900 > > > This is 2nd posting for Samsung SXGbE driver and just re-sending because > of > > line wrapping in previous posting. > > > > Changes since v1: > > - changed name of driver to SXGbE as per Ben's comment > > - squ

RE: [PATCH V2 RE-SEND 1/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-15 Thread Andrew.an
Francois Romieu > Byungho An : > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > - sxgbe core initialization > > - Tx and Rx support > > - MDIO support > > - ISRs for Tx and Rx > > - ifconfig support to driver > > You'll find a partial review belo

Re: [PATCH 1/2] watchdog: s3c2410_wdt: Remove unneeded initialization

2014-03-15 Thread Wim Van Sebroeck
Hi Sachin, > Initializing clk to NULL as a reset/error condition does not > help as NULL is not an invalid condition w.r.t clk. Remove this > initialization altogether as there is no state retention. > > Signed-off-by: Sachin Kamat > --- > drivers/watchdog/s3c2410_wdt.c |2 -- > 1 file chan

Re: [PATCH 2/2] watchdog: s3c2410_wdt: Check return value of clk_prepare_enable

2014-03-15 Thread Wim Van Sebroeck
Hi Sachin, > clk_prepare_enable can fail. Check its return value. > > Signed-off-by: Sachin Kamat > --- > drivers/watchdog/s3c2410_wdt.c |6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c > index a0f8

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-15 Thread Tomasz Figa
On 15.03.2014 12:36, Kyungmin Park wrote: On Sat, Mar 15, 2014 at 2:35 AM, Tomasz Figa wrote: Hi Chanwoo, Mark, On 14.03.2014 11:56, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 07:35 PM, Mark Rutland wrote: On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03/14

Re: [PATCHv2 8/8] devfreq: exynos4: Add busfreq driver for exynos4210/exynos4x12

2014-03-15 Thread Kyungmin Park
On Sat, Mar 15, 2014 at 2:35 AM, Tomasz Figa wrote: > Hi Chanwoo, Mark, > > > On 14.03.2014 11:56, Chanwoo Choi wrote: >> >> Hi Mark, >> >> On 03/14/2014 07:35 PM, Mark Rutland wrote: >>> >>> On Fri, Mar 14, 2014 at 07:14:37AM +, Chanwoo Choi wrote: Hi Mark, On 03/14/2014 0