Re: [PATCH] iommu/exynos: Remove driver

2014-03-09 Thread KyongHo Cho
Mon, Feb 10, 2014 at 10:21 PM, Kukjin Kim wrote: >>> >>> > Just adding KyongHo Cho. >>> > >>> > If he can fixup for this time, it would be best solution because he knows >>> > well than others, I think. >>> >>> It's

Re: [PATCH v6 05/12] iommu/exynos: support for device tree

2013-02-01 Thread KyongHo Cho
On Fri, Feb 1, 2013 at 10:51 PM, Joerg Roedel wrote: > Cho, > > On Wed, Jan 02, 2013 at 02:53:49PM +0900, KyongHo Cho wrote: >> On Tuesday, January 1, 2013, Sylwester Nawrocki >> > >> > Cc: devicetree-disc...@lists.ozlabs.org > > Since patch 7 of this s

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-16 Thread KyongHo Cho
On Wed, Jan 16, 2013 at 7:53 PM, Will Deacon wrote: > On Wed, Dec 26, 2012 at 01:53:15AM +, Cho KyongHo wrote: >> notice: v6 patch-set is rebased on next/iommu-exynos branch of >> linux-samsung.git. This patch-set does not include 2 patches (05 and 06 >> patches in v5 patch-se) because they a

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-16 Thread KyongHo Cho
On Wed, Jan 9, 2013 at 7:23 AM, Sylwester Nawrocki wrote: > On 01/07/2013 11:45 AM, KyongHo Cho wrote: >>> >>> > The current exynos-iommu(System MMU) driver does not work autonomously >>> > since it is lack of support for power management of peripheral blocks.

Re: [RESEND][PATCH] ARM: Exynos4: fixed SYSMMU setup definition to mate parameter name

2012-08-27 Thread KyongHo Cho
On Mon, Aug 27, 2012 at 4:11 PM, Seung-Woo Kim wrote: > This is trivial patch to mate parameter name between iommu api enabled case > and > disabled case. > > Signed-off-by: Seung-Woo Kim > Signed-off-by: Kyungmin Park > --- > Sorry about typo in previous patch. > > arch/arm/mach-exynos/includ

Re: [PATCH 0/2] Exynos: fix SYSMMU driver to work with power domains

2012-04-16 Thread KyongHo Cho
On Mon, Apr 16, 2012 at 7:01 PM, Kyungmin Park wrote: > On 4/16/12, KyongHo Cho wrote: >> On Sun, Apr 15, 2012 at 12:51 AM, Kukjin Kim wrote: >>> On 04/12/12 01:19, KyongHo Cho wrote: >>>> >>>> On Wed, Apr 11, 2012 at 11:34 PM, Marek Szyprowski >&

Re: [PATCH 2/2] ARM: Exynos4: update SYSMMU setup code for gen_pd power domain driver

2012-04-16 Thread KyongHo Cho
On Wed, Apr 11, 2012 at 11:34 PM, Marek Szyprowski wrote: > SYSMMU platform devices must be registered before setting up power > domains to let power domain driver to correctly register also SYSMMU > controller devices. This patch also registers SYSMMU controller devices > to respective power doma

Re: [PATCH 0/2] Exynos: fix SYSMMU driver to work with power domains

2012-04-16 Thread KyongHo Cho
On Sun, Apr 15, 2012 at 12:51 AM, Kukjin Kim wrote: > On 04/12/12 01:19, KyongHo Cho wrote: >> >> On Wed, Apr 11, 2012 at 11:34 PM, Marek Szyprowski >>  wrote: >>> >>> Hi! >>> >>> These two patches fixes operation of the SYSMMU driver (v1

Re: [PATCH 0/2] Exynos: fix SYSMMU driver to work with power domains

2012-04-12 Thread KyongHo Cho
On Wed, Apr 11, 2012 at 11:34 PM, Marek Szyprowski wrote: > Hi! > > These two patches fixes operation of the SYSMMU driver (v12 version [1]) > with the new power domain driver based on generic power domains and > runtime pw, which has been merged to Linux kernel v3.4-rc1. > Thanks, Marek. Your wa

Re: [PATCH v12 2/3] ARM: EXYNOS: Change System MMU platform device definitions

2012-03-28 Thread KyongHo Cho
On Thu, Mar 29, 2012 at 10:23 AM, Kukjin Kim wrote: > Joerg Roedel wrote: >> >> On Fri, Mar 16, 2012 at 01:47:50PM -0700, Kukjin Kim wrote: >>> >>> Anyway Joerg, how do you want to handle this? Do you want to pick up >>> 1/2/3 all of them in your tree? If so, 2nd patch should be on top of >>> some

Re: [PATCH v12 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-26 Thread KyongHo Cho
ivers/iommu due to Ohad Ben-Cohen gathered IOMMU drivers >> there >> >> Any device driver in Exynos platforms that needs to control its >> System MMU must call platform_set_sysmmu() to inform System MMU >> driver who will control it. >> platform_set_sysmmu() is

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-20 Thread KyongHo Cho
On Tue, Mar 20, 2012 at 10:50 PM, Subash Patel wrote: > Sorry for digging this very late. But as part of integrating dma_map v7 & > sysmmu v12 on 3.3-rc5, I am facing below issue: > > a) By un-selecting IOMMU in menu config, I am able to allocate memory in > vb2-dma-contig > > b) When I enable SYS

Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-13 Thread KyongHo Cho
On Tue, Mar 13, 2012 at 7:00 PM, Joerg Roedel wrote: > On Tue, Mar 13, 2012 at 05:50:16PM +0900, KyongHo Cho wrote: >> >> +struct sysmmu_drvdata { >> >> +     struct device *sysmmu; >> >> +     char *dbgname; >> >> +     int nsfrs; >> >

Re: [PATCH v11 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-13 Thread KyongHo Cho
On Tue, Mar 13, 2012 at 12:01 AM, Joerg Roedel wrote: > On Fri, Mar 09, 2012 at 09:15:24PM +0900, Cho KyongHo wrote: >> +/* We does not consider super section mapping (16MB) */ >> +struct iommu_client { >> +     struct list_head node; >> +     struct device *dev; >> +}; >> + >> +struct exynos_iomm

Re: [PATCH v10 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-06 Thread KyongHo Cho
On Wed, Mar 7, 2012 at 2:28 PM, InKi Dae wrote: >> +static irqreturn_t exynos_sysmmu_irq(int irq, void *dev_id) >> +{ >> +       /* SYSMMU is in blocked when interrupt occurred. */ >> +       struct sysmmu_drvdata *data = dev_id; >> +       struct resource *irqres; >> +       struct platform_devic

Re: [PATCH v10 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-06 Thread KyongHo Cho
On Tue, Mar 6, 2012 at 10:13 PM, Kyungmin Park wrote: > On Tue, Mar 6, 2012 at 5:31 PM, KyongHo Cho wrote: >> HAALgBjAGgAbwBAAHMAYQBtAHMAdQBuAGcALgBjAG8AbQA=;Tue, >>  06 Mar 2012 0

Re: [PATCH v10 2/3] ARM: EXYNOS: Change System MMU platform device definitions

2012-03-06 Thread KyongHo Cho
On Tue, Mar 6, 2012 at 7:03 PM, Kyungmin Park wrote: >> >> -#define S5P_SYSMMU_TOTAL_IPNUM               EXYNOS4_SYSMMU_TOTAL_IPNUM >> +#define SYSMMU_DEVNAME_BASE "exynos-sysmmu" >> + >> +#define SYSMMU_CLOCK_NAME "sysmmu" >> +#define SYSMMU_CLOCK_NAME2 "sysmmu_mc" > What's the meaning of "mc"? I

[PATCH v10 1/3] S5P: SYSMMU: Remove System MMU device driver

2012-03-06 Thread KyongHo Cho
moving the driver file from arch/arm/ to drivers/iommu. Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig |8 - arch/arm/plat-s5p/Makefile |1 - arch/arm/plat-s5p/sysmmu.c | 313 --- arch/arm/plat-samsung

[PATCH v10 3/3] iommu/exynos: Add iommu driver for Exynos Platforms

2012-03-06 Thread KyongHo Cho
-Cohen gathered IOMMU drivers there Any device driver in Exynos platforms that needs to control its System MMU must call platform_set_sysmmu() to inform System MMU driver who will control it. platform_set_sysmmu() is defined in Cc: Joerg Roedel Cc: Kukjin Kim Signed-off-by: KyongHo Cho

[PATCH v10 2/3] ARM: EXYNOS: Change System MMU platform device definitions

2012-03-06 Thread KyongHo Cho
becomes a child if its power domain device. - clkdev Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos/Kconfig| 11 +- arch/arm/mach-exynos/Makefile |2 +- arch/arm/mach-exynos/clock-exynos4.c| 79 ++-- arch/arm/mach-exynos/clock-exynos4

[PATCH v10 0/3] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-03-06 Thread KyongHo Cho
These patches are successfully compiled in linux-samsung.git/for-next branch You can find the git repo. In http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=summary Changes since v9: - Split the first patch into 2 patches. One removes System MMU driver from arch/arm/plat- tre

Re: [PATCHv7 9/9] ARM: dma-mapping: add support for IOMMU mapper

2012-03-02 Thread KyongHo Cho
On Thu, Mar 1, 2012 at 12:04 AM, Marek Szyprowski wrote: > +/** > + * arm_iommu_map_sg - map a set of SG buffers for streaming mode DMA > + * @dev: valid struct device pointer > + * @sg: list of buffers > + * @nents: number of buffers to map > + * @dir: DMA transfer direction > + * > + * Map a set

Re: [PATCH v9 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-03-01 Thread KyongHo Cho
On Tue, Feb 28, 2012 at 4:01 PM, Kyungmin Park wrote: > Hi, > > Some comments. > 1. It's not same patch series. since it has additional feature, > exynos5 series support which don't covered at previous time. > 2. It assumes that name conversion is based on exynos5 as default. now > you use gsc at

Re: [PATCH v9 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2012-02-28 Thread KyongHo Cho
On Tue, Feb 28, 2012 at 4:53 PM, Kyungmin Park wrote: >> +void exynos_sysmmu_set_prefbuf(struct device *owner, >> +                             unsigned long base0, unsigned long size0, >> +                             unsigned long base1, unsigned long size1) >> +{ >> +     struct sysmmu_drvdata

Re: [PATCH v9 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2012-02-28 Thread KyongHo Cho
On Tue, Feb 28, 2012 at 4:20 PM, Kyungmin Park wrote: > Hi, > > On 2/28/12, KyongHo Cho wrote: >> Handling System MMUs with an identifier is not flexible to manage >> System MMU platform devices because of the following reasons: >> 1. A device driver which needs to

[PATCH v9 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2012-02-27 Thread KyongHo Cho
there Any device driver in Exynos platforms that needs to control its System MMU must call platform_set_sysmmu() to inform System MMU driver who will control it. platform_set_sysmmu() is defined in Cc: Joerg Roedel Cc: Kukjin Kim Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig

[PATCH v9 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2012-02-27 Thread KyongHo Cho
becomes a child if its power domain device. - clkdev Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos/Kconfig| 11 +- arch/arm/mach-exynos/Makefile |2 +- arch/arm/mach-exynos/clock-exynos4.c| 79 ++-- arch/arm/mach-exynos/clock-exynos4

[PATCH v9 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-02-27 Thread KyongHo Cho
Changes since v8: - exynos_iommu_map/unmap() just works for the page sizes that System MMU supports. (Joerg's comment) - 1 platform device for 1 H/W though a multimedia accelerator with several System MMUs attached. This make controlling System MMU simpler. - Information between System MMU

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-02-27 Thread KyongHo Cho
On Tue, Feb 28, 2012 at 12:51 AM, Marek Szyprowski wrote: >> The next patch will be submitted by 2/28. > > Ok, I will check it soon then. Thank you a lot. >> The next IOMMU driver defines just one platform device for a H/W device. >> Thus, it defines just one SYSMMU_MFC platform device, for exa

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-02-24 Thread KyongHo Cho
Hi Marek. On Fri, Feb 24, 2012 at 10:45 PM, Marek Szyprowski wrote: > Hi, > > On Thursday, December 29, 2011 1:24 PM KyongHo Cho wrote: > >> Changes since v7: >> - Rebased with the recent commits of the following git branches >>   * git.kernel.org/pub/scm/linux/

Re: [PATCH v8 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2012-01-30 Thread KyongHo Cho
On Fri, Jan 27, 2012 at 11:13 AM, Kukjin Kim wrote: > KyongHo Cho wrote: >> >> Hi, >> On Mon, Jan 23, 2012 at 11:27 PM, Joerg Roedel wrote: >> > Hi, >> > >> > please also get and inclue Acks from the Exynos maintainer for the next >> > po

Re: [PATCH v8 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2012-01-24 Thread KyongHo Cho
e issues I pointed > out below. > Thanks for review! I will include the Acks in the next patchset. I will post the next patchset with corrections by the day after tomorrow. And sorry for late reply. I had holidays for the new year's day based on Lunar system. > On Thu, Dec 29, 2011

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-08 Thread KyongHo Cho
On Thu, Jan 5, 2012 at 8:47 PM, Joerg Roedel wrote: > On Wed, Jan 04, 2012 at 09:26:20PM +, Russell King - ARM Linux wrote: >> On Wed, Jan 04, 2012 at 04:01:01PM +0100, Joerg Roedel wrote: >> > On Tue, Jan 03, 2012 at 09:55:27AM +, Russell King - ARM Linux wrote: >> > > It comes through wh

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-03 Thread KyongHo Cho
On Tue, Jan 3, 2012 at 10:02 AM, Kukjin Kim wrote: > Joerg Roedel wrote: >> >> On Tue, Jan 03, 2012 at 12:21:30AM +0900, KyongHo Cho wrote: >> > > I still get >> > > >> > >  LD      .tmp_vmlinux1 >> > > /data/cross/gcc-4.6.0-nolibc

Re: [PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2012-01-02 Thread KyongHo Cho
Hi On Mon, Jan 2, 2012 at 10:42 PM, Joerg Roedel wrote: > Hi, > > On Thu, Dec 29, 2011 at 09:24:18PM +0900, KyongHo Cho wrote: >> Changes since v7: >> - Rebased with the recent commits of the following git branches >>   * git.kernel.org/pub/scm/linux/ker

[PATCH v8 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-12-29 Thread KyongHo Cho
debugging message and generates kernel oops. This IOMMU driver calls bus_set_iommu() instead of register_iommu() since Joerg suggested that installing iommu_ops in bus_type. Cc: Joerg Roedel Cc: Marek Szyprowski Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig |8

[PATCH v8 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2011-12-29 Thread KyongHo Cho
becomes a child if its power domain device. - clkdev Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos/Kconfig |5 + arch/arm/mach-exynos/clock-exynos4210.c | 16 ++ arch/arm/mach-exynos/clock-exynos4212.c |1 + arch/arm/mach-exynos/clock.c

[PATCH v8 0/2] ommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-29 Thread KyongHo Cho
Changes since v7: - Rebased with the recent commits of the following git branches * git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git/next * git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git/for-next - Changed magic numbers into macros - Setting owner of a System MMU in 'iomm

RE: [PATCH] iommu: Initialize domain->handler in iommu_domain_alloc()

2011-12-16 Thread KyongHo Cho
On Thu, Dec 15, 2011 at 05:11:26PM +0100, Joerg Roedel wrote: > On Tue, Dec 13, 2011 at 04:14:20PM +0900, KyongHo Cho wrote: > > Since it is not guaranteed that an iommu driver initializes in its > > domain_init() function, it must be initialized with NULL to prevent > > cal

[PATCH] iommu: Initialize domain->handler in iommu_domain_alloc()

2011-12-14 Thread KyongHo Cho
Since it is not guaranteed that an iommu driver initializes in its domain_init() function, it must be initialized with NULL to prevent calling a function in an arbitrary location when iommu fault occurred. Signed-off-by: KyongHo Cho --- drivers/iommu/iommu.c |1 + 1 files changed, 1

Re: [PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-12-07 Thread KyongHo Cho
2011/12/6 Marek Szyprowski : > Hello, > > On Tuesday, December 06, 2011 1:21 PM KyongHo Cho wrote: > >> On Tue, Dec 6, 2011 at 8:48 PM, Marek Szyprowski >> wrote: >> > Hello, >> > >> > I'm trying to integrate your SYSMMU driver with m

Re: [PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-12-06 Thread KyongHo Cho
On Tue, Dec 6, 2011 at 8:48 PM, Marek Szyprowski wrote: > Hello, > > I'm trying to integrate your SYSMMU driver with my DMA-mapping & IOMMU > API integration patches. I've noticed some issues, please see my comments > below. > Thank you! > On Friday, November

Re: [PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-12-06 Thread KyongHo Cho
On Tue, Dec 6, 2011 at 8:24 AM, Kyungmin Park wrote: > On 12/6/11, Joerg Roedel wrote: >> On Fri, Nov 18, 2011 at 06:47:28PM +0900, KyongHo Cho wrote: >>> Patch Summary: >>> [PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions >>> [P

[PATCH v7 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2011-11-18 Thread KyongHo Cho
becomes a child if its power domain device. - clkdev Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos/Kconfig |2 + arch/arm/mach-exynos/clock-exynos4210.c | 16 ++ arch/arm/mach-exynos/clock.c | 55 ++-- arch/arm/mach-exynos/dev

[PATCH v7 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-11-18 Thread KyongHo Cho
debugging message and generates kernel oops. This IOMMU driver calls bus_set_iommu() instead of register_iommu() since Joerg suggested that installing iommu_ops in bus_type. Cc: Joerg Roedel Cc: Ohad Ben-Cohen Cc: Sylwester Nawrocki Cc: Russell King Signed-off-by: KyongHo Cho --- arch/arm/plat

[PATCH v7 0/2] iommu/exynos: Add IOMMU/System MMU driver for Samsung Exynos

2011-11-18 Thread KyongHo Cho
Changes since v6: - Totally rewrite exynos_iommu_map() and exynos_iommu_unmap() according to the change in iommu_map() and iommu_unmap(). - Change special slab for Lv2 page table to kmalloc(). Changes since v5: - Relation between device and a domain become n:1 (Joerg's comment) - Implements iomm

Re: [PATCH v6 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2011-11-14 Thread KyongHo Cho
On Tue, Nov 15, 2011 at 3:12 PM, KyongHo Cho wrote: > On Tue, Nov 15, 2011 at 2:37 PM, Kyungmin Park wrote: >>> @@ -988,6 +989,21 @@ static struct platform_device *universal_devices[] >>> __initdata = { >>>       &cam_i_core_fixed_reg_dev,

Re: [PATCH v6 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-11-14 Thread KyongHo Cho
On Tue, Nov 15, 2011 at 3:05 PM, Kyungmin Park wrote: >> +static bool set_sysmmu_active(struct sysmmu_drvdata *data) >> +{ >> +     /* return true if the System MMU was not active previously >> +        and it needs to be initialized */ >> +     data->activations++; >> +     return data->activatio

Re: [PATCH v6 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2011-11-14 Thread KyongHo Cho
On Tue, Nov 15, 2011 at 2:37 PM, Kyungmin Park wrote: >> @@ -988,6 +989,21 @@ static struct platform_device *universal_devices[] >> __initdata = { >>       &cam_i_core_fixed_reg_dev, >>       &cam_s_if_fixed_reg_dev, >>       &s5p_device_fimc_md, >> +     &SYSMMU_PLATDEV(sss), >> +     &SYSMMU_PLA

[PATCH v6 1/2] ARM: EXYNOS: Change System MMU platform device definitions

2011-11-14 Thread KyongHo Cho
becomes a child if its power domain device. - clkdev Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos/Kconfig |2 + arch/arm/mach-exynos/clock-exynos4210.c | 16 ++ arch/arm/mach-exynos/clock.c | 55 ++-- arch/arm/mach-exynos/dev

[PATCH v6 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-11-14 Thread KyongHo Cho
debugging message and generates kernel oops. This IOMMU driver calls bus_set_iommu() instead of register_iommu() since Joerg suggested that installing iommu_ops in bus_type. Cc: Joerg Roedel Cc: Ohad Ben-Cohen Cc: Sylwester Nawrocki Cc: Russell King Signed-off-by: KyongHo Cho --- arch/arm/plat

[PATCH v6 0/2] iommu/exynos: Add IOMMU and Enhance System MMU driver for Samsung Exynos

2011-11-14 Thread KyongHo Cho
Hi. Patch Summary: [PATCH v6 1/2] ARM: EXYNOS: Change System MMU platform device definitions [PATCH v6 2/2] iommu/exynos: Add iommu driver for Exynos Platforms The first patche enhances System MMU platform device definition: - Removed System MMU for MDMA0 in TOP block because it is not used.

Re: [PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-14 Thread KyongHo Cho
On Fri, Oct 14, 2011 at 11:17 PM, Roedel, Joerg wrote: > On Thu, Oct 13, 2011 at 04:13:23AM -0400, KyongHo Cho wrote: >> +struct exynos_iommu_domain { >> +       struct device *dev; >> +       unsigned long *pgtable; >> +       spinlock_t lock; >> +       spinl

[PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-13 Thread KyongHo Cho
ed1a96aa9a5ad3a Author: KyongHo Cho Date: Thu Oct 13 17:06:55 2011 +0900 This is the System MMU driver and IOMMU API implementation for Exynos SOC platforms. Exynos platforms has more than 10 System MMUs dedicated for each multimedia accellerators. The System MMU driver is already in arc/arm/pla

[PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-12 Thread KyongHo Cho
debugging message and generates kernel oops. This IOMMU driver calls bus_set_iommu() instead of register_iommu() since Joerg suggested that installing iommu_ops in bus_type. Cc: Joerg Roedel Cc: Ohad Ben-Cohen Cc: Sylwester Nawrocki Cc: Russell King Signed-off-by: KyongHo Cho --- arch/arm/plat

[PATCH v5 1/2] ARM: EXYNOS4: Change System MMU device definition

2011-10-12 Thread KyongHo Cho
that is included in LCD0 block because it is not used anymore. Use MDMA in TOP block. 3. Changed System MMU definitions of platform device. It is not an array anymore. Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos4/Kconfig |2 - arch/arm/mach-exynos4/clock.c

[PATCH v5 0/2] iommu/exynos: Add IOMMU and Enhance System MMU driver for Exynos4

2011-10-12 Thread KyongHo Cho
Hi. This is the fifth try of submitting patches about IOMMU/System MMU Patch Summary: [PATCH v5 1/2] ARM: EXYNOS4: Change System MMU device definition [PATCH v5 2/2] iommu/exynos: Add iommu driver for Exynos Platforms The first patche enhances System MMU platform device definition: - Removed Sy

Re: [PATCH v4 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-12 Thread KyongHo Cho
Hi Ohad, On Wed, Oct 12, 2011 at 5:22 PM, Ohad Ben-Cohen wrote: >> +static int exynos_iommu_unmap(struct iommu_domain *domain, unsigned long >> iova, >> +                          int gfp_order) >> +{ > ... >> +       return 0; >> +} > > ->unmap() should return the size of the unmapped region (in

[PATCH v4 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-12 Thread KyongHo Cho
debugging message and generates kernel oops. This IOMMU driver calls bus_set_iommu() instead of register_iommu() since Joerg suggested that installing iommu_ops in bus_type. Cc: Joerg Roedel Cc: Ohad Ben-Cohen Cc: Sylwester Nawrocki Cc: Russell King Signed-off-by: KyongHo Cho --- arch/arm/plat

[PATCH v4 1/2] ARM: EXYNOS4: Change System MMU device definition

2011-10-12 Thread KyongHo Cho
that is included in LCD0 block because it is not used anymore. Use MDMA in TOP block. 3. Changed System MMU definitions of platform device. It is not an array anymore. Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos4/Kconfig |2 - arch/arm/mach-exynos4/clock.c

[PATCH v4 0/2] iommu/exynos: Add IOMMU and Enhance System MMU driver for Exynos4

2011-10-12 Thread KyongHo Cho
Hi. This is the firth try of submitting patches about IOMMU/System MMU Patch Summary: [PATCH v4 1/2] ARM: EXYNOS4: Change System MMU device definition [PATCH v4 2/2] iommu/exynos: Add iommu driver for Exynos Platforms The first patche enhances System MMU platform device definition: - Removed Sy

Re: [PATCH v3 RE-SEND 2/2] iommu/exynos: Add iommu driver for Exynos Platforms

2011-10-08 Thread KyongHo Cho
On Sat, Oct 8, 2011 at 5:46 AM, Sylwester Nawrocki wrote: >> - >> -config S5P_SLEEP >> -     bool >> -     help >> -       Internal config node to apply common S5P sleep management code. >> -       Can be selected by S5P and newer SoCs with similar sleep procedure. >> - > > Is S5P_SLEEP being remo

Re: [PATCH v2 5/5] iommu/exynos: Use bus_set_iommu instead of register_iommu

2011-09-30 Thread KyongHo Cho
On Fri, Sep 30, 2011 at 10:46 PM, Roedel, Joerg wrote: > On Fri, Sep 30, 2011 at 03:31:49AM -0400, Kukjin Kim wrote: >> From: KyongHo Cho >> >> This replaces register_iommu() with bus_set_iommu() according to the >> suggestion of Joerg Roedel. > > This should be

Re: [PATCH v2 2/5] ARM: S5P: Remove system MMU driver from arm/plat-s5p

2011-09-30 Thread KyongHo Cho
On Fri, Sep 30, 2011 at 10:42 PM, Roedel, Joerg wrote: > On Fri, Sep 30, 2011 at 03:30:57AM -0400, Kukjin Kim wrote: >> From: KyongHo Cho >> >> Due to Ohad Ben-Cohen gathered IOMMU drivers in drivers/iommu directory, >> System MMU driver is moved to drivers/iommu di

Re: [PATCH v2 3/5] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-30 Thread KyongHo Cho
On Fri, Sep 30, 2011 at 9:06 PM, Roedel, Joerg wrote: > First comment: Pleas remove the 'inline' annotations in this patch. It > is better to let the compiler decide what to inline and what not. Ok. Thanks :) > > Hmm, may it make sense to store data directly in dev->arch.iommu? This > will save y

[PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-27 Thread KyongHo Cho
This is the System MMU driver and IOMMU API implementation for Exynos4 SOC platforms. Exynos4 platforms has more than 10 System MMUs dedicated for each multimedia accellerators. Signed-off-by: KyongHo Cho --- drivers/iommu/Kconfig| 14 + drivers/iommu/Makefile |1 + drivers

[PATCH 1/4 v2] ARM: EXYNOS4: Change System MMU device definition

2011-09-27 Thread KyongHo Cho
that is included in LCD0 block because it is not used anymore. Use MDMA in TOP block. 3. Changed System MMU definitions of platform device. It is not an array anymore. Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos4/Kconfig |2 - arch/arm/mach-exynos4/clock.c

[PATCH 4/4 v2] iommu/exynos: Use bus_set_iommu instead of register_iommu

2011-09-27 Thread KyongHo Cho
This replaces register_iommu() with bus_set_iommu() according to the suggestion of Joerg Roedel. Cc: Joerg Roedel Signed-off-by: KyongHo Cho --- drivers/iommu/exynos_iommu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/exynos_iommu.c b/drivers/iommu

[PATCH 1/4] ARM: EXYNOS4: Change System MMU device definition

2011-09-27 Thread KyongHo Cho
that is included in LCD0 block because it is not used anymore. Use MDMA in TOP block. 3. Changed System MMU definitions of platform device. It is not an array anymore. Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos4/Kconfig |2 - arch/arm/mach-exynos4/clock.c

[PATCH 3/4 v2] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-27 Thread KyongHo Cho
This is the System MMU driver and IOMMU API implementation for Exynos4 SOC platforms. Exynos4 platforms has more than 10 System MMUs dedicated for each multimedia accellerators. Signed-off-by: KyongHo Cho --- drivers/iommu/Kconfig| 14 + drivers/iommu/Makefile |1 + drivers

[PATCH 0/4] iommu/exynos: Add IOMMU and Enhance System MMU for Exynos4

2011-09-27 Thread KyongHo Cho
Hi, The first 2 patches are the revolutionary change to the device definition of System MMU for Exynos4 SoCs: - System MMU ID is removed and a device and its dedicated System MMU are bound during the machine initialization. - Only the System MMU platform devices that are bound to their master

[PATCH 4/4] iommu/exynos: Use bus_set_iommu instead of register_iommu

2011-09-27 Thread KyongHo Cho
This replaces register_iommu() with bus_set_iommu() according to the suggestion of Joerg Roedel. Cc: Joerg Roedel Signed-off-by: KyongHo Cho --- drivers/iommu/exynos_iommu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/exynos_iommu.c b/drivers/iommu

[PATCH 2/4] ARM: S5P: Remove system MMU driver from arm/plat-s5p

2011-09-27 Thread KyongHo Cho
Due to Ohad Ben-Cohen gathered IOMMU drivers in drivers/iommu directory, System MMU driver is moved to drivers/iommu directory and removed from arch/arm/plat-s5p directory. Please see https://lkml.org/lkml/2011/6/8/69 Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig

[PATCH 2/4 v2] ARM: S5P: Remove system MMU driver from arm/plat-s5p

2011-09-27 Thread KyongHo Cho
Due to Ohad Ben-Cohen gathered IOMMU drivers in drivers/iommu directory, System MMU driver is moved to drivers/iommu directory and removed from arch/arm/plat-s5p directory. Please see https://lkml.org/lkml/2011/6/8/69 Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig

[PATCH 3/3] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-27 Thread KyongHo Cho
This is the System MMU driver and IOMMU API implementation for Exynos4 SOC platforms. Exynos4 platforms has more than 10 System MMUs dedicated for each multimedia accellerators. Signed-off-by: KyongHo Cho --- drivers/iommu/Kconfig| 14 + drivers/iommu/Makefile |1 + drivers

[PATCH 0/4 v2] iommu/exynos: Add IOMMU and Enhance System MMU driver for Exynos4

2011-09-27 Thread KyongHo Cho
This is the second try of submitting patches about IOMMU/System MMU driver for Exynos4 SoCs with the fixes of the following probles pointed by Russell King.: - Missing unlocking a spinlock in exynos_iommu_attach_dev(). - atomic_t -> int in sysmmu_drvdata.activations - sysmmu_platdata -> sysmmu_d

[PATCH 0/4] iommu/exynos: Add IOMMU and Enhance System MMU driver for Exynos4

2011-09-27 Thread KyongHo Cho
First 2 patches enhance System MMU platform device definition: - Removed System MMU for MDMA0 in LCD block because it is not used. Use MDMA2 in TOP block. - Removed System MMU ID. Instead a System MMU is bound to a device that the System MMU is dedicated during machin initialization. If a d

[PATCH 4/4] iommu/exynos: Use bus_set_iommu instead of register_iommu

2011-09-27 Thread KyongHo Cho
This replaces register_iommu() with bus_set_iommu() according to the suggestion of Joerg Roedel. Cc: Joerg Roedel Signed-off-by: KyongHo Cho --- drivers/iommu/exynos_iommu.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/iommu/exynos_iommu.c b/drivers/iommu

[PATCH 1/4] ARM: EXYNOS4: Change System MMU device definition

2011-09-27 Thread KyongHo Cho
that is included in LCD0 block because it is not used anymore. Use MDMA in TOP block. 3. Changed System MMU definitions of platform device. It is not an array anymore. Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos4/Kconfig |2 - arch/arm/mach-exynos4/clock.c

[PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-27 Thread KyongHo Cho
This is the System MMU driver and IOMMU API implementation for Exynos4 SOC platforms. Exynos4 platforms has more than 10 System MMUs dedicated for each multimedia accellerators. Signed-off-by: KyongHo Cho --- drivers/iommu/Kconfig| 14 + drivers/iommu/Makefile |1 + drivers

[PATCH 2/3] ARM: S5P: Remove system MMU driver from arm/plat-s5p

2011-09-27 Thread KyongHo Cho
Due to Ohad Ben-Cohen gathered IOMMU drivers in drivers/iommu directory, System MMU driver is moved to drivers/iommu directory and removed from arch/arm/plat-s5p directory. Please see https://lkml.org/lkml/2011/6/8/69 Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig

[PATCH 1/3] ARM: EXYNOS4: Change System MMU device definition

2011-09-27 Thread KyongHo Cho
that is included in LCD0 block because it is not used anymore. Use MDMA in TOP block. 3. Changed System MMU definitions of platform device. It is not an array anymore. Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos4/Kconfig |2 - arch/arm/mach-exynos4/clock.c

[PATCH 2/4] ARM: S5P: Remove system MMU driver from arm/plat-s5p

2011-09-27 Thread KyongHo Cho
Due to Ohad Ben-Cohen gathered IOMMU drivers in drivers/iommu directory, System MMU driver is moved to drivers/iommu directory and removed from arch/arm/plat-s5p directory. Please see https://lkml.org/lkml/2011/6/8/69 Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig

[PATCH 0/3] iommu/exynos: Add iommu driver for Exynos4 SoCs

2011-09-27 Thread KyongHo Cho
Hi. This patch set enhances System MMU platform device definitions of Exynos SoC platforms, adds the implementation of IOMMU API as well as and moves Syste MMU driver to the drivers/iommu directory. The IOMMU driver also implements fault handler that Ohad Ben-Cohen has suggeested and iommu_ops pe

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-27 Thread KyongHo Cho
On Tue, Sep 27, 2011 at 5:48 PM, Ohad Ben-Cohen wrote: > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index d084e87..2987199 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -98,11 +98,12 @@ extern void iommu_set_fault_handler(struct > iommu_domain *domain, >

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread KyongHo Cho
On Tue, Sep 27, 2011 at 12:59 AM, Ohad Ben-Cohen wrote: > On Mon, Sep 26, 2011 at 5:48 PM, KyongHo Cho wrote: >> I am sorry but I still think that >> installing default fault handler is quite simple and straightforward. > > ... and abusing the IOMMU API. > > Please do

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread KyongHo Cho
On Mon, Sep 26, 2011 at 6:36 PM, Ohad Ben-Cohen wrote: > It seems your default behavior just prints an error message with the > details of the fault (addresses, flags, etc..). We can probably have > this unified. > > In case you want to print exonys-specific info when the fault is not > handled b

Re: [PATCH 0/4 v2] iommu/exynos: Add IOMMU and Enhance System MMU driver for Exynos4

2011-09-26 Thread KyongHo Cho
2011 at 7:00 PM, KyongHo Cho wrote: > This is the second try of submitting patches about IOMMU/System MMU > driver for Exynos4 SoCs with the fixes of the following problems > pointed by Russell King.: >  - Missing unlocking a spinlock in exynos_iommu_attach_dev(). &

[PATCH 1/4 v2] ARM: EXYNOS4: Change System MMU device definition

2011-09-26 Thread KyongHo Cho
that is included in LCD0 block because it is not used anymore. Use MDMA in TOP block. 3. Changed System MMU definitions of platform device. It is not an array anymore. Signed-off-by: KyongHo Cho --- arch/arm/mach-exynos4/Kconfig |2 - arch/arm/mach-exynos4/clock.c

[PATCH 0/4 v2] iommu/exynos: Add IOMMU and Enhance System MMU driver for Exynos4

2011-09-26 Thread KyongHo Cho
This is the second try of submitting patches about IOMMU/System MMU driver for Exynos4 SoCs with the fixes of the following problems pointed by Russell King.: - Missing unlocking a spinlock in exynos_iommu_attach_dev(). - atomic_t -> int in sysmmu_drvdata.activations - sysmmu_platdata -> sysmmu_

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread KyongHo Cho
On Mon, Sep 26, 2011 at 6:05 PM, Ohad Ben-Cohen wrote: > On Mon, Sep 26, 2011 at 11:58 AM, KyongHo Cho wrote: >> As you've noticed, it is default behavior for iommu fault. > > Then why not add it to the IOMMU core ? it's quite generic and can be > useful for others,

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-26 Thread KyongHo Cho
Hi. On Mon, Sep 26, 2011 at 4:59 PM, Ohad Ben-Cohen wrote: > 2011/9/24 조경호 : >> This is the System MMU driver and IOMMU API implementation for >> Exynos4 SOC platforms. Exynos4 platforms has more than 10 System >> MMUs dedicated for each multimedia accellerators. >> &g

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-25 Thread KyongHo Cho
Thanks. I will try. Regards, Cho KyongHo. On Mon, Sep 26, 2011 at 11:17 AM, Wanlong Gao wrote: > On 09/26/2011 08:44 AM, KyongHo Cho wrote: > >> Hi. >> >> On Sat, Sep 24, 2011 at 6:38 PM, Russell King - ARM Linux >> wrote: >>> On Sat, Sep 24, 2011 at 07:3

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-25 Thread KyongHo Cho
Hi. On Sat, Sep 24, 2011 at 6:38 PM, Russell King - ARM Linux wrote: > On Sat, Sep 24, 2011 at 07:35:45AM +, 조경호 wrote: >> +# EXYNOS IOMMU support >> +config EXYNOS_IOMMU >> + bool "Exynos IOMMU Support" >> + depends on ARCH_EXYNOS4 >> + select IOMMU_API >> + select EXYNOS4_DEV_SYSMMU >> + he

Re: [PATCH 3/4] iommu/exynos: Add iommu driver for Exynos4 Platforms

2011-09-24 Thread KyongHo Cho
han 10 System > MMUs dedicated for each multimedia accellerators. > > Signed-off-by: KyongHo Cho > --- > drivers/iommu/Kconfig| 14 + > drivers/iommu/Makefile |1 + > drivers/iommu/exynos_iommu.c | 859 ++ > 3 files

Re: [PATCH 0/4] iommu/exynos: Add IOMMU and Enhance System MMU driver for Exynos4

2011-09-24 Thread KyongHo Cho
Sorry for duplicate emails :( My mistake. 2011/9/24 조경호 : > Hi. > > First 2 patches enhance System MMU platform device definition: > - Removed System MMU for MDMA0 in LCD block because it is not used. > Use MDMA2 in TOP block. > - Removed System MMU ID. Instead a System MMU is bound to a devi

Re: [PATCH 2/2] ARM: Samsung: update/rewrite Samsung SYSMMU (IOMMU) driver

2011-09-06 Thread KyongHo Cho
Hi. On Fri, Sep 2, 2011 at 10:56 PM, Marek Szyprowski wrote: > + * > + * iova must be aligned on a 4kB, 64kB, 1MB and 16MB boundaries, > respectively. > + */ Actually, iova is just needed to be aligned by 4KiB because it is minimum requirement. I think IOMMU driver is capable of mapping a group

[PATCH] ARM: S5P: Remove sysmmu driver from arch tree

2011-07-15 Thread KyongHo Cho
cause any problem. Signed-off-by: KyongHo Cho --- arch/arm/plat-s5p/Kconfig |8 - arch/arm/plat-s5p/Makefile |1 - arch/arm/plat-s5p/include/plat/sysmmu.h | 95 -- arch/arm/plat-s5p/sysmmu.c | 312 --- 4 files

Re: [PATCH 0/6+1] ARM: EXYNOS4: SYSMMU: Improvements on SYSMMU driver

2011-07-05 Thread KyongHo Cho
On Tue, Jul 5, 2011 at 8:14 PM, Marek Szyprowski wrote: > Hello, > > On Tuesday, July 05, 2011 1:38 AM KyongHo Cho wrote: > >> On Mon, Jul 4, 2011 at 3:47 PM, Marek Szyprowski >> wrote: >> > Hello, >> > >> > I really don't get why do You p

Re: [PATCH 0/6+1] ARM: EXYNOS4: SYSMMU: Improvements on SYSMMU driver

2011-07-04 Thread KyongHo Cho
Hi. On Mon, Jul 4, 2011 at 3:47 PM, Marek Szyprowski wrote: > Hello, > > I really don't get why do You persist in creating one monster platform > device with resources for ALL SYSMMU/IOMMU controllers that are available > on Exynos4 CPU. We (SPRC, see Andrzej's SYSMMU patches) already proposed > a

  1   2   >