Re: [PATCH V3 2/2] sdhci-s3c: Add support no internal clock divider in host controller

2010-10-10 Thread Kyungmin Park
On Fri, Oct 8, 2010 at 5:46 PM, Kukjin Kim wrote: > From: Jeongbae Seo > > This patch adds to support no internal clock divider in SDHCI. > The external clock divider can be used to make a proper clock > because SDHCI doesn't support internal clock divider by itself. > > If external clock divider

Re: [PATCH 1/2] ARM: S3C64XX: Add suspend support

2010-10-05 Thread Kyungmin Park
On Wed, Oct 6, 2010 at 8:27 AM, Maurus Cuelenaere wrote: >  Op 06-10-10 01:23, Kyungmin Park schreef: >> Hi, >> >> I agree your approach, put the common features in common place. >> but Samsung maintainers insist put these at each machine file at current >> tim

Re: [PATCH 1/2] ARM: S3C64XX: Add suspend support

2010-10-05 Thread Kyungmin Park
Hi, I agree your approach, put the common features in common place. but Samsung maintainers insist put these at each machine file at current time. So move this to the each machines for their tastes. Thank you, Kyungmin Park On Wed, Oct 6, 2010 at 8:09 AM, Maurus Cuelenaere wrote: > The o

Re: [PATCH v2 3/3] ARM: S5PC210: Set the common L2 cache configurations

2010-10-05 Thread Kyungmin Park
On Tue, Oct 5, 2010 at 5:47 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> From: Kyungmin Park >> >> S5PC210 has PL310 1MiB L2 cache. >> It uses the optimized data & tag latency and also enable the prefetch. >> >> Signed-off-by: Kyungmin Pa

Re: [PATCH 0/7] ARM: S5PC210: I2C devices support and Universal board updates

2010-10-05 Thread Kyungmin Park
On Tue, Oct 5, 2010 at 5:40 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> Hi, >> > Hi, > >> I think we made some conclusion. first apply the current style and >> improve it later for consistency. >> > Yeah, we should decide for this. > >

Re: [PATCH] ARM: S5PC100: Cleanup the GPIOlib code

2010-10-01 Thread Kyungmin Park
oop. just put it at each configuration as is. Thank you, Kyungmin Park > - .base = S5PC100_GPA0_BASE, > - .config = &gpio_cfg, On Fri, Oct 1, 2010 at 9:58 PM, Kukjin Kim wrote: > This patch clean up the GPIO code and removes useless GPIO addresses. &g

Re: [PATCH 06/27] ARM: S5P64X0: 2nd Change to using s3c_gpio_cfgpin_range()

2010-10-01 Thread Kyungmin Park
make a wrapper, s3c_gpio_cfgrange_pullup, then you can also remove above codes. There's lots of codes use PULL_UP as default pin setup. Thank you, Kyungmin Park >                break; > >        case 1: > -               s3c_gpio_cfgpin(S5P6440_GPC(4), S3C_GPIO_SFN(2)); >

Re: [PATCH 3/3] ARM: S5PV210: Add voltage consumer of WM8994 to the regulator framework

2010-10-01 Thread Kyungmin Park
On Fri, Oct 1, 2010 at 4:24 PM, Mark Brown wrote: > On Fri, Oct 01, 2010 at 02:40:02PM +0900, Kyungmin Park wrote: > >> FYI: now wm8994 codec is connected to I/O power directly. and there's >> no connection with PMIC. > > Presumably there's a power rail connect

Re: [PATCH 3/3] ARM: S5PV210: Add voltage consumer of WM8994 to the regulator framework

2010-09-30 Thread Kyungmin Park
ays enabled.  That said, is the > PMIC on these boards supported by Linux yet? FYI: now wm8994 codec is connected to I/O power directly. and there's no connection with PMIC. Maybe you mean the I/O power LDO and use it. but it's always on in case of s5pc110. and can't turn off the t

Re: [PATCH v4] ARM: Samsung: Add common s5p gpio interrupt support

2010-09-30 Thread Kyungmin Park
ort for all of them would be a resource waste. Because of that >> the interrupt support for standard gpio pins is registered dynamically >> by the s5p_register_gpio_interrupt() function. >> >> Signed-off-by: Marek Szyprowski >> Signed-off-by: Joonyoung Shim >>

Re: [PATCH 5/5] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-29 Thread Kyungmin Park
On Thu, Sep 30, 2010 at 2:40 PM, Jeongbae Seo wrote: > Chris wrote: > >> Hi Kyungmin, Ben, >> >> On Thu, Sep 30, 2010 at 10:18:12AM +0900, Kyungmin Park wrote: >> > On Sat, Sep 18, 2010 at 12:59 AM, Chris Ball wrote: >> > > Hi, >> > >

Re: [PATCH 5/5] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-29 Thread Kyungmin Park
On Sat, Sep 18, 2010 at 12:59 AM, Chris Ball wrote: > Hi, > > On Thu, Sep 16, 2010 at 06:08:28PM +0900, Kyungmin Park wrote: >> Well there are two implementations. and no conclusion yet. >> as s5pc210 don't support internal SDHCI clock, DMC overrides the >> functi

[PATCH 1/6] ARM: Samsung: Add common s5p gpio interrupt support

2010-09-28 Thread Kyungmin Park
; by the s5p_register_gpio_interrupt() function. >> >> Hi, >> >> I checked only S5PV210/S5PC110 GPIO interrupt. >> >> > >> > Signed-off-by: Marek Szyprowski >> > Signed-off-by: Joonyoung Shim >> > Signed-off-by: Kyungmin Park >

Re: [PATCH v3] regulators: add support max8952 regulator

2010-09-28 Thread Kyungmin Park
On Tue, Sep 28, 2010 at 4:58 PM, Kukjin Kim wrote: > Kukjin Kim wrote: >> >> Kyungmin Park wrote: >> > >> > Do you check the DVS feature? >> > It can support the DVS by GPIOs and platform can set the each voltages > at >> > each mode. >&

Re: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-27 Thread Kyungmin Park
gt; And make sure it's text type. > >>Hi, >>Thank you for your interesting. >>On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park wrote: > > (snip) > >>> +#define TORBRECK_UFCON_DEFAULT (S3C2410_UFCON_FIFOMO

Re: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-27 Thread Kyungmin Park
On Mon, Sep 27, 2010 at 7:10 PM, 최규호 wrote: > Hi, > Thank you for your interesting. > > On Mon, Sep 27, 2010 at 11:58 AM, Kyungmin Park > wrote: >> >> Hi, >> >> Looks good to me except minor fixup. >> >> Acked-by: Kyungmin Park >&g

Re: [PATCH] ARM: S5PV210: Add Torbreck board support

2010-09-26 Thread Kyungmin Park
Hi, Looks good to me except minor fixup. Acked-by: Kyungmin Park On Sun, Sep 26, 2010 at 10:05 AM, Kyuho Choi wrote: > This patch adds to support Torbreck board of aESOP community using > Samsung S5PV210 SoC. > > Signed-off-by: Kyuho Choi > Signed-off-by: Hyunchul Ko > --

Re: [PATCH] sdhci-s3c: fix NULL ptr access in sdhci_s3c_remove

2010-09-26 Thread Kyungmin Park
already included at patch. so no need to ACK from me. Thank you, Kyungmin Park > > Andrew, I've been waiting for an ACK from Ben Dooks, since he's listed > in MAINTAINERS for this driver, but he hasn't replied yet (I've tried > pinging privately).  I'll plan on

Re: [PATCH v3] ARM: S5PV210: Add Power Management Support

2010-09-16 Thread Kyungmin Park
2010/9/17 Sangbeom Kim : > > > Kyungmin Park wrote: > >>On Wed, Sep 15, 2010 at 5:33 PM, Sangbeom Kim wrote: >>> From: Jongpill Lee >>> >>> This patch adds suspend-to-ram support for S5PV210. >>> Note. This patch is confirmed on SMDKV210 a

Re: [PATCH 0/5] ARM: S5PV210: Add support CPUFREQ for S5PV210/S5PC110

2010-09-16 Thread Kyungmin Park
2010/9/17 Kukjin Kim : > Kyungmin Park wrote: >> >> First thank you for posting the patches. >> but I'm worry about sending the same feature patches from different > divisions. >> > It doesn't matter which division it is from. > What matters is

Re: [PATCH 1/5] ARM: S5PV310: Add HSMMC support and SDHCI configuration

2010-09-16 Thread Kyungmin Park
On Fri, Sep 17, 2010 at 9:57 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Thu, Sep 16, 2010 at 5:36 PM, Jeongbae Seo >> wrote: >> > From: Hyuk Lee >> > >> > This patch adds to support HSMMC for S5PV310 and S5PC210 and setup for >>

Re: [PATCH 1/5] ARM: S5PV310: Add HSMMC support and SDHCI configuration

2010-09-16 Thread Kyungmin Park
disabled. I think it's not needed since most boards have fixed bandwith and cfg_gpio handle it regardless these configuration. Also we use the select state if needed, e.g., when MMC0 uses 8-buswidth then don't select MMC1. I saw the SMDK board use this configuration. but just choose b

Re: [PATCH 5/5] sdhci-s3c: Add support no internal clock divider in host controller

2010-09-16 Thread Kyungmin Park
Hi, Well there are two implementations. and no conclusion yet. as s5pc210 don't support internal SDHCI clock, DMC overrides the function operation itself when s5pc210. System LSI use the quirks. Choose any one from MMC maintainer. Thank you, Kyungmin Park On Thu, Sep 16, 2010 at 5:

Re: [PATCH 0/5] ARM: S5PV210: Add support CPUFREQ for S5PV210/S5PC110

2010-09-15 Thread Kyungmin Park
mpark/linux-2.6-samsung/shortlog/refs/heads/cpufreq To kgene, One code from DMC(me), another code from System LSI(you). then which codes do you pick up and apply to mainline? and what's rules or principles? Thank you, Kyungmin Park On Wed, Sep 15, 2010 at 4:52 PM, Jaecheol Lee wrote: > This

Re: [PATCH v3] ARM: S5PV210: Add Power Management Support

2010-09-15 Thread Kyungmin Park
On Wed, Sep 15, 2010 at 5:33 PM, Sangbeom Kim wrote: > From: Jongpill Lee > > This patch adds suspend-to-ram support for S5PV210. > Note. This patch is confirmed on SMDKV210 and SMDKC110 board. > > Signed-off-by: Jongpill Lee > Signed-off-by: Sangbeom Kim > --- > Changes since v2: > 1. Fixed co

Re: [PATCH 3/3] ARM: S5PC210: Set the common L2 cache configurations

2010-09-14 Thread Kyungmin Park
On Tue, Sep 14, 2010 at 6:48 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> From: Kyungmin Park >> >> S5PC210 has PL310 1MiB L2 cache. >> It uses the optimized data & tag latency and also enable the prefetch. >> >> Signed-off-by: Kyungmin Pa

Re: [PATCH 4/6] ARM: S5PV210: Enable USB HSOTG gadget build

2010-09-10 Thread Kyungmin Park
ernel for our board. Thank you, Kyungmin Park On Fri, Sep 10, 2010 at 7:33 PM, Kukjin Kim wrote: > Marek Szyprowski wrote: >> >> Add the necessary definitions and mapping information to enable the >> s3c-hsotg gadget to build. >> >> Signed-off-by: Mar

RE: [PATCH v3] regulators: add support max8952 regulator

2010-09-07 Thread Kyungmin Park
Do you check the DVS feature? It can support the DVS by GPIOs and platform can set the each voltages at each mode. As quick review of max8649. It can't support it. Thank you, Kyungmin Park -Original Message- From: Kukjin Kim [mailto:kgene@samsung.com] Sent: Wednesday, Septemb

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Kyungmin Park
On Tue, Sep 7, 2010 at 2:29 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This patch changes RTC initialization method on probe() as > per Wan ZongShun's suggestion. The 'rtc_valid_tm(tm)' can > check whether RTC BCD is valid or not. > > And should be changed the method of check because previo

Re: [PATCH 12/13] ARM: S5P64X0: Add UART serial support for S5P6450

2010-09-01 Thread Kyungmin Park
On Wed, Sep 1, 2010 at 4:09 PM, Kukjin Kim wrote: > This patch adds UART serial port support for S5P6450 SoC. > The S5P6450 has 6 UARTs, so adds resource of UART4 and UART5. > And to fix membase which is in serial/samsung.c is from Ben Dooks. > > Signed-off-by: Kukjin Kim > Cc: Ben Dooks > --- >

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Kyungmin Park
On Wed, Sep 1, 2010 at 7:27 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Wed, Sep 1, 2010 at 6:44 PM, Kukjin Kim wrote: >> > Mark Brown wrote: >> >> >> >> On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: >> >> &g

Re: [PATCH v2] MAX8952 PMIC Driver Initial Release

2010-09-01 Thread Kyungmin Park
On Wed, Sep 1, 2010 at 6:44 PM, Kukjin Kim wrote: > Mark Brown wrote: >> >> On Wed, Sep 01, 2010 at 09:15:36AM +0900, Kukjin Kim wrote: >> >> > Seems almost same between the operation of max8649 and max8952 except >> output >> > voltage range. >> >> > How do you think that can support max8952 with

Re: [PATCH 11/13] ARM: S5P64X0: Move SMDK6440 board file and Add SMDK6450 board file

2010-09-01 Thread Kyungmin Park
On Wed, Sep 1, 2010 at 4:09 PM, Kukjin Kim wrote: > This patch moves smdk6440 board file from mach-s5p6440 into the new > mach-s5p64x0 directory and adds smdk6450 board file. > > Signed-off-by: Kukjin Kim > --- >  .../{mach-s5p6440 => mach-s5p64x0}/mach-smdk6440.c |   87 ++ >  arch/arm/ma

Re: [PATCH 02/13] ARM: S5P64X0: Update Kconfig and Makefile

2010-09-01 Thread Kyungmin Park
; index 000..2655829 > --- /dev/null > +++ b/arch/arm/mach-s5p64x0/Makefile > @@ -0,0 +1,30 @@ > +# arch/arm/mach-s5p64x0/Makefile > +# > +# Copyright (c) 2009-2010 Samsung Electronics Co., Ltd. > +#              http://www.samsung.com > +# > +# Licens

Re: [PATCH 01/13] ARM: S5P: Moves initial map for merging S5P64X0

2010-09-01 Thread Kyungmin Park
For long time you insist to use the S5P prefix, but it's changed to each SoC name. anyway good move. On Wed, Sep 1, 2010 at 4:09 PM, Kukjin Kim wrote: > This patch moves some initial maps from plat-s5p to machine, > so that can merge mach-s5p6440 and mach-s5p6450. > > Signed-off-by: Kukjin Kim >

Re: [GIT PULL] Samsung fixes for 2.6.36-rc3

2010-08-27 Thread Kyungmin Park
wm > > Kukjin Kim (4): >      ARM: SAMSUNG: Fix on build warning regarding VMALLOC_END type >      ARM: S5PV310: Fix on default ZRELADDR of ARCH_S5PV310 >      ARM: S5PV310: Fix on typo irqs.h of S5PV310 >      ARM: S5PV310: Add CMU block for S5

Re: [PATCH RE-SEND] ARM: S5P: Move OneNAND device definitions in plat-s5p

2010-08-22 Thread Kyungmin Park
On Mon, Aug 23, 2010 at 11:35 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> " Note: S5PC110 and S5PC210 have same OneNAND driver." >> >> Yes I also think it's same device. At least Spec is same. But I heard it > has >> some different feature

Re: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-22 Thread Kyungmin Park
On Mon, Aug 23, 2010 at 11:15 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Mon, Aug 23, 2010 at 9:18 AM, Kukjin Kim wrote: >> > Kyungmin Park wrote: >> >> >> >> NAK. >> >> >> > I don't know why I need your ack for

RE: [PATCH RE-SEND] ARM: S5P: Move OneNAND device definitions in plat-s5p

2010-08-22 Thread Kyungmin Park
If it's true. we need to separate it if required. Thank you, Kyungmin Park -Original Message- From: Kukjin Kim [mailto:kgene@samsung.com] Sent: Monday, August 23, 2010 9:07 AM To: linux-arm-ker...@lists.infradead.org; linux-samsung-soc@vger.kernel.org Cc: ben-li...@fluff.org; Kuk

Re: [PATCH 00/14] ARM: S5PV310: Updates clock

2010-08-22 Thread Kyungmin Park
this codes at your board? Thank you, Kyungmin Park Uncompressing Linux... done, booting the kernel. [0.00] Linux version 2.6.36-rc1-ga400ca7-dirty (dofm...@dofmind-linux) (gcc version 4.4.1 (GCC) ) #334 PREEMPT Mon Aug 23 10:45:59 KST 2010 [0.00] CPU: ARMv7 Processor [412fc09

Re: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-22 Thread Kyungmin Park
On Mon, Aug 23, 2010 at 9:18 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> NAK. >> > I don't know why I need your ack for this...if any opinions, just comments > is enough. Okay I said in other word, I can't agree this patch. > >> This approach

Re: [PATCH 1/3] ARM: SAMSUNG: Change the 3rd HSMMC interrupt name for compatibility

2010-08-21 Thread Kyungmin Park
Acked-by: Kyungmin Park On Fri, Aug 20, 2010 at 9:33 PM, Kukjin Kim wrote: > This patch changes the 3rd HSMMC interrupt name for compatibility > from IRQ_MMC to IRQ_HSMMC3. > > Signed-off-by: Kukjin Kim > --- >  arch/arm/mach-s5pv210/include/mach/irqs.h |    2 +- >  

Re: [PATCH 2/3] ARM: S5P: Add initial map for GPIO2 and GPIO3

2010-08-21 Thread Kyungmin Park
n use the common GPIO framework and remove the VA_GPIO dependency. Thank you, Kyungmin Park On Fri, Aug 20, 2010 at 9:33 PM, Kukjin Kim wrote: > From: Jongpill Lee > > This patch adds initial map for GPIO2 and GPIO3. > S5PV310/S5PC210 has separated GPIO1, GPIO2 and GPIO3. > >

Re: [PATCH 3/3] ARM: S5PV310: Add support HSMMC on SMDKC210 and SMDKV310

2010-08-21 Thread Kyungmin Park
On Fri, Aug 20, 2010 at 9:33 PM, Kukjin Kim wrote: > From: Hyuk Lee > > This patch adds support HSMMC on SMDKC210 and SMDKV310, and adds > setup functions for it. S5PV310/S5PC210 can support 4 hsmmc such > as hsmmc0, hsmmc1, hsmmc2 and hsmmc3. > > Signed-off-by: Hyuk Lee > Signed-off-by: Kukjin

Re: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

2010-08-18 Thread Kyungmin Park
On Thu, Aug 19, 2010 at 10:10 AM, Kyungmin Park wrote: > On Thu, Aug 19, 2010 at 3:33 AM, Andrew Morton > wrote: >> On Fri, 13 Aug 2010 10:13:04 +0200 >> Marek Szyprowski wrote: >> >>> Hello, >>> >>> On Friday, August 13, 2010 9:32 AM Kukjin

Re: 'error: 'SDHCI_QUIRK_NO_HISPD_BIT' undeclared' and 'undefined reference to `sdhci_card_detect''

2010-08-18 Thread Kyungmin Park
On Thu, Aug 19, 2010 at 3:33 AM, Andrew Morton wrote: > On Fri, 13 Aug 2010 10:13:04 +0200 > Marek Szyprowski wrote: > >> Hello, >> >> On Friday, August 13, 2010 9:32 AM Kukjin Kim wrote: >> >> > This is just information about Samsung sdmmc stuff building error now. >> > >> > I found Marek's 'sdh

Re: [PATCH] ARM: Update number of VIC

2010-08-15 Thread Kyungmin Park
m-kernel&m=127555986709819&w=2 Thank you, Kyungmin Park On Fri, Aug 13, 2010 at 8:09 PM, Kukjin Kim wrote: > Update the number of VIC to handle the 3 or 4 VICs of > the S5PV210, S5P6442 and S5PC100. > > Signed-off-by: Kukjin Kim > Cc: Ben Dooks > Cc: Russell King >

Re: [PATCH v4] ARM: S5PV310: Add Samsung UNIVERSAL_C210 support

2010-08-06 Thread Kyungmin Park
On Fri, Aug 6, 2010 at 9:14 PM, Kukjin Kim wrote: > From: Kyungmin Park > > This patch adds Samsung Mobile S5PC210 Reference Board, UNIVERSAL_C210 board > support. > > Signed-off-by: Kyungmin Park > [kgene@samsung.com: changed machine name] > Signed-off-by: Kukj

Re: [PATCH] ARM: SAMSUNG: Fix on inclusion mach/gpio.h for Samsung SoCs

2010-08-04 Thread Kyungmin Park
Acked-by: Kyungmin Park On Thu, Aug 5, 2010 at 8:07 AM, Kukjin Kim wrote: > This patch fixes on inclusion to . > > Signed-off-by: Kukjin Kim > Cc: Ben Dooks > --- >  arch/arm/mach-s3c64xx/dev-audio.c        |    2 +- >  arch/arm/mach-s3c64xx/dev-spi.c          |    

Re: [PATCH v6 5/7] ARM: S5PV210: Access for DMCx registers

2010-08-04 Thread Kyungmin Park
-off-by: MyungJoo Ham >> Signed-off-by: Kyungmin Park >> --- >>  arch/arm/mach-s5pv210/cpu.c              |   12 +++- >>  arch/arm/mach-s5pv210/include/mach/map.h |    4 >>  2 files changed, 15 insertions(+), 1 deletions(-) >> >> diff -

Re: [RFC 9/9] crypto: Add Samsung crypto engine driver

2010-08-02 Thread Kyungmin Park
Hi, Any update on this? Thank you, Kyungmin Park On Sat, Jun 12, 2010 at 4:49 AM, Maurus Cuelenaere wrote: > This patch adds support for the Samsung crypto engine driver available in the > S3C64XX and S5PC100 SoCs. Currently this supports AES and (T)DES with ECB and > CBC block ciph

Re: [PATCH v3 1/8] ARM: Samsung: Add register definitions for Samsung S5P SoC camera interface

2010-08-02 Thread Kyungmin Park
>> > file with register definitions to drivers/media? >> >> What I'm suggesting is what's been pretty standard in Linux for a long >> time.  Take a look at: drivers/net/3c503.[ch], or for a more recent >> driver, drivers/net/e1000/*.[ch].  Or drivers/mmc/hos

Re: [PATCH v4 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver

2010-08-02 Thread Kyungmin Park
On Tue, Aug 3, 2010 at 10:05 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Tue, Aug 3, 2010 at 9:46 AM, Kukjin Kim wrote: >> > Kyungmin Park wrote: >> >> >> >> On Tue, Aug 3, 2010 at 8:58 AM, Kukjin Kim > wrote: >> >> >

Re: Please remind 'WARNING: about Samsung merge window over'

2010-08-02 Thread Kyungmin Park
On Tue, Aug 3, 2010 at 9:53 AM, Kukjin Kim wrote: > Russell King wrote: >> >> On Mon, Aug 02, 2010 at 05:35:37PM +0900, Kyungmin Park wrote: >> > As the maintainer, he merged his features freely but others can't get >> > the chance if the implementation is no

Re: [PATCH v4 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver

2010-08-02 Thread Kyungmin Park
On Tue, Aug 3, 2010 at 9:46 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Tue, Aug 3, 2010 at 8:58 AM, Kukjin Kim wrote: >> > Marek Szyprowski wrote: >> >> >> >> From: Sylwester Nawrocki >> >> >> >> FIMC (CAMIF) d

Re: [PATCH v4 3/8] ARM: Samsung: Add platform definitions and helpers for FIMC driver

2010-08-02 Thread Kyungmin Park
> memory to memory operations, color conversion, resizing and rotation. >> >> Signed-off-by: Sylwester Nawrocki >> Signed-off-by: Kyungmin Park >> Signed-off-by: Marek Szyprowski >> --- >> >> This is patch is a v3 version rebased onto latest kgene/for-

Re: Please remind 'WARNING: about Samsung merge window over'

2010-08-02 Thread Kyungmin Park
On Mon, Aug 2, 2010 at 4:31 PM, Russell King - ARM Linux wrote: > On Mon, Aug 02, 2010 at 03:24:13PM +0900, Kyungmin Park wrote: >> Absurd !!! >> >> Did you mentioned that samsung merge window over before? >> why it's reminder mail? it's unilateral notific

Re: Please remind 'WARNING: about Samsung merge window over'

2010-08-01 Thread Kyungmin Park
Absurd !!! Did you mentioned that samsung merge window over before? why it's reminder mail? it's unilateral notification at this time. In my feelings. only include the your side (LSI) patches and don't include others (mobile). since it's not fit your taste. Can you explain the difference between

Re: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kyungmin Park
On Fri, Jul 30, 2010 at 10:03 AM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Thu, Jul 29, 2010 at 6:42 PM, Kukjin Kim wrote: >> > From: Naveen Krishna Ch >> > >> > This patch adds HAVE_S3C2410_I2C to control inclusion of I2C bus driver >

Re: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kyungmin Park
s using Samsung ARCH_S3C2410, > _S3C64XX, _S5P6440, _S5PC100, and _S5PV210 to select the I2C driver by default What's the different from use PLAT_SAMSUNG? config I2C_S3C2410 tristate "S3C2410 I2C Driver" depends on PLAT_SAMSUNG Please don't populate t

Re: [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila

2010-07-29 Thread Kyungmin Park
set to 0x3(XUSBXTI) of 0xE010E000(OTHERS) >> +      * for 24MHZ >> +      */ >> +     writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS); > > Not sure if this should be being done directly? will it affect > the current clock tree? It's almost done by bootlo

Re: [PATCH v4 5/8] ARM: S5PV310: Add Timer support

2010-07-26 Thread Kyungmin Park
You mean we can use pwm2 and I2c simultaneously since we don't use the Tout. Do you also consider low power audio case? In the previous time to this reason, HRT uses the RTC and systimer. anyway thank you for clarification. Thank you, Kyungmin Park On Tue, Jul 27, 2010 at 1:58 PM, Sangbeo

Re: [PATCH v4 5/8] ARM: S5PV310: Add Timer support

2010-07-26 Thread Kyungmin Park
xplain it in detail? In the spec, PWM2 is muxed with I2C_7. I muxed it I2C pin to use i2c chip. Thank you, Kyungmin Park > > Thanks and regards, > Sangbeom Kim > > Kyungmin Park wrote: > >>Can you confirm that during boot time, change the pwm2 pin to i2c >>functions

Re: [PATCH v4 5/8] ARM: S5PV310: Add Timer support

2010-07-26 Thread Kyungmin Park
pwm2 pin is changed to i2c function at bootloader to access the i2c chips. Then below code is working? Thank you, Kyungmin Park On Mon, Jul 26, 2010 at 9:42 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This patch adds timer support for S5PV310.  Until now, all

Re: [PATCH v3 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-23 Thread Kyungmin Park
;wp_gpio); > + Put it just one place like this. if (gpio_is_valid(pdata->wp_gpio)) { sdhci_s3c_cfg_wp(pdata->wp_gpio); sdhci_s3c_ops.get_ro = sdhci_s3c_get_ro; host->quirks |= SDHCI_QUIRK_NO_WP_BIT; } It reduce the below quirks check by one. If you add the quriks as your patch, h

Re: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 10:29 PM, Kyungmin Park wrote: > On Wed, Jul 21, 2010 at 9:55 PM, Kukjin Kim wrote: >> Kyungmin Park wrote: >>> >>> On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim wrote: >>> > From: Changhwan Youn >>> > >>> >

Re: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 10:55 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> I don't want to modify Kconfig anymore. it's simple to modify driver > itself. >> > Yeah, I think so. > >> Think the usage of I2c. I think there's no case don&#x

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry "S5PC110_EVT0_WORKAROUND"

2010-07-21 Thread Kyungmin Park
around from a >>>> kernel. We can add such workaround codes with this Kconfig entry. >>>> >>>> Signed-off-by: MyungJoo Ham >>>> Signed-off-by: Kyungmin Park >>>> --- >>>>  arch/arm/mach-s5pv210/Kconfig |    7 +++ >>&

Re: [PATCH v2 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-21 Thread Kyungmin Park
7;s really new IPs of I2C are created. but I expect we also need to define new PLAT_SAMSUNG2 Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 9:59 PM, Kukjin Kim wrote: > From: Naveen Krishna Ch > > This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and > S5P6440.

Re: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 9:29 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> I don't see the Samsung SoCs don't have RTC feature. >> > Yes, you're right... > But it doesn't mean the RTC driver can support every Samsung SoCs now. Vice versa, if th

Re: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-21 Thread Kyungmin Park
On Wed, Jul 21, 2010 at 9:55 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim wrote: >> > From: Changhwan Youn >> > >> > This patch adds Samsung S5PV310/S5PC210 CPU support. >> > The S5

Re: [PATCH v2 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-21 Thread Kyungmin Park
which tree do you use? If not fix the s5pv210_IIC2_IRQ correcly, it can't compile it. but I'm not see related patch at mailing list. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 9:58 PM, Kukjin Kim wrote: > From: Naveen Krishna Ch > > This patch adds support I2C-0

Re: [PATCH] ARM: SAMSUNG: Make RTC driver dependency SoC specific instead of machine specific

2010-07-21 Thread Kyungmin Park
I don't see the Samsung SoCs don't have RTC feature. I think S3C_RTC only depends on PLAT_SAMSUNG so PLAT_SAMSUNG select HAVE_S3C_RTC is enough. Thank you, Kyungmin Park On Wed, Jul 21, 2010 at 6:00 PM, Kukjin Kim wrote: > From: Atul Dahiya > > This patch moves the depen

Re: [PATCH v3 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-20 Thread Kyungmin Park
On Tue, Jul 20, 2010 at 9:11 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This patch adds Samsung S5PV310/S5PC210 CPU support. > The S5PV310/S5PC210 integrates a ARM Cortex A9 multi-core. > > Signed-off-by: Changhwan Youn > Signed-off-by: Jongpill Lee > Signed-off-by: Jiseong Oh > Signed-o

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry "S5PC110_EVT0_WORKAROUND"

2010-07-19 Thread Kyungmin Park
On Mon, Jul 19, 2010 at 4:59 PM, Kukjin Kim wrote: > MyungJoo Ham wrote: >> >> Early S5PC110 (EVT0) chip had some issues required workaround from a >> kernel. We can add such workaround codes with this Kconfig entry. >> >> Signed-off-by: MyungJoo Ham

Re: [PATCH v2 2/5] ARM: S5P: Added default pll values for APLL 800/1000MHz

2010-07-16 Thread Kyungmin Park
ifferently >>> between EVT0 and EVT1 machines. Although this version of kernel >>> assumes that the CPU is EVT1, users may use code for EVT0 later. >>> >>> Note that at 1GHz of ARMCLK, APLL should be 1GHz and for other lower >>> ARMCLK, APLL should

Re: [PATCH v2 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-16 Thread Kyungmin Park
f yes, can you make it similar way? Thank you, Kyungmin Park On Fri, Jul 16, 2010 at 8:52 PM, Russell King - ARM Linux wrote: > On Fri, Jul 16, 2010 at 05:58:28PM +0900, Kukjin Kim wrote: >> diff --git a/arch/arm/mach-s5pv310/platsmp.c >> b/arch/arm/mach-s5pv310/platsmp.c >

Re: [PATCH v2 2/5] ARM: S5P: Added default pll values for APLL 800/1000MHz

2010-07-16 Thread Kyungmin Park
kernel >> assumes that the CPU is EVT1, users may use code for EVT0 later. >> >> Note that at 1GHz of ARMCLK, APLL should be 1GHz and for other lower >> ARMCLK, APLL should be 800MHz. >> >> Signed-off-by: MyungJoo Ham >> Signed-off-by: Kyungmin Park >&g

Re: [PATCH 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-16 Thread Kyungmin Park
gt; > +static struct i2c_board_info smdkc100_i2c_devs0[] __initdata = { > +       { I2C_BOARD_INFO("24c08", 0x50), },     /* Samsung S524AD0XD1 */ > +}; > + why smdkc100? > +static struct i2c_board_info smdkc100_i2c_devs1[] __initdata = { > +       /* To Be Updated *

Re: [PATCH 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-16 Thread Kyungmin Park
_SLAVE > >  config I2C_S3C2410 >        tristate "S3C2410 I2C Driver" > -       depends on ARCH_S3C2410 || ARCH_S3C64XX > +       depends on ARCH_S3C2410 || ARCH_S3C64XX || ARCH_S5PV210 || > ARCH_S5P6440 Are there any SoCs don't have i2c? If no, how about to just depen

Re: [PATCH 0/3] Add support I2C devices on SMDK6440, SMDKC110 and SMDKV210

2010-07-16 Thread Kyungmin Park
k you, Kyungmin Park On Fri, Jul 16, 2010 at 10:13 PM, Kukjin Kim wrote: > This patches is to support I2C devices on SMDK6440, SMDKC110 and SMDKV210. > S5P6440 can support I2C channel 0 and 1, and S5PV210/S5PC110 can support > I2C channel 0, 1 and 2. > > [PATCH 1/3] ARM: S5P6440: Add suppo

Re: [PATCH v2 2/8] ARM: S5PV310: Add new CPU initialization support

2010-07-16 Thread Kyungmin Park
On Fri, Jul 16, 2010 at 5:58 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This patch adds Samsung's S5PV310/S5PC210 CPU support. > The S5PV310/S5PC210 integrates a ARM Cortex A9 multi-core. > > Signed-off-by: Changhwan Youn > Signed-off-by: Jongpill Lee > Signed-off-by: Kukjin Kim > --- >

Re: [PATCH v2 7/8] ARM: S5PV310: Add Board support file

2010-07-16 Thread Kyungmin Park
On Fri, Jul 16, 2010 at 5:58 PM, Kukjin Kim wrote: > From: Changhwan Youn > > This patch adds Samsung SMDKV310 board support file. > > Signed-off-by: Changhwan Youn > Signed-off-by: Kukjin Kim > --- >  arch/arm/mach-s5pv310/Makefile        |    4 ++ >  arch/arm/mach-s5pv310/mach-smdkv310.c |  

Re: [PATCH v2 5/8] ARM: S5PV310: Add Timer support

2010-07-16 Thread Kyungmin Park
ach-s5pv310/time.c > @@ -0,0 +1,287 @@ > +/* linux/arch/arm/mach-s5pv310/time.c > + * > + * Copyright (c) 2010 Samsung Electronics Co., Ltd. > + *             http://www.samsung.com > + * > + * S5PV310 (and compatible) HRT support > + * PWM 2/4 is used for this feature P

Re: [PATCH v2] ARM: s5pv210_defconfig: Update for removing s5pc110_defconfig

2010-07-14 Thread Kyungmin Park
-based against linux-2.6.35-rc5 which includes >>   'ARM: reduce defconfigs' from Uwe Kleine-Konig. No need to update board_defconfig since the latest merge removes the all arm *_defconfig. Thank you, Kyungmin Park >> >>  arch/arm/configs/s5pc110_defconfig |   66 ---

Re: [PATCH 1/3] arm: s5pv210: GONI: add support for framebuffer

2010-07-14 Thread Kyungmin Park
One framebuffer window in 480x800x16bpp mode is >> > defined. >> > >> > Signed-off-by: Marek Szyprowski >> > Signed-off-by: Kyungmin Park >> > --- >> >  arch/arm/mach-s5pv210/Kconfig     |    2 + >> >  arch/arm/mach-s5pv210/mach-g

Re: [PATCH v2] ARM: s5pv210_defconfig: Update for removing s5pc110_defconfig

2010-07-12 Thread Kyungmin Park
On Tue, Jul 13, 2010 at 3:17 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> Question? >> >> Are there difference between smdkc110 and smdkv210? > > Yes. > > The components on the board are different such as default LCD module, > external memory, conne

Re: [PATCH v2] ARM: s5pv210_defconfig: Update for removing s5pc110_defconfig

2010-07-12 Thread Kyungmin Park
Question? Are there difference between smdkc110 and smdkv210? Thank you, Kyungmin Park On Tue, Jul 13, 2010 at 11:22 AM, Kukjin Kim wrote: > Now that S5PC110 machines and S5PV210 machines can be built into > one kernel, update mach-s5pv210/Kconfig and s5pv210_defconfig. > > Tested

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-12 Thread Kyungmin Park
On Mon, Jul 12, 2010 at 6:58 PM, Kukjin Kim wrote: > Kyungmin Park wrote: > >> >> Interesting. >> >> I got tested with >> #define MAX_PHYSMEM_BITS        31 >> #define SECTION_SIZE_BITS       27 >> >> # cat /proc/sys/vm/min_free_kbytes

Re: About SECTION_SIZE_BITS for Sparsemem

2010-07-12 Thread Kyungmin Park
sys/vm/min_free_kbytes 1820 # echo 1700 > /proc/sys/vm/min_free_kbytes # cat /proc/sys/vm/min_free_kbytes 1700 No kernel panic. Thank you, Kyungmin Park On Mon, Jul 12, 2010 at 5:32 PM, Kukjin Kim wrote: > Russell, > > Hi, > > Kukjin Kim wrote: >> Russell wrote: >> > So, m

Re: Requested features for next merge on s5pc110

2010-07-08 Thread Kyungmin Park
2010/7/9 Kukjin Kim : > Kyungmin Park wrote: >> >> Hi Kukjin, >> > Hi, > >> Before next merge window, I hope these features will be included. >> If your team is done already, please reply it. If not, our team will do > it. >> >> 1. High-res

Re: Requested features for next merge on s5pc110

2010-07-07 Thread Kyungmin Park
On Thu, Jul 8, 2010 at 12:39 PM, Jassi Brar wrote: > On Thu, Jul 8, 2010 at 12:05 PM, Kyungmin Park wrote: > >> 3. Aquila & goni board support. >>    If possible all feature are included at current maineline kernel >> implemented. > > Without doubt it's

Requested features for next merge on s5pc110

2010-07-07 Thread Kyungmin Park
ting, and cpufreq. Of course I hope it's included. 3. Aquila & goni board support. If possible all feature are included at current maineline kernel implemented. If I'm missing one features, please let me know, Give your opinions. Thank you, Kyungmin Park -- To unsubscribe from t

Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.

2010-07-06 Thread Kyungmin Park
XI offset address becomes 0x_ ~ 0x07FF_. If AXI base address of memory chip0 is 0x2000_, then memory chip0 has an address range of 0x2000_ ~ 0x27FF_. Thank you, Kyungmin Park > > As you know, the size of a section should be a power of 2 and a physical > address s

Re: [PATCH] ARM: S5PV210: Fix on SECTION_SIZE_BITS on S5PV210/S5PC110.

2010-07-05 Thread Kyungmin Park
oblem? Even though 80MiB is used at logical size. it used the physical 128MiB so. it's reasonable to use 128MiB align instead of 16MiB. Are there boards use 64MiB or less? I think if decrease the SECTIONS_SIZE_BITS, it wastes the memory. Thank you, Kyungmin Park > > Reported-by

Re: [PATCH v2] SDHCI-S3C fixes and enhancements (driver specific code)

2010-07-05 Thread Kyungmin Park
Hi Andrew, I hope to merge it at next merge windows. Others any comments? Thank you, Kyungmin Park On Wed, Jun 16, 2010 at 3:49 PM, Marek Szyprowski wrote: > Hello, > > This series includes various fixes to sdhci-s3c driver as well as a > major feature enhancement. This pat

Re: [PATCH] ARM: S5P: Add PMU device

2010-07-05 Thread Kyungmin Park
On Tue, Jul 6, 2010 at 12:12 PM, Kukjin Kim wrote: > Kyungmin Park wrote: >> >> On Mon, Jul 5, 2010 at 9:57 PM, Kukjin Kim wrote: >> > Maurus Cuelenaere wrote: >> >> >> >>  Op 05-07-10 03:46, Joonyoung Shim schreef: >> >> >

Re: [PATCH] ARM: S5P: Add PMU device

2010-07-05 Thread Kyungmin Park
lpful if you could add 6440 PMUIRQ (VIC1[23]) in > this patch. It's another story. Can you explain the difference between 6440 and 6442? As I heard it's same chip and type is difference. If true, how about to delete the 6442 directory? It makes a single kernel simple. Thank you, Kyu

Re: [PATCH] ARM: SAMSUNG: updates sdhci.h for Samsung SoCs

2010-07-05 Thread Kyungmin Park
k you, Kyungmin Park On Mon, Jul 5, 2010 at 9:18 PM, Kukjin Kim wrote: > This patch updates sdhci.h as Maurus suggestion like following: > > From: >        #ifdef ... >        function() >        { >                blahblah; >        } >        #else >        fu

Re: [PATCH 8/8] ARM: S5PV310: Add serial port support

2010-07-01 Thread Kyungmin Park
Hi, As previous description. it's also same except the udivslot calculation and clock selection. How about to just modify current v210 serial codes by just adding the V310 or C210 type? Thank you, Kyungmin Park On Fri, Jun 25, 2010 at 11:27 PM, Kukjin Kim wrote: > From: Changh

<    1   2   3   4   >