Re: [PATCH] sg: increase sglist_len of the sg_scatter_hold structure

2007-08-05 Thread FUJITA Tomonori
On Sun, 05 Aug 2007 12:55:16 -0400 Douglas Gilbert <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > unsigned short is too small for sizeof(struct scatterlist) * > > min(q->max_hw_segments, q->max_phys_segments). > > > > This fixes memory leak with 4096 segments since 16 (likely sg size > >

[PATCH] sg: use idr to replace static arrays

2007-08-05 Thread James Bottomley
sg uses a scheme to reallocate a single contiguous array of all its pointers for lookup and management. This didn't matter too much when sg could only attach 256 nodes, but now the maximum has been bumped up to 32k we're starting to push the limits of the maximum allocatable contiguous memory. Th

Re: [3/3] 2.6.23-rc2: known regressions

2007-08-05 Thread Jeremy Fitzhardinge
Michal Piotrowski wrote: > Virtualization > > Subject : drivers/net/xen-netfront.c: bogus code > References : http://lkml.org/lkml/2007/7/22/256 > Last known good : ? > Submitter : Adrian Bunk <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : Jeremy Fitzhardinge <[EMA

Re: [2/2] 2.6.23-rc2: known regressions with patches

2007-08-05 Thread Ingo Molnar
* Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Memory management > > Subject : [bug] SLUB & freeing locks > References : http://lkml.org/lkml/2007/7/26/90 > Last known good : ? > Submitter : Ingo Molnar <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : Peter Zijl

Re: [PATCH] sg: increase sglist_len of the sg_scatter_hold structure

2007-08-05 Thread Douglas Gilbert
FUJITA Tomonori wrote: > unsigned short is too small for sizeof(struct scatterlist) * > min(q->max_hw_segments, q->max_phys_segments). > > This fixes memory leak with 4096 segments since 16 (likely sg size > with x86) * 4096 sets sglist_len to zero. > > This might not happen without sg chaining s

Re: Some quick scsi documentation questions:

2007-08-05 Thread Douglas Gilbert
Stefan Richter wrote: > Rob Landley wrote: >> So an sg device is for something like a scanner that doesn't >> present a block device? > > That's what I heard. The sg driver is a SCSI pass-through while the bsg driver is a pass-through the specializes in SCSI and other (usually) storage related p

Re: [2/2] 2.6.23-rc2: known regressions with patches

2007-08-05 Thread Thomas Renninger
On Sun, 2007-08-05 at 18:26 +0200, Michal Piotrowski wrote: > Hi all, > Modpost > > Subject : modpost bug breaks ia64 cross compilation > References : http://lkml.org/lkml/2007/7/27/30 > http://lkml.org/lkml/2007/7/27/418 > Last known good : ? > Submitter : Ja

Re: [2/2] 2.6.23-rc2: known regressions with patches

2007-08-05 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc2 with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk6

Re: [3/3] 2.6.23-rc2: known regressions

2007-08-05 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.23-rc2. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk6 Andi Kleen

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Justin T. Gibbs
All of this logic was simplified back in '05 in the BSD drivers by adding this to the top of the function: u_int dummy_column; if (cur_column == NULL) { dummy_column = 0; cur_column = &dummy_column; } and then stripping out the cur_column =

Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining

2007-08-05 Thread FUJITA Tomonori
From: Boaz Harrosh <[EMAIL PROTECTED]> Subject: Re: [PATCHSET 0/5] Peaceful co-existence of scsi_sgtable and Large IO sg-chaining Date: Tue, 31 Jul 2007 23:12:26 +0300 > Boaz Harrosh wrote: > > FUJITA Tomonori wrote: > >> From: Benny Halevy <[EMAIL PROTECTED]> > >> Subject: Re: [PATCHSET 0/5] Pea

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Jesper Juhl
On Sunday 05 August 2007 17:42:31 Justin T. Gibbs wrote: > All of this logic was simplified back in '05 in the BSD drivers by adding > this to the top of the function: > > u_int dummy_column; > > if (cur_column == NULL) { > dummy_column = 0; > c

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread James Bottomley
On Sun, 2007-08-05 at 17:36 +0200, Jesper Juhl wrote: > On 04/08/07, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: > > > (resend of patch previously submitted on 28-Jul-2007 23:06) > > > > > > > > > Ehlo, > > > > > > The Coverity checker notice

Re: [PATCH][RESEND] Fix a potential NULL pointer deref in the aic7xxx, ahc_print_register() function

2007-08-05 Thread Jesper Juhl
On 04/08/07, James Bottomley <[EMAIL PROTECTED]> wrote: > On Sat, 2007-08-04 at 20:30 +0200, Jesper Juhl wrote: > > (resend of patch previously submitted on 28-Jul-2007 23:06) > > > > > > Ehlo, > > > > The Coverity checker noticed that we have a potential NULL pointer > > deref in drivers/scsi/aic7

[PATCH] sg: increase sglist_len of the sg_scatter_hold structure

2007-08-05 Thread FUJITA Tomonori
unsigned short is too small for sizeof(struct scatterlist) * min(q->max_hw_segments, q->max_phys_segments). This fixes memory leak with 4096 segments since 16 (likely sg size with x86) * 4096 sets sglist_len to zero. This might not happen without sg chaining support. Signed-off-by: FUJITA Tomono

Megaraid2: Dell PERC 4/DC connected to Dell Powervault 220S, poor performance.

2007-08-05 Thread Paul Bright
Hi, Im wondering if anyone can help me out with the megaraid2 driver. Ive got a Dell PERC 4/DC connected to a Dell powervault 220S, cluster mode is enabled (write cache OFF) because eventually there will be two machines connected to the powervault for shared scsi. Ive tried the Dell PERC 4 card