Re: [PATCH v5 0/4] [SCSI] sg: fix race condition in sg_open

2013-07-31 Thread Douglas Gilbert
On 13-07-22 01:03 PM, Jörn Engel wrote: On Mon, 22 July 2013 12:40:29 +0800, Vaughan Cao wrote: There is a race when open sg with O_EXCL flag. Also a race may happen between sg_open and sg_remove. Changes from v4: * [3/4] use ERR_PTR series instead of adding another parameter in sg_add_sfp

Re: [PATCH] virtio-scsi: Fix virtqueue affinity setup

2013-07-31 Thread Rusty Russell
Asias He writes: > vscsi->num_queues counts the number of request virtqueue which does not > include the control and event virtqueue. It is wrong to subtract > VIRTIO_SCSI_VQ_BASE from vscsi->num_queues. > > This patch fixes the following panic. Applied. Thanks, Rusty. > > (qemu) device_del scs

Re: [PATCH] virtio-scsi: Fix virtqueue affinity setup

2013-07-31 Thread Wanlong Gao
On 07/31/2013 10:17 PM, Asias He wrote: > vscsi->num_queues counts the number of request virtqueue which does not > include the control and event virtqueue. It is wrong to subtract > VIRTIO_SCSI_VQ_BASE from vscsi->num_queues. > > This patch fixes the following panic. > > (qemu) device_del scsi0

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-31 Thread Bernd Schubert
On 07/31/2013 05:15 AM, Martin K. Petersen wrote: >> "Bernd" == Bernd Schubert writes: > > Bernd, > >>> Product revision level: R001 > > It's clearly not verbatim passthrough... > > Bernd> Besides the firmware, the difference might be that I'm exporting > Bernd> single disks without any a

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-31 Thread Alexander Gordeev
On Thu, Jul 25, 2013 at 12:16:41PM +0200, Alexander Gordeev wrote: > On Mon, Jul 22, 2013 at 02:10:36PM -0700, Nicholas A. Bellinger wrote: > > Np. FYI, you'll want to use the latest commit e7827b351 HEAD from > > target-pending/scsi-mq, which now has functioning scsi-generic support. > > Survive

Re: [PATCHv2] pm80xx: fix Adaptec 71605H hang

2013-07-31 Thread Jack Wang
On 07/26/2013 06:43 PM, Hans Verkuil wrote: > The IO command size is 128 bytes for these new controllers as opposed to 64 > for the old 8001 controller. > > The Adaptec out-of-tree driver did this correctly. After comparing the two > this turned out to be the crucial difference. > > So don't hard

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-31 Thread Alan Stern
On Wed, 31 Jul 2013, Oliver Neukum wrote: > These errors should be handled cleanly. How about this patch? > From 76a377d9894dc8945e9afecc7f9864e6dc3156b1 Mon Sep 17 00:00:00 2001 > From: Oliver Neukum > Date: Wed, 31 Jul 2013 13:32:51 +0200 > Subject: [PATCH] sd: handle errors during suspend >

Re: Kernel 3.10.3 "reset SuperSpeed USB device number 2 using xhci_hcd"

2013-07-31 Thread Alan Stern
On Tue, 30 Jul 2013, Martin K. Petersen wrote: > James? > > [PATCH] SCSI: Don't attempt to send extended INQUIRY command if > skip_vpd_pages is set > > If a device has the skip_vpd_pages flag set we should simply fail the > scsi_get_vpd_page() call. > > Signed-off-by: Martin K. Petersen > Ack

[PATCH] virtio-scsi: Fix virtqueue affinity setup

2013-07-31 Thread Asias He
vscsi->num_queues counts the number of request virtqueue which does not include the control and event virtqueue. It is wrong to subtract VIRTIO_SCSI_VQ_BASE from vscsi->num_queues. This patch fixes the following panic. (qemu) device_del scsi0 BUG: unable to handle kernel NULL pointer dereferenc

Re: [PATCH 7/7] scsi: ufs: configure the attribute for power mode

2013-07-31 Thread Subhash Jadavani
Change looks good (except one minor question). Reviewed-by: Subhash Jadavani On 7/26/2013 7:19 PM, Seungwon Jeon wrote: UIC attributes can be set with using DME_SET command for power mode change. For configuration the link capability attributes are used, which is updated after successful link

Re: Ejected Nook (usb mass storage) prevents suspend

2013-07-31 Thread Oliver Neukum
On Mon, 2013-07-29 at 10:21 -0400, Alan Stern wrote: > On Mon, 29 Jul 2013, Oliver Neukum wrote: > > > On Fri, 2013-07-26 at 16:31 -0400, Alan Stern wrote: > > > > > In addition to my earlier comment, the patch below should be applied. > > > It will fix your immediate problem, although not in t

Re: [PATCH RESEND 0/1] AHCI: Optimize interrupt processing

2013-07-31 Thread Tejun Heo
Hello, On Tue, Jul 30, 2013 at 09:16:02PM -0700, Marc C wrote: > >> One thing which would probably be worthwhile tho is getting rid of the > >> bitmap based qc tag allocator in libata. That one is just borderline > >> stupid to keep around on any setup which is supposed to be scalable. > > Your b

RE: [PATCH] scsi/isci/port_config: Fix a infinite loop.

2013-07-31 Thread Dorau, Lukasz
On Wednesday, July 17, 2013 4:54 AM Xinghai Yu wrote: > > It seems the "phy_index++;" have been placed in wrong place, without it > the while circle up will do a infinite loop. > > Signed-off-by: Xinghai Yu Acked-by: Lukasz Dorau > --- > drivers/scsi/isci/port_config.c |2 +- > 1 files