Re: [PATCH 09/11] target_core_alua: Use workqueue for ALUA transitioning

2013-10-16 Thread Hannes Reinecke
On 10/17/2013 12:06 AM, Nicholas A. Bellinger wrote: > On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: >> Use a workqueue for processing ALUA state transitions; this allows >> us to process implicit delay properly. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/target/target_cor

Re: [PATCH 02/11] target_core_alua: Store supported ALUA states

2013-10-16 Thread Hannes Reinecke
On 10/16/2013 11:19 PM, Nicholas A. Bellinger wrote: > On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: >> The supported ALUA states might be different for individual >> devices, so store it in a separate field. >> >> Signed-off-by: Hannes Reinecke >> --- >> drivers/target/target_core_al

RE: [PATCH][SCSI] megaraid_sas: Fix synchronization problem between sysPD IO path and AEN path

2013-10-16 Thread Saxena, Sumit
>-Original Message- >From: James Bottomley [mailto:jbottom...@parallels.com] >Sent: Thursday, October 17, 2013 3:15 AM >To: Saxena, Sumit >Cc: linux-scsi@vger.kernel.org; Desai, Kashyap; aradf...@gmail.com >Subject: Re: [PATCH][SCSI] megaraid_sas: Fix synchronization problem >between sysP

RE: [PATCH Resend] [scsi] pm8001 : fix panic when cat /sys/class/sas_phy/phy-8:0/running_disparity_error_count

2013-10-16 Thread lindar_liu
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80xx_h > wi.c index 9f91030..c0ea473 100644 > --- a/drivers/scsi/pm8001/pm80xx_hwi.c > +++ b/drivers/scsi/pm8001/pm80xx_hwi.c > @@ -3076,8 +3076,43 @@ static int mpi_get_controller_config_resp(struct pm80 > 01_hba_info *pm8001_

Re: [PATCH 3/3] Fix device detection issues with mvsas driver

2013-10-16 Thread Praveen Murali
The only way to reproduce this is to keep hot plugging drives. To speed it up once in a while remove the drive before the detection completes. > On Oct 16, 2013, at 7:42 PM, "xiangliang yu" wrote: > > Hi, > > >Subject: Re: [PATCH 3/3] Fix device detection issues with mvsas driver > > >Hi Xian

Re: [Bug] 12.864681 BUG: lock held when returning to user space!

2013-10-16 Thread vaughan
On 10/17/2013 06:41 AM, Douglas Gilbert wrote: > That seems to be the case. Vaughan acknowledged the > problem and forwarded it to me 8 days ago. Yes, it > seems to be a "no-no" to hold a any kernel semaphore > when returning to the user space; in this case from > sg_open(). I was hoping a revised

Re: [PATCH 2/2] target_core_alua: Referrals configfs integration

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:25 +0200, Hannes Reinecke wrote: > Referrals need an LBA map, which needs to be kept > consistent across all target port groups. So > instead of tying the map to the target port groups > I've implemented a single attribute containing the > entire map. > > Signed-off-by: Ha

Re: [Bug] 12.864681 BUG: lock held when returning to user space!

2013-10-16 Thread Douglas Gilbert
On 13-10-16 09:24 AM, James Bottomley wrote: On Tue, 2013-10-08 at 09:45 -0400, Douglas Gilbert wrote: On 13-10-08 02:44 AM, vaughan wrote: Hi Madper, CC to Douglas to get comments. I use the rw_semaphore o_sem to protect excl open, introduced in commit 15b06f9a02406e5460001db6d5af5c738cd3d4e7

Re: [PATCH] target: Pass through I/O topology for block backstores

2013-10-16 Thread Andy Grover
On 10/12/2013 01:08 AM, Christoph Hellwig wrote: On Fri, Oct 11, 2013 at 11:52:53AM -0700, Andy Grover wrote: It seemed better to me to keep the munging from queue_limits values to what the target core needed in the block backstore code, and not use a block-specific structure in the backstore<->

Re: [PATCH 1/2] target_core_alua: Referrals infrastructure

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:25 +0200, Hannes Reinecke wrote: > Add infrastructure for referrals. > > Signed-off-by: Hannes Reinecke > --- > drivers/target/target_core_alua.c | 151 > ++ > drivers/target/target_core_alua.h | 4 +- > drivers/target/target_co

Re: [PATCH 3/3] Fix device detection issues with mvsas driver

2013-10-16 Thread Praveen Murali
Hi Xiang, Can you please take a look at the attached patch and ack it? Thanks, Praveen On 10/16/2013 02:45 PM, James Bottomley wrote: On Tue, 2013-10-15 at 19:40 -0700, Praveen Murali wrote: Yes, I checked that today and was meaning to ask you about it. :) Ideally, I need someone from Marvell

How are you doing.

2013-10-16 Thread Brice
Dear friend I am Mr.Axel Brice a banker from one of the international bank here in my country. Although the world is spherical and hard place to met people because you don't know who to trust or believe, but I have developed my trust to you to confide this confidential business proposal.

Re: [PATCH 00/11] target_core_mod: ALUA updates

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: > Hi Nic, > > here are some updates to TCM ALUA handling. Apart from some > minor fixes and spellchecks the main features are: > - Make supported states configurable: > We should make the list of supported ALUA states configurable, > as

Re: [PATCH 09/11] target_core_alua: Use workqueue for ALUA transitioning

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: > Use a workqueue for processing ALUA state transitions; this allows > us to process implicit delay properly. > > Signed-off-by: Hannes Reinecke > --- > drivers/target/target_core_alua.c | 174 > +++--- >

Help us complete this charity project, reply for detail!!!

2013-10-16 Thread Mr. Allen & Violet Large
-- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] Fix device detection issues with mvsas driver

2013-10-16 Thread James Bottomley
On Tue, 2013-10-15 at 19:40 -0700, Praveen Murali wrote: > Yes, I checked that today and was meaning to ask you about it. :) Ideally, I need someone from Marvell to ack it ... can you prod them? Thanks, James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body

Re: [PATCH][SCSI] megaraid_sas: Fix synchronization problem between sysPD IO path and AEN path

2013-10-16 Thread James Bottomley
On Wed, 2013-10-16 at 17:04 +0530, sumit.sax...@lsi.com wrote: > There is syncronization problem between sysPD IO path and AEN path. Driver > maintains instance->pd_list[] array, which will get updated(by calling > function megasas_get_pd_list[]), whenever any of below events occurs- > > MR_EVT_

Re: [PATCH 07/11] target_core_alua: Allocate ALUA metadata on demand

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: > We should only allocate ALUA metadata if we're actually going > to write them. > > Signed-off-by: Hannes Reinecke > --- > drivers/target/target_core_alua.c | 70 > +-- > drivers/target/target_core_al

Re: [PATCH 06/11] target_core_alua: Validate ALUA state transition

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: > As we now can modify the list of supported states we need to > validate the requested ALUA state when doing a state transition. > > Signed-off-by: Hannes Reinecke > --- Looks good. --nab > drivers/target/target_core_alua.c | 85 > ++

Re: [PATCH 03/11] target_core_alua: Make supported states configurable

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke > --- > drivers/target/target_core_configfs.c | 50 > +++ > 1 file changed, 50 insertions(+) > > diff --git a/drivers/target/target_core_configfs.c > b/drivers/target/targ

Re: [PATCH 02/11] target_core_alua: Store supported ALUA states

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: > The supported ALUA states might be different for individual > devices, so store it in a separate field. > > Signed-off-by: Hannes Reinecke > --- > drivers/target/target_core_alua.c | 14 -- > drivers/target/target_core_alua.

Re: [PATCH 01/11] target core: rename (ex,im)plict -> (ex,im)plicit

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:20 +0200, Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke > --- > drivers/target/target_core_alua.c | 110 > - > drivers/target/target_core_alua.h | 20 +++--- > drivers/target/target_core_configfs.c | 26 > d

Re: [PATCH 0/5] Updates for tcm_loop

2013-10-16 Thread Nicholas A. Bellinger
On Wed, 2013-10-16 at 09:12 +0200, Hannes Reinecke wrote: > Hi Nic, > > here are some updates to tcm_loop I've done during ALUA testing. > I've implemented a 'transport_state' attribute to simulate > transport failure and added command abort callbacks. > > Hannes Reinecke (5): > tcm_loop: Check

Re: [PATCH] target: Return an error for WRITE SAME with ANCHOR==1

2013-10-16 Thread Nicholas A. Bellinger
On Mon, 2013-10-14 at 15:49 -0700, Roland Dreier wrote: > From: Roland Dreier > > Per SBC-3, since we report ANC_SUP==0 in VPD page B2h, we need to return > an error (ILLEGAL REQUEST/INVALID FIELD IN CDB) for all WRITE SAME > requests with ANCHOR==1. > > Signed-off-by: Roland Dreier Applied to

kernel cant access SATA adapter device

2013-10-16 Thread Robert Story
Hi, I've got a SATA adapter for a SD card in a Dell Poweredge R610. The BIOS can see and boot the sdcard, (to Windows, or using syslinux/extlinux), but when it hands over control to the Linux kernel, the kernel cannot access it. Here's an excerpt from dmesg: scsi 0:0:2:0: Direct-Access ATA

Re: [Bug] 12.864681 BUG: lock held when returning to user space!

2013-10-16 Thread James Bottomley
On Tue, 2013-10-08 at 09:45 -0400, Douglas Gilbert wrote: > On 13-10-08 02:44 AM, vaughan wrote: > > Hi Madper, > > > > CC to Douglas to get comments. > > I use the rw_semaphore o_sem to protect excl open, introduced in commit > > 15b06f9a02406e5460001db6d5af5c738cd3d4e7 since v3.12-rc1. > > Is it

Re: [PATCH 1/3] scsi: Fix erratic device offline during EH

2013-10-16 Thread James Bottomley
On Mon, 2013-09-02 at 13:58 +0200, Hannes Reinecke wrote: > Commit 18a4d0a22ed6c54b67af7718c305cd010f09ddf8 > (Handle disk devices which can not process medium access commands) > was introduced to offline any device which cannot process medium > access commands. > However, commit 3eef6257de48ff84a5

Re: [PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-10-16 Thread James Bottomley
On Mon, 2013-07-01 at 08:50 +0200, Hannes Reinecke wrote: > This patchs adds an 'eh_deadline' sysfs attribute to the scsi > host which limits the overall runtime of the SCSI EH. > The 'eh_deadline' value is stored in the now obsolete field > 'resetting'. > When a command is failed the start time of

Re: [PATCH] drivers: scsi: lpfc: Fix typo on NULL assignment

2013-10-16 Thread James Smart
Acked-by: James Smart -- james s On 10/15/2013 8:29 PM, Felipe Pena wrote: In the lpfc_ct_free_iocb function after freeing associated memory to the ctiocb->context3, the ctiocb->context1 is set to NULL instead of context3. Signed-off-by: Felipe Pena --- drivers/scsi/lpfc/lpfc_ct.c |2

Re: eSATA Drive Detection issues on mvsas

2013-10-16 Thread Praveen Murali
On 10/15/2013 06:11 PM, Dan Williams wrote: On Tue, Oct 15, 2013 at 5:15 PM, Praveen Murali wrote: Dan/James, Can you please take a look at this and let me know if I am at the right place? Or point me in the right direction? As I understand, this deost not look like an mvsas driver issue.

Re: How to online remove an error scsi disk from the system?

2013-10-16 Thread taco
On Fri, Feb 01, 2013 at 02:13:16PM +0800, Tao Ma wrote: > Hi All, > In our product system, we have several sata disks attached to one > machine. So when one of the disk fails, the jbd2(yes, we use ext4) will > hang forever and we will get something in /var/log/messages like below. > It seems

[PATCH] drivers: scsi: lpfc: Remove useless casting in lpfc_init.c

2013-10-16 Thread Geyslan G. Bem
Casting (void *) value returned by kzalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. Signed-off-by: Geyslan G. Bem --- drivers/scsi/lpfc/lpfc_init.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpf

[PATCH] drivers: scsi: Remove useless casting in hpsa.c

2013-10-16 Thread Geyslan G. Bem
Casting (void *) value returned by kmalloc is useless as mentioned in Documentation/CodingStyle, Chap 14. Signed-off-by: Geyslan G. Bem --- drivers/scsi/hpsa.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 891c86b..896a57d 1

[PATCH][SCSI] megaraid_sas: Fix synchronization problem between sysPD IO path and AEN path

2013-10-16 Thread Sumit.Saxena
There is syncronization problem between sysPD IO path and AEN path. Driver maintains instance->pd_list[] array, which will get updated(by calling function megasas_get_pd_list[]), whenever any of below events occurs- MR_EVT_PD_INSERTED MR_EVT_PD_REMOVED MR_EVT_CTRL_HOST_BUS_SCAN_REQUESTED MR_EVT_

[Bug 63141] New: Linux Kernel will shows "Got wrong page" in kernel log when Linux kernel tries to send SCSI ModeSense command with Page code 0x08 (Caching Mode Page)

2013-10-16 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=63141 Bug ID: 63141 Summary: Linux Kernel will shows "Got wrong page" in kernel log when Linux kernel tries to send SCSI ModeSense command with Page code 0x08 (Caching Mode Page) P

[PATCH 2/2] target_core_alua: Referrals configfs integration

2013-10-16 Thread Hannes Reinecke
Referrals need an LBA map, which needs to be kept consistent across all target port groups. So instead of tying the map to the target port groups I've implemented a single attribute containing the entire map. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 101 +++

[PATCH 1/2] target_core_alua: Referrals infrastructure

2013-10-16 Thread Hannes Reinecke
Add infrastructure for referrals. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 151 ++ drivers/target/target_core_alua.h | 4 +- drivers/target/target_core_configfs.c | 12 ++- drivers/target/target_core_device.c | 2 + dri

[PATCH 0/2] TCM Referrals support

2013-10-16 Thread Hannes Reinecke
Hi Nic, I've finally bitten the bullet and implemented referrals support for TCM. It has been on my to-do list for a long time, but finally I've gotten around to actually _do_ anything about it. TCM now will enable referrals support when an appropriate map is being fed into 'lba_map'. Format ther

Re: PROBLEM: special sense code asc,ascq=04h,0Ch abort scsi scan in the middle

2013-10-16 Thread vaughan
On 10/16/2013 02:52 PM, Hannes Reinecke wrote: > But seeing that this approach raises quite some issues I've attached a > different patch. Vaughan, could you test with that, too? Should be > functionally equivalent to the previous one. Cheers, Hannes Of course. This one is more clear to express ou

[PATCH 04/11] target_core_alua: Rename ALUA_ACCESS_STATE_OPTIMIZED

2013-10-16 Thread Hannes Reinecke
Rename ALUA_ACCESS_STATE_OPTMIZED to ALUA_ACCESS_STATE_OPTIMIZED. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 10 +- drivers/target/target_core_alua.h | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/target/target_core_alua.c b/d

[PATCH 06/11] target_core_alua: Validate ALUA state transition

2013-10-16 Thread Hannes Reinecke
As we now can modify the list of supported states we need to validate the requested ALUA state when doing a state transition. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 85 ++- 1 file changed, 56 insertions(+), 29 deletions(-) diff

[PATCH 08/11] target_core_alua: store old and pending ALUA state

2013-10-16 Thread Hannes Reinecke
During state transition we should be storing both the original and the pending state. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 15 ++- include/target/target_core_base.h | 6 -- 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/

[PATCH 00/11] target_core_mod: ALUA updates

2013-10-16 Thread Hannes Reinecke
Hi Nic, here are some updates to TCM ALUA handling. Apart from some minor fixes and spellchecks the main features are: - Make supported states configurable: We should make the list of supported ALUA states configurable, as some setups would possibly like to support a small subset of ALUA sta

[PATCH 03/11] target_core_alua: Make supported states configurable

2013-10-16 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- drivers/target/target_core_configfs.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index d4c28a3..53e9e00 100644 --- a/drivers/target/targe

[PATCH 09/11] target_core_alua: Use workqueue for ALUA transitioning

2013-10-16 Thread Hannes Reinecke
Use a workqueue for processing ALUA state transitions; this allows us to process implicit delay properly. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 174 +++--- include/target/target_core_base.h | 4 + 2 files changed, 128 insertions(

[PATCH 07/11] target_core_alua: Allocate ALUA metadata on demand

2013-10-16 Thread Hannes Reinecke
We should only allocate ALUA metadata if we're actually going to write them. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 70 +-- drivers/target/target_core_alua.h | 3 ++ include/target/target_core_base.h | 3 -- 3 files changed, 3

[PATCH 02/11] target_core_alua: Store supported ALUA states

2013-10-16 Thread Hannes Reinecke
The supported ALUA states might be different for individual devices, so store it in a separate field. Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 14 -- drivers/target/target_core_alua.h | 11 +++ include/target/target_core_base.h | 1 + 3 files ch

[PATCH 05/11] target_core_alua: spellcheck

2013-10-16 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c index 593de80..a16115e 100644 --- a/drivers/target/target_core_alua.c

[PATCH 01/11] target core: rename (ex,im)plict -> (ex,im)plicit

2013-10-16 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- drivers/target/target_core_alua.c | 110 - drivers/target/target_core_alua.h | 20 +++--- drivers/target/target_core_configfs.c | 26 drivers/target/target_core_device.c| 6 +- drivers/target/target_cor

[PATCH 2/5] tcm_loop: Implement transport offline

2013-10-16 Thread Hannes Reinecke
Add attribute 'transport_status' to simulate link failure. Signed-off-by: Hannes Reinecke --- drivers/target/loopback/tcm_loop.c | 53 +- drivers/target/loopback/tcm_loop.h | 4 +++ 2 files changed, 56 insertions(+), 1 deletion(-) diff --git a/drivers/target

[PATCH 5/5] tcm_loop: Implement target reset

2013-10-16 Thread Hannes Reinecke
Implement target reset by resetting the transport status. Signed-off-by: Hannes Reinecke --- drivers/target/loopback/tcm_loop.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index febe166.

[PATCH 1/5] tcm_loop: Check for valid hba in tcm_loop_drop_nexus()

2013-10-16 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke --- drivers/target/loopback/tcm_loop.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/target/loopback/tcm_loop.c index 0f6d69d..57d5a95 100644 --- a/drivers/target/loopback/tcm_loop.c +++ b/drive

[PATCH 0/5] Updates for tcm_loop

2013-10-16 Thread Hannes Reinecke
Hi Nic, here are some updates to tcm_loop I've done during ALUA testing. I've implemented a 'transport_state' attribute to simulate transport failure and added command abort callbacks. Hannes Reinecke (5): tcm_loop: Check for valid hba in tcm_loop_drop_nexus() tcm_loop: Implement transport of

[PATCH 4/5] tcm_loop: TCQ and command abort support

2013-10-16 Thread Hannes Reinecke
Implement TCQ support, which enables us to do proper command abort, too. Signed-off-by: Hannes Reinecke --- drivers/target/loopback/tcm_loop.c | 71 +++--- drivers/target/loopback/tcm_loop.h | 2 ++ 2 files changed, 69 insertions(+), 4 deletions(-) diff --git a/

[PATCH 3/5] tcm_loop: separate out tcm_loop_issue_tmr

2013-10-16 Thread Hannes Reinecke
No functional change. Signed-off-by: Hannes Reinecke --- drivers/target/loopback/tcm_loop.c | 83 +++--- include/target/target_core_base.h | 1 + 2 files changed, 51 insertions(+), 33 deletions(-) diff --git a/drivers/target/loopback/tcm_loop.c b/drivers/targe