On Tue, 2014-11-04 at 11:14 -0500, Alan Stern wrote:
> On Tue, 4 Nov 2014, James Bottomley wrote:
>
> > On Mon, 2014-11-03 at 16:06 -0500, Dale R. Worley wrote:
> > > Was there any resolution as to how large disk drives would be handled
> > > if their interface
On Mon, 2014-11-03 at 16:06 -0500, Dale R. Worley wrote:
> Was there any resolution as to how large disk drives would be handled
> if their interface did not support the "capacity" request that would
> tell how large they were?
Realistically no ... unless someone comes up with a reliable heuristic
On Sun, 2014-11-02 at 15:47 -0600, James Bottomley wrote:
> With full diff below.
For those of you paying attention, I managed to generate a reverse diff.
The actual forward diff is below.
James
---
diff --git a/MAINTAINERS b/MAINTAINERS
index dab92a7..82d4ad2 100644
--- a/MAINTAINERS
++
This is a set of six patches consisting of two MAINTAINER updates, two
scsi-mq fixs for the old parallel interface (not every request is tagged
and we need to set the right flags to populate the SPI tag message) and
a fix for a memory leak in scatterlist traversal caused by a
preallocation update i
On Mon, 2014-10-27 at 09:37 -0500, Brian King wrote:
> The ipr driver does not yet support async aborts, so disable this
> for now.
>
> Signed-off-by: Brian King
By "does not yet support" do you mean doesn't work with or merely not
tested with but seems to work OK? if the former, then surely th
On Tue, 2014-10-21 at 17:05 +0300, Boaz Harrosh wrote:
> Hi Sir Linus
>
> A small administrative stuff, was on vacation and the old email bounced on me.
> I was hoping to still make the 3 weeks merge window, but it was 2 weeks at the
> end.
> Your call if to make this wait for next window. Needles
On Mon, 2014-10-20 at 20:06 +0300, Ebru Akagunduz wrote:
> do_gettimeofday() only can get 32-bit time types
> but the driver should be able to use dates that are
> after January 2038.
>
> Remove do_gettimeofday() and use
> jiffies comparison to supply 64-bit time types.
>
> Signed-off-by: Ebru Ak
On Sat, 2014-10-11 at 10:39 -0700, Christoph Hellwig wrote:
> On Fri, Oct 10, 2014 at 08:49:01AM +0100, Sitsofe Wheeler wrote:
> > Microsoft Hyper-V virtual disks currently only claim SPC-2 compliance
> > even though they implement post SPC-2 features (such as thin
> > provisioning) which means the
On Thu, 2014-10-09 at 16:29 +0200, Arnd Bergmann wrote:
> On Thursday 09 October 2014 06:40:26 James Bottomley wrote:
> > On Wed, 2014-10-08 at 22:58 +0200, Arnd Bergmann wrote:
> > > On Wednesday 08 October 2014 13:44:55 James Bottomley wrote:
> > > > > diff --g
On Wed, 2014-10-08 at 22:58 +0200, Arnd Bergmann wrote:
> On Wednesday 08 October 2014 13:44:55 James Bottomley wrote:
> > > diff --git a/drivers/scsi/ips.h b/drivers/scsi/ips.h
> > > index 45b9566..ff2a0b3 100644
> > > --- a/drivers/scsi/ips.h
> > > ++
On Wed, 2014-10-08 at 23:14 +0300, Ebru Akagunduz wrote:
> This patch changes 32-bit time types to 64-bit in
> ips.c
>
> time_t can only represent signed 32-bit dates but
> the driver should represent dates that are after
> January 2038.
>
> Use time64_t type instead of time_t.
>
> Signed-off-by
This patch set consists of the usual driver updates (megaraid_sas,
arcmsr, be2iscsi, lpfc, mpt2sas, mpt3sas, qla2xxx, ufs) plus several
assorted fixes and miscellaneous updates (including the
pci_msix_enable_range() changes that have been pending for a while).
The patch is available here:
git://g
This is a set of two small fixes, both to code which went in during the
merge window: cxgb4i has a scheduling in atomic bug in its new ipv6 code
and uas fails to work properly with the new scsi-mq code.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-
tag, because when using uas over usb-2 streams are not used.
> >>
> >> Cc: Christoph Hellwig
> >> Reported-by: Douglas Gilbert
> >> Signed-off-by: Hans de Goede
> >> Reviewed-by: Christoph Hellwig
> >
> > This doesn't apply to my usb
On Thu, 2014-10-02 at 15:18 +0200, Hans de Goede wrote:
> Hi,
>
> On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
> > On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
> >> Yes, although that likely would need to go through stable, without
> >> going into 3.18 .
> >>
> >> Greg, is th
On Thu, 2014-10-02 at 14:14 +0200, Hannes Reinecke wrote:
> On 10/02/2014 02:05 PM, James Bottomley wrote:
> > On Thu, 2014-10-02 at 08:51 +0200, Hannes Reinecke wrote:
> >> On 10/01/2014 11:10 PM, Christoph Hellwig wrote:
> >>> On Wed, Oct 01, 2014 at 02:51
On Thu, 2014-10-02 at 08:51 +0200, Hannes Reinecke wrote:
> On 10/01/2014 11:10 PM, Christoph Hellwig wrote:
> > On Wed, Oct 01, 2014 at 02:51:31PM -0400, Webb Scales wrote:
> >> Hannes,
> >>
> >> In megasas_change_queue_type(), is it possible for sdev->queue_depth to be
> >> greater than 256?
> >>
On Wed, 2014-10-01 at 15:10 +, Markus Stockhausen wrote:
> [SCSI] enclosure: Handle non-unique element descriptors
>
> Some SES devices give non-unique Element Descriptors as part of the
> Element Descriptor diag page. Since we use these for creating sysfs
> entries, they need to be unique. Th
On Wed, 2014-10-01 at 08:08 +, Anish Bhatt wrote:
> James,
> This is bugfix and prevents a "scheduling while atomic" bug that can be
> hit when using an ipv6 address with cxgb4i, and can possibly be seen without
> Chelsio hardware. Could this be cherry picked for 3.17 please ?
Can you de
On Mon, 2014-09-29 at 13:55 -0500, micha...@cs.wisc.edu wrote:
> From: Mike Christie
>
> Dan Carpenter found a issue where be2iscsi would copy the ip
> from userspace to the driver buffer before checking the len
> of the data being copied:
> http://marc.info/?l=linux-scsi&m=140982651504251&w=2
>
On Mon, 2014-09-29 at 12:52 -0400, Webb Scales wrote:
> [Hannes, James, Christoph: sorry for the extra copies -- my mail client
> didn't automatically convert to plain-text for the list, so it bounced.]
>
> Could someone enlighten me on when and where a driver might want to or
> be required to
On Fri, 2014-09-26 at 10:20 +0200, Hannes Reinecke wrote:
> On 09/26/2014 10:03 AM, Christoph Hellwig wrote:
> > On Fri, Sep 26, 2014 at 08:29:29AM +0200, Hannes Reinecke wrote:
> >> Hi Christoph,
> >>
> >> as discussed it would make sense to use the request->tag in eg
> >> scmd_printk() to identif
This is a set of three fixes. One represents a nasty shared tag map
regression (another inverted condition) caused by recent SCSI MQ
patches, one is a longstanding potential buffer overrun in the iscsi
data buffer and the final one is a use after free for the rare
bidirectional commands.
The patc
On Tue, 2014-09-16 at 14:37 -0700, Christoph Hellwig wrote:
> On Mon, Sep 15, 2014 at 03:58:18PM -0700, Christoph Hellwig wrote:
> > I've pushed two updates to the core-for-3.17 branch of
> >
> > git://git.infradead.org/users/hch/scsi-queue.git
> >
> > which should go to Linus before the next
On Sun, 2014-09-14 at 12:32 +0200, Hans de Goede wrote:
> Hi,
>
> On 09/14/2014 12:29 PM, James Bottomley wrote:
> > On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote:
> >> Hi,
> >>
> >> On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
> >>
On Sun, 2014-09-14 at 11:26 +0200, Hans de Goede wrote:
> Hi,
>
> On 09/13/2014 09:31 PM, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 9/13/2014 1:26 PM, Hans de Goede wrote:
> >
> >> The data urbs are all killed before calling zap_pending, and their
> >> completion
> >> handler should have cle
On Tue, 2014-09-09 at 16:01 -0700, Dmitry Torokhov wrote:
> On Tuesday, September 09, 2014 03:46:23 PM James Bottomley wrote:
> > On Wed, 2014-09-10 at 07:41 +0900, Tejun Heo wrote:
> > >
> > > The thing is that we have to have dynamic mechanism to listen for
> &g
On Wed, 2014-09-10 at 12:07 +0200, Ceriel Jacobs wrote:
> Tom Gundersen schreef op 10-09-14 om 08:46:
> >> >Indeed. What I proposed with a multiplier for the timeout for the
> >> >different types of built in commands was deemed complex but saw no
> >> >alternatives proposed despite my interest to w
On Wed, 2014-09-10 at 07:41 +0900, Tejun Heo wrote:
> Hello,
>
> On Tue, Sep 09, 2014 at 03:26:02PM -0700, James Bottomley wrote:
> > > We no longer report back error on probe failure on module load.
> >
> > Yes, we do; for every probe failure of a device on a dr
On Wed, 2014-09-10 at 06:42 +0900, Tejun Heo wrote:
> Hey, James.
>
> On Tue, Sep 09, 2014 at 12:35:46PM -0700, James Bottomley wrote:
> > I don't have very strong views on this one. However, I've got to say
> > from a systems point of view that if the desire is
On Tue, 2014-09-09 at 12:16 -0700, Luis R. Rodriguez wrote:
> On Mon, Sep 8, 2014 at 10:38 PM, James Bottomley
> wrote:
> > If we want to sort out some sync/async mechanism for probing devices, as
> > an agreement between the init systems and the kernel, that's fi
On Tue, 2014-09-09 at 10:10 +0900, Tejun Heo wrote:
> Hello, Luis.
>
> On Mon, Sep 08, 2014 at 06:04:23PM -0700, Luis R. Rodriguez wrote:
> > > I have no idea how the selection should be. It could be per-insmod or
> > > maybe just a system-wide flag with explicit exceptions marked on
> > > driver
On Mon, 2014-09-08 at 10:51 -0400, Alan Stern wrote:
> On Sun, 7 Sep 2014, Shirish Pargaonkar wrote:
>
> > I think the problem is, when a gendisk is detached, its request queue
> > is not put in bypass mode
> > cause when it is re-attached, code tries to put it out of bypass mode,
> > hence the wa
On Fri, 2014-09-05 at 09:31 -0400, James Smart wrote:
> On 9/5/2014 1:35 AM, Christoph Hellwig wrote:
> > - patches that you send on with your maintainer hat on should be
> > signed off by you, not just reviewed.
>
> ok - but I guess I had a different interpretation of the meaning for
> sig
On Wed, 2014-09-03 at 16:30 -0400, Alan Stern wrote:
> On Wed, 3 Sep 2014, James Bottomley wrote:
>
> > Before we embark on elaborate hacks, why don't we just make the capacity
> > writeable (by root) in sysfs from userspace (will require block change)?
> > We
On Wed, 2014-09-03 at 15:05 -0400, Alan Stern wrote:
> On Wed, 3 Sep 2014, Dale R. Worley wrote:
>
> > > From: Alan Stern
> > >
> > > On Fri, 29 Aug 2014, Matthew Dharm wrote:
> > > > Is there an 'easy' way to override the detected size of a storage
> > > > device from userspace? If we had that
On Fri, 2014-08-29 at 10:13 +0200, Hannes Reinecke wrote:
> On 08/29/2014 09:39 AM, Bart Van Assche wrote:
> > On 08/29/14 08:19, Hannes Reinecke wrote:
> >> On 08/29/2014 04:42 AM, Mike Christie wrote:
> >>> How are distros handling 0x6/0x3f/0x0e (report luns changed) when it
> >>> gets passed to
On Thu, 2014-08-28 at 14:21 +0200, Hans de Goede wrote:
> Hi,
>
> On 08/28/2014 02:04 PM, Hannes Reinecke wrote:
> > On 08/25/2014 01:15 PM, Paolo Bonzini wrote:
> >> Il 25/08/2014 12:28, Bart Van Assche ha scritto:
> >>>
> >>> From SPC-4: "7.5.8 Control mode page [ ... ] A task aborted status (T
On Thu, 2014-08-28 at 14:37 +0200, Hans de Goede wrote:
> Hi,
>
> On 08/28/2014 02:33 PM, Paolo Bonzini wrote:
> > Il 28/08/2014 14:26, Hans de Goede ha scritto:
> Then, blk_complete_request will do nothing because its call to
> blk_mark_rq_complete returns true.
>
> All this,
On Wed, 2014-08-27 at 15:21 -0400, Dale R. Worley wrote:
> > From: James Bottomley
>
> > Did you try read capacity 16 on it? What happened? (the AS2105 rejects
> > read capacity 16, so there's no reliable way to deduce the capacity of
> > drives over 2TB).
&g
On Tue, 2014-08-26 at 15:39 -0400, Dale R. Worley wrote:
> This is almost certainly a form of the problem reported in
> "AS2105-based enclosure size issues with >2TB HDDs". I'm repeating my
> original message here so linux-usb can see it, and so it can be
> connected to the older thread. I'll add
On Tue, 2014-08-26 at 10:13 +0200, Hans de Goede wrote:
> Hi,
>
> On 08/25/2014 05:41 PM, James Bottomley wrote:
> > On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote:
> >> Il 25/08/2014 13:26, Hans de Goede ha scritto:
> >>> Thanks Bart and Paolo,
On Tue, 2014-08-26 at 16:23 +0200, Juergen Gross wrote:
> On 08/26/2014 04:14 PM, David Vrabel wrote:
> > On 18/08/14 10:31, jgr...@suse.com wrote:
> >> From: Juergen Gross
> >>
> >> Add myself as maintainer for the Xen pvSCSI stuff.
> >>
> >> Signed-off-by: Juergen Gross
> >> ---
> >> MAINTAIN
On Mon, 2014-08-25 at 17:19 -0400, Alan Stern wrote:
> On Mon, 25 Aug 2014, Alan Stern wrote:
>
> > On Mon, 25 Aug 2014, James Bottomley wrote:
> >
> > > On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote:
> > >
> > > > James, can you e
On Mon, 2014-08-25 at 10:44 -0400, Alan Stern wrote:
> James, can you explain how the INQUIRY command in scsi_probe_lun()
> managed to work back in the days when multi-lun SCSI-2 devices were
> common? sdev->scsi_level doesn't get set when sdev is allocated, so it
> initially contains 0, so the
On Mon, 2014-08-25 at 18:48 +, Alfredo Dal Ava Junior wrote:
> On Mon, 25 Aug 2014, Alan Stern wrote:
> >
> > Don't forget that lots of disks go crazy if you try to read from a
> > nonexistent
> > block, that is, one beyond the end of the disk.
> > IMO, this bug cannot be worked around in any
On Mon, 2014-08-25 at 13:39 +0200, Paolo Bonzini wrote:
> Il 25/08/2014 13:26, Hans de Goede ha scritto:
> > Thanks Bart and Paolo, your insights into this are greatly appreciated.
> >
> > So with uas there are separate usb transaction for cmd, data in, data out
> > and sense for each tag. At the
number of commands (say around
5%) and then try normal operation. This is what I used to test our
submission and resubmission routines, but I haven't run it for a year or
so.
The final suggestion is that you need to make sure this patch is in
their environment:
commit c69e6f812bab0d5442b40e2f1bf
On Fri, 2014-08-22 at 10:53 -0400, Alan Stern wrote:
> On Thu, 21 Aug 2014, Christoph Hellwig wrote:
>
> > On Thu, Aug 21, 2014 at 05:43:41PM -0400, Martin K. Petersen wrote:
> > > Alan> Okay, here's a patch that implements the suggestion, except that I
> > > Alan> put the flag in the Scsi_Host s
On Wed, 2014-08-20 at 16:18 -0400, Dale R. Worley wrote:
> I don't know if this is the correct place for this problem, but you
> people can probably tell me the correct place.
linux-usb can probably also help (cc'd).
> I have two "USB to SATA adapter" dongles. In general, they work fine.
> Howev
On Tue, 2014-08-19 at 23:17 +0300, Aaro Koskinen wrote:
> Hi,
>
> On Tue, Aug 19, 2014 at 09:47:35AM -0500, James Bottomley wrote:
> > On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote:
> > > > On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote:
> > >
These are the two bug fixes I mentioned in the final merge window pull.
One is a reversed logic check in the device busy tests which can cause a
nasty hang and another crash seen in the new SCSI pool support if the
use count ever goes to zero.
The patch is available here:
git://git.kernel.org/pub
On Tue, 2014-08-19 at 10:30 -0500, scame...@beardog.cce.hp.com wrote:
>
> Is it permitted for a LLD to call scsi_done() for a command which
> has been or is attempting to be aborted via the LLD abort error handler
> function?
>
> I am looking at the scsi mid layer code, and I'm a bit confused.
H
On Tue, 2014-08-19 at 17:37 +0300, Meelis Roos wrote:
> > On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote:
> > > 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test
> > > machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc
> > > 53c1010 and all behave the s
On Tue, 2014-08-19 at 14:25 +0300, Meelis Roos wrote:
> 3.16 scsi worked fine, 3.17-rc1 misbehaves on 3 of my sparc64 test
> machines. E220R and E420R are with onboard 5c3875, V210 is with onboarc
> 53c1010 and all behave the same. Any ideas whre to dig deeper? bisection
> might be nontrivial, b
Just a note, we do have a couple of bug fixes coming under separate
cover, but they don't have to be part of the merge window
This is a small set of updates which missed the first pull. It's more
msix updates, some iscsi and qla4xxx fixes, we also have some string
null termination fixes a return
On Fri, 2014-08-15 at 12:25 -0700, Christoph Hellwig wrote:
> On Thu, Aug 14, 2014 at 10:47:08AM -0700, James Bottomley wrote:
> > So this is a bit late to get through linux-next and into a pull request.
> > I was planning on sending the final pull tomorrow (in case Linus planned
On Thu, 2014-08-14 at 05:54 -0700, Christoph Hellwig wrote:
> On Mon, Aug 04, 2014 at 07:20:04AM -0700, James Bottomley wrote:
> > > The drivers side are a bunch of smaller fixes for iscsi and pm8001 which
> > > never have been a problem to put in near the end of the merge win
On Fri, 2014-08-08 at 19:03 +0200, Julia Lawall wrote:
> > > diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> > > index 67283ef..62e276b 100644
> > > --- a/drivers/scsi/dpt_i2o.c
> > > +++ b/drivers/scsi/dpt_i2o.c
> > > @@ -1169,11 +1169,6 @@ static struct adpt_device*
> > > adpt_fin
On Wed, 2014-08-06 at 12:39 +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Delete NULL test on array (always false).
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //
> @r@
> type T;
> T [] e;
> position p;
> @@
> e
Restrict max_lun to 16-bit for older HBAs
scsi_scan: Restrict sequential scan to 256 LUNs
scsi: Remove CONFIG_SCSI_MULTI_LUN
Himangi Saraogi (1):
aic7xxx: Use kstrdup
James Bottomley (1):
scsi: use short driver name for per-driver cmd slab caches
Janusz Dziemidowicz (1):
On Mon, 2014-08-04 at 04:03 -0700, Christoph Hellwig wrote:
> On Mon, Aug 04, 2014 at 06:22:59AM +0200, Juergen Gross wrote:
> > OTOH it would be possible to just delete .cmd_pool in the template when
> > deleting the pool. I'll send a patch doing this and you can decide
> > whether to take it or t
On Mon, 2014-08-04 at 04:11 -0700, Christoph Hellwig wrote:
> On Fri, Aug 01, 2014 at 04:32:01PM -0400, James Bottomley wrote:
> > On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote:
> > > I've pushed out updates to both the core-for-3.17 and drivers-for-3.17
>
On Fri, 2014-08-01 at 22:48 +0200, Jan Kara wrote:
> Hello,
>
> when debugging one bug, I've noticed one strangeness in
> scsi_request_fn(). We enter it with interrupts disabled and queue_lock
> held. In the function we do stuff like:
> spin_unlock_irq(shost->host_lock);
>
On Fri, 2014-08-01 at 05:20 -0700, Christoph Hellwig wrote:
> I've pushed out updates to both the core-for-3.17 and drivers-for-3.17
> branches.
So I'm afraid we missed the last -next build on these, so they can't go
in with the early SCSI pull. I'm open to doing one mid merge window,
but Linus t
On Fri, 2014-08-01 at 05:03 -0700, Christoph Hellwig wrote:
> On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgr...@suse.com wrote:
> > From: Juergen Gross
> >
> > If a scsi host driver specifies .cmd_len in it's scsi_host_template, a
> > driver's
> > private command pool is needed. scsi_find_host_cm
On Fri, 2014-08-01 at 08:02 +0200, Juergen Gross wrote:
> On 08/01/2014 07:41 AM, Juergen Gross wrote:
> > During test of Xen pvSCSI frontend module I found the following issue:
> >
> > When unplugging a passed-through SCSI-device the SCSI Host is removed.
> > When calling the final scsi_host_put()
failed barriers.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
James Bottomley (1):
scsi: handle flush errors properly
And the diffstat:
drivers/scsi/scsi_lib.c | 8
1 file changed, 8 insertions(+)
Full
On Wed, 2014-07-30 at 19:59 +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2014 at 12:22:11PM -0500, Mike Christie wrote:
> > Some drivers like qla2xxx do not set proc_name. I think if 2 drivers
> > like that are loaded then you will hit some other warns/bugs in the kmem
> > cache setup code rig
On Thu, 2014-07-31 at 12:10 +0300, Dan Carpenter wrote:
> [ This is not really a new bug, it's just that renaming the function
> made it show up as a new bug and I figured maybe you know what's going
> on since you are working with related code. -dan ]
>
> Hello Douglas Gilbert,
>
> This is
On Wed, 2014-07-30 at 16:52 +0200, Christoph Hellwig wrote:
> On Wed, Jul 30, 2014 at 08:21:35AM -0400, Josh Boyer wrote:
> > > Thanks, I've update the author, added a Cc to ћtable and pushed it out to
> > > the core-for-3.17 branch.
> >
> > This fixes a bug in the 3.16 kernel. Why wouldn't it be
On Wed, 2014-07-30 at 17:37 +0530, Suresh Thiagarajan wrote:
> From: Suresh Thiagarajan
>
> Update pmcs mail list for pm8001 driver support
>
> Signed-off-by: Suresh Thiagarajan
> ---
> MAINTAINERS |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/MAINTAINERS b/MAI
On Wed, 2014-07-30 at 17:33 +0530, Suresh Thiagarajan wrote:
> From: Suresh Thiagarajan
>
> The current implementation may mix the negative value returned
> from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted
> as bytes programmed, this patch fixes it.
>
> Signed-off-by: Tomas
On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> > Sent: Monday, July 28, 2014 12:03 PM
> > To: KY Srinivasan
> > Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig;
> > gre...@linuxf
On Sat, 2014-07-26 at 18:21 +0200, Christoph Hellwig wrote:
> Here's a formal one.
>
> James, can I get your signoff for it?
Sure:
Signed-off-by: James Bottomley
> Vladimir, can I get a reviewed-by from you (or anyone else)?
>
> ---
> >From 73b1034ab1418e2dea7
On Sat, 2014-07-26 at 13:11 -0700, Greg Kroah-Hartman wrote:
> On Fri, Jul 25, 2014 at 07:46:56AM -0700, James Bottomley wrote:
> > On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote:
> > > The host devices without a parent were "forcefully adopted"
> > > by
On Fri, 2014-07-25 at 16:47 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> > Sent: Thursday, July 24, 2014 8:54 AM
> > To: Sitsofe Wheeler
> > Cc: Martin K. Petersen; Christoph Hellwig; KY Srinivasan;
> > gre...@linux
On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote:
> The host devices without a parent were "forcefully adopted"
> by platform bus. This patch removes this assignment. In
> effect the dev_dev may be NULL now, which means ISA.
>
> Cc: James E.J. Bottomley
> Cc: linux-scsi@vger.kernel.org
> Signe
On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote:
> Microsoft Hyper-V targets currently only claim SPC-2 compliance / no
> compliance indicated even though they implement post SPC-2 features
> which means those features are not tested for. Add a blacklist flag to
> Hyper-V devices that forc
On Fri, 2014-07-18 at 22:01 +0200, poma wrote:
> On 18.07.2014 16:17, Christoph Hellwig wrote:
> > On Fri, Jul 18, 2014 at 05:21:04PM +0400, Vladimir Davydov wrote:
> >> Slab warns, because the name of the cache being created contains spaces.
> >> The "bad" cache is created by scsi_get_host_cmd_poo
On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote:
> On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote:
> > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
> > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> > > > On Fri, Ju
On Fri, 2014-07-18 at 17:17 +, Elliott, Robert (Server Storage)
wrote:
>
>
> > From: James Bottomley [mailto:jbottom...@parallels.com]
> >
> > On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
> > wrote:
> ...
> > >
> > >
I can get another review).
>
> James, does this look fine to you?
Yes:
Reviewed-by: James Bottomley
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 2014-07-18 at 16:44 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: Christoph Hellwig (h...@infradead.org) [mailto:h...@infradead.org]
> > Sent: Friday, July 18, 2014 8:11 AM
> > To: KY Srinivasan
> > Cc: Jens Axboe; James Bottomley
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
> On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
> > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
> > > We should prefer `const struct pci_device_id` over
> > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl
On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote:
> We should prefer `const struct pci_device_id` over
> `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
> This issue was reported by checkpatch.
What kernel coding style? checkpatch isn't the arbiter of style, if
that's the o
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage)
wrote:
> In sd_sync_cache:
> rq->timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER;
>
> Regardless of the baseline for the multiplication, a magic
> number of 2 is too arbitrary. That might work for an
> individual drive, but could b
On Wed, 2014-07-16 at 15:08 -0400, Martin K. Petersen wrote:
> >>>>> "James" == James Bottomley writes:
>
> James> It's the code we identified in sd.c:read_capacity_16():
>
> That's there to support devices that implement thin provisioning b
On Wed, 2014-07-16 at 14:45 -0400, Martin K. Petersen wrote:
> >>>>> "James" == James Bottomley writes:
>
> >> I don't have a problem with a BLIST_PREFER_UNMAP flag or something
> >> like that. But BLIST_TRY_VPD_PAGES seems more generally u
On Wed, 2014-07-16 at 13:47 -0400, Martin K. Petersen wrote:
> > "Christoph" == hch@infradead org writes:
>
> Christoph> Oh, we actually have devices that support WRITE SAME with
> Christoph> unmap, but not without? That's defintively a little strange.
>
> Yep :(
>
> There were several SSD
On Wed, 2014-07-16 at 04:01 -0700, h...@infradead.org wrote:
> On Sun, Jul 13, 2014 at 08:58:34AM -0400, Martin K. Petersen wrote:
> > > "KY" == KY Srinivasan writes:
> >
> > KY> Windows hosts do support UNMAP and set the field in the
> > KY> EVPD. However, since the host advertises SPC-2 com
On Mon, 2014-07-14 at 16:39 +0200, Hannes Reinecke wrote:
> On 07/14/2014 04:17 PM, James Bottomley wrote:
> > On Mon, 2014-07-14 at 11:22 +0200, Hannes Reinecke wrote:
> >> On 07/14/2014 10:35 AM, Christoph Hellwig wrote:
> >>> Back when the mpt3sas driver was fi
On Mon, 2014-07-14 at 11:22 +0200, Hannes Reinecke wrote:
> On 07/14/2014 10:35 AM, Christoph Hellwig wrote:
> > Back when the mpt3sas driver was first posted I suggested that it should
> > be merged into mpt2sas, but my proposal didn't get much traction.
> >
> > Illumos has now produced a shared d
On Thu, 2014-07-10 at 21:02 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: James Bottomley [mailto:jbottom...@parallels.com]
> > Sent: Wednesday, July 9, 2014 3:27 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; m...@mk
27; patch with a trivial comment fix and a proper changelog.
> James, can I get your signoff for this one? I'll throw it into the
> core-for-3.16 tree then.
OK, here it is. I tweaked the comment to be accurate.
James
---
>From 66aba46049037b55c5c77b45974a639f8f48b58b Mon Sep 17 00:
On Wed, 2014-07-09 at 21:14 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: James Bottomley [mailto:jbottom...@parallels.com]
> > Sent: Wednesday, July 9, 2014 12:57 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kerne
On Wed, 2014-07-09 at 19:52 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: Christoph Hellwig [mailto:h...@infradead.org]
> > Sent: Wednesday, July 9, 2014 1:43 AM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > oher...@suse.com;
On Wed, 2014-06-25 at 18:51 +0200, Christoph Hellwig wrote:
> Avoid taking the queue_lock to check the per-device queue limit. Instead
> we do an atomic_inc_return early on to grab our slot in the queue,
> and if nessecary decrement it after finishing all checks.
>
> Unlike the host and target bu
This is a set of 13 fixes, a MAINTAINERS update and a sparse update.
The fixes are mostly correct value initialisations, avoiding NULL derefs
and some uninitialised pointer avoidance.
All the patches have been incubated in -next for a few days. The final
patch (use the scsi data buffer length to
On Thu, 2014-07-03 at 09:33 -0700, Christoph Hellwig wrote:
> On Thu, Jul 03, 2014 at 09:27:48AM -0700, Greg Kroah-Hartman wrote:
> > I copy everyone on the patch. You were not on that patch as it doesn't
> > look like it went through your tree at all.
>
> It went through the target tree despite
901 - 1000 of 3148 matches
Mail list logo
