Some drives set the ILI flag together with MEDIUM ERROR
sense code. Clear the ILI flag in this case so that the
medium error will be handled. The problem was reported by
Maurizio Lombardi.
Signed-off-by: Kai Mäkisara
---
drivers/scsi/st.c |9 ++---
1 file changed, 6 insertions(+), 3 dele
;ofer, Michael Leodolter, Eyal Lebedinsky,
Michael Schaefer, J"org Weule, and Eric Youngdale.
- Copyright 1992 - 2010 Kai Makisara
+ Copyright 1992 - 2016 Kai Makisara
email kai.makis...@kolumbus.fi
Some small formal changes - aeb, 950809
@@ -17,7 +17,7 @@
Last modified: 1
get your LTO drive test without my changes in to
>make sure you see the same issue and then if you do test with the
>changes I added above. That's just to double check that there's nothing
>wrong with my setup and the code changes are required.
Thanks,
Kai
--
---8<--
--- ref/drivers/scsi/st.c 2015-12-21 18:54:05.068882001 +0200
+++ new/drivers/scsi/st.c 2016-01-29 19:12:06.139738037 +0200
@@ -9,7 +9,7 @@
Steve Hirsch, Andreas Koppenh"ofer, Michael Leodolter, Eyal Lebedinsk
egative numbers. A minimal patch is needed.
Thanks,
Kai
---8<
--- ref/drivers/scsi/st.c 2015-12-21 18:54:05.068882001 +0200
+++ new/drivers/scsi/st.c 2016-01-24 22:36:13.250928500 +0200
@@ -9,7 +9,7 @@
Steve H
sch, Andreas Koppenh"ofer, Michael Leodolter, Eyal Lebedinsky,
Michael Schaefer, J"org Weule, and Eric Youngdale.
- Copyright 1992 - 2010 Kai Makisara
+ Copyright 1992 - 2016 Kai Makisara
email kai.makis...@kolumbus.fi
Some small formal changes - aeb, 950809
@@ -17,7 +17,7 @@
ter, Eyal Lebedinsky,
Michael Schaefer, J"org Weule, and Eric Youngdale.
- Copyright 1992 - 2010 Kai Makisara
+ Copyright 1992 - 2016 Kai Makisara
email kai.makis...@kolumbus.fi
Some small formal changes - aeb, 950809
@@ -17,7 +17,7 @@
Last modified: 18-JAN-1998 Rich
On Monday 2015-12-21 20:57, "Kai Mäkisara (Kolumbus)" wrote:
...
>I can look at the manuals during Christmas holidays and try to think about a
>suggestion.
>All other suggestions are, of course, welcome. My view may be somewhat
>theoretical
>because I don’t have access to current hardware.
>
I h
Matthias Eble [psychotr...@gmail.com] kirjoitti:
Hi list,
When a tape device is reserved with old reserve/release commands,
we see inquiry only works on the scsi generic device. For scsi tape devices
open() fails already:
# lsscsi -g | grep st15
[2:0:6:0]tapeHP Ultrium 5-SCSI I5
uld result in
> put_disk() dropping a not taken reference.
>
> Thus, disk->queue should be set only after a successful
> blk_queue_get().
> Revised patch due to a hint from Kai Makisara.
>
> Signed-off-by: Bodo Stroesser
Acked-by: Kai Mäkisara
>
> ---
>
> --- a
On Tue, 5 Mar 2013, Joe Lawrence wrote:
> Changes from v1:
> Corrected error paths as noted by Ewan Milne and Jan Vesely.
>
> These changes were applied to scsi.git, branch "misc". This patch
> fixes a reference count bug in the SCSI tape driver which can be
> reproduced with the following:
>
On Mon, 10 Sep 2012, Lee Duncan wrote:
> From: Hannes Reinecke
>
> The st_mutex was created when the BKL was removed, and
> prevents simultaneous st_open calls. It is better to
> protect just the necessary data.
>
> Signed-off-by: Hannes Reinecke
> Reviewed-by: Lee Duncan
Acked-by: Kai Mäkis
On Sat, 18 Aug 2012, Jeff Mahoney wrote:
> This patchset cleans up the SCSI tape device handling code and leverages it
> to lift the limitation of the number of tape drives from the previous
> arbitrary limit of 128 to the maximum supported by a device node that
> creates 8 character devices per p
On Mon, 20 Aug 2012, Olaf Hering wrote:
>
> Currently the st driver does not to break up write requests into smaller
> chunks to satisfy the ->max_hw_sectors limit of the underlying host driver.
>
> # modprobe -v scsi_debug ptype=1 opts=1 dev_size_mb=123
> # dd if=/dev/zero of=/dev/st0 bs=$((1
On Wed, 15 Aug 2012, Hannes Reinecke wrote:
> st_open() is taking a global mutex 'st_mutex' to protect
> against concurrent calls to st_open(). However, as
> st_open() might take quite some time before returning,
> _any_ open to _any_ st device will be blocked during
> that time.
>
> Seeing that
MTIOCTOP ioctl (defined in include/linux/mtio.h). For example:
> cat /sys/class/scsi_tape/nst0/options
0x0d07
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
---
The patch is against Feb 24 git version of 2.6.25-rc2. Candidate for
inclusion into 2.6.26.
Documentation/scsi/st.t
for every
block speeds up some real applications considerably.
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
---
The patch is against Feb 24 git version of 2.5.25-rc2. Candidate for
inclusion into 2.6.26.
Documentation/scsi/st.txt |7 ++-
drivers/scsi/st.c
Remove the now useless counting of adjacent pages from the debugging code in
to make it compile when DEBUG is set non-zero.
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
---
The patch does not touch any code compiled when DEBUG is zero and is suitable
for 2.5.25.
drivers/scsi/st.c
On Wed, 20 Feb 2008, John LLOYD wrote:
>
>
> > On Mon, 4 Feb 2008, James Bottomley wrote:
> >
> > >
> > > On Mon, 2008-02-04 at 22:28 +0100, Borislav Petkov wrote:
...
> > > > > This does still occur with 2.6.22; with a blank tape in my HP
> DDS-4 drive:
> > > > >
> > > > > $ tar tzvf /dev/ns
On Tue, 5 Feb 2008, Kai Makisara wrote:
> On Mon, 4 Feb 2008, James Bottomley wrote:
>
> >
> > On Mon, 2008-02-04 at 22:28 +0100, Borislav Petkov wrote:
> > > On Mon, Feb 04, 2008 at 03:22:06PM +0100, maximilian attems wrote:
> > >
> > > (Ad
On Mon, 4 Feb 2008, James Bottomley wrote:
>
> On Mon, 2008-02-04 at 22:28 +0100, Borislav Petkov wrote:
> > On Mon, Feb 04, 2008 at 03:22:06PM +0100, maximilian attems wrote:
> >
> > (Added Bart to CC)
> >
> > > hello borislav,
> > >
> > > may i forward you that *old* Debian kernel bug,
> > >
Convert st to unlocked_ioctl. The necessary locking was already in place.
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
---
The patch is against 2.6.24-rc8.
drivers/scsi/st.c |9 -
1 file changed, 4 insertions(+), 5 deletions(-)
--- linux-2.6/drivers/scsi/st.c 2007-12-20
h=acdd0b1c371b2fbb4b6110a51ba69cb0af9e6f45
>
I have done some tests. Firstly, I did not see the BUG with 2.6.24-rc5.
Looking at include/linux/scatterlist.h suggested that CONFIG_DEBUG_SG has
something to do with this. When enabled SG debugging, I also saw the BUG.
Adding this patch solved the
On Wed, 7 Nov 2007, James Pearson wrote:
> I have two LTO-3 (QUANTUM ULTRIUM 3) drives attached to a dual Adaptec U160
> controller (one per SCSI host) on a Dell PE2850 running a RHEL4 based kernel
> (2.6.9 based).
>
> I'm trying to read (with tar) LTO-3 tapes written on another system (possibly
On Sun, 29 Jul 2007, Matthias Kaehlcke wrote:
> The SCSI Tape driver uses a semaphore as mutex. Use the mutex API
> instead of the (binary) semaphore.
>
> Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]>
>
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
Thanks
On Tue, 17 Jul 2007, Frank Hempel wrote:
> Hello,
>
> I have expierenced a problem with the aic7xxx driver or the scsi tape support
> in the linux kernel.
>
> [Problem Description]
> Under linux kernels since 2.6.15 every "action" I issue to the tape drive (I
> mainly do this via from the cpio
On Mon, 16 Jul 2007, Martin K. Petersen wrote:
> > "John" == John Stoffel <[EMAIL PROTECTED]> writes:
>
> John> Will this help out tape drive performance at all? I looked
> John> through the patches quickly, esp the AIC7xxx stuff since that's
> John> what I use, but nothing jumped out at me.
On Wed, 4 Apr 2007, Kern Sibbald wrote:
> On Wednesday 04 April 2007 20:46, Kai Makisara wrote:
...
> > > > c. There is a real lack of information about any error condition
> > > > (read/write). One can probably get it via direct SCSI commands,
> but
&g
On Tue, 3 Apr 2007, Andrew Morton wrote:
>
> (cc's added, with permission)
>
> On Tue, 3 Apr 2007 15:08:37 +0200
> Kern Sibbald <[EMAIL PROTECTED]> wrote:
>
> > Hello,
> >
> > I am the project manager for Bacula, an Open Source network backup program
> > that runs on all popular OSes. After
On Mon, 12 Feb 2007, Oliver Paulus wrote:
> Hello,
>
> I get a kernel oops if I want to read from my SCSI HP tape (C5683A) drive -
> using tar command.
>
> Here my system information:
> 1. Kernel: 2.6.18-3-vserver-amd64
> 2. OS: Debian Etch
>
...
> I get a kernel oops if I want to access the /d
On Sat, 3 Feb 2007, James Bottomley wrote:
> On Sat, 2007-02-03 at 13:21 +0200, Kai Makisara wrote:
> > This patch may also fix the bug 7900.
> >
> > The patch compiles and is lightly tested.
>
> We can give it a spin in scsi-misc ... do you want me to hold off from
On Mon, 29 Jan 2007, Andrew Morton wrote:
> On Mon, 29 Jan 2007 17:39:25 -0800
> [EMAIL PROTECTED] wrote:
>
> > http://bugzilla.kernel.org/show_bug.cgi?id=7900
> >
> >Summary: Kernel OOPS when using tape drive (compiler bug?)
> > Kernel Version: 2.6.20-rc5
> > Status:
surfaced only after 2.6.17 although the st
problem is old. There may be another bug in the block subsystem and this
patch works around it. However, the patch fixes a problem in st and in
this way it is a valid fix.
This patch may also fix the bug 7900.
The patch compiles and is lightly test
y correct and explains the bug. According to the
SCSI standards, the sense code is NO SENSE or RECOVERED ERROR in case
writing filemark(s) succeeds. If it fails (partly or completely) the sense
code is VOLUME OVERFLOW. The patch below is tested to fix the case when
one filemark is successfully
On Wed, 20 Dec 2006, Andrew Morton wrote:
>
> (please respond via emailed reply-to-all)
>
> On Wed, 20 Dec 2006 02:31:18 -0800
> [EMAIL PROTECTED] wrote:
>
> > http://bugzilla.kernel.org/show_bug.cgi?id=7717
> >
> >Summary: Tapes unreadable after unload
> > Kernel Version: test
On Fri, 1 Dec 2006, Andrew Morton wrote:
>
>
> Begin forwarded message:
>
> Date: Fri, 1 Dec 2006 08:40:16 -0800
> From: [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
> Subject: [Bugme-new] [Bug 7610] New: sense key error when sending even number
> of bytes to /dev/st0
>
>
> http://bugzilla.kern
On Mon, 27 Nov 2006, Mike Christie wrote:
> Mike Christie wrote:
> > Boaz Harrosh wrote:
> >> Playing with some tests which I admit are not 100% orthodox I have
> >> stumbled upon a bug that raises a serious question:
> >>
> >> In the call to scsi_execute_async() in the use_sg case, must the
> >>
On Sun, 19 Nov 2006, Tejun Heo wrote:
> Add scsi_device->retries to provide generic control over command
> retries, which is very similar to sdev->timeout. The initial value is
> -1 and high level driver is free to override on attach if negative.
> Note that -1 has the same effect as 0 (no retry)
On Sun, 19 Nov 2006, Tejun Heo wrote:
> Each high level driver uses scsi_device->timeout diffrently.
>
...
> Index: scsi-misc-2.6/drivers/scsi/st.c
> ===
> --- scsi-misc-2.6.orig/drivers/scsi/st.c
> +++ scsi-misc-2.6/drivers/scsi/st.
. The new code is adapted from linux/fs/bio.c.
Doug's fix is correct and simple, no question about it. I just have learned to
hate these signed/unsigned comparisons where they can be avoided (having
originally created this bug is one more reason ;-)
Signed-off-by: Kai Makisara <[EMAIL P
On Fri, 26 Aug 2005, Kai Makisara wrote:
> On Thu, 25 Aug 2005, Andrew Morton wrote:
>
> >
> >
> > Begin forwarded message:
> >
> > Date: Tue, 23 Aug 2005 12:53:38 -0700
> > From: [EMAIL PROTECTED]
> > To: [EMAIL PROTECTED]
> > Subject:
On Wed, 24 Aug 2005, Hans-Joachim Baader wrote:
> Hi,
>
> > This kind of a problem of a process using a tape hanging in D state has
> > occurred sometimes for numerous years. When the user has waited long
> > enough (the default timeouts are lng), the process has continued. When
> > st has
On Thu, 25 Aug 2005, Andrew Morton wrote:
>
>
> Begin forwarded message:
>
> Date: Tue, 23 Aug 2005 12:53:38 -0700
> From: [EMAIL PROTECTED]
> To: [EMAIL PROTECTED]
> Subject: [Bugme-new] [Bug 5117] New: Panic when accessing scsi-tapedrives
> with 4G-remap
>
>
> http://bugzilla.kernel.org/s
I am sorry that this is not a proper reply email. For some reason I did
not get this email although I subscribe to linux-scsi and found this
accidentally from an archive.
On Wed, 24 Aug 2005 [EMAIL PROTECTED] wrote:
> Hans-Joachim Baader <[EMAIL PROTECTED]> wrote:
> >
> > Hi,
> >
> > > >
> > >
async IO is issued (in case
st_sleep_done is bypassed)
- fix a bogus use of last_SRpnt in st_chk_result
Nate Dailey
Stratus Technologies
Signed-off-by: Nate Dailey <[EMAIL PROTECTED]>
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
--- linux-2.6.13-rc5-k1/drivers/scsi/st.c 2005-0
class_simple_device_remove() did
nothing when the class did not exist.)
The patch also fixes a "class leak" in init_st() error path.
I would like to get this into 2.6.13 but it may be too late?
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
--- linux-2.6.13-rc5/drivers/scsi/st.c 2005-06-30 21:27:51
The following comments are based on looking at the patch, not testing it.
The tape devices do not provide much information about problems via the normal
API: mostly it just tells that something went wrong. The driver prints the
sense data to the kernel log but this information may not be accessibl
On Tue, 12 Jul 2005, Dailey, Nate wrote:
> I'll try porting my changes to a recent kernel, verify that the bugs I
> found are still bugs, and get back to you with a new patch.
>
> In the meantime, responses to your comments:
>
> - using a new kref in the scsi_tape structure: I've given this some
On Thu, 7 Jul 2005, Brian King wrote:
> Kai Makisara wrote:
> >>The primary change is adding a kref to the Scsi_Tape structure, to avoid
> >>an oops when the tape drive is removed while open. This includes
> >>scsi_tape_get/put routines and scsi_tape_release,
This is an area where st can be improved. I am happy to see that people
(probably) having resources to test the changes are working on this.
On Tue, 5 Jul 2005, Dailey, Nate wrote:
> These patches (against a 2.6.9 kernel, Redhat AS 4) for st add a
> reference count, and fix a few bugs I hit duri
On Thu, 21 Apr 2005, Nate Dailey wrote:
> Hi, this patch changes the err_out case in st_open to decrement STp->in_use
> under the st_dev_arr_lock.
>
> I'm just basing this on looking at the code (I didn't run into an actual
> problem here), but it seems like the right thing to do; st_open and
On Fri, 25 Mar 2005, James Bottomley wrote:
> On Fri, 2005-03-25 at 14:38 +0900, Tejun Heo wrote:
> > We have users of scsi_do_req() other than scsi_wait_req() and they
> > use different done() functions to do different things. I've checked
> > other done functions and none uses contents inside
On Tue, 15 Mar 2005, James Bottomley wrote:
> On Sat, 2005-03-12 at 19:04 +0200, Kai Makisara wrote:
> > This is an updated version of the patch I sent March 7. The sense descriptor
> > initialization has been made lighter.
> >
> > The patch at the end of this message
does not count the partitions separately.
Sebastien Godard, the systat maintainer, has expressed his interest into
adding support for the tape statistics to systat.
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
--- linux-2.6.11-bk7-k4/drivers/scsi/st.c 2005-03-13 19:24:29.000
access and that have security problems with the current command
filtering. This patch solves the problem for tapes and no more elaborate
patches are needed.
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
--- linux-2.6.11-bk7-k3/drivers/scsi/st.c 2005-03-12 18:11:11.0
This patch applies over the previous patch in this thread. The patch removes
updating filp->f_pos. It has been dead code since 2.6.8 and nobody has missed
it.
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
--- linux-2.6.11-bk7-k2/drivers/scsi/st.c 2005-03-12 13:52:30.000
printout of spacing counts fixed to work also with 64-bit systems
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
--- linux-2.6.11-bk7-k1/drivers/scsi/st.c 2005-03-12 13:38:32.0
+0200
+++ linux-2.6.11-bk7-k2/drivers/scsi/st.c 2005-03-12 13:52:30.0
+0200
@@ -17,7
writing of filemark
if the previous operation was write (tar expects this)
- the block number is set to unknown (-1) if spacing forward ends at BLANK CHECK
- debugging printout of spacing counts fixed to work also with 64-bit systems
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
---
On Sun, 6 Mar 2005 [EMAIL PROTECTED] wrote:
>
>
> Use msleep_interruptible() instead of
> schedule_timeout() to guarantee the task delays as expected.
>
This patch is already in the scsi-misc-2.6 tree merged into one of the st
patches.
Thanks for the reminder and the patch.
--
Kai
-
To unsu
On Fri, 25 Feb 2005, Gerhard Schneider wrote:
> On Thu, 2005-02-24 at 23:00 +0200, Kai Makisara wrote:
>
> > >
> > Sounds strange but the following things come into my mind:
> > - Check from the dmesg output and/or system logs what SCSI transfer
> > settings th
On Sat, 26 Feb 2005, Christian Iversen wrote:
>
> Whenever I use --verify for tar, I get problems. Specifically, I get
> "Illegal seek" when tar gets to the verify phase.
>
I looked at tar 1.13.25 sources and this looks like a tar bug: verify from
tape does not work for the first file (and I
On Wed, 23 Feb 2005, Gerhard Schneider wrote:
>
> Kernel: 2.6.10-rc4 w/ 3 tape patches from Kai Makisara
>
> SCSI: 53C1030 controller, tape drive is on one channel of the
> controller.
>
> Tape: Overland Changer w/ Seagate LTO-1 drive
> Typical transfer speed: 12
driver compiles,
did not crash the system and produced reasonable looking numbers.
Signed-off-by: Kai Makisara <[EMAIL PROTECTED]>
--- linux-2.6.11-rc4-k2/drivers/scsi/st.c 2005-02-20 22:22:51.0
+0200
+++ linux-2.6.11-rc4-k3/drivers/scsi/st.c 2005-02-21 22:07:32.0
change makes sure that the
last file on the tape is properly terminated with a filemark and reading the
file does not fail at the end.
The patch is against 2.6.11-rc4 + the descriptor based sense data patch I
sent to linux-scsi on Feb 13.
Signed-off-by: Kai Makisara <[EMAIL PROTEC
behavior. The
patch is against 2.6.11-rc4 and has been tested to some extent.
The patch also includes the msleep_interruptible change from from kernel
janitors.
Thanks to Doug Gilbert for doing a first version of this sense data
conversion.
Signed-off-by: Kai Makisara <[EMAIL PROTEC
On Wed, 19 Jan 2005, Tape Help wrote:
> On Wed, 19 Jan 2005 20:50:32 +0200 (EET), Kai Makisara
...
> > I will forward this analysis (with a preface) to the cpio maintainers.
> >
> > --
> > Kai
> >
>
> Are the cpio maintainers on a list?
> I would like
On Tue, 18 Jan 2005, Tape Help wrote:
> Ok, I have the debug info, with comments where needed.
> Thanks alot!
>
...
> # find home -depth|cpio -o --format=newc --block-size=128 -F /dev/st0
> 14:24:48 kernel: st0: Block limits 1 - 16777215 bytes.
> 14:24:48 kernel: st0: Mode sense. Length 11, mediu
On Sat, 15 Jan 2005, Tape Help wrote:
> No one on linux-tape has responded. I think that list is dead.
> Can anyone help?
>
linux-tape may not be dead but you have to give us some time ;-)
> Thanks.
>
> -- Forwarded message --
> From: Tape Help <[EMAIL PROTECTED]>
> Date: Fri,
On Thu, 19 Jul 2001, Cameron, Steve wrote:
...
> Or, is this just normal behavior for linux for now? That is, one
> cannot expect to be able to safely rmmod a low-level scsi driver
> in 100% of the attempts?
>
I don't think what you see is normal. The high level SCSI drivers
increment the module
On Tue, 15 May 2001, John Lange wrote:
> Just joined the list so I apologize if this has already been addressed.
>
> Ever since I upgraded my kernel to 2.4.4 from 2.4.2, it will no longer
> recognize my Onstream ADR50 tape drive.
>
> When I downgrade my kernel back to 2.4.2, it again works perfec
This answer is longish and I send this only to linux-scsi to save
linux-kernel bandwidth.
On Sun, 8 Apr 2001, Alex Q Chen wrote:
> I am trying to find a way to pin down user space memory from kernel, so
> that these user space buffer can be used for direct IO transfer or
> otherwise known as "ze
On Sat, 27 Jan 2001, Ken Bass wrote:
> I am really stuck. I'm using the /dev/sg driver in cooperation with the
> /dev/st driver.
> I am using fwrite to the /dev/st device to write data to a tape. Every 10
> seconds, the same task, uses /dev/sg to request a LOG SENSE. I'm trying to
> monitor the d
72 matches
Mail list logo
