- Retain firmware defined configuration settings in the absence of
user-provided configuration by eliminating the global RSS and the
PF/VF capabilities mailbox commands.
- Remove S_IRUGO from sysfs parameters that don't have 'show'
functionality.
Signed-off-by: Naresh Kumar Inn
n_evt_fw[PROTO_ERR_IMPL_LOGO]; /* fw events */
> + uint32_tn_evt_fw[PROTO_ERR_IMPL_LOGO + 1]; /* fw events */
> enum csio_ln_ev n_evt_sm[CSIO_LNE_MAX_EVENT]; /* State m/c events */
> uint32_tn_rnode_alloc; /* rnode allocated */
> uint32_t
_fw6_msg) :
> sizeof(struct cpl_fw4_msg);
> -
> - data = (__be64 *) msg;
> } else {
> csio_warn(hw, "unexpected CPL %#x on FW event queue\n", op);
> CSIO_INC_STATS(hw, n_cpl_unexp);
>
>
Acked-by: Naresh Kumar Inna
w)
> evt_entry = kzalloc(sizeof(struct csio_evt_msg), GFP_KERNEL);
> if (!evt_entry) {
> csio_err(hw, "Failed to initialize eventq");
> + rv = -ENOMEM;
> goto err_evtq_cleanup;
>
On 2/6/2013 6:39 PM, Dan Carpenter wrote:
> Hopefully, you recieved an email about this last November, but this
> is a follow up because the bug is still there.
>
I don't recollect getting that email. Thanks for reporting nevertheless.
There are some patches lined up for supporting new features a
X) {
> /* New VN-Port */
> spin_unlock_irq(&hw->lock);
> - csio_lnode_alloc(hw);
> + ln = csio_lnode_alloc(hw);
> spin_lock_irq(&hw->lock);
> if (!ln) {
mtype = FW_PARAMS_PARAM_Y_GET(*fw_cfg_param);
> maddr = FW_PARAMS_PARAM_Z_GET(*fw_cfg_param) << 16;
> @@ -2149,9 +2152,9 @@ csio_hw_flash_config(struct csio_hw *hw, u32
> *fw_cfg_param, char *path)
> strncpy(path, "/lib/firmware/" CSIO_CF_FNAME, 64);
>
erations csio_mem_debugfs_fops = {
> .owner = THIS_MODULE,
> - .open= csio_mem_open,
> + .open= simple_open,
> .read= csio_mem_read,
> .llseek = default_llseek,
> };
>
>
Acked-by: Naresh Kumar Inna
Thanks,
Naresh.
--
To unsubscribe
On 12/2/2012 5:21 PM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> This removes an open coded simple_open() function and
> replaces file operations references to the function
> with simple_open() instead.
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/scsi/csiostor/csio_init.c | 12 +---
+ 3) & ~3; /* should be multiple of 4 bytes */
> ae->len = htons(len);
> - memset(ae->value, 0, len - 4);
> memcpy(ae->value, val, len);
> *ptr += len;
> }
>
Acked-by: Naresh Kumar Inna
Thanks,
Naresh.
--
To unsubscribe from this list: sen
Hi James,
Could you please let me know when this patch would be pushed?
Thanks,
Naresh.
On 11/20/2012 6:15 PM, Naresh Kumar Inna wrote:
> This patch fixes sparse warnings related to endian-ness, which were
> reported by the 0-day kernel build and testing tool.
>
> Signed-off-by:
This patch fixes sparse warnings related to endian-ness, which were
reported by the 0-day kernel build and testing tool.
Signed-off-by: Naresh Kumar Inna
---
drivers/scsi/csiostor/csio_attr.c | 34 ++--
drivers/scsi/csiostor/csio_hw.c | 14 +++---
drivers/scsi/csiostor
On 11/15/2012 11:59 PM, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
> head: 0779fa137a73170b6c796fdb476f1455ba67b9aa
> commit: 0779fa137a73170b6c796fdb476f1455ba67b9aa [36/36] [SCSI] csiostor:
> Chelsio FCoE offload driver
>
>
> sparse wa
This patch contains the second set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
drivers/scsi/csiostor/csio_lnode.h | 255 ++
drivers/scsi/csiostor/csio_mb.h| 278 +++
drivers/scsi/csiostor/csio_rnode.h | 141
This patch contains the first set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
V2:
- Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead.
- Removed driver-specific return values, using errno values instead.
- Retained CSIO_INC_STATS, since it is
This patch contains updates to firmware/hardware header files shared
between csiostor and cxgb4/cxgb4vf, and the resulting changes to the
cxgb4/cxgb4vf source files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 10 +++---
drivers/net/ethernet/chelsio
ality.
[v6 PATCH 7/8]: Interrupt handling and fast path I/O functionality.
[v6 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes.
Naresh Kumar Inna (8):
cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header
updates).
csiostor: Chelsio FCoE offload driver submission (he
On 11/14/2012 7:56 AM, James Bottomley wrote:
> On Thu, 2012-10-25 at 15:20 +0530, Naresh Kumar Inna wrote:
>> This patch contains updates to firmware/hardware header files shared
>> between csiostor and cxgb4/cxgb4vf, and the resulting changes to the
>> cxgb4/cxgb4vf sourc
Hi James,
Could you please let me know where we are with the review of this driver?
Thanks,
Naresh.
On 10/25/2012 3:20 PM, Naresh Kumar Inna wrote:
> This is the initial submission of the Chelsio FCoE offload driver (csiostor)
> to the upstream kernel. This driver currently support
This patch contains the second set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
drivers/scsi/csiostor/csio_lnode.h | 255 ++
drivers/scsi/csiostor/csio_mb.h| 278 +++
drivers/scsi/csiostor/csio_rnode.h | 141
This patch contains the first set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
V2:
- Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead.
- Removed driver-specific return values, using errno values instead.
- Retained CSIO_INC_STATS, since it is
This patch contains updates to firmware/hardware header files shared
between csiostor and cxgb4/cxgb4vf, and the resulting changes to the
cxgb4/cxgb4vf source files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |8 ++--
drivers/net/ethernet/chelsio
ality.
[v6 PATCH 7/8]: Interrupt handling and fast path I/O functionality.
[v6 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes.
Naresh Kumar Inna (8):
cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header
updates).
csiostor: Chelsio FCoE offload driver submission (he
Hi James,
I hope now is a good time to resume the review of this driver. I will
send out v6 version of the driver shortly, which has some bug fixes and
other cleanup.
Thanks,
Naresh.
On 10/8/2012 3:55 PM, James Bottomley wrote:
> On Mon, 2012-10-08 at 15:37 +0530, Naresh Kumar Inna wr
Hi James,
Please let me know if you are expecting any more changes to this driver
to resume its review. I have addressed all review comments as of the
last series of patches (below).
Thanks,
Naresh.
On 9/24/2012 10:47 PM, Naresh Kumar Inna wrote:
> This is the initial submission of the Chel
Hi James,
Do you have any update with regards to the review of this driver? You
were mentioning about getting FC folks to take a look at it.
Thanks,
Naresh.
On 9/24/2012 10:47 PM, Naresh Kumar Inna wrote:
> This is the initial submission of the Chelsio FCoE offload driver (csiostor)
>
This patch contains the second set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
drivers/scsi/csiostor/csio_lnode.h | 255 ++
drivers/scsi/csiostor/csio_mb.h| 278 +++
drivers/scsi/csiostor/csio_rnode.h | 141
This patch contains the first set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
V2:
- Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead.
- Removed driver-specific return values, using errno values instead.
- Retained CSIO_INC_STATS, since it is
This patch contains updates to firmware/hardware header files shared
between csiostor and cxgb4/cxgb4vf, and the resulting changes to the
cxgb4/cxgb4vf source files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +-
drivers/net/ethernet/chelsio
x services.
[V5 PATCH 6/8]: Local and remote port state tracking functionality.
[V5 PATCH 7/8]: Interrupt handling and fast path I/O functionality.
[V5 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes.
Naresh Kumar Inna (8):
cxgb4/cxgb4vf: Chelsio FCoE offload driver submission
On 9/18/2012 2:06 PM, James Bottomley wrote:
> On Tue, 2012-09-18 at 09:54, Naresh Kumar Inna wrote:
>> Hi James,
>>
>> Could you please consider merging version V4 of the driver patches, if
>> you think they are in good shape now?
>
> Well, definitely not yet; yo
Hi James,
Could you please consider merging version V4 of the driver patches, if
you think they are in good shape now?
Thanks,
Naresh.
On 9/12/2012 10:48 PM, Naresh Kumar Inna wrote:
> This is the initial submission of the Chelsio FCoE offload driver (csiostor)
> to the upstream kernel
On 9/12/2012 10:22 PM, Andi Kleen wrote:
> Naresh Kumar Inna writes:
>>
>> OK, I think I should be able to arrange the patch set to fulfill that
>> requirement. I was under the impression it was fine for new drivers to
>> split patches in this fashion, since they g
This patch contains the second set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
drivers/scsi/csiostor/csio_lnode.h | 255 ++
drivers/scsi/csiostor/csio_mb.h| 278 +++
drivers/scsi/csiostor/csio_rnode.h | 141
This patch contains the first set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
V2:
- Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead.
- Removed driver-specific return values, using errno values instead.
- Retained CSIO_INC_STATS, since it is
This patch contains updates to firmware/hardware header files shared
between csiostor and cxgb4/cxgb4vf, and the resulting changes to the
cxgb4/cxgb4vf source files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +-
drivers/net/ethernet/chelsio
g and fast path I/O functionality.
[V4 PATCH 8/8]: Hardware interface, Makefile and Kconfig changes.
Naresh Kumar Inna (8):
cxgb4/cxgb4vf: Chelsio FCoE offload driver submission (common header
updates).
csiostor: Chelsio FCoE offload driver submission (headers part 1).
csiostor: Chelsio FC
On 9/12/2012 11:17 AM, David Miller wrote:
> From: Naresh Kumar Inna
> Date: Wed, 12 Sep 2012 11:05:22 +0530
>
>> On 9/11/2012 11:03 PM, David Miller wrote:
>>> From: Naresh Kumar Inna
>>> Date: Tue, 11 Sep 2012 20:09:07 +0530
>>>
>>>> This
On 9/11/2012 11:05 PM, David Miller wrote:
> From: Naresh Kumar Inna
> Date: Tue, 11 Sep 2012 20:09:03 +0530
>
>> +#include
>
> This header include is not necessary.
>
I will remove it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-s
On 9/11/2012 11:03 PM, David Miller wrote:
> From: Naresh Kumar Inna
> Date: Tue, 11 Sep 2012 20:09:07 +0530
>
>> This patch contains minor fixes to make cxgb4vf driver work with the updates
>> to
>> shared firmware/hardware header files.
>>
>> Signed-off
This patch contains updates to firmware/hardware header files shared
between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4
source files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +-
drivers/net/ethernet/chelsio/cxgb4/sge.c
This patch contains minor fixes to make cxgb4vf driver work with the updates to
shared firmware/hardware header files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net
This patch contains the second set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
drivers/scsi/csiostor/csio_lnode.h | 255 ++
drivers/scsi/csiostor/csio_mb.h| 278 +++
drivers/scsi/csiostor/csio_rnode.h | 141
This patch contains the first set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
V2:
- Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead.
- Removed driver-specific return values, using errno values instead.
- Retained CSIO_INC_STATS, since it is
ader files part 1.
[V3 PATCH 7/9]: Header files part 2.
[V3 PATCH 8/9]: Updates to header files shared between cxgb4, cxgb4vf and
csiostor.
[V3 PATCH 9/9]: Header file compatibility fixes to cxgb4vf.
Naresh Kumar Inna (9):
csiostor: Chelsio FCoE offload driver submission (sour
On 9/5/2012 10:03 PM, Stephen Hemminger wrote:
> On Wed, 5 Sep 2012 18:03:59 +0530
> Naresh Kumar Inna wrote:
>
>> +
>> +#define CSIO_ASSERT(cond)
On 9/5/2012 9:59 PM, Stephen Hemminger wrote:
> On Wed, 5 Sep 2012 18:03:55 +0530
> Naresh Kumar Inna wrote:
>
>> This patch contains code for driver initialization, driver resource
>> allocation and the Work Request module functionality. Driver initialization
>>
On 9/5/2012 10:01 PM, Stephen Hemminger wrote:
> On Wed, 5 Sep 2012 18:03:59 +0530
> Naresh Kumar Inna wrote:
>
>> +#define CSIO_ROUNDUP(__v, __r) (((__v) + (__r) - 1) / (__r))
>
> This is similar to existing round_up() in kernel.h could you use that?
>
On 9/5/2012 9:53 PM, Stephen Hemminger wrote:
> On Wed, 5 Sep 2012 18:03:54 +0530
> Naresh Kumar Inna wrote:
>
>> +
>> +/* FCoE Adapter types & its description */
>> +static struct csio_adap_desc csio_fcoe_adapters[] = {
>
> Tables like this should be co
This patch contains updates to firmware/hardware header files shared
between csiostor and cxgb4/cxgb4vf, and the resulting changes to the cxgb4
source files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +-
drivers/net/ethernet/chelsio/cxgb4/sge.c
eader file compatibility fixes to cxgb4vf.
Naresh Kumar Inna (9):
csiostor: Chelsio FCoE offload driver submission (sources part 1).
csiostor: Chelsio FCoE offload driver submission (sources part 2).
csiostor: Chelsio FCoE offload driver submission (sources part 3).
csiostor: Chelsio FCoE offl
This patch contains minor fixes to make cxgb4vf driver work with the updates to
shared firmware/hardware header files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4vf/sge.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/net
This patch contains the second set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
drivers/scsi/csiostor/csio_lnode.h | 255 ++
drivers/scsi/csiostor/csio_mb.h| 278 +++
drivers/scsi/csiostor/csio_rnode.h | 141
This patch contains the first set of the header files for csiostor driver.
Signed-off-by: Naresh Kumar Inna
---
V2:
- Removed csio_fcoe_proto.h, using defines from include/scsi/fc instead.
- Removed driver-specific return values, using errno values instead.
- Retained CSIO_INC_STATS, since it is
On 8/26/2012 12:38 AM, Naresh Kumar Inna wrote:
> On 8/25/2012 12:40 AM, David Miller wrote:
>> From: Naresh Kumar Inna
>> Date: Sat, 25 Aug 2012 00:34:35 +0530
>>
>>> Thanks for reviewing. Is your comment with respect to any particular
>>> module par
On 8/26/2012 12:13 AM, Nicholas A. Bellinger wrote:
> On Sun, 2012-08-26 at 00:06 +0530, Naresh Kumar Inna wrote:
>> On 8/25/2012 2:26 AM, Nicholas A. Bellinger wrote:
>>> On Fri, 2012-08-24 at 23:10 +0530, Naresh Kumar Inna wrote:
>>>> On 8/24/2012 1:18 AM, Nichola
On 8/25/2012 12:40 AM, David Miller wrote:
> From: Naresh Kumar Inna
> Date: Sat, 25 Aug 2012 00:34:35 +0530
>
>> Thanks for reviewing. Is your comment with respect to any particular
>> module parameter[s] in this driver or all of them?
>
> All of them.
>
On 8/26/2012 12:10 AM, Nicholas A. Bellinger wrote:
> On Sat, 2012-08-25 at 23:39 +0530, Naresh Kumar Inna wrote:
>> On 8/25/2012 2:47 AM, Nicholas A. Bellinger wrote:
>>> On Sat, 2012-08-25 at 00:06 +0530, Naresh Kumar Inna wrote:
>>>> On 8/24/2012 1:28 AM, Nichola
On 8/25/2012 2:26 AM, Nicholas A. Bellinger wrote:
> On Fri, 2012-08-24 at 23:10 +0530, Naresh Kumar Inna wrote:
>> On 8/24/2012 1:18 AM, Nicholas A. Bellinger wrote:
>>> On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote:
>>>> This patch contains code to im
On 8/25/2012 2:47 AM, Nicholas A. Bellinger wrote:
> On Sat, 2012-08-25 at 00:06 +0530, Naresh Kumar Inna wrote:
>> On 8/24/2012 1:28 AM, Nicholas A. Bellinger wrote:
>>> On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote:
>>>> This patch contains the fir
On 8/24/2012 11:57 PM, Joe Perches wrote:
> On Fri, 2012-08-24 at 23:10 +0530, Naresh Kumar Inna wrote:
>> Is there a TRUE/FALSE define in a standard header file?
>
> include/linux/stddef.h:
> enum {
> false = 0,
> true= 1
> };
>
>> I see a
On 8/24/2012 10:34 PM, David Miller wrote:
> From: Naresh Kumar Inna
> Date: Fri, 24 Aug 2012 03:57:45 +0530
>
>> This is the initial submission of the Chelsio FCoE offload driver (csiostor)
>> to the upstream kernel. This driver currently supports FCoE offload
>> fu
On 8/23/2012 11:45 PM, Love, Robert W wrote:
> On 8/23/2012 3:27 PM, Naresh Kumar Inna wrote:
>> This patch contains the first set of the header files for csiostor driver.
>>
>> Signed-off-by: Naresh Kumar Inna
>> ---
>> drivers/scsi/csiostor/csio_defs.h
On 8/24/2012 1:28 AM, Nicholas A. Bellinger wrote:
> On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote:
>> This patch contains the first set of the header files for csiostor driver.
>>
>> Signed-off-by: Naresh Kumar Inna
>> ---
>> drivers/scsi/
On 8/24/2012 1:18 AM, Nicholas A. Bellinger wrote:
> On Fri, 2012-08-24 at 03:57 +0530, Naresh Kumar Inna wrote:
>> This patch contains code to implement the interrupt handling and the fast
>> path I/O functionality. The interrupt handling includes allocation of
>> MSIX vec
This patch contains updates to firmware/hardware header files shared
between csiostor and cxgb4, and the resulting changes to the cxgb4 files.
Signed-off-by: Naresh Kumar Inna
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |2 +-
drivers/net/ethernet/chelsio/cxgb4/sge.c| 10
ctionality.
[PATCH 5/8]: Interrupt handling and fast path I/O functionality.
[PATCH 6/8]: Header files part 1.
[PATCH 7/8]: Header files part 2.
[PATCH 8/8]: Updates to header files shared between cxgb4 and csiostor.
Naresh Kumar Inna (8):
csiostor: Chelsio FCoE offload driver submission (sour
67 matches
Mail list logo
