Re: [PATCH 13/22] scsi: use local buffer for printing the opcode

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 10:57 AM, Hannes Reinecke wrote: > On 09/01/2014 12:19 AM, Christoph Hellwig wrote: >> On Thu, Aug 28, 2014 at 07:33:27PM +0200, Hannes Reinecke wrote: >>> SCSI opcode printing is tricky and needs to take into account >>> several different corner cases. So instead of trying to come >>

Re: [PATCH 13/22] scsi: use local buffer for printing the opcode

2014-09-01 Thread Hannes Reinecke
On 09/01/2014 12:19 AM, Christoph Hellwig wrote: > On Thu, Aug 28, 2014 at 07:33:27PM +0200, Hannes Reinecke wrote: >> SCSI opcode printing is tricky and needs to take into account >> several different corner cases. So instead of trying to come >> up with an elaborate printk() statement we should b

Re: [PATCH 13/22] scsi: use local buffer for printing the opcode

2014-08-31 Thread Christoph Hellwig
On Thu, Aug 28, 2014 at 07:33:27PM +0200, Hannes Reinecke wrote: > SCSI opcode printing is tricky and needs to take into account > several different corner cases. So instead of trying to come > up with an elaborate printk() statement we should be printing > it into a local buffer. scsi_print_comma

[PATCH 13/22] scsi: use local buffer for printing the opcode

2014-08-28 Thread Hannes Reinecke
SCSI opcode printing is tricky and needs to take into account several different corner cases. So instead of trying to come up with an elaborate printk() statement we should be printing it into a local buffer. Signed-off-by: Hannes Reinecke --- drivers/scsi/constants.c | 72 ++