RE: [PATCH] st: implement sysfs based tape statistics

2014-11-20 Thread Seymour, Shane M
I was wondering if anyone had a chance to review the patch? Comments are appreciated and I'm more than happy to make changes that will allow it to be accepted. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More major

Re: [PATCH] st: implement sysfs based tape statistics

2014-11-20 Thread Laurence Oberman
Hi Shane, I was actually about to pull this patch and test it. Lots of changes and a big patch so going to create a another driver as a tape stats driver for now for testing. Will exercise this fully and provide feedback to the list. Regards Laurence Oberman On Thu, Nov 20, 2014 at 6:49 PM, Seymo

Re: [PATCH] st: implement sysfs based tape statistics

2014-11-30 Thread Laurence Oberman
Hello Shane, So far so good on the upstream, built as a new driver. I need to run some more tests to capture stats and validate the numbers, so far just functional tests and reading sysfs numbers. I then need to backport to RHEL6 and RHEL7 kernels as we have two BZ's out there for this. WIll be wo

RE: [PATCH] st: implement sysfs based tape statistics v2

2015-01-26 Thread Seymour, Shane M
I was wondering if anyone had any feedback or had any chance to review the changes? -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Seymour, Shane M Sent: Tuesday, January 13, 2015 2:43 PM To: linux-scsi@vger.kernel.org Cc:

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-02 Thread Laurence Oberman
I pulled this this morning and will be testing. The prior version was stable for me on the upstream and RHEL 6.5 kernel without exhaustive testing. We also just received more requests to get this into RHEL from HP / Red Hat customers. Kai, what are your thoughts. I realize this is a large amount o

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Kai Mäkisara (Kolumbus)
> On 2.2.2015, at 17.16, Laurence Oberman wrote: > > I pulled this this morning and will be testing. The prior version was > stable for me on the upstream and RHEL 6.5 kernel without exhaustive > testing. > We also just received more requests to get this into RHEL from HP / > Red Hat customers.

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Laurence Oberman
2015 12:03:29 PM Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 > On 2.2.2015, at 17.16, Laurence Oberman wrote: > > I pulled this this morning and will be testing. The prior version was > stable for me on the upstream and RHEL 6.5 kernel without exhaustive > tes

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Kai Mäkisara (Kolumbus)
ottomley (jbottom...@parallels.com)" > , je...@suse.com > Sent: Thursday, February 5, 2015 12:03:29 PM > Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 > > >> On 2.2.2015, at 17.16, Laurence Oberman wrote: >> >> I pulled this this morning a

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Laurence Oberman
Seymour" , lober...@redhat.com, > linux-scsi@vger.kernel.org, "James E.J. Bottomley (jbottom...@parallels.com)" > , je...@suse.com > Sent: Thursday, February 5, 2015 12:03:29 PM > Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 > > >> On 2.2

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread James Bottomley
On Thu, 2015-02-05 at 19:46 +0200, "Kai Mäkisara (Kolumbus)" wrote: > > On 5.2.2015, at 19.40, Laurence Oberman wrote: > > I missed the earlier conversations with James, I will go search for them. > > Do you mean add them so they are similar to the /proc/diskstats > > > > cat /proc/diskstats > >

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Bryn M. Reeves
On Thu, Feb 05, 2015 at 07:46:32PM +0200, "Kai Mäkisara (Kolumbus)" wrote: > > On 5.2.2015, at 19.40, Laurence Oberman wrote: > > From: "Kai Mäkisara (Kolumbus)" > > I still think that the tape statistics should be exported like the > > statistics of “real” block devices, i.e., one sysfs file ex

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread James Bottomley
On Thu, 2015-02-05 at 18:50 +, Bryn M. Reeves wrote: > On Thu, Feb 05, 2015 at 07:46:32PM +0200, "Kai Mäkisara (Kolumbus)" wrote: > > > On 5.2.2015, at 19.40, Laurence Oberman wrote: > > > From: "Kai Mäkisara (Kolumbus)" > > > I still think that the tape statistics should be exported like the

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-05 Thread Bryn M. Reeves
On Thu, Feb 05, 2015 at 10:55:50AM -0800, James Bottomley wrote: > OK, the sysfs bikeshedders hang out on linux-api > > https://www.kernel.org/doc/man-pages/linux-api-ml.html > > If you can convince them, we'll do the single file approach. Will do - I've got a couple of stats projects on the go

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-06 Thread Jeremy Linton
On 1/26/2015 6:11 PM, Seymour, Shane M wrote: > I was wondering if anyone had any feedback or had any chance to review the > changes? Per the other discussion about having the same stat format forever. It seems to me that you might want to preemptively add a few additional counters.

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-08 Thread Dale R. Worley
One feature of tape statistics is that they're as much about the *tape* as they are about the *drive*, which is uncommon for block devices. It might be useful to have a set of counters which is cleared every time a new tape is inserted into the drive. In particular, "bad reads since this tape was

RE: [PATCH] st: implement sysfs based tape statistics v2

2015-02-08 Thread Seymour, Shane M
4:08 AM To: Seymour, Shane M Cc: linux-scsi@vger.kernel.org Subject: Re: [PATCH] st: implement sysfs based tape statistics v2 One feature of tape statistics is that they're as much about the *tape* as they are about the *drive*, which is uncommon for block devices. It might be useful to hav

RE: [PATCH] st: implement sysfs based tape statistics v2

2015-02-08 Thread Seymour, Shane M
Message- From: Seymour, Shane M Sent: Monday, February 09, 2015 10:19 AM To: 'Dale R. Worley' Cc: linux-scsi@vger.kernel.org Subject: RE: [PATCH] st: implement sysfs based tape statistics v2 Both of those things would have to be futures and require discussion - the very original

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-09 Thread Kai Mäkisara (Kolumbus)
> On 9.2.2015, at 8.00, Seymour, Shane M wrote: > > Kai - see last 3 paragraphs for question about if something is a bug or not. > > BTW I had a look - I couldn't quickly find out if there was a way to tell if > the medium has changed in a tape drive (there could be something device > specifi

Re: [PATCH] st: implement sysfs based tape statistics v2

2015-02-10 Thread Dale R. Worley
"Seymour, Shane M" writes: > Both of those things would have to be futures and require discussion - > the very original version cleared stats on a device open but I got > asked to keep it the stats cumulative so they would be more similar to > disk stats. Yes, this is a futures question. But in