RE: [SCSI] bfa: Added support to obtain SFP info.

2014-04-30 Thread Anil Gurumurthy
sfp->state_query_lock = 0; sfp->state_query_cbfn = NULL; } Thanks, Anil -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: 29 April 2014 18:21 To: linux-scsi Cc: Vijaya Mohan Guvva; Anil Gurumurthy; Sudarsana Kalluru Subject: Re: [SCSI] bf

Re: [SCSI] bfa: Added support to obtain SFP info.

2014-04-29 Thread Dan Carpenter
Krishna isn't around any more. Does anyone else know what's going on in this code? It looks buggy to me. regards, dan carpenter On Fri, Mar 28, 2014 at 02:07:37AM +0300, Dan Carpenter wrote: > On Fri, Mar 28, 2014 at 02:05:14AM +0300, Dan Carpenter wrote: > > Hello Krishna Gudipati, > > > > Th

Re: [SCSI] bfa: Added support to obtain SFP info.

2014-03-27 Thread Dan Carpenter
On Fri, Mar 28, 2014 at 02:05:14AM +0300, Dan Carpenter wrote: > Hello Krishna Gudipati, > > The patch 51e569aa1f0c: "[SCSI] bfa: Added support to obtain SFP > info." from Jun 24, 2011, leads to the following static checker > warning: > > drivers/scsi/bfa/bfa_ioc.c:3668 bfa_cb_sfp_state_que

re: [SCSI] bfa: Added support to obtain SFP info.

2014-03-27 Thread Dan Carpenter
Hello Krishna Gudipati, The patch 51e569aa1f0c: "[SCSI] bfa: Added support to obtain SFP info." from Jun 24, 2011, leads to the following static checker warning: drivers/scsi/bfa/bfa_ioc.c:3668 bfa_cb_sfp_state_query() warn: add curly braces? drivers/scsi/bfa/bfa_ioc.c 3659 st