Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Kashyap Desai
On Tue, Aug 19, 2014 at 3:51 AM, Kashyap Desai kashyap.de...@avagotech.com wrote: -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, July 18, 2014 3:43 PM To: James Bottomley;

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Christoph Hellwig
On Tue, Aug 19, 2014 at 03:51:42AM +0530, Kashyap Desai wrote: I read this comment and find that very few drivers are using this cmd_list. I think if we remove this cmd_list, performance will scale as I am seeing major contention in this lock. Just thought to ping you to see if this is known

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-19 Thread Kashyap Desai
On Tue, Aug 19, 2014 at 9:36 PM, Christoph Hellwig h...@lst.de wrote: On Tue, Aug 19, 2014 at 03:51:42AM +0530, Kashyap Desai wrote: I read this comment and find that very few drivers are using this cmd_list. I think if we remove this cmd_list, performance will scale as I am seeing major

RE: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-08-18 Thread Kashyap Desai
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- ow...@vger.kernel.org] On Behalf Of Christoph Hellwig Sent: Friday, July 18, 2014 3:43 PM To: James Bottomley; linux-scsi@vger.kernel.org Cc: Jens Axboe; Bart Van Assche; Mike Christie; Martin K. Petersen;

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-25 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Christoph This patch adds support for an alternate I/O path in the scsi Christoph midlayer which uses the blk-mq infrastructure instead of the Christoph legacy request code. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-16 Thread Mike Christie
On 06/25/2014 11:52 AM, Christoph Hellwig wrote: +static int scsi_queue_rq(struct blk_mq_hw_ctx *hctx, struct request *req) +{ + struct request_queue *q = req-q; + struct scsi_device *sdev = q-queuedata; + struct Scsi_Host *shost = sdev-host; + struct scsi_cmnd *cmd =

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-16 Thread Christoph Hellwig
On Wed, Jul 16, 2014 at 06:13:21AM -0500, Mike Christie wrote: I see the request timer is started before calling queue_rq, but I could not figure out what the cancel_delayed_work here is for exactly. It seems if the request were to time out and the eh started while queue_rq was running we

Re: [PATCH 13/14] scsi: add support for a blk-mq based I/O path.

2014-07-09 Thread Hannes Reinecke
On 06/25/2014 06:52 PM, Christoph Hellwig wrote: This patch adds support for an alternate I/O path in the scsi midlayer which uses the blk-mq infrastructure instead of the legacy request code. Use of blk-mq is fully transparent to drivers, although for now a host template field is provided to